quadraui 0.1.0

Cross-platform Rust UI toolkit: write one AppLogic and run it unmodified on TUI, GTK4 (Linux), macOS, and Windows backends
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
//! Shared pixel-layout math for rasterisers (#499).
//!
//! `gtk::tree::gtk_tree_layout` and `macos::tree::mac_tree_layout` were
//! byte-identical apart from the function name and one comment; the
//! same was true of the two backends' `MultiSectionView` body-measure
//! match arms, and they had already **drifted** — GTK measured real
//! `MessageList` section height, macOS returned `0.0`; see
//! [`msv_body_measure`]'s doc for the fix.
//!
//! This module is the shared home for that math: **pure functions,
//! no native drawing handles** (no `cairo::Context`, no
//! `CGContextRef`, no `ID2D1RenderTarget`) — everything here takes
//! `(primitive, rect, line_height, ..)` and returns the primitive's
//! existing `*Layout` / `*Measure` struct. Backends call these and
//! keep only native painting. See
//! `quadraui/docs/PRIMITIVE_RULES.md`'s "Shared pixel-layout math"
//! section for the pattern and when to add to it.
//!
//! Where a rasteriser needs a *real* glyph width (Form's per-item hit
//! regions), it goes through [`TextMeasure`] instead of hardcoding an
//! estimate — each backend supplies a thin adapter over its live
//! font/context (see `macos::form::CtFontMeasure`).

use crate::event::Rect as QRect;
use crate::primitives::board::{BoardLayout, BoardMeasure, BoardModel};
use crate::primitives::chart::{Chart, ChartLayout, ChartMeasure};
use crate::primitives::data_table::{ColumnMeasure, DataTable, DataTableLayout};
use crate::primitives::form::{FieldKind, FormField, FormFieldMeasure, FormItemMeasure};
use crate::primitives::list::{ListItemMeasure, ListView, ListViewLayout};
use crate::primitives::minimap::{Minimap, MinimapLayout, MinimapScale, MinimapSizing};
use crate::primitives::multi_section_view::{
    MsvLayoutMetrics, MultiSectionView, MultiSectionViewLayout, SectionAux, SectionBody,
    SectionMeasure,
};
use crate::primitives::panel::{Panel, PanelLayout, PanelMeasure};
use crate::primitives::pipeline_view::{PipelineView, PipelineViewLayout, PipelineViewMeasure};
use crate::primitives::progress::{ProgressBar, ProgressBarLayout, ProgressBarMeasure};
use crate::primitives::split::{Split, SplitLayout, SplitMeasure};
use crate::primitives::split_tree::{SplitTree, SplitTreeLayout, SplitTreeMeasure};
use crate::primitives::tab_bar::{
    SegmentMeasure, TabBar, TabBarLayout, TabChrome, TabFrame, TabMeasure,
};
use crate::primitives::toast::{ToastMeasure, ToastOverlay, ToastStackLayout};
use crate::primitives::tree::{TreeRowMeasure, TreeView, TreeViewLayout};
use crate::types::Decoration;
use crate::WidgetId;

/// Backend-supplied text measurement. Implemented per-backend over
/// whatever live font/context object it already carries (a
/// `pango::Layout`, a `CTFont`, DirectWrite metrics, …) — this trait
/// exists so the shared layout math in this module never has to name
/// a native type.
pub trait TextMeasure {
    /// Width, in pixels/DIPs, of `text` rendered in the current UI font.
    fn width_of(&self, text: &str) -> f32;
}

/// Pixel/DIP-unit layout constants every pixel backend (`gtk`, `macos`,
/// `win`) used to redefine independently, at the same value, under a
/// different name (issue #1079): `GTK_DIVIDER_PX` / `MAC_DIVIDER_PX` /
/// `DIVIDER_DIP` were all `4.0`, `TOAST_WIDTH_PX` / `GTK_TOAST_WIDTH_PX` /
/// `TOAST_WIDTH_DIP` were all `320.0`, and so on for every constant below.
/// One definition here means one place to change a value backends must
/// agree on, and a `grep -rn 'const <NAME>' src/` that returns exactly one
/// hit instead of three-to-six near-identical ones.
///
/// Values are logical pixels for `gtk`/`macos`, DIPs for `win` — the same
/// numeric unit convention every backend already shared before this fix,
/// just previously copy-pasted instead of referenced.
pub mod pixel {
    /// [`crate::Split`] / [`crate::primitives::split_tree::SplitTree`]
    /// divider thickness.
    pub const DIVIDER: f32 = 4.0;

    /// [`crate::ToastOverlay`] max toast width.
    pub const TOAST_WIDTH: f32 = 320.0;
    /// [`crate::ToastOverlay`] margin from the viewport edge.
    pub const TOAST_MARGIN: f32 = 12.0;
    /// [`crate::ToastOverlay`] gap between stacked toasts.
    pub const TOAST_GAP: f32 = 8.0;
    /// [`crate::ToastOverlay`] vertical padding inside a toast box.
    pub const TOAST_PADDING: f32 = 8.0;
    /// [`crate::ToastOverlay`] width (and height — the dismiss affordance
    /// is a square) of the dismiss (`×`) affordance.
    pub const TOAST_DISMISS_WIDTH: f32 = 28.0;
    /// [`crate::ToastOverlay`] extra width reserved around an action label.
    pub const TOAST_ACTION_PADDING: f32 = 16.0;
    /// [`crate::ToastOverlay`] horizontal gap between two adjacent action
    /// buttons on the button row (#1185).
    pub const TOAST_ACTION_GAP: f32 = 8.0;

    /// [`crate::ProgressBar`] width of the cancel (`×`) affordance.
    pub const PROGRESS_CANCEL_WIDTH: f32 = 28.0;
    /// [`crate::ProgressBar`] width of the sliding indeterminate pulse.
    pub const PROGRESS_PULSE_WIDTH: f32 = 40.0;

    /// [`crate::Panel`] width reserved per title-bar action button.
    pub const PANEL_ACTION_BUTTON: f32 = 24.0;

    /// [`crate::primitives::pipeline_view::PipelineView`] arrow connector
    /// width between stage boxes.
    pub const PIPELINE_ARROW_WIDTH: f32 = 32.0;
    /// [`crate::primitives::pipeline_view::PipelineView`] height reserved
    /// for a stage's action button.
    pub const PIPELINE_ACTION_HEIGHT: f32 = 22.0;
    /// [`crate::primitives::pipeline_view::PipelineView`] height reserved
    /// above stage boxes for the keyboard-focus caret strip.
    pub const PIPELINE_FOCUS_INDICATOR_H: f32 = 8.0;
    /// [`crate::primitives::pipeline_view::PipelineView`] stage-box corner
    /// radius (paint-only — [`super::PipelineViewLayout`] carries only
    /// rectangles).
    pub const CORNER_RADIUS: f64 = 4.0;
    /// [`crate::primitives::pipeline_view::PipelineView`] horizontal
    /// padding inside a stage box (paint-only).
    pub const PIPELINE_H_PAD: f64 = 8.0;
    /// [`crate::primitives::pipeline_view::PipelineView`] stage-box
    /// border stroke width (paint-only).
    pub const PIPELINE_BORDER_WIDTH: f64 = 1.0;

    /// [`crate::DataTable`] width reserved for the vertical scrollbar.
    pub const DATA_TABLE_SCROLLBAR_WIDTH: f32 = 8.0;

    /// [`crate::primitives::minimap::Minimap`] buffer lines painted per
    /// minimap row. Every pixel backend shows one buffer line per row (no
    /// cross-line colour reduction — see [`crate::MinimapGrid`]'s doc for
    /// why TUI's braille packing differs).
    pub const MINIMAP_LINES_PER_ROW: usize = 1;

    /// [`crate::TabBar`] non-compact per-tab horizontal padding (left +
    /// right) inside the tab background fill. `gtk::tab_bar::TAB_PAD`,
    /// `macos::tab_bar::TAB_PAD`, and `win::tab_bar::TAB_PAD_DIP` were all
    /// `14.0` independently (issue #1080).
    pub const TAB_PAD: f32 = 14.0;
    /// [`crate::TabBar`] gap between a tab's label and its close glyph.
    pub const TAB_INNER_GAP: f32 = 10.0;
    /// [`crate::TabBar`] gap between adjacent tabs.
    pub const TAB_OUTER_GAP: f32 = 1.0;
    /// [`crate::TabBar`] gap between a tab's icon glyph
    /// ([`crate::TabIcon`]) and its label.
    pub const TAB_ICON_GAP: f32 = 6.0;
    /// 15-glyph sample string every pixel backend measures once per frame
    /// to estimate an average glyph advance for
    /// [`super::pixel_tab_bar_layout`]'s `available_cols` — proportional
    /// fonts have no single "char width", so this is the same estimate
    /// convention `gtk`/`macos` already used independently before #1080
    /// (`win` gained one for the first time).
    pub const TAB_CELL_WIDTH_SAMPLE: &str = "ABCDabcd0123.:_";
}

// ── Tree ─────────────────────────────────────────────────────────────

/// Compute the layout any pixel backend (GTK, macOS, and — with no
/// changes — a future Direct2D backend) produces for `tree` in `area`
/// at `line_height`. Header rows use `(line_height * 1.2).round()`
/// pitch, leaves/branches use `(line_height * 1.4).round()` unless
/// [`crate::types::TreeStyle::row_height`] overrides the non-header
/// pitch (#623). Chevron end-x is an *estimate*
/// (`line_height * 0.65` for the glyph) since exact glyph metrics
/// aren't available without laying out each chevron per row — every
/// backend already made this same tradeoff independently.
///
/// Coordinate frame: `visible_rows.bounds` and `hit_regions` are in
/// **tree-local** coords (origin at 0, 0). Callers subtract
/// `area.x`/`area.y` from absolute click coords before calling
/// [`TreeViewLayout::hit_test`].
pub fn tree_layout(tree: &TreeView, area: QRect, line_height: f64) -> TreeViewLayout {
    let header_height = (line_height * 1.2).round();
    let item_height = tree_row_pitch(tree, line_height);
    let indent_px = (line_height * 0.9).round();
    let show_chevrons = tree.style.show_chevrons;
    tree.layout(area.width, area.height, |i| {
        let row = &tree.rows[i];
        let is_header = matches!(row.decoration, Decoration::Header);
        let row_h = if is_header {
            header_height as f32
        } else {
            item_height as f32
        };
        // Approximate chevron end x in tree-local pixels:
        //   2px left margin + indent levels + estimated chevron glyph width + 4px gap.
        let chevron_end_x = if row.is_expanded.is_some() && show_chevrons {
            let est_glyph_w = line_height * 0.65;
            Some((2.0 + row.indent as f64 * indent_px + est_glyph_w + 4.0) as f32)
        } else {
            None
        };
        TreeRowMeasure {
            height: row_h,
            chevron_end_x,
        }
    })
}

/// The non-header row pitch [`tree_layout`] uses for the bulk of a
/// tree's rows: [`crate::types::TreeStyle::row_height`] when the host
/// set one, else `(line_height * 1.4).round()` (#623).
///
/// [`TreeView::vscrollbar`] takes a single, uniform `row_height` — it
/// has no way to reproduce `tree_layout`'s header-vs-leaf/branch split
/// (headers pitch at `line_height * 1.2`) — so this is the pitch every
/// pixel backend's `tree_vscrollbar` should pass it. Before #1043's fix
/// round, `gtk`/`macos`/`win`'s `tree_vscrollbar` passed the raw
/// `line_height` instead, which is ~40% short of what `tree_layout`
/// actually paints for non-header rows (and silently ignored
/// `TreeStyle::row_height` entirely) — making "does this tree
/// overflow its viewport" and the resulting thumb size/position wrong
/// against what `draw_tree` paints. Using the leaf/branch pitch here
/// still isn't exact for trees with header rows mixed in (the uniform
/// `vscrollbar` model can't be), but it matches what `tree_layout`
/// paints for the overwhelming majority of rows in any real tree,
/// which raw `line_height` never did.
pub fn tree_row_pitch(tree: &TreeView, line_height: f64) -> f64 {
    tree.style
        .row_height
        .map(|h| h as f64)
        .unwrap_or(line_height * 1.4)
        .round()
}

// ── List ─────────────────────────────────────────────────────────────

/// Compute the pixel-unit layout for a [`ListView`], including the
/// horizontal-scrollbar row reservation (#712). Every pixel backend
/// (`gtk_list_layout`, `mac_list_layout`, and any future Direct2D
/// equivalent) calls this one function so [`crate::Backend::list_layout`]
/// and the layout a backend actually paints can never disagree about
/// whether a row is reserved for the h-scrollbar.
///
/// Before #712, `gtk_list_layout` had this reservation inline and
/// `mac_list_layout` had none at all — `macos::list::draw_list`
/// recomputed a *second*, reduced-height layout only when painting, so
/// `MacBackend::list_layout` was one row taller than what macOS
/// actually painted whenever `max_content_width` forced a scrollbar.
/// This function is that reservation logic, generalised over
/// `border_inset` so both backends share one implementation instead of
/// two copies that can drift.
///
/// `char_width` is used only for the h-scrollbar-overflow threshold
/// check (`ListView::max_content_width` is in character columns); pass
/// [`crate::Backend::char_width`]'s cached value when no live text
/// measurer is available — the same approximation
/// `GtkBackend::list_hscrollbar` / `MacBackend::list_hscrollbar` already
/// use for this exact check.
///
/// `border_inset` is the pixel border a backend reserves around a
/// `bordered` list: `1.0` for GTK's `bordered` lists, `0.0` for
/// backends — like macOS today — that don't yet paint a list border
/// (see `macos::list`'s module doc "Scope omissions").
///
/// Coordinate frame: **LOCAL** — relative to `(0, 0)`, matching every
/// other layout_metrics fn. Windows does not yet reserve an
/// h-scrollbar row at all (`win_list_layout` has no `char_width`
/// parameter and no overflow check) — a real gap, not drift, tracked
/// separately from this fix; see `win::list`'s module doc.
pub fn list_layout(
    list: &ListView,
    w: f64,
    h: f64,
    line_height: f64,
    char_width: f64,
    border_inset: f64,
) -> ListViewLayout {
    let visible_px = (w - border_inset * 2.0).max(0.0);
    let needs_hscrollbar = list
        .max_content_width
        .is_some_and(|n| n as f64 * char_width > visible_px);
    let hscrollbar_h = if needs_hscrollbar { line_height } else { 0.0 };
    let title_h = if list.title.is_some() {
        line_height as f32
    } else {
        0.0
    };
    let layout_w = (w - border_inset * 2.0) as f32;
    let layout_h = (h - border_inset * 2.0 - hscrollbar_h).max(0.0) as f32;
    list.layout(layout_w, layout_h, title_h, |_| {
        ListItemMeasure::new(line_height as f32)
    })
}

// ── MultiSectionView ────────────────────────────────────────────────

/// Compute the [`MsvLayoutMetrics`] any pixel backend derives from a
/// `line_height`. Backends call this AND the primitive's `layout()`
/// with the same metrics so paint and click resolve to the same
/// bounds.
pub fn msv_metrics(line_height: f64, allow_resize: bool) -> MsvLayoutMetrics {
    MsvLayoutMetrics {
        header_size: (line_height * 1.4) as f32,
        divider_size: if allow_resize { 1.0 } else { 0.0 },
        // 8px gives a visible scrollbar against typical dark sidebar
        // backgrounds.
        scrollbar_size: 8.0,
        // Pixel backends paint at sub-pixel precision; no quantization.
        cell_quantum: 0.0,
    }
}

/// Compute the layout for a `MultiSectionView` using [`msv_metrics`].
/// Hosts call this to drive hit-testing without re-computing or
/// re-measuring — paint AND click share this single layout per frame.
pub fn msv_layout(
    view: &MultiSectionView,
    bounds: QRect,
    line_height: f64,
) -> MultiSectionViewLayout {
    let metrics = msv_metrics(line_height, view.allow_resize);
    view.layout(bounds, metrics, |i| {
        msv_body_measure(&view.sections[i].body, &view.sections[i].aux, line_height)
    })
}

/// Measure one section's body content size at `line_height`.
///
/// `SectionBody::MessageList` measures real content height (one
/// header line per message plus its wrapped body lines) rather than
/// returning `0.0`. Before #499 this was GTK-only — macOS's copy of
/// this match returned `0.0` for `MessageList`, a live layout bug
/// (macOS MSV sections containing a `MessageList` body collapsed to
/// zero height / mis-sized dividers). Sharing this function is what
/// fixes it: there is now exactly one measurement, so macOS gets the
/// correct height automatically.
pub fn msv_body_measure(
    body: &SectionBody,
    aux: &Option<SectionAux>,
    line_height: f64,
) -> SectionMeasure {
    let item_h = (line_height * 1.4).round() as f32;
    let aux_size = if aux.is_some() { item_h } else { 0.0 };
    let content_size = match body {
        SectionBody::Tree(t) => {
            let header_h = (line_height * 1.2).round() as f32;
            let mut total = 0.0_f32;
            for row in &t.rows {
                let is_header = matches!(row.decoration, Decoration::Header);
                total += if is_header { header_h } else { item_h };
            }
            total
        }
        SectionBody::List(l) => {
            let title_h = if l.title.is_some() {
                line_height as f32
            } else {
                0.0
            };
            title_h + l.items.len() as f32 * item_h
        }
        SectionBody::Form(f) => f.fields.len() as f32 * item_h,
        SectionBody::Chart(c) => {
            if matches!(c.kind, crate::primitives::chart::ChartKind::Sparkline) {
                line_height as f32
            } else {
                item_h * 8.0
            }
        }
        SectionBody::MessageList(m) => {
            // 1 header row + body lines per message.
            m.rows
                .iter()
                .map(|r| {
                    let lines = r.text.lines().count().max(1) as f32;
                    line_height as f32 + lines * line_height as f32
                })
                .sum()
        }
        SectionBody::Terminal(_) => 0.0,
        SectionBody::Text(lines) => lines.len() as f32 * line_height as f32,
        SectionBody::Empty(_) => item_h * 4.0, // icon + text + hint + action
        SectionBody::Custom(_) => 0.0,
    };
    SectionMeasure {
        content_size,
        aux_size,
    }
}

// ── Form ─────────────────────────────────────────────────────────────

/// Per-field row height at `line_height`: `(line_height * 1.4).round()`.
pub fn form_row_height(line_height: f64) -> f32 {
    (line_height * 1.4).round() as f32
}

/// X offset where row items (`ToggleGroup` / `ButtonRow` /
/// `SegmentedControl` / `Toolbar`) start: 6px row inset + label width
/// + 12px gap.
///
/// `for_toolbar` selects `Toolbar`'s pre-#499 behaviour: when its
/// label is empty, skip the `+ label_w + 12` entirely and start at
/// the 6px inset. `ToggleGroup` / `ButtonRow` / `SegmentedControl`
/// never had that special case — pre-#499 macOS computed the
/// unconditional `6.0 + label_w + 12.0` for all three even with an
/// empty label (GTK's still-unmigrated inline copy in
/// `gtk/backend.rs` does the same) — so `for_toolbar` must be `false`
/// for those three to keep this shared fn from silently changing
/// their output. See `quadraui/docs/PRIMITIVE_RULES.md`'s "Shared
/// pixel-layout math" section.
fn items_start_x(label: &str, measure: &dyn TextMeasure, for_toolbar: bool) -> f32 {
    if for_toolbar && label.is_empty() {
        return 6.0;
    }
    let label_w = measure.width_of(label);
    6.0 + label_w + 12.0
}

fn label_text(field: &FormField) -> String {
    field.label.spans.iter().map(|s| s.text.as_str()).collect()
}

/// Measure one `Form` field at `row_h`, using `measure` for any
/// per-item glyph widths (`ToggleGroup` / `ButtonRow` /
/// `SegmentedControl` / `Toolbar`).
///
/// `FieldKind::TextArea`'s multi-row height (`row_h * visible_rows`)
/// is intentionally **not** special-cased here — no pixel backend
/// currently paints a real multi-row `TextArea` (see
/// `macos::form`'s module doc, "Scope omissions"), so folding that in
/// here would be a silent behavior change beyond #499's scope, not a
/// dedup. Do that as its own follow-up once a backend actually renders
/// it.
pub fn form_field_measure(
    field: &FormField,
    row_h: f32,
    measure: &dyn TextMeasure,
) -> FormFieldMeasure {
    match &field.kind {
        FieldKind::ToggleGroup { toggles } => {
            let start_x = items_start_x(&label_text(field), measure, false);
            let items = toggles
                .iter()
                .map(|t| FormItemMeasure {
                    id: t.id.clone(),
                    width: measure.width_of(&t.label),
                })
                .collect();
            FormFieldMeasure::with_items(row_h, start_x, 8.0, items)
        }
        FieldKind::ButtonRow { buttons } => {
            let start_x = items_start_x(&label_text(field), measure, false);
            let items = buttons
                .iter()
                .map(|b| FormItemMeasure {
                    id: b.id.clone(),
                    width: measure.width_of(&format!("[{}]", b.label)),
                })
                .collect();
            FormFieldMeasure::with_items(row_h, start_x, 8.0, items)
        }
        FieldKind::SegmentedControl { options, .. } => {
            let start_x = items_start_x(&label_text(field), measure, false);
            let items = options
                .iter()
                .enumerate()
                .map(|(idx, opt)| FormItemMeasure {
                    id: WidgetId::new(format!("{}__seg_{idx}", field.id.as_str())),
                    width: measure.width_of(&format!("[{opt}]")),
                })
                .collect();
            // Segments butt up against each other — no inter-item gap.
            FormFieldMeasure::with_items(row_h, start_x, 0.0, items)
        }
        FieldKind::Toolbar(toolbar) => {
            use crate::primitives::toolbar::{measure_button, ToolbarButton};
            let label = label_text(field);
            let start_x = items_start_x(&label, measure, true);
            let items = toolbar
                .buttons
                .iter()
                .map(|btn| {
                    let id = match btn {
                        ToolbarButton::Action { id, .. } => id.clone(),
                        _ => field.id.clone(),
                    };
                    // Single button-measure formula shared with every
                    // pixel rasteriser (#730) — see `measure_button`'s
                    // doc.
                    let width = measure_button(measure, btn);
                    FormItemMeasure { id, width }
                })
                .collect();
            FormFieldMeasure::with_items(row_h, start_x, 0.0, items)
        }
        _ => FormFieldMeasure::new(row_h),
    }
}

// ── Toast ────────────────────────────────────────────────────────────

/// Compute the pixel-unit layout for a [`ToastOverlay`] any pixel backend
/// produces (issue #1079 — `gtk_toast_stack_layout`, `mac_toast_stack_layout`,
/// `win_toast_stack_layout` were three copies of this exact formula, only
/// differing in the constant names and how `measure` was obtained).
///
/// `(origin_x, origin_y)` is baked into the returned bounds (absolute
/// frame) — hosts call `layout.hit_test(x, y)` with raw click
/// coordinates, no localisation needed, matching every other
/// `*_toast_stack_layout`.
///
/// Height grows with a wrapped body (#1182 — up to
/// [`crate::primitives::toast::MAX_BODY_LINES`] lines via
/// [`crate::primitives::toast::wrap_text_lines`]), matching what
/// `native_surface_paint::paint`'s own copy of this formula actually
/// draws, so a no-paint layout call here always agrees with the last
/// paint.
#[allow(clippy::too_many_arguments)]
pub fn pixel_toast_stack_layout(
    stack: &ToastOverlay,
    measure: &dyn TextMeasure,
    origin_x: f32,
    origin_y: f32,
    viewport_width: f32,
    viewport_height: f32,
    line_height: f32,
) -> ToastStackLayout {
    stack.layout(
        origin_x,
        origin_y,
        viewport_width,
        viewport_height,
        pixel::TOAST_MARGIN,
        pixel::TOAST_GAP,
        |i| {
            let toast = &stack.toasts[i];
            let width =
                pixel::TOAST_WIDTH.min((viewport_width - pixel::TOAST_MARGIN * 2.0).max(0.0));
            let body_avail = (width - pixel::TOAST_PADDING * 2.0).max(0.0);
            let body_lines = if toast.body.is_empty() {
                0
            } else {
                crate::primitives::toast::wrap_text_lines(
                    &toast.body,
                    body_avail,
                    crate::primitives::toast::MAX_BODY_LINES,
                    &|s| measure.width_of(s),
                )
                .len()
                .max(1)
            };
            // Button row (#1185): a separate row below the title/body,
            // added only when the toast has actions.
            let has_actions = !toast.actions.is_empty();
            let button_row_h = if has_actions {
                pixel::TOAST_PADDING + line_height
            } else {
                0.0
            };
            let h = line_height
                + pixel::TOAST_PADDING * 2.0
                + body_lines as f32 * line_height
                + button_row_h;
            let action_widths: Vec<f32> = toast
                .actions
                .iter()
                .map(|a| measure.width_of(&a.label) + pixel::TOAST_ACTION_PADDING)
                .collect();
            let (dismiss_rect, action_rects) = crate::primitives::toast::toast_button_rects(
                width,
                h,
                pixel::TOAST_PADDING,
                pixel::TOAST_DISMISS_WIDTH,
                // Height is a single text row (see the matching call in
                // `native_surface_paint::paint`'s doc for why this
                // mustn't reuse `TOAST_DISMISS_WIDTH`, #1185).
                line_height,
                &action_widths,
                line_height,
                pixel::TOAST_ACTION_GAP,
            );
            ToastMeasure {
                width,
                height: h,
                dismiss_rect,
                action_rects,
            }
        },
    )
}

// ── Split / SplitTree ───────────────────────────────────────────────

/// Compute a [`Split`]'s layout at the shared [`pixel::DIVIDER`]
/// thickness — the twin of every backend's `*_split_layout` (issue
/// #1079).
pub fn pixel_split_layout(split: &Split, bounds: QRect) -> SplitLayout {
    split.layout(bounds, SplitMeasure::new(pixel::DIVIDER))
}

/// Compute a [`SplitTree`]'s layout at the shared [`pixel::DIVIDER`]
/// thickness — the twin of every backend's `*_split_tree_layout` (issue
/// #1079).
pub fn pixel_split_tree_layout(tree: &SplitTree, bounds: QRect) -> SplitTreeLayout {
    tree.layout(bounds, SplitTreeMeasure::new(pixel::DIVIDER))
}

// ── Progress ─────────────────────────────────────────────────────────

/// Compute a [`ProgressBar`]'s layout — the twin of every backend's
/// `*_progress_layout` (issue #1079). `x`/`y`/`w`/`h` are the bar's own
/// bounds; the cancel affordance (when `bar.cancellable`) reserves
/// [`pixel::PROGRESS_CANCEL_WIDTH`].
pub fn pixel_progress_layout(
    bar: &ProgressBar,
    x: f32,
    y: f32,
    w: f32,
    h: f32,
) -> ProgressBarLayout {
    let cancel_width = if bar.cancellable {
        pixel::PROGRESS_CANCEL_WIDTH
    } else {
        0.0
    };
    bar.layout(
        x,
        y,
        ProgressBarMeasure {
            width: w,
            height: h,
            cancel_width,
        },
    )
}

// ── PipelineView ─────────────────────────────────────────────────────

/// Compute a [`PipelineView`]'s layout — the twin of every backend's
/// `*_pipeline_view_layout` (issue #1079).
///
/// Note: the returned layout (incl. `bounds`) is offset down by
/// [`pixel::PIPELINE_FOCUS_INDICATOR_H`], so `bounds.y` starts below the
/// reserved caret strip. The focus caret is painted in the gap between
/// the passed-in `y` and `bounds.y`; a host that clips drawing to
/// `layout.bounds` would clip the caret — clip to the original `(y, h)`
/// instead.
pub fn pixel_pipeline_view_layout(
    view: &PipelineView,
    x: f32,
    y: f32,
    w: f32,
    h: f32,
) -> PipelineViewLayout {
    let action_h = if view.stages.iter().any(|s| s.action.is_some()) {
        pixel::PIPELINE_ACTION_HEIGHT
    } else {
        0.0
    };
    view.layout(
        x,
        y + pixel::PIPELINE_FOCUS_INDICATOR_H,
        PipelineViewMeasure::new(
            w,
            (h - pixel::PIPELINE_FOCUS_INDICATOR_H).max(0.0),
            pixel::PIPELINE_ARROW_WIDTH,
            action_h,
        ),
    )
}

// ── Board ────────────────────────────────────────────────────────────

/// Compute a [`BoardModel`]'s layout — the twin of every backend's
/// `*_board_layout` (issue #1079). The per-column/card geometry
/// constants (`BOARD_COL_MIN_PX` etc.) were already shared via
/// [`crate::primitives::board`] before this issue; this fn just removes
/// the last bit of drift, the three near-identical wrapper calls.
pub fn pixel_board_layout(model: &BoardModel, x: f32, y: f32, w: f32, h: f32) -> BoardLayout {
    use crate::primitives::board::{
        board_layout, BOARD_CARD_GAP_PX, BOARD_CARD_H_PX, BOARD_COL_GAP_PX, BOARD_COL_MIN_PX,
        BOARD_HEADER_H_PX,
    };
    board_layout(
        model,
        x,
        y,
        w,
        h,
        BoardMeasure::new(
            BOARD_COL_MIN_PX,
            BOARD_COL_GAP_PX,
            BOARD_HEADER_H_PX,
            BOARD_CARD_H_PX,
            BOARD_CARD_GAP_PX,
        ),
    )
}

// ── Panel ────────────────────────────────────────────────────────────

/// Compute a [`Panel`]'s layout — the twin of every backend's
/// `*_panel_layout` (issue #1079). `content_padding` is always `0.0`
/// today — no backend passes a non-zero value (see each backend's now
/// pre-#1079 `*_panel_layout` history).
pub fn pixel_panel_layout(
    panel: &Panel,
    x: f32,
    y: f32,
    w: f32,
    h: f32,
    line_height: f32,
) -> PanelLayout {
    let bounds = QRect::new(x, y, w, h);
    let measure = PanelMeasure {
        title_bar_height: if panel.title.is_some() {
            line_height
        } else {
            0.0
        },
        action_button_width: pixel::PANEL_ACTION_BUTTON,
        content_padding: 0.0,
    };
    panel.layout(bounds, measure)
}

// ── Chart ────────────────────────────────────────────────────────────

/// Compute a [`Chart`]'s layout — the twin of every backend's
/// `*_chart_layout` (issue #1079). Pure passthrough to
/// [`Chart::layout`]; kept here (rather than inlined at each call site)
/// so a future backend gets it for free, matching every other fn in
/// this module.
pub fn pixel_chart_layout(
    chart: &Chart,
    x: f32,
    y: f32,
    w: f32,
    h: f32,
    line_height: f32,
    char_width: f32,
) -> ChartLayout {
    chart.layout(
        x,
        y,
        ChartMeasure {
            width: w,
            height: h,
            char_width,
            line_height,
        },
    )
}

// ── DataTable ────────────────────────────────────────────────────────

/// Compute a [`DataTable`]'s layout via `measure` — the twin of every
/// backend's `*_data_table_layout` (issue #1079).
///
/// **The bug this fn fixes:** `GtkBackend::data_table_layout` (the
/// no-paint, click-routing path) used to measure each column header by
/// **byte length** (`col.title.len() as f32 * char_width`) instead of a
/// real text measurement — every other measurer in this crate (real
/// Pango/CoreText/DirectWrite metrics, or at worst a `chars().count()`
/// estimate) counts *characters*, not UTF-8 bytes, so a multi-byte
/// header (e.g. "日付") measured 2–3x too wide. Routing every backend's
/// column-header measurement through `measure: &dyn TextMeasure` — real
/// glyph metrics when a live font/context is available, a
/// character-count estimate otherwise (see each backend's `TextMeasure`
/// adapter) — makes that class of bug structurally impossible: there is
/// now exactly one measurement path, and it never sees raw byte counts.
pub fn pixel_data_table_layout(
    table: &DataTable,
    w: f32,
    h: f32,
    line_height: f32,
    measure: &dyn TextMeasure,
) -> DataTableLayout {
    let header_height = (line_height * 1.2).round();
    table.layout(
        w,
        h,
        line_height,
        header_height,
        pixel::DATA_TABLE_SCROLLBAR_WIDTH,
        |col| ColumnMeasure::new(measure.width_of(&col.title)),
    )
}

// ── Minimap ──────────────────────────────────────────────────────────

/// Compute a [`Minimap`]'s layout at an explicit [`MinimapScale`] (issue
/// #1143) — the twin of every backend's `*_minimap_layout_scaled` (issue
/// #1079). Every pixel backend shows one buffer line per painted row
/// ([`pixel::MINIMAP_LINES_PER_ROW`]) — no cross-line colour reduction
/// (see [`crate::MinimapGrid`]'s doc for why TUI's braille packing
/// differs).
pub fn pixel_minimap_layout_scaled(
    minimap: &Minimap,
    bounds: QRect,
    scale: MinimapScale,
) -> MinimapLayout {
    minimap.layout_with_sizing(
        bounds,
        pixel::MINIMAP_LINES_PER_ROW,
        MinimapSizing::FixedPitch(scale.row_pitch_px() as f32),
    )
}

// ── TabBar ───────────────────────────────────────────────────────────

/// Compute a [`TabBar`]'s pixel-unit layout — the composition every pixel
/// backend (`gtk`, `macos`, `win`) duplicated independently, once per
/// paint/no-paint twin (issue #1080: ~9 near-identical copies of this
/// exact arithmetic across `gtk::tab_bar`, `gtk::backend`,
/// `macos::tab_bar`, and `win::tab_bar`).
///
/// Backends still do their own **text measurement** — Pango / Core Text /
/// DirectWrite each need to switch fonts mid-tab (italic for a preview
/// label, a Nerd-Font family swap for an icon glyph), which a single
/// `&dyn TextMeasure` call can't express — so `tab_name_widths` and
/// `tab_icon_extras` are that backend-specific pass, precomputed by the
/// caller and handed in as parallel arrays indexed like `bar.tabs`
/// (`0.0` for a tab with no icon). Everything else is single-font and
/// lives here: close-button geometry, bracket framing (#631),
/// right-segment widths, the "corrected scroll offset" engine-feedback
/// signal, and `available_cols`.
///
/// `tab_pad` / `tab_inner_gap` / `tab_outer_gap` are the caller-resolved
/// values for this bar — pass the compact variant when `bar.compact` is
/// set, matching every backend's existing convention.
///
/// # The #1080 close-button fix
///
/// Every backend used to size the close-button hit region as
/// `tab_inner_gap + close_glyph_w + tab_pad + tab_outer_gap` — bundling
/// in the *trailing* chrome (the tab's own right padding and the gap to
/// the next tab) that paints nowhere near the × glyph. A click in that
/// dead space still resolved to [`crate::TabBarHit::TabClose`] instead of
/// [`crate::TabBarHit::Tab`]. This function reserves only
/// `tab_inner_gap + close_glyph_w` for the close region and pushes the
/// trailing chrome into [`TabMeasure::trailing_width`] instead (the same
/// mechanism #631 already used for bracket framing) — the close box now
/// covers just the glyph plus its leading gap, on every backend, bracket
/// framing or not.
///
/// # Returns
///
/// `(layout, corrected_scroll_offset, available_cols)`.
///
/// - `layout` — the resolved [`TabBarLayout`]; iterate `visible_tabs` /
///   `visible_segments` to paint, call `hit_test` for clicks. Computed
///   with `scroll_arrow_width: 0.0` (no backend using this fn paints
///   scroll arrows), so `layout.resolved_scroll_offset` is `bar
///   .scroll_offset` clamped to a valid index, not corrected — see
///   `corrected_scroll_offset` below for that.
/// - `corrected_scroll_offset` — the scroll offset that would keep the
///   active tab visible under *this frame's real measurements*. Callers
///   write this back to their stored scroll state for the next frame
///   (the "two-pass paint" pattern [`TabBar::layout`]'s doc describes).
/// - `available_cols` — the tab area's width in character-columns,
///   estimated from a [`pixel::TAB_CELL_WIDTH_SAMPLE`] sample measured
///   through `measure`. Hosts that budget tab visibility in cell units
///   even on a proportional-font backend (e.g. vimcode's
///   `Engine::set_tab_visible_count`) use this instead of a raw pixel
///   width.
#[allow(clippy::too_many_arguments)]
pub fn pixel_tab_bar_layout(
    bar: &TabBar,
    width: f32,
    height: f32,
    tab_pad: f32,
    tab_inner_gap: f32,
    tab_outer_gap: f32,
    tab_name_widths: &[f32],
    tab_icon_extras: &[f32],
    chrome: &TabChrome,
    measure: &dyn TextMeasure,
) -> (TabBarLayout, usize, usize) {
    let close_glyph_w = if bar.show_tab_close {
        measure.width_of("×")
    } else {
        0.0
    };
    let brackets = matches!(chrome.active_frame, TabFrame::Brackets);
    let (bracket_open_w, bracket_close_w) = if brackets {
        (measure.width_of("["), measure.width_of("]"))
    } else {
        (0.0, 0.0)
    };

    let measure_tab = |i: usize| -> TabMeasure {
        let name_w = tab_name_widths[i];
        let icon_extra = tab_icon_extras[i];
        let has_close = bar.show_tab_close && bar.tabs[i].is_closable;
        let is_bracket = brackets && bar.tabs[i].is_active;
        let close_extra = if has_close {
            tab_inner_gap + close_glyph_w
        } else {
            0.0
        };
        let bracket_extra = if is_bracket {
            bracket_open_w + bracket_close_w
        } else {
            0.0
        };
        let total =
            tab_pad + bracket_extra + icon_extra + name_w + close_extra + tab_pad + tab_outer_gap;
        if has_close {
            // #1080: tight close region — just the glyph and its leading
            // gap. Everything painted after it (the tab's own trailing
            // pad + outer gap, plus a closing bracket glyph when this is
            // the bracket-framed active tab) is `trailing_width`, not
            // part of the clickable close box.
            let close_w = tab_inner_gap + close_glyph_w;
            let trailing = tab_pad + tab_outer_gap + if is_bracket { bracket_close_w } else { 0.0 };
            TabMeasure::new(total, close_w).with_trailing(trailing)
        } else {
            TabMeasure::new(total, 0.0)
        }
    };
    let tab_measures: Vec<TabMeasure> = (0..bar.tabs.len()).map(&measure_tab).collect();

    let seg_widths: Vec<f32> = (0..bar.right_segments.len())
        .map(|i| measure.width_of(&bar.right_segments[i].text))
        .collect();

    let layout = bar.layout(
        width,
        height,
        0.0, // no scroll arrows — every pixel backend defers scroll to this fn
        |i| tab_measures[i],
        |i| SegmentMeasure::new(seg_widths[i]),
    );

    let reserved_px: f32 = seg_widths.iter().sum();
    let effective_tab_area = (width - reserved_px).max(0.0);

    let active_idx = bar.tabs.iter().position(|t| t.is_active);
    let corrected_scroll_offset = match active_idx {
        Some(active) => TabBar::fit_active_scroll_offset(
            active,
            bar.tabs.len(),
            effective_tab_area as usize,
            |i| tab_measures[i].total_width.ceil() as usize,
        ),
        None => bar.scroll_offset,
    };

    let sample_w = measure.width_of(pixel::TAB_CELL_WIDTH_SAMPLE);
    let char_w = (sample_w / pixel::TAB_CELL_WIDTH_SAMPLE.chars().count() as f32).max(1.0);
    let available_cols = (effective_tab_area / char_w).floor().max(0.0) as usize;

    (layout, corrected_scroll_offset, available_cols)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::primitives::message_list::{MessageList, MessageRow};
    use crate::primitives::multi_section_view::SectionBody;
    use crate::types::Color;

    #[test]
    fn msv_body_measure_message_list_is_not_zero() {
        // Regression for the macOS drift #499 fixes: MessageList bodies
        // must measure real content height, not 0.0.
        let rows = vec![MessageRow::new(
            "line one\nline two",
            Color::rgb(255, 255, 255),
            0.0,
        )];
        let body = SectionBody::MessageList(MessageList {
            id: WidgetId::new("test-msg-list"),
            rows,
            scroll_top: 0,
        });
        let measure = msv_body_measure(&body, &None, 20.0);
        assert!(
            measure.content_size > 0.0,
            "MessageList section must measure non-zero height, got {}",
            measure.content_size
        );
        // 1 header line + 2 body lines, at line_height 20.
        assert_eq!(measure.content_size, 20.0 + 2.0 * 20.0);
    }

    /// Fixed-width stand-in for a real font: `6.0` px per char. Lets
    /// `form_field_measure` (only exercised for real by macOS's
    /// `CtFontMeasure`, which can't run on a non-macOS CI host) get a
    /// platform-independent regression test here instead.
    struct FakeMeasure;
    impl TextMeasure for FakeMeasure {
        fn width_of(&self, text: &str) -> f32 {
            text.chars().count() as f32 * 6.0
        }
    }

    fn field_with(id: &str, label: &str, kind: FieldKind) -> FormField {
        FormField {
            id: WidgetId::new(id),
            label: crate::types::StyledText::plain(label),
            kind,
            hint: crate::types::StyledText::plain(""),
            disabled: false,
            validation: None,
        }
    }

    #[test]
    fn form_field_measure_toggle_group_computes_start_x_and_item_widths() {
        use crate::primitives::form::ToggleGroupItem;

        let field = field_with(
            "flags",
            "Flags", // 5 chars * 6.0 = 30.0
            FieldKind::ToggleGroup {
                toggles: vec![
                    ToggleGroupItem {
                        id: WidgetId::new("case"),
                        label: "Aa".into(), // 2 chars
                        value: false,
                    },
                    ToggleGroupItem {
                        id: WidgetId::new("word"),
                        label: "Word".into(), // 4 chars
                        value: true,
                    },
                ],
            },
        );
        let m = form_field_measure(&field, 20.0, &FakeMeasure);
        assert_eq!(m.height, 20.0);
        assert_eq!(m.items_start_x, 6.0 + 30.0 + 12.0);
        assert_eq!(m.item_gap, 8.0);
        assert_eq!(m.item_measures.len(), 2);
        assert_eq!(m.item_measures[0].width, 2.0 * 6.0);
        assert_eq!(m.item_measures[1].width, 4.0 * 6.0);
    }

    #[test]
    fn form_field_measure_segmented_control_has_no_item_gap() {
        let field = field_with(
            "scope",
            "",
            FieldKind::SegmentedControl {
                options: vec!["File".into(), "Project".into()],
                selected_idx: 0,
            },
        );
        let m = form_field_measure(&field, 20.0, &FakeMeasure);
        // `SegmentedControl` (unlike `Toolbar`) has no empty-label
        // special case: pre-#499 macOS and GTK's still-unmigrated
        // inline copy both compute the unconditional
        // `6.0 + label_w + 12.0` even when the label is empty.
        // Regression guard for the #499 review finding: this used to
        // silently drop to `6.0`.
        assert_eq!(m.items_start_x, 6.0 + 0.0 + 12.0);
        assert_eq!(m.item_gap, 0.0);
        assert_eq!(m.item_measures[0].id, WidgetId::new("scope__seg_0"));
        assert_eq!(m.item_measures[1].id, WidgetId::new("scope__seg_1"));
    }

    #[test]
    fn form_field_measure_toolbar_start_x_skips_gap_only_when_label_empty() {
        use crate::primitives::toolbar::{Toolbar, ToolbarButton};

        let toolbar = Toolbar {
            id: WidgetId::new("tb"),
            buttons: vec![ToolbarButton::Separator],
            bg: None,
            focused_index: None,
        };

        // Empty label -> Toolbar's pre-#499 special case: 6px inset,
        // no +label_w+12 addition.
        let empty_label = field_with("tb", "", FieldKind::Toolbar(toolbar.clone()));
        let m = form_field_measure(&empty_label, 20.0, &FakeMeasure);
        assert_eq!(m.items_start_x, 6.0);

        // Non-empty label -> unconditional 6 + label_w + 12, same as
        // the other row-item kinds.
        let with_label = field_with("tb", "Go", FieldKind::Toolbar(toolbar)); // 2 chars * 6.0 = 12.0
        let m = form_field_measure(&with_label, 20.0, &FakeMeasure);
        assert_eq!(m.items_start_x, 6.0 + 12.0 + 12.0);
    }

    #[test]
    fn form_field_measure_default_kind_has_no_items() {
        let field = field_with("name", "Name", FieldKind::Button);
        let m = form_field_measure(&field, 20.0, &FakeMeasure);
        assert_eq!(m.height, 20.0);
        assert!(m.item_measures.is_empty());
        assert_eq!(m.items_start_x, 0.0);
        assert_eq!(m.item_gap, 0.0);
    }

    /// Parity guard for issue #710: `GtkBackend::form_layout`,
    /// `macos::form::mac_form_layout`, and `win::form::win_form_layout`
    /// all measure every `FieldKind` by calling this one function —
    /// so this test is the single place that proves the invariant
    /// their painters rely on: `FormFieldMeasure::height` is always
    /// exactly one `row_h`, for *every* `FieldKind`, regardless of any
    /// field-specific content (multiple toggles, a long `TextArea`
    /// value, a large `visible_rows`).
    ///
    /// #710 was exactly a violation of this on GTK: before that fix,
    /// `GtkBackend::form_layout` had its own inline measurer (not this
    /// fn) that sized `FieldKind::TextArea` as `row_h * visible_rows`,
    /// while `gtk::form::draw_form` only ever painted one row per
    /// field — so the `visible_rows - 1` rows the layout believed
    /// belonged to the `TextArea` were actually painted with the
    /// *following* fields, and still hit-tested to the `TextArea`.
    /// Now that GTK measures via this shared fn too (matching macOS
    /// and Windows), a future regression that special-cases `TextArea`
    /// (or any other kind) back to a multi-row height here would be
    /// caught by every backend at once, instead of silently
    /// reappearing on just one of them.
    #[test]
    fn form_field_measure_height_is_one_row_for_every_field_kind() {
        use crate::primitives::form::{ButtonRowItem, ToggleGroupItem};
        use crate::primitives::toolbar::Toolbar;
        use crate::types::{Color, StyledText};

        const ROW_H: f32 = 20.0;

        let kinds = vec![
            ("label", FieldKind::Label),
            ("toggle", FieldKind::Toggle { value: true }),
            (
                "text-input",
                FieldKind::TextInput {
                    value: "hello".into(),
                    placeholder: String::new(),
                    cursor: Some(2),
                    selection_anchor: None,
                },
            ),
            ("button", FieldKind::Button),
            (
                "read-only",
                FieldKind::ReadOnly {
                    value: StyledText::plain("v1.0"),
                },
            ),
            (
                "slider",
                FieldKind::Slider {
                    value: 5.0,
                    min: 0.0,
                    max: 10.0,
                    step: 1.0,
                },
            ),
            (
                "color-picker",
                FieldKind::ColorPicker {
                    value: Color::rgb(255, 0, 0),
                },
            ),
            (
                "dropdown",
                FieldKind::Dropdown {
                    options: vec![StyledText::plain("a"), StyledText::plain("b")],
                    selected_idx: 0,
                },
            ),
            (
                // The regression case: a large `visible_rows` must NOT
                // scale `height` — see this test's own doc comment.
                "text-area",
                FieldKind::TextArea {
                    value: "line one\nline two\nline three".into(),
                    placeholder: String::new(),
                    cursor: Some(3),
                    visible_rows: 6,
                },
            ),
            (
                "password",
                FieldKind::PasswordInput {
                    value: "hunter2".into(),
                    placeholder: String::new(),
                    cursor: Some(3),
                    mask_char: '•',
                },
            ),
            (
                "segmented",
                FieldKind::SegmentedControl {
                    options: vec!["File".into(), "Folder".into()],
                    selected_idx: 0,
                },
            ),
            (
                "toggle-group",
                FieldKind::ToggleGroup {
                    toggles: vec![
                        ToggleGroupItem {
                            id: WidgetId::new("a"),
                            label: "Aa".into(),
                            value: false,
                        },
                        ToggleGroupItem {
                            id: WidgetId::new("b"),
                            label: "Bb".into(),
                            value: true,
                        },
                    ],
                },
            ),
            (
                "button-row",
                FieldKind::ButtonRow {
                    buttons: vec![ButtonRowItem {
                        id: WidgetId::new("find"),
                        label: "Find".into(),
                        disabled: false,
                        icon: None,
                    }],
                },
            ),
            (
                "toolbar",
                FieldKind::Toolbar(Toolbar {
                    id: WidgetId::new("tb"),
                    buttons: vec![],
                    bg: None,
                    focused_index: None,
                }),
            ),
        ];

        for (name, kind) in kinds {
            let field = field_with(name, "Label", kind);
            let m = form_field_measure(&field, ROW_H, &FakeMeasure);
            assert_eq!(
                m.height, ROW_H,
                "FieldKind::{name} must measure exactly one row_h ({ROW_H}), got {}",
                m.height,
            );
        }
    }

    // ── List (#712) ──────────────────────────────────────────────────

    fn list_with_max_content_width(n_items: usize, max_content_width: Option<usize>) -> ListView {
        use crate::primitives::list::ListItem;
        use crate::types::StyledText;

        ListView {
            id: WidgetId::new("l"),
            title: None,
            items: (0..n_items)
                .map(|i| ListItem {
                    text: StyledText::plain(format!("row {i}")),
                    icon: None,
                    detail: None,
                    decoration: Decoration::Normal,
                })
                .collect(),
            selected_idx: 0,
            scroll_offset: 0,
            has_focus: true,
            bordered: false,
            h_scroll: 0,
            max_content_width,
            show_v_scrollbar: false,
        }
    }

    /// The single reservation rule #712 exists to unify: when
    /// `max_content_width` (in chars) exceeds the visible width (chars ×
    /// `char_width`, in pixels), the bottom `line_height` row is reserved
    /// for the h-scrollbar and is not available to items — one fewer row
    /// fits than when no overflow is signalled. Every pixel backend
    /// shares this exact function, so proving it here proves it for all
    /// of them at once.
    #[test]
    fn list_layout_reserves_hscrollbar_row_when_content_overflows() {
        const LINE_HEIGHT: f64 = 10.0;
        const CHAR_WIDTH: f64 = 8.0;
        const W: f64 = 200.0; // 25 chars visible at CHAR_WIDTH.
        const H: f64 = 100.0; // 10 rows at LINE_HEIGHT with no reservation.

        let overflowing = list_with_max_content_width(12, Some(1000));
        let fitting = list_with_max_content_width(12, None);

        let with_reservation = list_layout(&overflowing, W, H, LINE_HEIGHT, CHAR_WIDTH, 0.0);
        let without_reservation = list_layout(&fitting, W, H, LINE_HEIGHT, CHAR_WIDTH, 0.0);

        assert_eq!(
            without_reservation.visible_items.len(),
            10,
            "sanity: 100px / 10px rows == 10 full rows with no reservation"
        );
        assert_eq!(
            with_reservation.visible_items.len(),
            9,
            "overflowing max_content_width must reserve exactly one \
             line_height row for the h-scrollbar, leaving 9 rows"
        );

        let last = with_reservation.visible_items.last().unwrap();
        assert!(
            (last.bounds.y + last.bounds.height) as f64 <= H - LINE_HEIGHT,
            "reserved layout's content must stop at or before the \
             scrollbar row's top edge"
        );
    }

    #[test]
    fn list_layout_border_inset_reduces_visible_width_for_overflow_check() {
        // A `max_content_width` that only overflows once the border
        // inset narrows the visible width must still trigger the
        // reservation — mirrors GTK's `bordered` lists.
        const LINE_HEIGHT: f64 = 10.0;
        const CHAR_WIDTH: f64 = 8.0;
        const W: f64 = 200.0;
        const H: f64 = 100.0;
        const BORDER_INSET: f64 = 1.0;

        // 24 chars * 8px = 192px, which fits in the full 200px width but
        // not in the 198px width left after a 1px border inset on each
        // side... so pick a value that straddles exactly that gap.
        let list = list_with_max_content_width(12, Some(25)); // 25*8=200 > 198

        let with_border = list_layout(&list, W, H, LINE_HEIGHT, CHAR_WIDTH, BORDER_INSET);
        let without_border = list_layout(&list, W, H, LINE_HEIGHT, CHAR_WIDTH, 0.0);

        assert_eq!(
            without_border.visible_items.len(),
            10,
            "200px content width == 200px visible width: no overflow, no reservation"
        );
        assert_eq!(
            with_border.visible_items.len(),
            9,
            "200px content width > 198px visible width once border-inset \
             narrows it: overflow, reservation kicks in"
        );
    }

    // ── #1043 tree_row_pitch ─────────────────────────────────────────

    fn bare_tree() -> TreeView {
        TreeView {
            id: WidgetId::new("t"),
            rows: vec![],
            selection_mode: crate::types::SelectionMode::Single,
            selected_path: None,
            scroll_offset: 0,
            style: crate::types::TreeStyle::default(),
            has_focus: false,
        }
    }

    #[test]
    fn tree_row_pitch_matches_tree_layout_non_header_pitch_by_default() {
        // Must stay identical to the `item_height` `tree_layout` computes
        // for non-header rows — that's the whole point of sharing this fn.
        let tree = bare_tree();
        assert_eq!(tree_row_pitch(&tree, 16.0), (16.0_f64 * 1.4).round());
    }

    #[test]
    fn tree_row_pitch_honors_tree_style_row_height_override() {
        // #623: a host-set `TreeStyle::row_height` must win over the
        // `line_height`-derived default, exactly like `tree_layout` does.
        let mut tree = bare_tree();
        tree.style.row_height = Some(42);
        assert_eq!(tree_row_pitch(&tree, 16.0), 42.0);
        // And it must NOT vary with `line_height` once set.
        assert_eq!(tree_row_pitch(&tree, 100.0), 42.0);
    }

    // ── #1080 pixel_tab_bar_layout ────────────────────────────────────

    /// Fixed-width stand-in for a proportional font: every glyph measures
    /// `6.0` px, matching `FakeMeasure` above but named locally so this
    /// section reads standalone.
    struct FakeTabMeasure;
    impl TextMeasure for FakeTabMeasure {
        fn width_of(&self, text: &str) -> f32 {
            text.chars().count() as f32 * 6.0
        }
    }

    fn tab_bar_with(tabs: Vec<crate::primitives::tab_bar::TabItem>) -> TabBar {
        TabBar {
            id: WidgetId::new("tabs"),
            tabs,
            scroll_offset: 0,
            right_segments: vec![],
            active_accent: None,
            show_tab_close: true,
            compact: false,
        }
    }

    fn closable_tab(label: &str, is_active: bool) -> crate::primitives::tab_bar::TabItem {
        crate::primitives::tab_bar::TabItem {
            label: label.to_string(),
            is_active,
            is_dirty: false,
            is_preview: false,
            is_closable: true,
        }
    }

    #[test]
    fn pixel_tab_bar_layout_populates_available_cols() {
        let bar = tab_bar_with(vec![closable_tab("main.rs", true)]);
        let name_widths = [bar.tabs[0].label.chars().count() as f32 * 6.0];
        let icon_extras = [0.0_f32];
        let (_, _, available_cols) = pixel_tab_bar_layout(
            &bar,
            400.0,
            22.0,
            pixel::TAB_PAD,
            pixel::TAB_INNER_GAP,
            pixel::TAB_OUTER_GAP,
            &name_widths,
            &icon_extras,
            &TabChrome::default(),
            &FakeTabMeasure,
        );
        assert!(
            available_cols > 0,
            "a 400px bar with a single short tab should report a non-zero \
             available_cols, got {available_cols}"
        );
    }

    /// The issue #1080 acceptance test: a click in the dead space the old
    /// per-backend measure used to bundle into the close region — between
    /// the × glyph and the tab's own right edge (`tab_pad + tab_outer_gap`
    /// of trailing chrome) — must resolve to `Tab`, not `TabClose`. RED
    /// before this fix on every backend that called
    /// `TabMeasure::new(total, tab_inner_gap + close_w + tab_pad +
    /// tab_outer_gap)` instead of reserving `trailing_width` for that
    /// chrome.
    #[test]
    fn pixel_tab_bar_layout_close_region_excludes_trailing_padding() {
        use crate::primitives::tab_bar::TabBarHit;

        let bar = tab_bar_with(vec![closable_tab("main.rs", true)]);
        let name_widths = [bar.tabs[0].label.chars().count() as f32 * 6.0];
        let icon_extras = [0.0_f32];
        let (layout, _, _) = pixel_tab_bar_layout(
            &bar,
            400.0,
            22.0,
            pixel::TAB_PAD,
            pixel::TAB_INNER_GAP,
            pixel::TAB_OUTER_GAP,
            &name_widths,
            &icon_extras,
            &TabChrome::default(),
            &FakeTabMeasure,
        );

        let vt = &layout.visible_tabs[0];
        let close = vt
            .close_bounds
            .expect("closable tab must report close bounds");
        let tab_right_edge = vt.bounds.x + vt.bounds.width;

        // The old (buggy) close region ran all the way to the tab's right
        // edge. The fixed region must stop short of it, leaving the
        // trailing `tab_pad + tab_outer_gap` as dead space that belongs to
        // the tab body, not the close button.
        assert!(
            close.x + close.width < tab_right_edge,
            "close region [{}, {}) must stop before the tab's right edge {}",
            close.x,
            close.x + close.width,
            tab_right_edge,
        );

        // A click just inside that trailing dead space — 1px short of the
        // tab's right edge — must resolve to `Tab`, not `TabClose`.
        let probe_x = tab_right_edge - 1.0;
        assert!(
            probe_x >= close.x + close.width,
            "test fixture's probe point must actually fall in the trailing \
             gap, past the close region's own right edge"
        );
        match layout.hit_test(probe_x, vt.bounds.y + vt.bounds.height / 2.0) {
            TabBarHit::Tab(0) => {}
            other => panic!(
                "click at x={probe_x} (old padding, now outside the close glyph) \
                 expected Tab(0), got {other:?}"
            ),
        }

        // And a click at the close region's own centre must still resolve
        // to `TabClose` — the fix must not shrink the box past the glyph
        // itself.
        let (cx, cy) = (
            close.x + close.width / 2.0,
            vt.bounds.y + vt.bounds.height / 2.0,
        );
        assert_eq!(layout.hit_test(cx, cy), TabBarHit::TabClose(0));
    }

    #[test]
    fn pixel_tab_bar_layout_corrected_scroll_offset_keeps_active_tab_visible() {
        let tabs: Vec<_> = (0..10)
            .map(|i| closable_tab(&format!("t{i}"), i == 9))
            .collect();
        let mut bar = tab_bar_with(tabs);
        bar.scroll_offset = 0; // stale — active tab (9) is not visible at offset 0
        let name_widths = vec![6.0_f32; bar.tabs.len()]; // "t0".."t9" — 2 chars * 6px
        let icon_extras = vec![0.0_f32; bar.tabs.len()];
        let (_, corrected_scroll_offset, _) = pixel_tab_bar_layout(
            &bar,
            120.0,
            22.0,
            pixel::TAB_PAD,
            pixel::TAB_INNER_GAP,
            pixel::TAB_OUTER_GAP,
            &name_widths,
            &icon_extras,
            &TabChrome::default(),
            &FakeTabMeasure,
        );
        assert!(
            corrected_scroll_offset > 0,
            "active tab 9 isn't visible at the stale scroll_offset 0; the \
             corrected offset must be non-zero"
        );
    }

    #[test]
    fn pixel_tab_bar_layout_bracket_chrome_still_excludes_trailing_padding() {
        // #631 bracket framing must not regress the #1080 tight-close-box
        // fix: the close region still excludes the trailing pad/gap (now
        // plus the closing bracket glyph), matching the plain path.
        use crate::primitives::tab_bar::{TabBarHit, TabFrame};

        let bar = tab_bar_with(vec![closable_tab("main.rs", true)]);
        let name_widths = [bar.tabs[0].label.chars().count() as f32 * 6.0];
        let icon_extras = [0.0_f32];
        let chrome = TabChrome::new(TabFrame::Brackets);
        let (layout, _, _) = pixel_tab_bar_layout(
            &bar,
            400.0,
            22.0,
            pixel::TAB_PAD,
            pixel::TAB_INNER_GAP,
            pixel::TAB_OUTER_GAP,
            &name_widths,
            &icon_extras,
            &chrome,
            &FakeTabMeasure,
        );

        let vt = &layout.visible_tabs[0];
        let close = vt
            .close_bounds
            .expect("closable tab must report close bounds");
        let tab_right_edge = vt.bounds.x + vt.bounds.width;
        assert!(
            close.x + close.width < tab_right_edge,
            "bracket-framed close region must still stop before the tab's \
             right edge (now with room for the closing bracket too)"
        );
        match layout.hit_test(tab_right_edge - 1.0, vt.bounds.y + vt.bounds.height / 2.0) {
            TabBarHit::Tab(0) => {}
            other => {
                panic!("click in the trailing bracket+padding gap expected Tab(0), got {other:?}")
            }
        }
    }
}