qql-cli 0.4.1

Command-line interface, REPL, converter, and migration tools for QQL
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
use std::path::PathBuf;

use serde::{Deserialize, Serialize};

#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(default)]
pub struct EdgeConfig {
    pub data_dir: PathBuf,
    pub on_disk_payload: bool,
    /// WAL segment capacity in MiB for local edge shards. `None` keeps the
    /// qdrant-edge default (32 MiB pre-allocated per segment). Also exposed by
    /// the Python/Node edge SDKs; qdrant-edge 0.8's own Python binding cannot
    /// set it.
    pub wal_segment_mb: Option<u64>,
    pub embedder: String,
    pub model: Option<String>,
    /// Offline sparse model for fastembed (e.g. `"splade"`, `"bge-m3"`).
    pub sparse_model: Option<String>,
    /// Offline multivector model for fastembed (e.g. `"bge-m3"`).
    pub multi_model: Option<String>,
    /// Offline CLIP vision model (e.g. `"clip-vision"`).
    pub image_model: Option<String>,
    /// Offline cross-encoder model (e.g. `"bge-reranker-base"`).
    pub reranker_model: Option<String>,
    pub cache_dir: Option<PathBuf>,
    pub show_download_progress: bool,
    /// Client-side BM25 `k1` for the local wire-compatible document encoder
    /// (used when no offline sparse model is configured). `None` → Qdrant
    /// `qdrant/bm25` default (`1.2`). Write-path only; invalid values fail
    /// closed with `QQL-VALIDATION-CONFIG`.
    pub bm25_k1: Option<f64>,
    /// Client-side BM25 `b` (`[0, 1]`); `None` → `0.75`.
    pub bm25_b: Option<f64>,
    /// Client-side BM25 expected average document length in tokens;
    /// `None` → `256`.
    pub bm25_avg_len: Option<f64>,
    /// BM25 text-processing language (Qdrant name/alias); `None` → English.
    pub bm25_language: Option<String>,
    /// BM25 tokenizer (`word`/`whitespace`/`prefix`/`multilingual`).
    pub bm25_tokenizer: Option<String>,
    /// Lowercase before matching; `None` → `true`.
    pub bm25_lowercase: Option<bool>,
    /// Lucene ASCII folding before lowercasing; `None` → `false`.
    pub bm25_ascii_folding: Option<bool>,
    /// Drop tokens shorter than this (chars).
    pub bm25_min_token_len: Option<usize>,
    /// Drop over-long tokens on the document path (chars).
    pub bm25_max_token_len: Option<usize>,
    /// Custom stopwords replacing the language default (config file only;
    /// lists don't fit CLI flags; `[]` disables filtering).
    pub bm25_stopwords: Option<Vec<String>>,
    /// Additional language stopword lists (config file only).
    pub bm25_stopwords_languages: Option<Vec<String>>,
    /// Stemmer override (`None` = language default; `"none"` disables).
    pub bm25_stemmer: Option<String>,
    pub embed_url: Option<String>,
    pub embed_key: String,
    pub embed_model: String,
    pub embed_dimension: usize,
    pub multi_embed_url: Option<String>,
    pub multi_embed_key: Option<String>,
    pub multi_embed_model: Option<String>,
    pub multi_embed_dimension: usize,
    pub image_embed_url: Option<String>,
    pub image_embed_key: Option<String>,
    pub image_embed_model: Option<String>,
    pub image_embed_dimension: usize,
}

impl Default for EdgeConfig {
    fn default() -> Self {
        let data_dir = qql::config::QqlConfig::config_dir()
            .unwrap_or_else(|_| PathBuf::from(".qql"))
            .join("edge-data");
        Self {
            data_dir,
            on_disk_payload: true,
            wal_segment_mb: None,
            embedder: "fastembed".to_string(),
            model: None,
            sparse_model: None,
            multi_model: None,
            image_model: None,
            reranker_model: None,
            cache_dir: None,
            show_download_progress: false,
            bm25_k1: None,
            bm25_b: None,
            bm25_avg_len: None,
            bm25_language: None,
            bm25_tokenizer: None,
            bm25_lowercase: None,
            bm25_ascii_folding: None,
            bm25_min_token_len: None,
            bm25_max_token_len: None,
            bm25_stopwords: None,
            bm25_stemmer: None,
            bm25_stopwords_languages: None,
            embed_url: None,
            embed_key: String::new(),
            embed_model: "nomic-embed-text".to_string(),
            embed_dimension: 768,
            multi_embed_url: None,
            multi_embed_key: None,
            multi_embed_model: None,
            multi_embed_dimension: 0,
            image_embed_url: None,
            image_embed_key: None,
            image_embed_model: None,
            image_embed_dimension: 0,
        }
    }
}

/// Fields explicitly supplied to `qql config edge`.
///
/// This is a **patch**, not a full config: `None` (and omitted serialization)
/// means "leave the persisted value untouched", so an update preserves sibling
/// keys — including keys written by a newer binary that this build does not
/// know about.
#[derive(Debug, Clone, Default, Serialize)]
pub struct EdgeConfigPatch {
    #[serde(skip_serializing_if = "Option::is_none")]
    pub data_dir: Option<PathBuf>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub on_disk_payload: Option<bool>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub wal_segment_mb: Option<u64>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub embedder: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub model: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub sparse_model: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub multi_model: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub image_model: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub reranker_model: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub cache_dir: Option<PathBuf>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub show_download_progress: Option<bool>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_k1: Option<f64>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_b: Option<f64>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_avg_len: Option<f64>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_language: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_tokenizer: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_lowercase: Option<bool>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_ascii_folding: Option<bool>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_min_token_len: Option<usize>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_max_token_len: Option<usize>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub bm25_stemmer: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub embed_url: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub embed_key: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub embed_model: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub embed_dimension: Option<usize>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub multi_embed_url: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub multi_embed_key: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub multi_embed_model: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub multi_embed_dimension: Option<usize>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub image_embed_url: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub image_embed_key: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub image_embed_model: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub image_embed_dimension: Option<usize>,
}

impl EdgeConfigPatch {
    /// Overlay this patch onto a persisted JSON object: keys the patch sets
    /// win, every other key is preserved verbatim — including unknown/future
    /// keys this binary does not understand.
    pub fn merge_into(
        &self,
        object: &mut serde_json::Map<String, serde_json::Value>,
    ) -> Result<(), qql_core::error::QqlError> {
        let value = serde_json::to_value(self).map_err(|error| {
            qql_core::error::QqlError::execution(
                "QQL-EDGE-CONFIG",
                format!("failed to serialize edge configuration patch: {error}"),
                None,
            )
        })?;
        if let serde_json::Value::Object(patch) = value {
            object.extend(patch);
        }
        Ok(())
    }
}

impl EdgeConfig {
    pub fn path() -> Result<PathBuf, qql_core::error::QqlError> {
        Ok(qql::config::QqlConfig::config_dir()?.join("edge.json"))
    }

    #[cfg(feature = "edge")]
    pub fn load() -> Result<Self, qql_core::error::QqlError> {
        let path = Self::path()?;
        if !path.exists() {
            return Ok(Self::default());
        }
        let source = std::fs::read_to_string(&path).map_err(|error| {
            qql_core::error::QqlError::execution(
                "QQL-EDGE-CONFIG",
                format!("failed to read {}: {error}", path.display()),
                None,
            )
        })?;
        serde_json::from_str(&source).map_err(|error| {
            qql_core::error::QqlError::execution(
                "QQL-EDGE-CONFIG",
                format!("failed to parse {}: {error}", path.display()),
                None,
            )
        })
    }

    /// Overlay `patch` onto the persisted `edge.json`.
    ///
    /// Every key the patch does not set is preserved verbatim, including
    /// unknown/future keys. Returns the merged typed config (for validation
    /// against the final state, not just the patch) and the merged JSON object
    /// to write.
    pub fn merged_with(
        patch: &EdgeConfigPatch,
    ) -> Result<(Self, serde_json::Map<String, serde_json::Value>), qql_core::error::QqlError> {
        let mut object = Self::load_object()?;
        patch.merge_into(&mut object)?;
        let merged: Self = serde_json::from_value(serde_json::Value::Object(object.clone()))
            .map_err(|error| {
                qql_core::error::QqlError::execution(
                    "QQL-EDGE-CONFIG",
                    format!("failed to parse merged edge configuration: {error}"),
                    None,
                )
            })?;
        Ok((merged, object))
    }

    /// Read `edge.json` as a JSON object; `{}` when the file does not exist.
    fn load_object() -> Result<serde_json::Map<String, serde_json::Value>, qql_core::error::QqlError>
    {
        let path = Self::path()?;
        if !path.exists() {
            return Ok(serde_json::Map::new());
        }
        let source = std::fs::read_to_string(&path).map_err(|error| {
            qql_core::error::QqlError::execution(
                "QQL-EDGE-CONFIG",
                format!("failed to read {}: {error}", path.display()),
                None,
            )
        })?;
        match serde_json::from_str::<serde_json::Value>(&source).map_err(|error| {
            qql_core::error::QqlError::execution(
                "QQL-EDGE-CONFIG",
                format!("failed to parse {}: {error}", path.display()),
                None,
            )
        })? {
            serde_json::Value::Object(object) => Ok(object),
            _ => Err(qql_core::error::QqlError::execution(
                "QQL-EDGE-CONFIG",
                format!("{} must contain a JSON object", path.display()),
                None,
            )),
        }
    }

    /// Pretty-write a merged object to `edge.json` with `0600` permissions.
    pub fn write_object(
        object: &serde_json::Map<String, serde_json::Value>,
    ) -> Result<PathBuf, qql_core::error::QqlError> {
        let path = Self::path()?;
        let source = serde_json::to_string_pretty(object).map_err(|error| {
            qql_core::error::QqlError::execution(
                "QQL-EDGE-CONFIG",
                format!("failed to serialize edge configuration: {error}"),
                None,
            )
        })?;
        std::fs::write(&path, source).map_err(|error| {
            qql_core::error::QqlError::execution(
                "QQL-EDGE-CONFIG",
                format!("failed to write {}: {error}", path.display()),
                None,
            )
        })?;
        #[cfg(unix)]
        {
            use std::os::unix::fs::PermissionsExt;

            std::fs::set_permissions(&path, std::fs::Permissions::from_mode(0o600)).map_err(
                |error| {
                    qql_core::error::QqlError::execution(
                        "QQL-EDGE-CONFIG",
                        format!("failed to protect {}: {error}", path.display()),
                        None,
                    )
                },
            )?;
        }
        Ok(path)
    }

    #[cfg(feature = "edge")]
    pub fn apply_environment(mut self) -> Self {
        if let Some(value) = env_string("QQL_EDGE_DATA_DIR") {
            self.data_dir = PathBuf::from(value);
        }
        if let Some(value) = env_string("QQL_EDGE_EMBEDDER") {
            self.embedder = value;
        }
        if let Some(value) = env_string("QQL_EDGE_MODEL") {
            self.model = Some(value);
        }
        if let Some(value) = env_string("QQL_EDGE_SPARSE_MODEL") {
            self.sparse_model = Some(value);
        }
        if let Some(value) = env_string("QQL_EDGE_MULTI_MODEL") {
            self.multi_model = Some(value);
        }
        if let Some(value) = env_string("QQL_EDGE_IMAGE_MODEL") {
            self.image_model = Some(value);
        }
        if let Some(value) =
            env_string("QQL_EDGE_RERANKER_MODEL").or_else(|| env_string("RERANK_MODEL"))
        {
            self.reranker_model = Some(value);
        }
        if let Some(value) = env_string("QQL_EDGE_CACHE_DIR") {
            self.cache_dir = Some(PathBuf::from(value));
        }
        if let Some(value) = env_f64("QQL_EDGE_BM25_K1") {
            self.bm25_k1 = Some(value);
        }
        if let Some(value) = env_f64("QQL_EDGE_BM25_B") {
            self.bm25_b = Some(value);
        }
        if let Some(value) = env_f64("QQL_EDGE_BM25_AVG_LEN") {
            self.bm25_avg_len = Some(value);
        }
        if let Some(value) = env_string("QQL_EDGE_BM25_LANGUAGE") {
            self.bm25_language = Some(value);
        }
        if let Some(value) = env_string("QQL_EDGE_BM25_TOKENIZER") {
            self.bm25_tokenizer = Some(value);
        }
        if let Some(value) = env_bool("QQL_EDGE_BM25_LOWERCASE") {
            self.bm25_lowercase = Some(value);
        }
        if let Some(value) = env_bool("QQL_EDGE_BM25_ASCII_FOLDING") {
            self.bm25_ascii_folding = Some(value);
        }
        // Note: unlike env_f64 (garbage → NaN → validator rejects), unparseable
        // bool/usize env values read as unset (keep default). Strings that must
        // fail closed (language/tokenizer/stemmer) go through the validator.
        if let Some(value) = env_usize("QQL_EDGE_BM25_MIN_TOKEN_LEN") {
            self.bm25_min_token_len = Some(value);
        }
        if let Some(value) = env_usize("QQL_EDGE_BM25_MAX_TOKEN_LEN") {
            self.bm25_max_token_len = Some(value);
        }
        if let Some(value) = env_string("QQL_EDGE_BM25_STEMMER") {
            self.bm25_stemmer = Some(value);
        }
        if let Some(value) = env_bool("QQL_EDGE_ON_DISK") {
            self.on_disk_payload = value;
        }
        if let Some(value) = env_usize("QQL_EDGE_WAL_SEGMENT_MB") {
            self.wal_segment_mb = Some(value as u64);
        }
        if let Some(value) = env_string("EMBED_URL") {
            self.embed_url = Some(value);
        }
        if let Some(value) = env_string("EMBED_KEY") {
            self.embed_key = value;
        }
        if let Some(value) = env_string("EMBED_MODEL") {
            self.embed_model = value;
        }
        if let Some(value) = env_usize("EMBED_DIM") {
            self.embed_dimension = value;
        }
        if let Some(value) = env_string("MULTI_EMBED_URL") {
            self.multi_embed_url = Some(value);
        }
        if let Some(value) = env_string("MULTI_EMBED_KEY") {
            self.multi_embed_key = Some(value);
        }
        if let Some(value) = env_string("MULTI_EMBED_MODEL") {
            self.multi_embed_model = Some(value.clone());
            if self.multi_model.is_none() {
                self.multi_model = Some(value);
            }
        }
        if let Some(value) = env_usize("MULTI_EMBED_DIM") {
            self.multi_embed_dimension = value;
        }
        if let Some(value) = env_string("IMAGE_EMBED_URL") {
            self.image_embed_url = Some(value);
        }
        if let Some(value) = env_string("IMAGE_EMBED_KEY") {
            self.image_embed_key = Some(value);
        }
        if let Some(value) = env_string("IMAGE_EMBED_MODEL") {
            self.image_embed_model = Some(value.clone());
            if self.image_model.is_none() {
                self.image_model = Some(value);
            }
        }
        if let Some(value) = env_usize("IMAGE_EMBED_DIM") {
            self.image_embed_dimension = value;
        }
        self
    }
}

#[cfg(feature = "edge")]
fn env_string(name: &str) -> Option<String> {
    std::env::var(name)
        .ok()
        .filter(|value| !value.trim().is_empty())
}

#[cfg(feature = "edge")]
fn env_bool(name: &str) -> Option<bool> {
    let value = env_string(name)?;
    match value.to_ascii_lowercase().as_str() {
        "1" | "true" | "yes" | "on" => Some(true),
        "0" | "false" | "no" | "off" => Some(false),
        _ => None,
    }
}

#[cfg(feature = "edge")]
fn env_usize(name: &str) -> Option<usize> {
    env_string(name)?.parse().ok()
}

/// Parse a float env override, mapping malformed values to `NaN` so they fail
/// closed in the BM25 validator (`QQL-VALIDATION-CONFIG`) instead of being
/// silently ignored.
#[cfg(feature = "edge")]
fn env_f64(name: &str) -> Option<f64> {
    parse_bm25_env(env_string(name))
}

#[cfg(feature = "edge")]
fn parse_bm25_env(value: Option<String>) -> Option<f64> {
    Some(value?.parse().unwrap_or(f64::NAN))
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn edge_config_default_has_no_sparse_model() {
        let cfg = EdgeConfig::default();
        assert!(cfg.sparse_model.is_none());
    }

    #[test]
    fn edge_config_with_sparse_model() {
        let cfg = EdgeConfig {
            sparse_model: Some("splade".into()),
            ..Default::default()
        };
        assert_eq!(cfg.sparse_model.as_deref(), Some("splade"));
    }

    #[test]
    fn edge_config_default_keeps_other_models_none() {
        let cfg = EdgeConfig::default();
        assert!(cfg.model.is_none());
        assert!(cfg.sparse_model.is_none());
        assert!(cfg.multi_model.is_none());
        assert!(cfg.image_model.is_none());
        assert!(cfg.reranker_model.is_none());
    }

    #[test]
    fn edge_config_default_keeps_bm25_unset() {
        let cfg = EdgeConfig::default();
        assert_eq!(cfg.bm25_k1, None);
        assert_eq!(cfg.bm25_b, None);
        assert_eq!(cfg.bm25_avg_len, None);
    }

    #[test]
    fn edge_config_bm25_values_roundtrip_through_json() {
        let cfg = EdgeConfig {
            bm25_k1: Some(2.0),
            bm25_b: Some(0.5),
            bm25_avg_len: Some(8.0),
            ..Default::default()
        };
        let json = serde_json::to_string(&cfg).expect("serialize");
        let back: EdgeConfig = serde_json::from_str(&json).expect("deserialize");
        assert_eq!(back.bm25_k1, Some(2.0));
        assert_eq!(back.bm25_b, Some(0.5));
        assert_eq!(back.bm25_avg_len, Some(8.0));
    }

    #[test]
    #[cfg(feature = "edge")]
    fn parse_bm25_env_malformed_values_fail_closed_as_nan() {
        // Malformed numbers must not be silently dropped: NaN fails the BM25
        // validator so the executor refuses to start instead.
        assert!(
            parse_bm25_env(Some("not-a-number".into()))
                .unwrap()
                .is_nan()
        );
        assert!(parse_bm25_env(Some(f64::NAN.to_string())).unwrap().is_nan());
        assert_eq!(parse_bm25_env(Some("2.5".into())), Some(2.5));
        assert_eq!(parse_bm25_env(None), None);
    }

    #[test]
    fn patch_serializes_only_set_fields() {
        let patch = EdgeConfigPatch {
            wal_segment_mb: Some(4),
            embedder: Some("http".into()),
            ..Default::default()
        };
        assert_eq!(
            serde_json::to_value(&patch).expect("serialize patch"),
            serde_json::json!({ "wal_segment_mb": 4, "embedder": "http" })
        );
    }

    #[test]
    fn patch_merge_preserves_siblings_and_unknown_keys() {
        let mut persisted = serde_json::json!({
            "wal_segment_mb": 8,
            "embedder": "http",
            "embed_url": "http://embed.local/v1/embeddings",
            "embed_model": "custom-model",
            "future_knob": { "nested": true },
        })
        .as_object()
        .cloned()
        .expect("object");

        let patch = EdgeConfigPatch {
            wal_segment_mb: Some(4),
            ..Default::default()
        };
        patch.merge_into(&mut persisted).expect("merge");

        assert_eq!(persisted["wal_segment_mb"], serde_json::json!(4));
        // Known siblings the patch did not set survive the update.
        assert_eq!(persisted["embedder"], serde_json::json!("http"));
        assert_eq!(
            persisted["embed_url"],
            serde_json::json!("http://embed.local/v1/embeddings")
        );
        assert_eq!(persisted["embed_model"], serde_json::json!("custom-model"));
        // Unknown/future keys survive too.
        assert_eq!(
            persisted["future_knob"],
            serde_json::json!({"nested": true})
        );

        // The merged object still deserializes into a complete config.
        let merged: EdgeConfig =
            serde_json::from_value(serde_json::Value::Object(persisted)).expect("typed merge");
        assert_eq!(merged.wal_segment_mb, Some(4));
        assert_eq!(merged.embedder, "http");
        assert_eq!(
            merged.embed_url.as_deref(),
            Some("http://embed.local/v1/embeddings")
        );
        assert_eq!(merged.embed_model, "custom-model");
    }
}