1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
use crate::PluginError;
/// CSRF protection plugin.
///
/// Validates the `Origin` or `Referer` header on state-changing requests
/// (POST, PATCH, DELETE, PUT) against a list of allowed origins. This is
/// complementary to CORS: CORS controls which origins can *read* responses,
/// while CSRF protection ensures that state-changing requests originate from
/// trusted sources.
pub struct CsrfPlugin {
allowed_origins: Vec<String>,
}
impl CsrfPlugin {
/// Create a CSRF plugin with explicit allowed origins.
pub fn new(allowed_origins: Vec<String>) -> Self {
Self { allowed_origins }
}
/// Convenience constructor for local development. Allows both `localhost`
/// and `127.0.0.1` on the given port.
pub fn with_localhost(port: u16) -> Self {
Self::new(vec![
format!("http://localhost:{port}"),
format!("http://127.0.0.1:{port}"),
])
}
/// Safe (read-only) methods that do not require origin validation.
fn is_safe_method(method: &str) -> bool {
matches!(method, "GET" | "HEAD" | "OPTIONS")
}
/// Check whether `origin` is in the allowlist. A wildcard entry (`"*"`)
/// matches every origin.
fn is_allowed_origin(&self, origin: &str) -> bool {
self.allowed_origins.iter().any(|o| o == origin || o == "*")
}
/// Extract the origin portion (`scheme://host[:port]`) from a full URL
/// such as a `Referer` header value.
///
/// ```text
/// "http://example.com/path?q=1" -> Some("http://example.com")
/// "https://a.b:8080/x" -> Some("https://a.b:8080")
/// "garbage" -> None
/// ```
fn origin_from_referer(referer: &str) -> Option<String> {
// Split on '/' keeping at most 4 parts:
// "http:" "" "example.com" "path..."
let parts: Vec<&str> = referer.splitn(4, '/').collect();
if parts.len() >= 3 && !parts[2].is_empty() {
Some(format!("{}//{}", parts[0], parts[2]))
} else {
None
}
}
/// Validate an incoming request.
///
/// For safe methods this always succeeds. For state-changing methods the
/// `Origin` header is checked first; if absent the origin is derived from
/// the `Referer` header. If neither header provides a trusted origin the
/// request is rejected.
pub fn check(
&self,
method: &str,
origin: Option<&str>,
referer: Option<&str>,
) -> Result<(), PluginError> {
if Self::is_safe_method(method) {
return Ok(());
}
let effective_origin = origin
.map(String::from)
.or_else(|| referer.and_then(Self::origin_from_referer));
match effective_origin {
Some(ref o) if self.is_allowed_origin(o) => Ok(()),
Some(ref o) => Err(PluginError {
code: "CSRF_REJECTED".into(),
message: format!("Origin '{}' not allowed", o),
status: 403,
}),
None => Err(PluginError {
code: "CSRF_NO_ORIGIN".into(),
message: "Missing Origin header on state-changing request".into(),
status: 403,
}),
}
}
}
impl crate::Plugin for CsrfPlugin {
fn name(&self) -> &str {
"csrf"
}
fn on_request(
&self,
_method: &str,
_path: &str,
_auth: &pylon_auth::AuthContext,
) -> Result<(), PluginError> {
// The Plugin trait's on_request does not receive HTTP headers, so CSRF
// validation cannot happen here automatically. Use `check()` at the
// HTTP layer where headers are available.
Ok(())
}
}
#[cfg(test)]
mod tests {
use super::*;
fn localhost_plugin() -> CsrfPlugin {
CsrfPlugin::with_localhost(3000)
}
// -- Safe methods always pass --
#[test]
fn safe_methods_pass_without_origin() {
let csrf = localhost_plugin();
for method in &["GET", "HEAD", "OPTIONS"] {
assert!(csrf.check(method, None, None).is_ok());
}
}
#[test]
fn safe_methods_pass_with_bad_origin() {
let csrf = localhost_plugin();
assert!(csrf.check("GET", Some("https://evil.com"), None).is_ok());
}
// -- Matching origin passes --
#[test]
fn matching_origin_passes() {
let csrf = localhost_plugin();
assert!(csrf
.check("POST", Some("http://localhost:3000"), None)
.is_ok());
assert!(csrf
.check("DELETE", Some("http://127.0.0.1:3000"), None)
.is_ok());
}
// -- Wrong origin rejected --
#[test]
fn wrong_origin_rejected() {
let csrf = localhost_plugin();
let err = csrf
.check("POST", Some("https://evil.com"), None)
.unwrap_err();
assert_eq!(err.code, "CSRF_REJECTED");
assert_eq!(err.status, 403);
}
// -- Missing origin rejected --
#[test]
fn missing_origin_rejected() {
let csrf = localhost_plugin();
let err = csrf.check("PUT", None, None).unwrap_err();
assert_eq!(err.code, "CSRF_NO_ORIGIN");
assert_eq!(err.status, 403);
}
// -- Wildcard allows all --
#[test]
fn wildcard_allows_all() {
let csrf = CsrfPlugin::new(vec!["*".into()]);
assert!(csrf
.check("POST", Some("https://anything.example.com"), None)
.is_ok());
assert!(csrf.check("DELETE", Some("http://evil.com"), None).is_ok());
}
// -- Referer extraction --
#[test]
fn origin_from_referer_extraction() {
assert_eq!(
CsrfPlugin::origin_from_referer("http://example.com/path?q=1"),
Some("http://example.com".into())
);
assert_eq!(
CsrfPlugin::origin_from_referer("https://a.b:8080/x/y"),
Some("https://a.b:8080".into())
);
assert_eq!(CsrfPlugin::origin_from_referer("garbage"), None);
assert_eq!(CsrfPlugin::origin_from_referer(""), None);
}
// -- Referer fallback when Origin is missing --
#[test]
fn referer_fallback_when_origin_missing() {
let csrf = localhost_plugin();
assert!(csrf
.check("POST", None, Some("http://localhost:3000/some/path"))
.is_ok());
}
#[test]
fn referer_fallback_wrong_origin() {
let csrf = localhost_plugin();
let err = csrf
.check("POST", None, Some("https://evil.com/attack"))
.unwrap_err();
assert_eq!(err.code, "CSRF_REJECTED");
}
// -- All state-changing methods are checked --
#[test]
fn all_state_changing_methods_require_origin() {
let csrf = localhost_plugin();
for method in &["POST", "PUT", "PATCH", "DELETE"] {
assert!(csrf.check(method, None, None).is_err());
}
}
// -- Plugin trait --
#[test]
fn plugin_name() {
let csrf = localhost_plugin();
assert_eq!(crate::Plugin::name(&csrf), "csrf");
}
}