1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
use std::sync::Arc;
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::mpsc;
use crossterm::event::KeyEvent;
use crate::app::{App, Screen};
use crate::event::AppEvent;
pub(super) fn handle_confirm_delete(app: &mut App, key: KeyEvent) {
// Use the central confirm-key router so the y/n/Esc contract is uniform
// across all confirm dialogs.
match super::route_confirm_key(key) {
super::ConfirmAction::Yes => {
if let Screen::ConfirmDelete { ref alias } = app.screen {
let alias = alias.clone();
if let Some((element, position)) = app.config.delete_host_undoable(&alias) {
if let Err(e) = app.config.write() {
// Restore the element on write failure
app.config.insert_host_at(element, position);
app.notify_error(crate::messages::failed_to_save(&e));
} else {
// Stop active tunnel for the deleted host
if let Some(mut tunnel) = app.active_tunnels.remove(&alias) {
let _ = tunnel.child.kill();
let _ = tunnel.child.wait();
}
// Clean up cert file if it exists. NotFound is the
// expected case for hosts that never had a cert. Other
// errors are surfaced via the status bar (never via
// eprintln, which would corrupt the ratatui screen).
let mut cert_cleanup_warning: Option<String> = None;
if !crate::demo_flag::is_demo() {
if let Ok(cert_path) = crate::vault_ssh::cert_path_for(&alias) {
match std::fs::remove_file(&cert_path) {
Ok(()) => {}
Err(e) if e.kind() == std::io::ErrorKind::NotFound => {}
Err(e) => {
cert_cleanup_warning =
Some(crate::messages::cert_cleanup_warning(
&cert_path.display(),
&e,
));
}
}
}
}
app.undo_stack
.push(crate::app::DeletedHost { element, position });
if app.undo_stack.len() > 50 {
app.undo_stack.remove(0);
}
app.update_last_modified();
app.reload_hosts();
if let Some(warning) = cert_cleanup_warning {
app.notify_error(warning);
} else {
app.notify(crate::messages::goodbye_host(&alias));
}
}
} else {
app.notify_warning(crate::messages::host_not_found(&alias));
}
}
app.screen = Screen::HostList;
}
super::ConfirmAction::No => {
app.screen = Screen::HostList;
}
super::ConfirmAction::Ignored => {}
}
}
pub(super) fn handle_confirm_vault_sign(
app: &mut App,
key: KeyEvent,
events_tx: &mpsc::Sender<AppEvent>,
) {
// Vault Sign is a destructive/material action: signing N certificates
// hits Vault, may take time and is hard to reverse. Stray keys must NOT
// cancel — use `route_confirm_key` so only y/Y/n/N/Esc are honored.
// History: an earlier `_ => app.screen = Screen::HostList` catch-all
// could be triggered by any keypress next to `y` (e.g. fat-fingered
// `t` or `u`), silently aborting a bulk sign.
match super::route_confirm_key(key) {
super::ConfirmAction::Yes => {
// Extract the precomputed signable list, then transition back to
// the host list and kick off the background signing loop.
let signable = if let Screen::ConfirmVaultSign { signable } = &app.screen {
signable.clone()
} else {
return;
};
app.screen = Screen::HostList;
start_vault_bulk_sign(app, signable, events_tx);
}
super::ConfirmAction::No => {
app.screen = Screen::HostList;
}
super::ConfirmAction::Ignored => {}
}
}
/// Start the background vault bulk sign loop with fast-fail, progress, TOCTOU
/// coordination and cancellation. Stores the JoinHandle on App for clean exit.
fn start_vault_bulk_sign(
app: &mut App,
signable: Vec<(String, String, String, std::path::PathBuf, Option<String>)>,
events_tx: &mpsc::Sender<AppEvent>,
) {
let total = signable.len();
if total == 0 {
return;
}
app.notify_progress(crate::messages::vault_signing_progress(
crate::animation::SPINNER_FRAMES[0],
0,
total,
"",
));
let cancel = Arc::new(AtomicBool::new(false));
app.vault.signing_cancel = Some(cancel.clone());
let in_flight = app.vault.sign_in_flight.clone();
let tx = events_tx.clone();
let spawn_result = std::thread::Builder::new()
.name("vault-bulk-sign".into())
.spawn(move || {
let mut signed = 0u32;
let mut failed = 0u32;
let mut skipped = 0u32;
let mut consecutive_failures = 0usize;
let mut first_error: Option<String> = None;
let mut aborted_message: Option<String> = None;
for (idx, (alias, role, cert_file, pubkey, vault_addr)) in signable.iter().enumerate()
{
if cancel.load(Ordering::Relaxed) {
break;
}
let done = idx + 1;
// TOCTOU: skip host if another thread already has it in-flight.
// Otherwise mark it in-flight for the duration of this iteration.
{
// If the mutex is poisoned a worker thread panicked while holding
// the lock. Recover the inner value without clearing — clearing
// the whole set would make every in-flight alias simultaneously
// eligible for re-signing, risking duplicate cert writes.
let mut set = match in_flight.lock() {
Ok(g) => g,
Err(p) => p.into_inner(),
};
if !set.insert(alias.clone()) {
skipped += 1;
let _ = tx.send(AppEvent::VaultSignProgress {
alias: alias.clone(),
done,
total,
});
continue;
}
}
let _ = tx.send(AppEvent::VaultSignProgress {
alias: alias.clone(),
done,
total,
});
let cert_path = match crate::vault_ssh::resolve_cert_path(alias, cert_file) {
Ok(p) => p,
Err(e) => {
failed += 1;
consecutive_failures += 1;
let scrubbed = crate::vault_ssh::scrub_vault_stderr(&e.to_string());
if first_error.is_none() {
first_error = Some(scrubbed);
}
remove_in_flight(&in_flight, alias);
if consecutive_failures >= 3 {
aborted_message = Some(format!(
"Vault SSH signing aborted after {} consecutive failures. Press V to retry. Last error: {}",
failed,
first_error.clone().unwrap_or_else(|| "unknown".into())
));
break;
}
continue;
}
};
let status = crate::vault_ssh::check_cert_validity(&cert_path);
if !crate::vault_ssh::needs_renewal(&status) {
skipped += 1;
consecutive_failures = 0;
remove_in_flight(&in_flight, alias);
continue;
}
let sign_result =
crate::vault_ssh::sign_certificate(role, pubkey, alias, vault_addr.as_deref());
// Always clean up in_flight for this alias before handling the
// result. Using a single cleanup point (rather than per-arm)
// prevents orphaned aliases when new control flow is added.
remove_in_flight(&in_flight, alias);
match sign_result {
Ok(_) => {
let _ = tx.send(AppEvent::VaultSignResult {
alias: alias.clone(),
certificate_file: cert_file.clone(),
success: true,
message: String::new(),
});
signed += 1;
consecutive_failures = 0;
}
Err(e) => {
let raw = e.to_string();
let scrubbed = crate::vault_ssh::scrub_vault_stderr(&raw);
if first_error.is_none() {
first_error = Some(scrubbed.clone());
}
let _ = tx.send(AppEvent::VaultSignResult {
alias: alias.clone(),
certificate_file: cert_file.clone(),
success: false,
message: scrubbed,
});
failed += 1;
consecutive_failures += 1;
if consecutive_failures >= 3 {
aborted_message = Some(format!(
"Vault SSH signing aborted after {} consecutive failures. Press V to retry. Last error: {}",
failed,
first_error.clone().unwrap_or_else(|| "unknown".into())
));
break;
}
}
}
}
let cancelled = cancel.load(Ordering::Relaxed);
let _ = tx.send(AppEvent::VaultSignAllDone {
signed,
failed,
skipped,
cancelled,
aborted_message,
first_error,
});
});
match spawn_result {
Ok(handle) => {
app.vault.sign_thread = Some(handle);
}
Err(e) => {
// Spawn failed (e.g. OS thread limit). Clear the cancel flag and
// surface the error — otherwise the status bar is stuck at
// "Signing 0/N" with no way for the user to recover.
app.vault.signing_cancel = None;
app.vault.sign_thread = None;
app.notify_error(crate::messages::vault_spawn_failed(&e));
}
}
}
pub(super) fn remove_in_flight(
set: &std::sync::Arc<std::sync::Mutex<std::collections::HashSet<String>>>,
alias: &str,
) {
// On mutex poison, recover the inner value and remove only the target alias.
// Do NOT clear the entire set — other in-flight aliases are still owned by
// live worker iterations and clearing them would allow duplicate signs.
let mut guard = match set.lock() {
Ok(g) => g,
Err(p) => p.into_inner(),
};
guard.remove(alias);
}
pub(super) fn handle_confirm_host_key_reset(app: &mut App, key: KeyEvent) {
// Host key reset wipes the host's known_hosts entry — uniform y/n/Esc
// contract via the central router so stray keys cannot trigger it.
match super::route_confirm_key(key) {
super::ConfirmAction::Yes => {
if let Screen::ConfirmHostKeyReset {
ref alias,
ref hostname,
ref known_hosts_path,
ref askpass,
} = app.screen
{
let alias = alias.clone();
let hostname = hostname.clone();
let known_hosts_path = known_hosts_path.clone();
let askpass = askpass.clone();
let output = std::process::Command::new("ssh-keygen")
.arg("-R")
.arg(&hostname)
.arg("-f")
.arg(&known_hosts_path)
.output();
match output {
Ok(result) if result.status.success() => {
app.notify(crate::messages::removed_host_key(&hostname));
if app.demo_mode {
app.notify(crate::messages::DEMO_CONNECTION_DISABLED);
} else {
app.pending_connect = Some((alias, askpass));
}
}
Ok(result) => {
let stderr = String::from_utf8_lossy(&result.stderr);
app.notify_error(crate::messages::host_key_remove_failed(stderr.trim()));
}
Err(e) => {
app.notify_error(crate::messages::ssh_keygen_failed(&e));
}
}
}
app.screen = Screen::HostList;
}
super::ConfirmAction::No => {
app.screen = Screen::HostList;
}
super::ConfirmAction::Ignored => {}
}
}