Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
//! Cookie credential — legacy auth flow.
//!
//! This is the **legacy** session credential. It will be removed once all
//! ecosystem clients have migrated to the grant flow. Retirement is a folder
//! delete: `rm -rf actors/auth/cookie/` plus dropping the cookie arm in the
//! facade.
//!
//! ## Cross-target behavior
//!
//! The struct shape is identical on every target — only the *availability*
//! of the cookie secret differs by runtime:
//!
//! | Runtime | Set-Cookie visibility | Cookie secret stored | Attach strategy |
//! |---|---|---|---|
//! | Native (`reqwest`) | Yes | Always `Some` | Manual `Cookie` header |
//! | Node.js WASM (undici) | Yes | `Some` | Manual `Cookie` header |
//! | Browser WASM (fetch) | **Hidden by spec** | `None` | Browser cookie jar |
//!
//! The browser case is the only one where we cannot capture the secret —
//! the WHATWG fetch spec hides `Set-Cookie` from JavaScript so the runtime
//! cookie jar is the only place the value lives. On every other runtime
//! the SDK owns the secret and exports/imports just like on native.

use std::any::Any;
use std::sync::{Arc, RwLock};

use async_trait::async_trait;
use pubky_common::{auth::AuthToken, crypto::PublicKey, session::CookieSessionRecord};

use reqwest::{Method, RequestBuilder, Response};

use crate::actors::session::core::PubkySession;
use crate::actors::session::credential::{SessionCredential, credential_session_missing};
use crate::{
    Error, PubkyHttpClient,
    actors::session::SessionInfo,
    actors::storage::resource::resolve_pubky,
    cross_log,
    errors::{PkarrError, Result},
    util::check_http_status,
};

#[cfg(not(target_arch = "wasm32"))]
use crate::errors::AuthError;

const SESSION_PATH: &str = "/session";

/// Cookie-based session credential (legacy).
///
/// On native and Node.js WASM the credential owns the opaque secret string
/// and replays it on every request. On browser WASM the secret is
/// inaccessible (the fetch spec hides `Set-Cookie`) and the browser cookie
/// jar handles attachment automatically — `cookie` is `None`.
#[derive(Clone, Debug)]
pub struct CookieCredential {
    /// User public key — used to name the `Cookie` header.
    user: PublicKey,
    /// Full cookie session record for cookie-specific view access.
    record: Arc<RwLock<CookieSessionRecord>>,
    /// Cookie secret captured from `Set-Cookie`. `None` only on browser
    /// WASM where the value is hidden by the fetch spec.
    cookie: Option<String>,
    /// Homeserver this cookie may attach to.
    homeserver: Arc<RwLock<Option<PublicKey>>>,
}

impl CookieCredential {
    /// Create a cookie credential from a [`CookieSessionRecord`].
    pub(crate) fn new(
        user: PublicKey,
        cookie: Option<String>,
        record: CookieSessionRecord,
        homeserver: Option<PublicKey>,
    ) -> Self {
        Self {
            user,
            record: Arc::new(RwLock::new(record)),
            cookie,
            homeserver: Arc::new(RwLock::new(homeserver)),
        }
    }

    pub(crate) fn set_homeserver(&self, homeserver: PublicKey) {
        if let Ok(mut hs) = self.homeserver.write() {
            *hs = Some(homeserver);
        }
    }

    fn bound_homeserver(&self) -> Option<PublicKey> {
        self.homeserver.read().ok().and_then(|hs| hs.clone())
    }

    fn homeserver_for_unbound_session(
        user: &PublicKey,
        resolution: Result<Option<PublicKey>>,
    ) -> Result<Option<PublicKey>> {
        match resolution {
            Ok(homeserver) => Ok(homeserver),
            Err(Error::Pkarr(PkarrError::Resolve(error))) => {
                cross_log!(
                    warn,
                    "Homeserver lookup for {user} failed; falling back to pubky URL routing: {error}"
                );
                Ok(None)
            }
            Err(error) => Err(error),
        }
    }

    async fn resolve_unbound_homeserver(
        client: &PubkyHttpClient,
        user: &PublicKey,
    ) -> Result<Option<PublicKey>> {
        let resolution = crate::Pkdns::with_client(client.clone())
            .get_homeserver_of(user)
            .await;
        Self::homeserver_for_unbound_session(user, resolution)
    }

    /// Build a cookie credential from a successful `/session` or `/signup`
    /// response. `homeserver` is the homeserver that served it, when known.
    pub(crate) async fn from_response(
        response: Response,
        homeserver: Option<PublicKey>,
    ) -> Result<Self> {
        let raw_set_cookies = collect_set_cookies(&response);

        let bytes = response.bytes().await?;
        let record = CookieSessionRecord::deserialize(&bytes)?;
        let user = record.public_key().clone();
        let cookie_name = user.z32();
        let cookie = raw_set_cookies
            .iter()
            .filter_map(|raw| cookie::Cookie::parse(raw.clone()).ok())
            .find(|c| c.name() == cookie_name)
            .map(|c| c.value().to_string());

        #[cfg(not(target_arch = "wasm32"))]
        {
            if cookie.is_none() {
                return Err(AuthError::Validation("missing session cookie".into()).into());
            }
        }

        #[cfg(target_arch = "wasm32")]
        if cookie.is_none() {
            cross_log!(
                info,
                "Hydrating WASM cookie credential without captured secret \
                 (browser jar will handle attachment) for {}",
                user
            );
        }

        cross_log!(info, "Hydrated cookie credential for {}", user);
        Ok(Self::new(user, cookie, record, homeserver))
    }

    /// Establish a cookie credential from a signed [`AuthToken`] (legacy flow).
    pub(crate) async fn from_auth_token(
        token: &AuthToken,
        client: &PubkyHttpClient,
        homeserver: Option<PublicKey>,
    ) -> Result<Self> {
        cross_log!(
            info,
            "Establishing new session exchange for {}",
            token.public_key()
        );
        let request = session_request(
            client,
            Method::POST,
            token.public_key(),
            homeserver.as_ref(),
        )
        .await?;
        let response = request.body(token.serialize()).send().await?;

        let response = check_http_status(response).await?;
        cross_log!(
            info,
            "Session exchange for {} succeeded; constructing credential",
            token.public_key()
        );
        Self::from_response(response, homeserver).await
    }

    /// Cookie secret accessor — used by [`super::view::CookieSessionView`]
    /// to export sessions for later restore. Returns `None` on browser WASM.
    pub(crate) fn cookie_secret(&self) -> Option<&str> {
        self.cookie.as_deref()
    }

    /// Returns a clone of the stored [`CookieSessionRecord`].
    pub(crate) fn cookie_record(&self) -> CookieSessionRecord {
        self.record
            .read()
            .expect("CookieCredential record RwLock poisoned")
            .clone()
    }

    /// Replace the cached record — used during revalidation.
    pub(crate) fn replace_record(&self, record: CookieSessionRecord) {
        if let Ok(mut r) = self.record.write() {
            *r = record;
        }
    }
}

fn session_resource(user: &PublicKey) -> String {
    format!("pubky{}{}", user.z32(), SESSION_PATH)
}

async fn session_request(
    client: &PubkyHttpClient,
    method: Method,
    user: &PublicKey,
    homeserver: Option<&PublicKey>,
) -> Result<RequestBuilder> {
    if let Some(homeserver) = homeserver {
        return client
            .cross_request_via_homeserver(method, homeserver, user, SESSION_PATH)
            .await;
    }

    let resolved = resolve_pubky(session_resource(user))?;
    client.cross_request(method, resolved).await
}

/// Cross-target reader for `Set-Cookie` response header values.
fn collect_set_cookies(response: &Response) -> Vec<String> {
    let mut out = Vec::new();
    for val in response.headers().get_all(reqwest::header::SET_COOKIE) {
        if let Ok(raw) = std::str::from_utf8(val.as_bytes()) {
            out.push(raw.to_owned());
        }
    }
    out
}

// Mirrors the cfg pair on the trait definition: native gets `Send` bounds
// for tokio, WASM uses `?Send` because `wasm-bindgen-futures` are not
// `Send`. See [`crate::actors::session::credential::SessionCredential`] for
// the full rationale.
#[cfg_attr(not(target_arch = "wasm32"), async_trait)]
#[cfg_attr(target_arch = "wasm32", async_trait(?Send))]
impl SessionCredential for CookieCredential {
    fn info(&self) -> SessionInfo {
        let record = self
            .record
            .read()
            .expect("CookieCredential record RwLock poisoned");
        SessionInfo::new(record.public_key().clone(), record.capabilities().to_vec())
    }

    async fn signout(&self, client: &PubkyHttpClient) -> Result<()> {
        let homeserver = match self.bound_homeserver() {
            Some(homeserver) => Some(homeserver),
            None => Self::resolve_unbound_homeserver(client, &self.user).await?,
        };
        let rb = session_request(client, Method::DELETE, &self.user, homeserver.as_ref()).await?;
        let rb = self.attach(rb, client).await?;
        let response = rb.send().await.map_err(crate::Error::from)?;
        check_http_status(response).await?;
        Ok(())
    }

    async fn attach(
        &self,
        rb: RequestBuilder,
        _client: &PubkyHttpClient,
    ) -> Result<RequestBuilder> {
        // When we own the secret (native, Node.js WASM) we attach it manually.
        match &self.cookie {
            Some(cookie) => {
                let cookie_name = self.user.z32();
                Ok(rb.header(reqwest::header::COOKIE, format!("{cookie_name}={cookie}")))
            }
            None => {
                // Browser WASM keeps the secret in the cookie jar.
                #[cfg(target_arch = "wasm32")]
                {
                    Ok(rb.fetch_credentials_include())
                }
                #[cfg(not(target_arch = "wasm32"))]
                {
                    Ok(rb)
                }
            }
        }
    }

    async fn can_attach_to(&self, homeserver: &PublicKey) -> bool {
        self.bound_homeserver().as_ref() == Some(homeserver)
    }

    async fn revalidate(
        &self,
        client: &PubkyHttpClient,
        user: &PublicKey,
    ) -> Result<Option<SessionInfo>> {
        let bound_homeserver = self.bound_homeserver();
        let bind_on_success = bound_homeserver.is_none();
        let homeserver = match bound_homeserver {
            Some(homeserver) => Some(homeserver),
            None => Self::resolve_unbound_homeserver(client, user).await?,
        };
        let rb = session_request(client, Method::GET, user, homeserver.as_ref()).await?;
        let rb = self.attach(rb, client).await?;
        let response = rb.send().await.map_err(crate::Error::from)?;
        if credential_session_missing(&response) {
            cross_log!(info, "Cookie session missing on revalidate");
            return Ok(None);
        }
        let response = check_http_status(response).await?;
        let bytes = response.bytes().await?;
        let record = CookieSessionRecord::deserialize(&bytes)?;
        let info = SessionInfo::new(record.public_key().clone(), record.capabilities().to_vec());
        self.replace_record(record);

        if bind_on_success && let Some(homeserver) = homeserver {
            self.set_homeserver(homeserver);
        }
        Ok(Some(info))
    }

    fn as_any(&self) -> &dyn Any {
        self
    }
}

impl PubkySession {
    /// Build a cookie-backed [`PubkySession`] from a [`CookieCredential`].
    ///
    /// Typical use: after
    /// [`PubkyCookieAuthFlow::await_credential`](crate::PubkyCookieAuthFlow::await_credential)
    /// returns a credential you want to hold separately, this lifts it into
    /// a full session bound to the given HTTP client.
    #[must_use]
    pub fn from_cookie_credential(client: PubkyHttpClient, credential: CookieCredential) -> Self {
        Self::from_credential(client, Arc::new(credential))
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use pkarr::errors::ResolveError;
    use pubky_common::{
        capabilities::{Capabilities, Capability},
        crypto::Keypair,
    };

    fn cookie_credential(user: &PublicKey, homeserver: Option<PublicKey>) -> CookieCredential {
        let record =
            CookieSessionRecord::new(user, Capabilities::from(vec![Capability::root()]), None);
        CookieCredential::new(
            user.clone(),
            Some("cookie-secret".to_string()),
            record,
            homeserver,
        )
    }

    #[tokio::test]
    async fn can_attach_to_only_matches_bound_homeserver() {
        let user = Keypair::random().public_key();
        let bound = Keypair::random().public_key();
        let other = Keypair::random().public_key();
        let credential = cookie_credential(&user, Some(bound.clone()));

        assert!(credential.can_attach_to(&bound).await);
        assert!(!credential.can_attach_to(&other).await);
    }

    #[tokio::test]
    async fn can_attach_to_is_false_until_bound() {
        let user = Keypair::random().public_key();
        let credential = cookie_credential(&user, None);
        let homeserver = Keypair::random().public_key();

        assert!(!credential.can_attach_to(&homeserver).await);

        credential.set_homeserver(homeserver.clone());
        assert!(credential.can_attach_to(&homeserver).await);
        assert!(
            !credential
                .can_attach_to(&Keypair::random().public_key())
                .await
        );
    }

    #[test]
    fn operational_resolution_error_uses_pubky_url_fallback() {
        let user = Keypair::random().public_key();
        let resolution = Err(PkarrError::Resolve(ResolveError::NoResponses).into());

        let homeserver = CookieCredential::homeserver_for_unbound_session(&user, resolution)
            .expect("operational resolution errors should use the fallback");

        assert_eq!(homeserver, None);
    }

    #[test]
    fn malformed_homeserver_record_does_not_use_pubky_url_fallback() {
        let user = Keypair::random().public_key();
        let resolution = Err(PkarrError::InvalidRecord("invalid target".into()).into());

        let error = CookieCredential::homeserver_for_unbound_session(&user, resolution)
            .expect_err("malformed records must remain visible");

        assert!(matches!(
            error,
            Error::Pkarr(PkarrError::InvalidRecord(message)) if message == "invalid target"
        ));
    }
}