1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
// SPDX-License-Identifier: MPL-2.0
//! Core model and functions
//! to write a functional PubGrub algorithm.
use std::collections::HashSet as Set;
use std::sync::Arc;
use crate::internal::{
Arena, DecisionLevel, HashArena, Id, IncompDpId, IncompId, Incompatibility, PartialSolution,
Relation, SatisfierSearch, SmallVec,
};
use crate::{DependencyProvider, DerivationTree, Map, NoSolutionError, VersionSet};
/// Current state of the PubGrub algorithm.
#[derive(Clone)]
pub(crate) struct State<DP: DependencyProvider> {
pub root_package: Id<DP::P>,
root_version: DP::V,
#[allow(clippy::type_complexity)]
incompatibilities: Map<Id<DP::P>, Vec<IncompDpId<DP>>>,
/// As an optimization, store the ids of incompatibilities that are already contradicted.
///
/// For each one keep track of the decision level when it was found to be contradicted.
/// These will stay contradicted until we have backtracked beyond its associated decision level.
contradicted_incompatibilities: Map<IncompDpId<DP>, DecisionLevel>,
/// All incompatibilities expressing dependencies,
/// with common dependents merged.
#[allow(clippy::type_complexity)]
merged_dependencies: Map<(Id<DP::P>, Id<DP::P>), SmallVec<IncompDpId<DP>>>,
/// Partial solution.
/// TODO: remove pub.
pub(crate) partial_solution: PartialSolution<DP>,
/// The store is the reference storage for all incompatibilities.
pub(crate) incompatibility_store: Arena<Incompatibility<DP::P, DP::VS, DP::M>>,
/// The store is the reference storage for all packages.
pub(crate) package_store: HashArena<DP::P>,
/// This is a stack of work to be done in `unit_propagation`.
/// It can definitely be a local variable to that method, but
/// this way we can reuse the same allocation for better performance.
unit_propagation_buffer: SmallVec<Id<DP::P>>,
}
impl<DP: DependencyProvider> State<DP> {
/// Initialization of PubGrub state.
pub(crate) fn init(root_package: DP::P, root_version: DP::V) -> Self {
let mut incompatibility_store = Arena::new();
let mut package_store = HashArena::new();
let root_package = package_store.alloc(root_package);
let not_root_id = incompatibility_store.alloc(Incompatibility::not_root(
root_package,
root_version.clone(),
));
let mut incompatibilities = Map::default();
incompatibilities.insert(root_package, vec![not_root_id]);
Self {
root_package,
root_version,
incompatibilities,
contradicted_incompatibilities: Map::default(),
partial_solution: PartialSolution::empty(),
incompatibility_store,
package_store,
unit_propagation_buffer: SmallVec::Empty,
merged_dependencies: Map::default(),
}
}
/// Add the dependencies for the current version of the current package as incompatibilities.
pub(crate) fn add_package_version_dependencies(
&mut self,
package: Id<DP::P>,
version: DP::V,
dependencies: impl IntoIterator<Item = (DP::P, DP::VS)>,
) -> Option<IncompId<DP::P, DP::VS, DP::M>> {
let dep_incompats =
self.add_incompatibility_from_dependencies(package, version.clone(), dependencies);
self.partial_solution.add_package_version_incompatibilities(
package,
version.clone(),
dep_incompats,
&self.incompatibility_store,
)
}
/// Add an incompatibility to the state.
pub(crate) fn add_incompatibility(&mut self, incompat: Incompatibility<DP::P, DP::VS, DP::M>) {
let id = self.incompatibility_store.alloc(incompat);
self.merge_incompatibility(id);
}
/// Add a single custom incompatibility that requires that the base package and the proxy
/// package share the same version range.
///
/// This intended for cases where proxy packages (also known as virtual packages) are used.
/// Without this information, pubgrub does not know that these packages have to be at the same
/// version. In cases where the base package is already set to an incompatible version, this
/// avoids going through all versions of the proxy package. In cases where there are two
/// incompatible proxy packages, it avoids trying versions for both of them. This improves both
/// performance (we don't need to check all versions when there is a conflict) and error
/// messages (report a conflict of version ranges instead of enumerating the conflicting
/// versions).
///
/// Using this method requires that each version of the proxy package depends on the exact
/// same version of the base package.
#[allow(unused)]
pub(crate) fn add_proxy_package_incompatibility(
&mut self,
proxy_package: Id<DP::P>,
base_package: Id<DP::P>,
versions: DP::VS,
) {
let incompat = Incompatibility::from_dependency(
proxy_package,
versions.clone(),
(base_package, versions),
);
let id = self
.incompatibility_store
.alloc_iter([incompat].into_iter());
for id in IncompDpId::<DP>::range_to_iter(id) {
self.merge_incompatibility(id);
}
}
/// Add an incompatibility to the state.
#[cold]
pub(crate) fn add_incompatibility_from_dependencies(
&mut self,
package: Id<DP::P>,
version: DP::V,
deps: impl IntoIterator<Item = (DP::P, DP::VS)>,
) -> std::ops::Range<IncompDpId<DP>> {
// Create incompatibilities and allocate them in the store.
let new_incompats_id_range =
self.incompatibility_store
.alloc_iter(deps.into_iter().map(|(dep_p, dep_vs)| {
let dep_pid = self.package_store.alloc(dep_p);
Incompatibility::from_dependency(
package,
<DP::VS as VersionSet>::singleton(version.clone()),
(dep_pid, dep_vs),
)
}));
// Merge the newly created incompatibilities with the older ones.
for id in IncompDpId::<DP>::range_to_iter(new_incompats_id_range.clone()) {
self.merge_incompatibility(id);
}
new_incompats_id_range
}
/// Unit propagation is the core mechanism of the solving algorithm.
/// CF <https://github.com/dart-lang/pub/blob/master/doc/solver.md#unit-propagation>
///
/// For each package with a satisfied incompatibility, returns the package and the root cause
/// incompatibility.
#[cold]
#[allow(clippy::type_complexity)] // Type definitions don't support impl trait.
pub(crate) fn unit_propagation(
&mut self,
package: Id<DP::P>,
) -> Result<SmallVec<(Id<DP::P>, IncompDpId<DP>)>, NoSolutionError<DP>> {
let mut satisfier_causes = SmallVec::default();
self.unit_propagation_buffer.clear();
self.unit_propagation_buffer.push(package);
while let Some(current_package) = self.unit_propagation_buffer.pop() {
// Iterate over incompatibilities in reverse order
// to evaluate first the newest incompatibilities.
let mut conflict_id = None;
// We only care about incompatibilities if it contains the current package.
for &incompat_id in self.incompatibilities[¤t_package].iter().rev() {
if self
.contradicted_incompatibilities
.contains_key(&incompat_id)
{
continue;
}
let current_incompat = &self.incompatibility_store[incompat_id];
match self.partial_solution.relation(current_incompat) {
// If the partial solution satisfies the incompatibility
// we must perform conflict resolution.
Relation::Satisfied => {
log::info!(
"Start conflict resolution because incompat satisfied:\n {}",
current_incompat.display(&self.package_store)
);
conflict_id = Some(incompat_id);
break;
}
Relation::AlmostSatisfied(package_almost) => {
// Add `package_almost` to the `unit_propagation_buffer` set.
// Putting items in `unit_propagation_buffer` more than once waste cycles,
// but so does allocating a hash map and hashing each item.
// In practice `unit_propagation_buffer` is small enough that we can just do a linear scan.
if !self.unit_propagation_buffer.contains(&package_almost) {
self.unit_propagation_buffer.push(package_almost);
}
// Add (not term) to the partial solution with incompat as cause.
self.partial_solution.add_derivation(
package_almost,
incompat_id,
&self.incompatibility_store,
);
// With the partial solution updated, the incompatibility is now contradicted.
self.contradicted_incompatibilities
.insert(incompat_id, self.partial_solution.current_decision_level());
}
Relation::Contradicted(_) => {
self.contradicted_incompatibilities
.insert(incompat_id, self.partial_solution.current_decision_level());
}
_ => {}
}
}
if let Some(incompat_id) = conflict_id {
let (package_almost, root_cause) = self
.conflict_resolution(incompat_id, &mut satisfier_causes)
.map_err(|terminal_incompat_id| {
self.build_derivation_tree(terminal_incompat_id)
})?;
self.unit_propagation_buffer.clear();
self.unit_propagation_buffer.push(package_almost);
// Add to the partial solution with incompat as cause.
self.partial_solution.add_derivation(
package_almost,
root_cause,
&self.incompatibility_store,
);
// After conflict resolution and the partial solution update,
// the root cause incompatibility is now contradicted.
self.contradicted_incompatibilities
.insert(root_cause, self.partial_solution.current_decision_level());
}
}
// If there are no more changed packages, unit propagation is done.
Ok(satisfier_causes)
}
/// Return the root cause or the terminal incompatibility. CF
/// <https://github.com/dart-lang/pub/blob/master/doc/solver.md#unit-propagation>
///
/// When we found a conflict, we want to learn as much as possible from it, to avoid making (or
/// keeping) decisions that will be rejected. Say we found that the dependency requirements on X and the
/// dependency requirements on Y are incompatible. We may find that the decisions on earlier packages B and C
/// require us to make incompatible requirements on X and Y, so we backtrack until either B or C
/// can be revisited. To make it practical, we really only need one of the terms to be a
/// decision. We may as well leave the other terms general. Something like "the dependency on
/// the package X is incompatible with the decision on C" tends to work out pretty well. Then if
/// A turns out to also have a dependency on X the resulting root cause is still useful.
/// (`unit_propagation` will ensure we don't try that version of C.)
/// Of course, this is more heuristics than science. If the output is too general, then
/// `unit_propagation` will handle the confusion by calling us again with the next most specific
/// conflict it comes across. If the output is too specific, then the outer `solver` loop will
/// eventually end up calling us again until all possibilities are enumerated.
///
/// To end up with a more useful incompatibility, this function combines incompatibilities into
/// derivations. Fulfilling this derivation implies the later conflict. By banning it, we
/// prevent the intermediate steps from occurring again, at least in the exact same way.
/// However, the statistics collected for `prioritize` may want to analyze those intermediate
/// steps. For example we might start with "there is no version 1 of Z", and
/// `conflict_resolution` may be able to determine that "that was inevitable when we picked
/// version 1 of X" which was inevitable when we picked W and so on, until version 1 of B, which
/// was depended on by version 1 of A. Therefore the root cause may simplify all the way down to
/// "we cannot pick version 1 of A". This will prevent us going down this path again. However
/// when we start looking at version 2 of A, and discover that it depends on version 2 of B, we
/// will want to prioritize the chain of intermediate steps to check if it has a problem with
/// the same shape. The `satisfier_causes` argument keeps track of these intermediate steps so
/// that the caller can use them for prioritization.
#[allow(clippy::type_complexity)]
#[cold]
fn conflict_resolution(
&mut self,
incompatibility: IncompDpId<DP>,
satisfier_causes: &mut SmallVec<(Id<DP::P>, IncompDpId<DP>)>,
) -> Result<(Id<DP::P>, IncompDpId<DP>), IncompDpId<DP>> {
let mut current_incompat_id = incompatibility;
let mut current_incompat_changed = false;
loop {
if self.incompatibility_store[current_incompat_id]
.is_terminal(self.root_package, &self.root_version)
{
return Err(current_incompat_id);
} else {
let (package, satisfier_search_result) = self.partial_solution.satisfier_search(
&self.incompatibility_store[current_incompat_id],
&self.incompatibility_store,
);
match satisfier_search_result {
SatisfierSearch::DifferentDecisionLevels {
previous_satisfier_level,
} => {
self.backtrack(
current_incompat_id,
current_incompat_changed,
previous_satisfier_level,
);
log::info!("backtrack to {previous_satisfier_level:?}");
satisfier_causes.push((package, current_incompat_id));
return Ok((package, current_incompat_id));
}
SatisfierSearch::SameDecisionLevels { satisfier_cause } => {
let prior_cause = Incompatibility::prior_cause(
current_incompat_id,
satisfier_cause,
package,
&self.incompatibility_store,
);
log::info!("prior cause: {}", prior_cause.display(&self.package_store));
current_incompat_id = self.incompatibility_store.alloc(prior_cause);
satisfier_causes.push((package, current_incompat_id));
current_incompat_changed = true;
}
}
}
}
}
/// Backtracking.
fn backtrack(
&mut self,
incompat: IncompDpId<DP>,
incompat_changed: bool,
decision_level: DecisionLevel,
) {
self.partial_solution.backtrack(decision_level);
// Remove contradicted incompatibilities that depend on decisions we just backtracked away.
self.contradicted_incompatibilities
.retain(|_, dl| *dl <= decision_level);
if incompat_changed {
self.merge_incompatibility(incompat);
}
}
/// Add this incompatibility into the set of all incompatibilities.
///
/// PubGrub collapses identical dependencies from adjacent package versions
/// into individual incompatibilities.
/// This substantially reduces the total number of incompatibilities
/// and makes it much easier for PubGrub to reason about multiple versions of packages at once.
///
/// For example, rather than representing
/// foo 1.0.0 depends on bar ^1.0.0 and
/// foo 1.1.0 depends on bar ^1.0.0
/// as two separate incompatibilities,
/// they are collapsed together into the single incompatibility {foo ^1.0.0, not bar ^1.0.0}
/// (provided that no other version of foo exists between 1.0.0 and 2.0.0).
/// We could collapse them into { foo (1.0.0 ∪ 1.1.0), not bar ^1.0.0 }
/// without having to check the existence of other versions though.
fn merge_incompatibility(&mut self, mut id: IncompDpId<DP>) {
if let Some((p1, p2)) = self.incompatibility_store[id].as_dependency() {
// If we are a dependency, there's a good chance we can be merged with a previous dependency
let deps_lookup = self.merged_dependencies.entry((p1, p2)).or_default();
if let Some((past, merged)) = deps_lookup.as_mut_slice().iter_mut().find_map(|past| {
self.incompatibility_store[id]
.merge_dependents(&self.incompatibility_store[*past])
.map(|m| (past, m))
}) {
let new = self.incompatibility_store.alloc(merged);
for (pkg, _) in self.incompatibility_store[new].iter() {
self.incompatibilities
.entry(pkg)
.or_default()
.retain(|id| id != past);
}
*past = new;
id = new;
} else {
deps_lookup.push(id);
}
}
for (pkg, term) in self.incompatibility_store[id].iter() {
if cfg!(debug_assertions) {
assert_ne!(term, &crate::term::Term::any());
}
self.incompatibilities.entry(pkg).or_default().push(id);
}
}
// Error reporting #########################################################
fn build_derivation_tree(
&self,
incompat: IncompDpId<DP>,
) -> DerivationTree<DP::P, DP::VS, DP::M> {
let mut all_ids: Set<IncompDpId<DP>> = Set::default();
let mut shared_ids = Set::default();
let mut stack = vec![incompat];
while let Some(i) = stack.pop() {
if let Some((id1, id2)) = self.incompatibility_store[i].causes() {
if all_ids.contains(&i) {
shared_ids.insert(i);
} else {
stack.push(id1);
stack.push(id2);
}
}
all_ids.insert(i);
}
// To avoid recursion we need to generate trees in topological order.
// That is to say we need to ensure that the causes are processed before the incompatibility they effect.
// It happens to be that sorting by their ID maintains this property.
let mut sorted_ids = all_ids.into_iter().collect::<Vec<_>>();
sorted_ids.sort_unstable_by_key(|id| id.into_raw());
let mut precomputed = Map::default();
for id in sorted_ids {
let tree = Incompatibility::build_derivation_tree(
id,
&shared_ids,
&self.incompatibility_store,
&self.package_store,
&precomputed,
);
precomputed.insert(id, Arc::new(tree));
}
// Now the user can refer to the entire tree from its root.
Arc::into_inner(precomputed.remove(&incompat).unwrap()).unwrap()
}
}