ps-qa 0.5.9

Drive a running Blitz app through its MCP control socket and assert what the renderer did
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
//! Decode and compare renderer captures.
//!
//! The runner owns interaction ordering and transport. This module owns the
//! pixel contract: buffer validation, tolerance, visible-ink measurement and
//! diagnostic artifacts. Keeping those concerns separate makes a paint verdict
//! testable without a live application or control socket.

use std::collections::HashMap;
use std::io::Write as _;

use base64::Engine as _;
use blitz_control_protocol::CapturedImage;
use eyre::{Context, Result};

use crate::cli;

/// Subpixel edge coverage can vary by a few 8-bit levels between equivalent
/// GPU captures. Four levels is the first difference treated as authored ink.
pub(crate) const CHANNEL_TOLERANCE: u8 = 3;

fn decode(image: &CapturedImage) -> std::result::Result<Vec<u8>, String> {
    let rgba = base64::engine::general_purpose::STANDARD
        .decode(&image.rgba_base64)
        .map_err(|error| format!("captured frame is not valid base64: {error}"))?;
    let expected = (image.width as usize)
        .checked_mul(image.height as usize)
        .and_then(|pixels| pixels.checked_mul(4))
        .ok_or_else(|| "captured frame dimensions overflowed".to_owned())?;
    if rgba.len() != expected {
        return Err(format!(
            "captured {}x{} frame has {} RGBA bytes; expected {expected}",
            image.width,
            image.height,
            rgba.len()
        ));
    }
    Ok(rgba)
}

pub(crate) fn pixel_delta(
    before: &CapturedImage,
    after: &CapturedImage,
) -> std::result::Result<(usize, u8), String> {
    let before_rgba = decode(before)?;
    let after_rgba = decode(after)?;
    if before_rgba.len() != after_rgba.len() {
        return Err(format!(
            "last frame buffer changed length from {} to {} bytes",
            before_rgba.len(),
            after_rgba.len()
        ));
    }
    let mut changed = 0;
    let mut max_delta = 0;
    for (before, after) in before_rgba
        .as_chunks::<4>()
        .0
        .iter()
        .zip(after_rgba.as_chunks::<4>().0.iter())
    {
        let pixel_delta = before
            .iter()
            .zip(after.iter())
            .map(|(left, right)| left.abs_diff(*right))
            .max()
            .unwrap_or_default();
        if pixel_delta > 0 {
            changed += 1;
            max_delta = max_delta.max(pixel_delta);
        }
    }
    Ok((changed, max_delta))
}

/// Whether same-sized captures differ only by bounded raster rounding.
pub(crate) fn pixels_hold_with_tolerance(
    before: &CapturedImage,
    after: &CapturedImage,
    channel_tolerance: u8,
) -> std::result::Result<bool, String> {
    if before.width != after.width || before.height != after.height {
        return Ok(false);
    }
    if before.rgba_base64 == after.rgba_base64 {
        return Ok(true);
    }
    let before_rgba = decode(before)?;
    let after_rgba = decode(after)?;
    Ok(before_rgba
        .iter()
        .zip(&after_rgba)
        .all(|(left, right)| left.abs_diff(*right) <= channel_tolerance))
}

pub(crate) fn pixels_hold(
    before: &CapturedImage,
    after: &CapturedImage,
) -> std::result::Result<(), String> {
    if before.width != after.width || before.height != after.height {
        return Err(format!(
            "rendered frame changed size from {}x{} to {}x{}",
            before.width, before.height, after.width, after.height
        ));
    }
    if before.rgba_base64 == after.rgba_base64 {
        return Ok(());
    }

    let before_rgba = decode(before)?;
    let after_rgba = decode(after)?;
    let changed = before_rgba
        .as_chunks::<4>()
        .0
        .iter()
        .zip(after_rgba.as_chunks::<4>().0.iter())
        .filter(|(before, after)| {
            before
                .iter()
                .zip(after.iter())
                .any(|(left, right)| left.abs_diff(*right) > CHANNEL_TOLERANCE)
        })
        .count();
    if changed == 0 {
        Ok(())
    } else {
        Err(format!(
            "{changed} rendered pixel(s) changed after the pointer returned to the same state"
        ))
    }
}

/// Compare visible RGB placement while ignoring alpha-only edge coverage.
pub(crate) fn rgb_pixels_hold(
    before: &CapturedImage,
    after: &CapturedImage,
) -> std::result::Result<(), String> {
    if before.width != after.width || before.height != after.height {
        return Err(format!(
            "rendered frame changed size from {}x{} to {}x{}",
            before.width, before.height, after.width, after.height
        ));
    }
    let before_rgba = decode(before)?;
    let after_rgba = decode(after)?;
    const RGB_TOLERANCE: u8 = 8;
    let changed = before_rgba
        .as_chunks::<4>()
        .0
        .iter()
        .zip(after_rgba.as_chunks::<4>().0.iter())
        .filter(|(before, after)| {
            before[..3]
                .iter()
                .zip(after[..3].iter())
                .any(|(left, right)| left.abs_diff(*right) > RGB_TOLERANCE)
        })
        .count();
    if changed == 0 {
        Ok(())
    } else {
        Err(format!(
            "{changed} visibly coloured pixel(s) changed after the first hover"
        ))
    }
}

/// Require an actual pixel change, including visible growth or shrinkage.
pub(crate) fn pixels_change(
    before: &CapturedImage,
    after: &CapturedImage,
) -> std::result::Result<(), String> {
    let before_rgba = decode(before)?;
    let after_rgba = decode(after)?;
    let canvas_width = before.width.max(after.width) as usize;
    let canvas_height = before.height.max(after.height) as usize;
    let pixel_at = |rgba: &[u8], capture: &CapturedImage, x: usize, y: usize| -> [u8; 4] {
        let offset_x = (canvas_width - capture.width as usize) / 2;
        let offset_y = (canvas_height - capture.height as usize) / 2;
        let Some(local_x) = x.checked_sub(offset_x) else {
            return [0; 4];
        };
        let Some(local_y) = y.checked_sub(offset_y) else {
            return [0; 4];
        };
        if local_x >= capture.width as usize || local_y >= capture.height as usize {
            return [0; 4];
        }
        let index = (local_y * capture.width as usize + local_x) * 4;
        rgba[index..index + 4]
            .try_into()
            .expect("validated RGBA frame")
    };

    for y in 0..canvas_height {
        for x in 0..canvas_width {
            let left = pixel_at(&before_rgba, before, x, y);
            let right = pixel_at(&after_rgba, after, x, y);
            if left
                .iter()
                .zip(right)
                .any(|(left, right)| left.abs_diff(right) > CHANNEL_TOLERANCE)
            {
                return Ok(());
            }
        }
    }
    Err("hover left every rendered pixel unchanged".to_owned())
}

/// What a captured frame contains, in the terms a person would use.
pub(crate) struct Ink {
    pub(crate) visible: usize,
    pub(crate) total: usize,
    pub(crate) background: (u8, u8, u8),
}

impl Ink {
    pub(crate) fn fraction(&self) -> f64 {
        if self.total == 0 {
            0.0
        } else {
            self.visible as f64 / self.total as f64
        }
    }
}

/// Discover the modal background and count pixels with visible contrast.
fn measure_ink_bounds(
    image: &CapturedImage,
    left: u32,
    top: u32,
    right: u32,
    bottom: u32,
) -> Result<Ink> {
    let rgba = decode(image).map_err(eyre::Report::msg)?;
    let mut histogram: HashMap<(u8, u8, u8), usize> = HashMap::new();
    let pixel = |x: u32, y: u32| {
        let start = ((y * image.width + x) * 4) as usize;
        [
            rgba[start],
            rgba[start + 1],
            rgba[start + 2],
            rgba[start + 3],
        ]
    };
    for y in top..bottom {
        for x in left..right {
            let pixel = pixel(x, y);
            *histogram.entry((pixel[0], pixel[1], pixel[2])).or_default() += 1;
        }
    }
    let background = histogram
        .iter()
        .max_by_key(|(_, count)| **count)
        .map(|(colour, _)| *colour)
        .unwrap_or((0, 0, 0));

    let luminance = |(r, g, b): (u8, u8, u8)| {
        0.299 * f64::from(r) + 0.587 * f64::from(g) + 0.114 * f64::from(b)
    };
    let background_luminance = luminance(background);
    let mut visible = 0;
    for y in top..bottom {
        for x in left..right {
            let pixel = pixel(x, y);
            if pixel[3] >= 32
                && (luminance((pixel[0], pixel[1], pixel[2])) - background_luminance).abs() > 24.0
            {
                visible += 1;
            }
        }
    }

    Ok(Ink {
        visible,
        total: ((right - left) as usize) * ((bottom - top) as usize),
        background,
    })
}

/// Discover visible ink anywhere in the captured region.
pub(crate) fn measure_ink(image: &CapturedImage) -> Result<Ink> {
    measure_ink_bounds(image, 0, 0, image.width, image.height)
}

/// Discover visible ink inside the control, excluding its border and focus ring.
pub(crate) fn measure_interior_ink(image: &CapturedImage) -> Result<Ink> {
    if image.width < 3 || image.height < 3 {
        return Err(eyre::eyre!(
            "captured {}x{} region is too small to exclude its border",
            image.width,
            image.height
        ));
    }
    let inset_x = (image.width / 5).max(1);
    let inset_y = (image.height / 5).max(1);
    let right = image.width.saturating_sub(inset_x);
    let bottom = image.height.saturating_sub(inset_y);
    if right <= inset_x || bottom <= inset_y {
        return Err(eyre::eyre!(
            "captured {}x{} region has no measurable interior",
            image.width,
            image.height
        ));
    }
    measure_ink_bounds(image, inset_x, inset_y, right, bottom)
}

pub(crate) fn write_ppm(image: &CapturedImage, output: &std::path::Path) -> Result<()> {
    let rgba = decode(image).map_err(eyre::Report::msg)?;
    let mut file = std::fs::File::create(output)
        .wrap_err_with(|| format!("could not create {}", output.display()))?;
    write!(file, "P6\n{} {}\n255\n", image.width, image.height)?;
    for pixel in rgba.as_chunks::<4>().0 {
        file.write_all(&pixel[..3])?;
    }
    println!("saved {}", output.display());
    Ok(())
}

pub(crate) fn save_artifacts(
    check_id: &str,
    before: &CapturedImage,
    after: &CapturedImage,
) -> Result<()> {
    let Some(directory) = cli::pixel_artifact_dir() else {
        return Ok(());
    };
    std::fs::create_dir_all(&directory)
        .wrap_err_with(|| format!("could not create {}", directory.display()))?;
    let safe_id: String = check_id
        .chars()
        .map(|character| {
            if character.is_ascii_alphanumeric() || matches!(character, '-' | '_') {
                character
            } else {
                '_'
            }
        })
        .collect();
    write_ppm(before, &directory.join(format!("{safe_id}-before.ppm")))?;
    write_ppm(after, &directory.join(format!("{safe_id}-after.ppm")))?;
    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;

    fn capture(rgba: &[u8]) -> CapturedImage {
        CapturedImage {
            width: 1,
            height: 1,
            rgba_base64: base64::engine::general_purpose::STANDARD.encode(rgba),
            node_id: Some(7),
        }
    }

    #[test]
    fn change_requires_pixels_not_only_dimensions() {
        let transparent = capture(&[0, 0, 0, 0]);
        let resized_transparent = CapturedImage {
            width: 2,
            height: 1,
            rgba_base64: base64::engine::general_purpose::STANDARD.encode([0, 0, 0, 0, 0, 0, 0, 0]),
            node_id: Some(7),
        };
        assert_eq!(
            pixels_change(&transparent, &resized_transparent).unwrap_err(),
            "hover left every rendered pixel unchanged"
        );
    }

    #[test]
    fn visible_ink_is_contrast_not_alpha_alone() {
        let background = [20, 20, 20, 255];
        let empty = CapturedImage {
            width: 2,
            height: 2,
            rgba_base64: base64::engine::general_purpose::STANDARD.encode(background.repeat(4)),
            node_id: Some(7),
        };
        assert_eq!(measure_ink(&empty).unwrap().visible, 0);

        let mut marked = background.repeat(4);
        marked[0..4].copy_from_slice(&[240, 240, 240, 255]);
        let marked = CapturedImage {
            rgba_base64: base64::engine::general_purpose::STANDARD.encode(marked),
            ..empty
        };
        assert_eq!(measure_ink(&marked).unwrap().visible, 1);
    }

    #[test]
    fn interior_ink_ignores_a_control_border() {
        let background = [20, 20, 20, 255];
        let border = [240, 240, 240, 255];
        let mut pixels = background.repeat(25);
        for y in 0..5 {
            for x in 0..5 {
                if x == 0 || x == 4 || y == 0 || y == 4 {
                    let start = (y * 5 + x) * 4;
                    pixels[start..start + 4].copy_from_slice(&border);
                }
            }
        }
        let bordered = CapturedImage {
            width: 5,
            height: 5,
            rgba_base64: base64::engine::general_purpose::STANDARD.encode(&pixels),
            node_id: Some(7),
        };
        assert!(measure_ink(&bordered).unwrap().visible > 0);
        assert_eq!(measure_interior_ink(&bordered).unwrap().visible, 0);

        pixels[(2 * 5 + 2) * 4..(2 * 5 + 2) * 4 + 4].copy_from_slice(&border);
        let labeled = CapturedImage {
            rgba_base64: base64::engine::general_purpose::STANDARD.encode(pixels),
            ..bordered
        };
        assert_eq!(measure_interior_ink(&labeled).unwrap().visible, 1);

        let mut tiny_border = background.repeat(16);
        for y in 0..4 {
            for x in 0..4 {
                if x == 0 || x == 3 || y == 0 || y == 3 {
                    let start = (y * 4 + x) * 4;
                    tiny_border[start..start + 4].copy_from_slice(&border);
                }
            }
        }
        let tiny = CapturedImage {
            width: 4,
            height: 4,
            rgba_base64: base64::engine::general_purpose::STANDARD.encode(tiny_border),
            node_id: Some(8),
        };
        assert_eq!(measure_interior_ink(&tiny).unwrap().visible, 0);
    }
}