1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
use blitz_traits::node_id::NodeId;
use parley::{AlignmentOptions, IndentOptions};
use style::values::specified::box_::DisplayOutside;
use style::values::{computed::CSSPixelLength, generics::text::GenericTextIndent};
use taffy::{
AvailableSpace, BlockContext, BlockFormattingContext, BoxSizing, CollapsibleMarginSet,
CoreStyle as _, Direction, LayoutInput, LayoutOutput, LayoutPartialTree as _, MaybeMath as _,
MaybeResolve as _, Overflow, Point, Position, RequestedAxis, ResolveOrZero as _, RunMode, Size,
SizingMode,
};
#[cfg(feature = "floats")]
use parley::YieldData;
#[cfg(feature = "floats")]
use taffy::{Clear, Float, prelude::TaffyMaxContent};
use super::resolve_calc_value;
/// Read once: this sits on the layout hot path.
static TRACE_INLINE: std::sync::OnceLock<bool> = std::sync::OnceLock::new();
use crate::BaseDocument;
impl BaseDocument {
pub(crate) fn compute_inline_layout(
&mut self,
node_id: NodeId,
inputs: taffy::tree::LayoutInput,
block_ctx: Option<&mut BlockContext<'_>>,
) -> taffy::LayoutOutput {
let LayoutInput {
known_dimensions,
parent_size,
run_mode,
..
} = inputs;
let style = self.nodes[node_id].style();
// Pull these out earlier to avoid borrowing issues
let is_scroll_container =
style.overflow.x.is_scroll_container() || style.overflow.y.is_scroll_container();
let padding = style
.padding()
.resolve_or_zero(parent_size.width, resolve_calc_value);
let border = style
.border()
.resolve_or_zero(parent_size.width, resolve_calc_value);
let padding_border_size = (padding + border).sum_axes();
let box_sizing_adjustment = if style.box_sizing() == BoxSizing::ContentBox {
padding_border_size
} else {
Size::ZERO
};
// Resolve node's preferred/min/max sizes (width/heights) against the available space (percentages resolve to pixel values)
// For ContentSize mode, we pretend that the node has no size styles as these should be ignored.
let (clamped_style_size, min_size, max_size, _aspect_ratio) = match inputs.sizing_mode {
SizingMode::ContentSize => {
let node_size = known_dimensions;
let node_min_size = Size::NONE;
let node_max_size = Size::NONE;
(node_size, node_min_size, node_max_size, None)
}
SizingMode::InherentSize => {
let aspect_ratio = style.aspect_ratio();
let style_size = style
.size()
.maybe_resolve(parent_size, resolve_calc_value)
.maybe_apply_aspect_ratio(aspect_ratio)
.maybe_add(box_sizing_adjustment);
let style_min_size = style
.min_size()
.maybe_resolve(parent_size, resolve_calc_value)
.maybe_apply_aspect_ratio(aspect_ratio)
.maybe_add(box_sizing_adjustment);
let style_max_size = style
.max_size()
.maybe_resolve(parent_size, resolve_calc_value)
.maybe_add(box_sizing_adjustment);
let node_size =
known_dimensions.or(style_size.maybe_clamp(style_min_size, style_max_size));
(node_size, style_min_size, style_max_size, aspect_ratio)
}
};
// If both min and max in a given axis are set and max <= min then this determines the size in that axis
let min_max_definite_size = min_size.zip_map(max_size, |min, max| match (min, max) {
(Some(min), Some(max)) if max <= min => Some(min),
_ => None,
});
let styled_based_known_dimensions = known_dimensions
.or(min_max_definite_size)
.or(clamped_style_size)
.maybe_max(padding_border_size);
// Short-circuit layout if the container's size is fully determined by the container's size and the run mode
// is ComputeSize (and thus the container's size is all that we're interested in)
if run_mode == RunMode::ComputeSize {
if let Size {
width: Some(width),
height: Some(height),
} = styled_based_known_dimensions
{
return LayoutOutput::from_outer_size(Size { width, height });
}
}
// Unwrap the block formatting context if one was passed, or else create a new one
match block_ctx {
Some(inherited_bfc) if !is_scroll_container => self.compute_inline_layout_inner(
node_id,
LayoutInput {
known_dimensions: styled_based_known_dimensions,
..inputs
},
inherited_bfc,
),
_ => {
let mut root_bfc = BlockFormattingContext::new();
let mut root_ctx = root_bfc.root_block_context();
self.compute_inline_layout_inner(
node_id,
LayoutInput {
known_dimensions: styled_based_known_dimensions,
..inputs
},
&mut root_ctx,
)
}
}
}
fn compute_inline_layout_inner(
&mut self,
node_id: NodeId,
inputs: taffy::tree::LayoutInput,
block_ctx: &mut BlockContext<'_>,
) -> taffy::LayoutOutput {
let scale = self.viewport.scale();
let LayoutInput {
known_dimensions,
parent_size,
available_space,
sizing_mode,
..
} = inputs;
// Take inline layout to satisfy borrow checker
let mut inline_layout = self.nodes[node_id]
.data
.downcast_element_mut()
.unwrap()
.take_inline_layout()
.unwrap();
let style = self.nodes[node_id].style();
// Note: both horizontal and vertical percentage padding/borders are resolved against the container's inline size (i.e. width).
// This is not a bug, but is how CSS is specified (see: https://developer.mozilla.org/en-US/docs/Web/CSS/padding#values)
let margin = style
.margin()
.resolve_or_zero(parent_size.width, resolve_calc_value);
let padding = style
.padding()
.resolve_or_zero(parent_size.width, resolve_calc_value);
let border = style
.border()
.resolve_or_zero(parent_size.width, resolve_calc_value);
let container_pb = padding + border;
let pb_sum = container_pb.sum_axes();
let box_sizing_adjustment = if style.box_sizing() == BoxSizing::ContentBox {
pb_sum
} else {
Size::ZERO
};
// Scrollbar gutters are reserved when the `overflow` property is set to `Overflow::Scroll`.
// However, the axis are switched (transposed) because a node that scrolls vertically needs
// *horizontal* space to be reserved for a scrollbar
let scrollbar_gutter = style.overflow().transpose().map(|overflow| match overflow {
Overflow::Scroll => style.scrollbar_width(),
_ => 0.0,
});
// TODO: make side configurable based on the `direction` property
let mut content_box_inset = container_pb;
content_box_inset.right += scrollbar_gutter.x;
content_box_inset.bottom += scrollbar_gutter.y;
let has_styles_preventing_being_collapsed_through = !style.is_block()
|| style.overflow().x.is_scroll_container()
|| style.overflow().y.is_scroll_container()
|| style.position() == Position::Absolute
|| padding.top > 0.0
|| padding.bottom > 0.0
|| border.top > 0.0
|| border.bottom > 0.0;
// || matches!(node_size.height, Some(h) if h > 0.0)
// || matches!(node_min_size.height, Some(h) if h > 0.0)
// || !inline_layout.text.is_empty();
// || !inline_layout.layout.inline_boxes().is_empty();
// Short circuit if inline context contains no text or inline boxes
if !has_styles_preventing_being_collapsed_through
&& inline_layout.text.is_empty()
&& inline_layout.layout.inline_boxes().is_empty()
{
// Put layout back
self.nodes[node_id]
.data
.downcast_element_mut()
.unwrap()
.inline_layout_data = Some(inline_layout);
return LayoutOutput::from_outer_size(
Size::ZERO.maybe_max(container_pb.sum_axes().map(Some)),
);
}
// Resolve node's preferred/min/max sizes (width/heights) against the available space (percentages resolve to pixel values)
// For ContentSize mode, we pretend that the node has no size styles as these should be ignored.
let (node_size, node_min_size, node_max_size, aspect_ratio) = match sizing_mode {
SizingMode::ContentSize => {
let node_size = known_dimensions;
let node_min_size = Size::NONE;
let node_max_size = Size::NONE;
(node_size, node_min_size, node_max_size, None)
}
SizingMode::InherentSize => {
let aspect_ratio = style.aspect_ratio();
let style_size = style
.size()
.maybe_resolve(parent_size, resolve_calc_value)
.maybe_apply_aspect_ratio(aspect_ratio)
.maybe_add(box_sizing_adjustment);
let style_min_size = style
.min_size()
.maybe_resolve(parent_size, resolve_calc_value)
.maybe_apply_aspect_ratio(aspect_ratio)
.maybe_add(box_sizing_adjustment);
let style_max_size = style
.max_size()
.maybe_resolve(parent_size, resolve_calc_value)
.maybe_add(box_sizing_adjustment);
let node_size =
known_dimensions.or(style_size.maybe_clamp(style_min_size, style_max_size));
(node_size, style_min_size, style_max_size, aspect_ratio)
}
};
// Compute available space
let available_space = Size {
width: known_dimensions
.width
.map(AvailableSpace::from)
.unwrap_or(available_space.width)
.maybe_sub(margin.horizontal_axis_sum())
.maybe_set(known_dimensions.width)
.maybe_set(node_size.width)
.map_definite_value(|size| {
size.maybe_clamp(node_min_size.width, node_max_size.width)
- content_box_inset.horizontal_axis_sum()
}),
height: known_dimensions
.height
.map(AvailableSpace::from)
.unwrap_or(available_space.height)
.maybe_sub(margin.vertical_axis_sum())
.maybe_set(known_dimensions.height)
.maybe_set(node_size.height)
.map_definite_value(|size| {
size.maybe_clamp(node_min_size.height, node_max_size.height)
- content_box_inset.vertical_axis_sum()
}),
};
// Compute size of inline boxes
let child_inputs = taffy::tree::LayoutInput {
known_dimensions: Size::NONE,
available_space,
sizing_mode: SizingMode::InherentSize,
parent_size: available_space.into_options(),
// Atomic inlines (e.g. inline-block) establish independent formatting
// contexts: their margins never collapse with their children's margins.
vertical_margins_are_collapsible: taffy::Line::FALSE,
..inputs
};
#[cfg(feature = "floats")]
let float_child_inputs = taffy::tree::LayoutInput {
available_space: Size::MAX_CONTENT,
..child_inputs
};
// Update inline boxes
for ibox in inline_layout.layout.inline_boxes_mut() {
let style = self.nodes[NodeId::from_u64(ibox.id)].style();
let margin = style
.margin
.resolve_or_zero(inputs.parent_size, resolve_calc_value);
#[cfg(feature = "floats")]
let is_floated = style.float.is_floated();
#[cfg(not(feature = "floats"))]
let is_floated = false;
if style.position == Position::Absolute || is_floated {
ibox.width = 0.0;
ibox.height = 0.0;
} else {
let output = self.compute_child_layout(taffy::NodeId::from(ibox.id), child_inputs);
ibox.width = (margin.left + margin.right + output.size.width) * scale;
// Vertical margins adjust the space the box reserves in the line, but the
// reserved space cannot be negative.
ibox.height = (margin.top + margin.bottom + output.size.height).max(0.0) * scale;
}
}
// TODO: Resolve against style widths as well as known dimensions
let text_indent = self.nodes[node_id]
.primary_styles()
.map(|s| s.clone_text_indent())
.unwrap_or_else(GenericTextIndent::zero);
let resolved_text_indent = text_indent
.length
.resolve(CSSPixelLength::new(known_dimensions.width.unwrap_or(0.0)))
.px();
inline_layout.layout.set_text_indent(
resolved_text_indent,
// NOTE: hanging and each_line don't current work because parsing them is cfg'd out in Stylo
// due to Servo not yet supporting those features. They should start to "just work" in Blitz
// once support is enabled in Stylo.
IndentOptions {
each_line: text_indent.each_line,
hanging: text_indent.hanging,
},
);
let pbw = container_pb.horizontal_components().sum() * scale;
let width = known_dimensions
.width
.map(|w| (w * scale) - pbw)
.unwrap_or_else(|| {
// The inline boxes were re-measured under the current constraint just above,
// so this is the point at which the cache key (their widths) is up to date.
// `TextLayout::content_widths` reuses the previous result only when those
// widths are unchanged, which handles the tricky part of caching here: an
// inline box may measure differently under a min-content constraint than
// under a max-content one, so a single cached pair is not valid for every
// constraint once inline boxes are involved.
let content_sizes = inline_layout.content_widths();
let min_content_width = content_sizes.min;
let max_content_width = content_sizes.max;
#[cfg(feature = "floats")]
let float_width = match available_space.width {
AvailableSpace::Definite(_) => 0.0,
AvailableSpace::MinContent => {
let mut width: f32 = 0.0;
for ibox in inline_layout.layout.inline_boxes_mut() {
let style = self.nodes[NodeId::from_u64(ibox.id)].style();
if style.float.is_floated() {
let margin = style
.margin
.resolve_or_zero(inputs.parent_size, resolve_calc_value);
let output = self.compute_child_layout(
taffy::NodeId::from(ibox.id),
child_inputs,
);
width = width.max(output.size.width + margin.left + margin.right);
}
}
width * scale
}
AvailableSpace::MaxContent => {
// When computing a max-content size the available width is effectively
// infinite, so floats never wrap onto a new "band" due to a lack of
// horizontal space. They only move below preceding floats when the `clear`
// property forces them to.
//
// Floats that share a band sit side-by-side and so their widths sum, whereas
// floats pushed onto a new band (via `clear`) stack vertically and so we
// take the maximum extent across bands rather than summing.
let mut left_band: f32 = 0.0;
let mut right_band: f32 = 0.0;
let mut width: f32 = 0.0;
for ibox in inline_layout.layout.inline_boxes_mut() {
let style = self.nodes[NodeId::from_u64(ibox.id)].style();
let float = style.float;
if float.is_floated() {
if matches!(style.clear, Clear::Left | Clear::Both) {
left_band = 0.0;
}
if matches!(style.clear, Clear::Right | Clear::Both) {
right_band = 0.0;
}
let margin = style
.margin
.resolve_or_zero(inputs.parent_size, resolve_calc_value);
let output = self.compute_child_layout(
taffy::NodeId::from(ibox.id),
child_inputs,
);
let box_width = output.size.width + margin.left + margin.right;
match float {
Float::Left => left_band += box_width,
Float::Right => right_band += box_width,
Float::None => {}
}
width = width.max(left_band + right_band);
}
}
width * scale
}
};
#[cfg(not(feature = "floats"))]
let float_width = 0.0;
let computed_width = match available_space.width {
AvailableSpace::MinContent => min_content_width.max(float_width),
AvailableSpace::MaxContent => max_content_width + float_width,
AvailableSpace::Definite(limit) => (limit * scale)
.min(max_content_width + float_width)
.max(min_content_width),
}
.ceil();
let style_width = node_size.width.map(|w| w * scale);
let min_width = node_min_size.width.map(|w| w * scale);
let max_width = node_max_size.width.map(|w| w * scale);
(style_width)
.unwrap_or(computed_width + pbw)
.max(computed_width)
.maybe_clamp(min_width, max_width)
- pbw
});
#[cfg(not(feature = "floats"))]
let _ = block_ctx; // Suppress unused variable warning
// Set block context width if this is a block context root
#[cfg(feature = "floats")]
let is_bfc_root = block_ctx.is_bfc_root();
#[cfg(feature = "floats")]
if is_bfc_root {
block_ctx.set_width((width + pbw) / scale);
}
// Create sub-context to account for the inline layout's padding/border
#[cfg(feature = "floats")]
let mut block_ctx =
block_ctx.sub_context(container_pb.top, [container_pb.left, container_pb.right]);
// block_ctx.apply_content_box_inset([container_pb.left, container_pb.right]);
if inputs.run_mode == taffy::RunMode::ComputeSize
&& inputs.axis == RequestedAxis::Horizontal
{
// Put layout back
self.nodes[node_id]
.data
.downcast_element_mut()
.unwrap()
.inline_layout_data = Some(inline_layout);
let measured_size = inputs.known_dimensions.unwrap_or(taffy::Size {
width: width.ceil() / scale,
// Height is ignored if RequestedAxis if Horizontal
height: 0.0,
});
let clamped_size = inputs
.known_dimensions
.or(node_size)
.unwrap_or(measured_size + content_box_inset.sum_axes())
.maybe_clamp(node_min_size, node_max_size)
.maybe_max(container_pb.sum_axes().map(Some));
return LayoutOutput::from_outer_size(clamped_size);
}
#[cfg(not(feature = "floats"))]
{
inline_layout.layout.break_all_lines(Some(width));
}
// Perform inline layout
#[cfg(feature = "floats")]
{
let mut breaker = inline_layout.layout.break_lines();
let initial_slot = block_ctx.find_content_slot(0.0, Clear::None, None);
let mut has_active_floats = initial_slot.segment_id.is_some();
let state = breaker.state_mut();
state.set_layout_max_advance(width);
// A float slot can never entitle a line to be wider than the
// containing block's own content width. `find_content_slot` returns
// the space between the floats at a given y, and when the block
// formatting context has no width of its own (this node is not the
// BFC root, so it inherited one) that comes back effectively
// unbounded and the whole paragraph is laid out on one line.
//
// Measured on a live transcript: blocks 713px wide holding a single
// parley line 1,715px wide, with the inline elements on it sitting
// up to 987px past the pane. `broke_at` said 713 the whole time,
// because `set_layout_max_advance` was correct and this was not.
state.set_line_max_advance((initial_slot.width * scale).min(width));
state.set_line_x(initial_slot.x * scale);
state.set_line_y((initial_slot.y * scale) as f64);
// TODO: revert state and retry layout if a line doesn't fit
//
// Save initial state. Saved state is used to revert the layout to a previous state if needed
// (e.g. to revert a line that doesn't fit in the space it was laid out into)
//
// let mut saved_state = breaker.state().clone();
while let Some(yield_data) = breaker.break_next() {
match yield_data {
YieldData::LineBreak(_line_break_data) => {
let state = breaker.state_mut();
if has_active_floats {
// TODO: revert state and retry layout if a line doesn't fit
// saved_state = state.clone();
let min_y = state.line_y() / scale as f64;
let next_slot =
block_ctx.find_content_slot(min_y as f32, Clear::None, None);
has_active_floats = next_slot.segment_id.is_some();
state.set_line_max_advance((next_slot.width * scale).min(width));
state.set_line_x(next_slot.x * scale);
state.set_line_y((next_slot.y * scale) as f64);
} else {
state.set_line_x(0.0);
state.set_line_max_advance(width);
}
continue;
}
YieldData::MaxHeightExceeded(_data) => {
// TODO
continue;
}
YieldData::InlineBoxBreak(box_break_data) => {
let state = breaker.state_mut();
let node_id = NodeId::from_u64(box_break_data.inline_box_id);
let node = &mut self.nodes[node_id];
// We can assume that the box is a float because we only set `break_on_box: true` for floats
let direction = match node.style().float {
Float::Left => taffy::FloatDirection::Left,
Float::Right => taffy::FloatDirection::Right,
Float::None => unreachable!(),
};
let clear = node.style().clear;
let margin = node
.style()
.margin
.resolve_or_zero(inputs.parent_size, resolve_calc_value);
let margin_sum = margin.sum_axes();
let output = self.compute_child_layout(
crate::taffy_node_id(node_id),
float_child_inputs,
);
let min_y = state.line_y() as f32 / scale;
// Note: `pos` is content-box relative
let pos = block_ctx.place_floated_box(
output.size + margin_sum,
min_y,
direction,
clear,
false,
);
let min_y = state.line_y() / scale as f64; //.max(pos.y as f64);
let next_slot =
block_ctx.find_content_slot(min_y as f32, Clear::None, None);
has_active_floats = next_slot.segment_id.is_some();
state.set_line_max_advance((next_slot.width * scale).min(width));
state.set_line_x(next_slot.x * scale);
state.set_line_y((next_slot.y * scale) as f64);
let layout = self.nodes[node_id].unrounded_layout_mut();
layout.size = output.size;
layout.location.x = pos.x + margin.left + container_pb.left;
layout.location.y = pos.y + margin.top + container_pb.top;
// dbg!(&layout.size);
// dbg!(&layout.location);
state.append_inline_box_to_line(box_break_data.advance, 0.0);
// if float.is_floated() {
// println!("INLINE FLOATED BOX ({}) {:?}", ibox.id, float);
// println!(
// "w:{} h:{} x:{}, y:{}",
// layout.size.width, layout.size.height, 0, 0
// );
// }
}
}
}
breaker.finish();
}
let alignment = self.nodes[node_id]
.primary_styles()
.map(|s| {
use parley::layout::Alignment;
use style::values::specified::TextAlignKeyword;
match s.clone_text_align() {
TextAlignKeyword::Start => Alignment::Start,
TextAlignKeyword::Left => Alignment::Left,
TextAlignKeyword::Right => Alignment::Right,
TextAlignKeyword::Center => Alignment::Center,
TextAlignKeyword::Justify => Alignment::Justify,
TextAlignKeyword::End => Alignment::End,
TextAlignKeyword::MozCenter => Alignment::Center,
TextAlignKeyword::MozLeft => Alignment::Left,
TextAlignKeyword::MozRight => Alignment::Right,
}
})
.unwrap_or(parley::layout::Alignment::Start);
inline_layout.layout.align(
alignment,
AlignmentOptions {
align_when_overflowing: false,
},
);
// Remember the width these lines were broken at.
//
// Taffy performs layout under a min-content constraint while sizing,
// and that pass breaks the same parley layout the screen reads from.
// If the real layout then hits the taffy cache, this function is never
// called again and the min-content break is what gets painted: measured
// on a live transcript as a paragraph broken at 164px inside a 1,426px
// box, 39 lines of one or two words each. `repair_inline_line_breaks`
// compares this against the box layout settled on and re-breaks the
// ones that disagree.
inline_layout.laid_out_at = Some(width);
#[allow(unused_mut)]
let mut height = inline_layout.layout.height();
// HACK. TODO: fix in Parley.
//
// A forced line break (e.g. `<br>` or a preserved newline) at the end of the
// inline content ends the final line box but must not generate an extra empty
// line box after it. Parley produces a trailing empty line in this case
// (text-editor semantics), so we exclude that line from the measured height.
// if inline_layout.text.ends_with('\n') {
// if let Some(last_line) = inline_layout.layout.lines().last() {
// if last_line.items().next().is_none() {
// height -= last_line.metrics().line_height;
// }
// }
// }
#[cfg(feature = "floats")]
{
if is_bfc_root {
height = height.max(block_ctx.floated_content_height_contribution() * scale)
};
}
// Note: `width` and `height` are content-box measurements of the inline content.
// `known_dimensions` must not be substituted in here: those are border-box sizes, and
// using them for `content_size` (which adds padding below) would double-count padding,
// incorrectly making the container's content overflow it.
let measured_size = taffy::Size {
width: width / scale,
height: height / scale,
};
let clamped_size = inputs
.known_dimensions
.or(node_size)
.unwrap_or(measured_size + content_box_inset.sum_axes())
.maybe_clamp(node_min_size, node_max_size);
let final_size = Size {
width: clamped_size.width,
height: f32_max(
clamped_size.height,
aspect_ratio
.map(|ratio| clamped_size.width / ratio)
.unwrap_or(0.0),
),
}
.maybe_max(container_pb.sum_axes().map(Some));
let container_direction = self.nodes[node_id].style().direction;
// Store sizes and positions of inline boxes.
//
// Only when actually performing layout. A measurement pass must not
// commit child positions: `ComputeSize` is asked the same subtree under
// a sequence of trial widths, and every one of those overwrote the
// boxes of the inline elements on the line. Whichever trial ran last
// won, so an item-reference chip ended up at the x it would have had on
// a max-content line, 1,620px into a block that had correctly resolved
// to 713px and correctly wrapped to three lines. The text rewrapped;
// the elements on it did not move. That is the transcript spill.
//
// The early return above already covers `ComputeSize` on the horizontal
// axis. The vertical one falls through to here, which is the pass that
// did the damage: it is measuring a height, and it has no business
// deciding where anything sits.
//
// The probe that caught it recorded, among others, a chip 166px wide
// placed at x=0 on a line broken at width 0, from a
// `known = Some(0.0)` height measurement.
// Tracing, `BLITZ_TRACE_INLINE=1`.
//
// One line per inline layout that places element boxes, saying the
// width the lines were broken at and the size the block ended up. That
// width is the number the outside cannot see, and the gap between the
// two is the bug: a block laid out at 1,723px has its chips written at
// that width, and is then sized to 713px by a pass that reuses the
// cached output without re-running the inline layout. The boxes are
// then perfectly placed on a line that no longer exists.
//
// The first version of this only fired when a box overflowed the width
// it was placed at, so it was silent through the entire bug and read as
// evidence of absence. Those boxes were never outside their own line,
// only outside the box the block ended up with.
// Filtering this on `PerformLayout` is what hid the bug for a whole
// session. The accusation is that a *measure* re-breaks the lines and
// leaves them behind, so a trace that only prints measures' well-behaved
// sibling reads zero and gets believed. Every pass that reaches this
// point has already re-broken the lines, so every pass prints, and the
// run mode and axis are columns rather than a filter.
//
// `places=` is the column that names the defect: box placement below is
// `PerformLayout`-only, so a line printing `places=no` with a `broke_at`
// different from the last `places=yes` has just moved the text out from
// under boxes that stayed where they were.
if *TRACE_INLINE.get_or_init(|| std::env::var_os("BLITZ_TRACE_INLINE").is_some()) {
let boxes = inline_layout.layout.inline_boxes().len();
let ws = self.nodes[node_id]
.primary_styles()
.map(|s| format!("{:?}", s.get_inherited_text().clone_white_space_collapse()))
.unwrap_or_default();
let wrap = self.nodes[node_id]
.primary_styles()
.map(|s| format!("{:?}", s.get_inherited_text().clone_text_wrap_mode()))
.unwrap_or_default();
let places = if inputs.run_mode == taffy::RunMode::PerformLayout {
"yes"
} else {
"no"
};
eprintln!(
"inline-layout node={:?} mode={:?} axis={:?} places={places} boxes={boxes} broke_at={:.1} known={:?} avail={:?} final={:.1} ws={ws} wrap={wrap} layout_w={:.1} lines={}",
node_id,
inputs.run_mode,
inputs.axis,
width / scale,
inputs.known_dimensions.width,
inputs.available_space.width,
final_size.width,
inline_layout.layout.width() / scale,
inline_layout.layout.len(),
);
}
if inputs.run_mode == taffy::RunMode::PerformLayout {
for line in inline_layout.layout.lines() {
for item in line.items() {
if let parley::layout::PositionedLayoutItem::InlineBox(ibox) = item {
let node = &mut self.nodes[NodeId::from_u64(ibox.id)];
let padding = node
.style()
.padding
.resolve_or_zero(child_inputs.parent_size, resolve_calc_value);
let border = node
.style()
.border
.resolve_or_zero(child_inputs.parent_size, resolve_calc_value);
let margin = node
.style()
.margin
.resolve_or_zero(child_inputs.parent_size, resolve_calc_value);
#[cfg(feature = "floats")]
let is_floated = node.style().float != Float::None;
#[cfg(not(feature = "floats"))]
let is_floated = false;
if node.style().position == Position::Absolute {
let direction = node.style().direction;
// The static position of an absolutely positioned box depends on the
// display its hypothetical box would have had (the display specified
// before position:absolute blockified it): inline-level boxes sit at
// their position within the line, while block-level boxes start at the
// content-box left edge of their containing block.
let is_inline_level = node
.primary_styles()
.map(|s| {
s.get_box().original_display.outside() == DisplayOutside::Inline
})
.unwrap_or(true);
let static_position = taffy::Point {
x: if is_inline_level {
ibox.x
} else {
container_pb.left
},
y: ibox.y,
};
layout_abspos_child(
self,
ibox.id,
static_position,
is_inline_level,
final_size,
taffy::Point::ZERO,
direction,
);
} else if is_floated {
let layout =
self.nodes[NodeId::from_u64(ibox.id)].unrounded_layout_mut();
layout.padding = padding; //.map(|p| p / scale);
layout.border = border; //.map(|p| p / scale);
} else {
// Re-measure the box to get its border-box size (this hits the layout
// cache). The size cannot be recovered from `ibox` dimensions as the
// space reserved in the line is clamped to be non-negative.
let size = self
.compute_child_layout(taffy::NodeId::from(ibox.id), child_inputs)
.size;
let node = &mut self.nodes[NodeId::from_u64(ibox.id)];
// Resolve relative inset offsets against the containing block
// (the content box of the inline container).
let style = node.style();
let container_content_size = final_size - content_box_inset.sum_axes();
let inset = taffy::Rect {
left: style.inset.left.maybe_resolve(
container_content_size.width,
resolve_calc_value,
),
right: style.inset.right.maybe_resolve(
container_content_size.width,
resolve_calc_value,
),
top: style.inset.top.maybe_resolve(
container_content_size.height,
resolve_calc_value,
),
bottom: style.inset.bottom.maybe_resolve(
container_content_size.height,
resolve_calc_value,
),
};
let inset_offset = taffy::Point {
x: if container_direction == Direction::Rtl {
inset.right.map(|x| -x).or(inset.left).unwrap_or(0.0)
} else {
inset.left.or(inset.right.map(|x| -x)).unwrap_or(0.0)
},
y: inset.top.or(inset.bottom.map(|x| -x)).unwrap_or(0.0),
};
let layout = node.unrounded_layout_mut();
layout.size = size;
layout.location.x =
(ibox.x / scale) + margin.left + container_pb.left + inset_offset.x;
// A negative `margin-top` shrinks the space the box reserves in the
// line but does not move the box itself, which stays anchored to the
// bottom of the reserved space.
layout.location.y = (ibox.y / scale)
+ margin.top.max(0.0)
+ container_pb.top
+ inset_offset.y;
layout.padding = padding; //.map(|p| p / scale);
layout.border = border; //.map(|p| p / scale);
}
}
}
}
}
// println!("INLINE LAYOUT FOR {:?}. max_advance: {:?}", node_id, max_advance);
// dbg!(&inline_layout.text);
// println!("Computed: w: {} h: {}", inline_layout.layout.width(), inline_layout.layout.height());
// println!("known_dimensions: w: {:?} h: {:?}", inputs.known_dimensions.width, inputs.known_dimensions.height);
// println!("\n");
let first_baseline = inline_layout
.layout
.lines()
.next()
.map(|line| (line.metrics().baseline / scale) + container_pb.top);
// Put layout back
self.nodes[node_id]
.data
.downcast_element_mut()
.unwrap()
.inline_layout_data = Some(inline_layout);
LayoutOutput {
size: final_size,
content_size: measured_size + padding.sum_axes(),
first_baselines: Point {
x: None,
y: first_baseline,
},
top_margin: CollapsibleMarginSet::ZERO,
bottom_margin: CollapsibleMarginSet::ZERO,
margins_can_collapse_through: !has_styles_preventing_being_collapsed_through
&& final_size.height == 0.0
&& measured_size.height == 0.0,
}
}
}
#[inline(always)]
fn f32_max(a: f32, b: f32) -> f32 {
a.max(b)
}
/// Perform absolute layout on all absolutely positioned children.
#[inline]
fn layout_abspos_child(
tree: &mut impl taffy::LayoutBlockContainer,
item_id: u64,
static_position: Point<f32>,
is_inline_level: bool,
area_size: Size<f32>,
area_offset: Point<f32>,
direction: taffy::Direction,
) {
let area_width = area_size.width;
let area_height = area_size.height;
let node_id = taffy::NodeId::from(item_id);
let child_style = tree.get_block_child_style(node_id);
// Skip items that are display:none or are not position:absolute
if child_style.box_generation_mode() == taffy::BoxGenerationMode::None
|| child_style.position() != taffy::Position::Absolute
{
return;
}
let aspect_ratio = child_style.aspect_ratio();
let overflow = child_style.overflow();
let scrollbar_width = child_style.scrollbar_width();
let margin = child_style
.margin()
.map(|margin| margin.resolve_to_option(area_width, resolve_calc_value));
let padding = child_style
.padding()
.resolve_or_zero(Some(area_width), resolve_calc_value);
let border = child_style
.border()
.resolve_or_zero(Some(area_width), resolve_calc_value);
let padding_border_sum = (padding + border).sum_axes();
let box_sizing_adjustment = if child_style.box_sizing() == taffy::BoxSizing::ContentBox {
padding_border_sum
} else {
Size::ZERO
};
// Resolve inset
let left = child_style
.inset()
.left
.maybe_resolve(area_width, resolve_calc_value);
let right = child_style
.inset()
.right
.maybe_resolve(area_width, resolve_calc_value);
let top = child_style
.inset()
.top
.maybe_resolve(area_height, resolve_calc_value);
let bottom = child_style
.inset()
.bottom
.maybe_resolve(area_height, resolve_calc_value);
// Compute known dimensions from min/max/inherent size styles
let style_size = child_style
.size()
.maybe_resolve(area_size, resolve_calc_value)
.maybe_apply_aspect_ratio(aspect_ratio)
.maybe_add(box_sizing_adjustment);
let min_size = child_style
.min_size()
.maybe_resolve(area_size, resolve_calc_value)
.maybe_apply_aspect_ratio(aspect_ratio)
.maybe_add(box_sizing_adjustment)
.or(padding_border_sum.map(Some))
.maybe_max(padding_border_sum);
let max_size = child_style
.max_size()
.maybe_resolve(area_size, resolve_calc_value)
.maybe_apply_aspect_ratio(aspect_ratio)
.maybe_add(box_sizing_adjustment);
let mut known_dimensions = style_size.maybe_clamp(min_size, max_size);
drop(child_style);
// Fill in width from left/right and reapply aspect ratio if:
// - Width is not already known
// - Item has both left and right inset properties set
if let (None, Some(left), Some(right)) = (known_dimensions.width, left, right) {
let new_width_raw =
area_width.maybe_sub(margin.left).maybe_sub(margin.right) - left - right;
known_dimensions.width = Some(f32_max(new_width_raw, 0.0));
known_dimensions = known_dimensions
.maybe_apply_aspect_ratio(aspect_ratio)
.maybe_clamp(min_size, max_size);
}
// Fill in height from top/bottom and reapply aspect ratio if:
// - Height is not already known
// - Item has both top and bottom inset properties set
if let (None, Some(top), Some(bottom)) = (known_dimensions.height, top, bottom) {
let new_height_raw =
area_height.maybe_sub(margin.top).maybe_sub(margin.bottom) - top - bottom;
known_dimensions.height = Some(f32_max(new_height_raw, 0.0));
known_dimensions = known_dimensions
.maybe_apply_aspect_ratio(aspect_ratio)
.maybe_clamp(min_size, max_size);
}
let measured_size = tree
.compute_child_layout(
node_id,
taffy::LayoutInput {
known_dimensions,
parent_size: area_size.map(Some),
available_space: Size {
width: AvailableSpace::Definite(
area_width.maybe_clamp(min_size.width, max_size.width),
),
height: AvailableSpace::Definite(
area_height.maybe_clamp(min_size.height, max_size.height),
),
},
sizing_mode: SizingMode::ContentSize,
run_mode: RunMode::ComputeSize,
axis: taffy::RequestedAxis::Both,
vertical_margins_are_collapsible: taffy::Line::FALSE,
},
)
.size;
let final_size = known_dimensions
.unwrap_or(measured_size)
.maybe_clamp(min_size, max_size);
let layout_output = tree.compute_child_layout(
node_id,
taffy::LayoutInput {
known_dimensions: final_size.map(Some),
parent_size: area_size.map(Some),
available_space: Size {
width: AvailableSpace::Definite(
area_width.maybe_clamp(min_size.width, max_size.width),
),
height: AvailableSpace::Definite(
area_height.maybe_clamp(min_size.height, max_size.height),
),
},
sizing_mode: SizingMode::ContentSize,
run_mode: RunMode::PerformLayout,
axis: taffy::RequestedAxis::Both,
vertical_margins_are_collapsible: taffy::Line::FALSE,
},
);
let non_auto_margin = taffy::Rect {
left: if left.is_some() {
margin.left.unwrap_or(0.0)
} else {
0.0
},
right: if right.is_some() {
margin.right.unwrap_or(0.0)
} else {
0.0
},
top: if top.is_some() {
margin.top.unwrap_or(0.0)
} else {
0.0
},
bottom: if bottom.is_some() {
margin.bottom.unwrap_or(0.0)
} else {
0.0
},
};
// Expand auto margins to fill available space
// https://www.w3.org/TR/CSS21/visudet.html#abs-non-replaced-width
let auto_margin = {
// Auto margins for absolutely positioned elements in block containers only resolve
// if inset is set. Otherwise they resolve to 0.
let absolute_auto_margin_space = Point {
x: right
.map(|right| area_size.width - right - left.unwrap_or(0.0))
.unwrap_or(final_size.width),
y: bottom
.map(|bottom| area_size.height - bottom - top.unwrap_or(0.0))
.unwrap_or(final_size.height),
};
let free_space = Size {
width: absolute_auto_margin_space.x
- final_size.width
- non_auto_margin.horizontal_axis_sum(),
height: absolute_auto_margin_space.y
- final_size.height
- non_auto_margin.vertical_axis_sum(),
};
let auto_margin_size = Size {
// If all three of 'left', 'width', and 'right' are 'auto': First set any 'auto' values for 'margin-left' and 'margin-right' to 0.
// Then, if the 'direction' property of the element establishing the static-position containing block is 'ltr' set 'left' to the
// static position and apply rule number three below; otherwise, set 'right' to the static position and apply rule number one below.
//
// If none of the three is 'auto': If both 'margin-left' and 'margin-right' are 'auto', solve the equation under the extra constraint
// that the two margins get equal values, unless this would make them negative, in which case when direction of the containing block is
// 'ltr' ('rtl'), set 'margin-left' ('margin-right') to zero and solve for 'margin-right' ('margin-left'). If one of 'margin-left' or
// 'margin-right' is 'auto', solve the equation for that value. If the values are over-constrained, ignore the value for 'left' (in case
// the 'direction' property of the containing block is 'rtl') or 'right' (in case 'direction' is 'ltr') and solve for that value.
width: {
let auto_margin_count = margin.left.is_none() as u8 + margin.right.is_none() as u8;
if auto_margin_count == 2
&& (style_size.width.is_none() || style_size.width.unwrap() >= free_space.width)
{
0.0
} else if auto_margin_count > 0 {
free_space.width / auto_margin_count as f32
} else {
0.0
}
},
height: {
let auto_margin_count = margin.top.is_none() as u8 + margin.bottom.is_none() as u8;
if auto_margin_count == 2
&& (style_size.height.is_none()
|| style_size.height.unwrap() >= free_space.height)
{
0.0
} else if auto_margin_count > 0 {
free_space.height / auto_margin_count as f32
} else {
0.0
}
},
};
taffy::Rect {
left: margin.left.map(|_| 0.0).unwrap_or(auto_margin_size.width),
right: margin.right.map(|_| 0.0).unwrap_or(auto_margin_size.width),
top: margin.top.map(|_| 0.0).unwrap_or(auto_margin_size.height),
bottom: margin
.bottom
.map(|_| 0.0)
.unwrap_or(auto_margin_size.height),
}
};
let resolved_margin = taffy::Rect {
left: margin.left.unwrap_or(auto_margin.left),
right: margin.right.unwrap_or(auto_margin.right),
top: margin.top.unwrap_or(auto_margin.top),
bottom: margin.bottom.unwrap_or(auto_margin.bottom),
};
let x_offset = match (left, right) {
(Some(left), Some(right)) => {
if direction == Direction::Rtl {
area_size.width - final_size.width - right - resolved_margin.right
} else {
left + resolved_margin.left
}
}
(Some(left), None) => left + resolved_margin.left,
(None, Some(right)) => area_size.width - final_size.width - right - resolved_margin.right,
(None, None) => {
if direction == Direction::Rtl && is_inline_level {
static_position.x - final_size.width - resolved_margin.right - area_offset.x
} else {
static_position.x + resolved_margin.left - area_offset.x
}
}
};
let location = Point {
x: x_offset + area_offset.x,
y: top
.map(|top| top + resolved_margin.top)
.or(bottom.map(|bottom| {
area_size.height - final_size.height - bottom - resolved_margin.bottom
}))
.maybe_add(area_offset.y)
.unwrap_or(static_position.y + resolved_margin.top),
};
// Note: axis intentionally switched here as scrollbars take up space in the opposite axis
// to the axis in which scrolling is enabled.
let scrollbar_size = Size {
width: if overflow.y == Overflow::Scroll {
scrollbar_width
} else {
0.0
},
height: if overflow.x == Overflow::Scroll {
scrollbar_width
} else {
0.0
},
};
tree.set_unrounded_layout(
node_id,
&taffy::Layout {
order: 0, // TODO: order
size: final_size,
content_size: layout_output.content_size,
scrollbar_size,
location,
padding,
border,
margin: resolved_margin,
},
);
}