protosocket-rpc 1.0.4

RPC using protosockets
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
use std::{
    collections::HashMap,
    future::Future,
    pin::{pin, Pin},
    task::{Context, Poll},
};

use futures::{
    stream::{FuturesUnordered, SelectAll},
    Stream,
};
use tokio::sync::mpsc;
use tokio_util::sync::PollSender;

use crate::{server::RpcKind, Error, Message, ProtosocketControlCode};

use super::{
    abortable::{AbortableState, IdentifiableAbortHandle, IdentifiableAbortable},
    ConnectionService,
};

#[derive(Debug)]
pub struct RpcConnectionServer<TConnectionServer>
where
    TConnectionServer: ConnectionService,
{
    connection_server: TConnectionServer,
    // inbound: mpsc::UnboundedReceiver<<TConnectionServer as ConnectionService>::Request>,
    outbound: PollSender<<TConnectionServer as ConnectionService>::Response>,
    // next_messages_buffer: Vec<<TConnectionServer as ConnectionService>::Request>,
    // outstanding_unary_rpcs:
    //     FuturesUnordered<IdentifiableAbortable<TConnectionServer::UnaryFutureType>>,
    // outstanding_streaming_rpcs: SelectAll<IdentifiableAbortable<TConnectionServer::StreamType>>,
    aborts: HashMap<u64, IdentifiableAbortHandle>,
}

impl<TConnectionServer> Future for RpcConnectionServer<TConnectionServer>
where
    TConnectionServer: ConnectionService,
{
    type Output = Result<(), crate::Error>;

    fn poll(mut self: Pin<&mut Self>, context: &mut Context<'_>) -> Poll<Self::Output> {
        // receive new messages
        if let Some(early_out) = self.as_mut().poll_receive_buffer(context) {
            return early_out;
        }
        // either we're pending on inbound or we're awake
        self.as_mut().handle_message_buffer();

        // retire and advance outstanding rpcs
        if let Some(early_out) = self.as_mut().poll_advance_unary_rpcs(context) {
            return early_out;
        }
        if let Some(early_out) = self.poll_advance_streaming_rpcs(context) {
            return early_out;
        }

        Poll::Pending
    }
}

impl<TConnectionServer> RpcConnectionServer<TConnectionServer>
where
    TConnectionServer: ConnectionService,
{
    pub fn new(
        connection_server: TConnectionServer,
        inbound: mpsc::UnboundedReceiver<<TConnectionServer as ConnectionService>::Request>,
        outbound: mpsc::Sender<<TConnectionServer as ConnectionService>::Response>,
    ) -> Self {
        Self {
            connection_server,
            inbound,
            outbound: PollSender::new(outbound),
            next_messages_buffer: Default::default(),
            outstanding_unary_rpcs: Default::default(),
            outstanding_streaming_rpcs: Default::default(),
            aborts: Default::default(),
        }
    }

    
}

#[cfg(test)]
mod test {
    use std::{
        future::Future,
        pin::pin,
        ptr,
        task::{Context, Poll, RawWaker, RawWakerVTable, Waker},
    };

    use futures::{FutureExt, StreamExt};
    use tokio::sync::mpsc;

    use crate::{
        server::{ConnectionService, RpcKind},
        ProtosocketControlCode,
    };

    use super::RpcConnectionServer;

    #[derive(Clone, PartialEq, Eq, prost::Message, PartialOrd, Ord)]
    pub struct Message {
        #[prost(uint64, tag = "1")]
        pub id: u64,
        #[prost(uint32, tag = "2")]
        pub code: u32,
        #[prost(uint64, tag = "3")]
        pub n: u64,
    }

    impl crate::Message for Message {
        fn message_id(&self) -> u64 {
            self.id
        }

        fn control_code(&self) -> crate::ProtosocketControlCode {
            crate::ProtosocketControlCode::from_u8(self.code as u8)
        }

        fn set_message_id(&mut self, message_id: u64) {
            self.id = message_id;
        }

        fn cancelled(message_id: u64) -> Self {
            Self {
                id: message_id,
                n: 0,
                code: ProtosocketControlCode::Cancel.as_u8() as u32,
            }
        }

        fn ended(message_id: u64) -> Self {
            Self {
                id: message_id,
                n: 0,
                code: ProtosocketControlCode::End.as_u8() as u32,
            }
        }
    }

    const HANGING_UNARY_MESSAGE: u64 = 2000;
    const HANGING_STREAMING_MESSAGE: u64 = 3000;
    struct TestConnectionService;
    impl std::fmt::Debug for TestConnectionService {
        fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
            f.debug_struct("TestConnectionService").finish()
        }
    }

    impl ConnectionService for TestConnectionService {
        type Request = Message;
        type Response = Message;
        // Boxing is used for convenience in tests. You should try to use a static type in your real code.
        type UnaryFutureType = futures::future::BoxFuture<'static, Message>;
        type StreamType = futures::stream::BoxStream<'static, Message>;

        fn new_rpc(
            &mut self,
            request: Self::Request,
        ) -> crate::server::RpcKind<Self::UnaryFutureType, Self::StreamType> {
            if request.id == HANGING_UNARY_MESSAGE {
                RpcKind::Unary(futures::future::pending().boxed())
            } else if request.id == HANGING_STREAMING_MESSAGE {
                RpcKind::Streaming(futures::stream::pending().boxed())
            } else if request.id < 1000 {
                RpcKind::Unary(
                    futures::future::ready(Message {
                        id: request.id,
                        code: ProtosocketControlCode::Normal.as_u8() as u32,
                        n: request.n + 1,
                    })
                    .boxed(),
                )
            } else {
                RpcKind::Streaming(
                    futures::stream::iter((0..request.n).map(move |n| Message {
                        id: request.id,
                        code: ProtosocketControlCode::Normal.as_u8() as u32,
                        n,
                    }))
                    .boxed(),
                )
            }
        }
    }

    pub fn noop_waker() -> Waker {
        const NOOP_WAKER_VTABLE: RawWakerVTable = RawWakerVTable::new(
            |_| RawWaker::new(ptr::null(), &NOOP_WAKER_VTABLE),
            |_| {},
            |_| {},
            |_| {},
        );
        let raw = RawWaker::new(ptr::null(), &NOOP_WAKER_VTABLE);
        // SAFETY: the contracts for RawWaker and RawWakerVTable are trivially upheld by always making new wakers
        unsafe { Waker::from_raw(raw) }
    }

    fn test_server(
        outbound_buffer: usize,
    ) -> (
        mpsc::UnboundedSender<Message>,
        mpsc::Receiver<Message>,
        RpcConnectionServer<TestConnectionService>,
    ) {
        let (inbound_sender, inbound) = mpsc::unbounded_channel();
        let (outbound, outbound_receiver) = mpsc::channel(outbound_buffer);
        let server = RpcConnectionServer::new(TestConnectionService, inbound, outbound);
        (inbound_sender, outbound_receiver, server)
    }

    #[track_caller]
    fn assert_next(
        message: Message,
        outbound_receiver: &mut mpsc::Receiver<Message>,
        context: &mut Context<'_>,
    ) {
        assert_eq!(
            Poll::Ready(Some(message)),
            outbound_receiver.poll_recv(context)
        );
    }

    #[track_caller]
    fn poll_next(
        outbound_receiver: &mut mpsc::Receiver<Message>,
        context: &mut Context<'_>,
    ) -> Message {
        match outbound_receiver.poll_recv(context) {
            Poll::Ready(Some(message)) => message,
            got => panic!("expected message, got {got:?}"),
        }
    }

    #[test]
    fn unary() {
        let waker = noop_waker();
        let mut context = Context::from_waker(&waker);

        let (inbound_sender, mut outbound_receiver, mut server) = test_server(3);

        // test messages below 1000 are unary. Response is n + 1
        let _ = inbound_sender.send(Message {
            id: 1,
            code: 0,
            n: 1,
        });

        assert_eq!(
            Poll::Pending,
            outbound_receiver.poll_recv(&mut context),
            "nothing should be sent until the server advances to accept the message"
        );

        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );
        assert_eq!(
            0,
            server.outstanding_unary_rpcs.len(),
            "it completed in one poll"
        );

        assert_next(
            Message {
                id: 1,
                code: 0,
                n: 2,
            },
            &mut outbound_receiver,
            &mut context,
        );
    }

    #[test]
    fn concurrent_unary() {
        let waker = noop_waker();
        let mut context = Context::from_waker(&waker);

        let (inbound_sender, mut outbound_receiver, mut server) = test_server(3);

        let _ = inbound_sender.send(Message {
            id: 1,
            code: 0,
            n: 1,
        });
        let _ = inbound_sender.send(Message {
            id: 2,
            code: 0,
            n: 3,
        });
        let _ = inbound_sender.send(Message {
            id: 3,
            code: 0,
            n: 5,
        });

        // the server takes up to MAXIMUM_MESSAGES_PER_POLL per poll. I only submitted 3, so they should
        // all get processed in the a single round of poll.
        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );
        assert_eq!(
            0,
            server.outstanding_unary_rpcs.len(),
            "it completed in one poll"
        );

        let mut concurrent_completions = vec![
            poll_next(&mut outbound_receiver, &mut context),
            poll_next(&mut outbound_receiver, &mut context),
            poll_next(&mut outbound_receiver, &mut context),
        ];
        // they are allowed to complete in any order but I'd like a deterministic order for the assertion
        concurrent_completions.sort();

        assert_eq!(
            vec![
                Message {
                    id: 1,
                    code: 0,
                    n: 2
                },
                Message {
                    id: 2,
                    code: 0,
                    n: 4
                },
                Message {
                    id: 3,
                    code: 0,
                    n: 6
                },
            ],
            concurrent_completions,
        );
        assert_eq!(
            Poll::Pending,
            outbound_receiver.poll_recv(&mut context),
            "no made up messages"
        );
    }

    #[test]
    fn streaming() {
        let waker = noop_waker();
        let mut context = Context::from_waker(&waker);

        let (inbound_sender, mut outbound_receiver, mut server) = test_server(3);
        // "test" messages at and above 1000 are streaming. Stream has responses n=0..n
        let _ = inbound_sender.send(Message {
            id: 1000,
            code: 0,
            n: 2,
        });
        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );

        let first_message = poll_next(&mut outbound_receiver, &mut context);
        assert_eq!(
            1,
            server.outstanding_streaming_rpcs.len(),
            "there should still be an outstanding rpc because the stream is not done"
        );
        let messages = vec![
            first_message,
            poll_next(&mut outbound_receiver, &mut context),
            poll_next(&mut outbound_receiver, &mut context),
        ];
        // these must come in the correct order.

        assert_eq!(
            vec![
                Message {
                    id: 1000,
                    code: 0,
                    n: 0
                },
                Message {
                    id: 1000,
                    code: 0,
                    n: 1
                },
                Message {
                    id: 1000,
                    code: ProtosocketControlCode::End.as_u8() as u32,
                    n: 0
                },
            ],
            messages,
        );

        assert_eq!(1, server.outstanding_streaming_rpcs.len(), "server has not yet discovered that this rpc is complete. This might change if the poll batch process is changed");
        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );
        assert_eq!(
            0,
            server.outstanding_streaming_rpcs.len(),
            "all rpcs should be completed"
        );
        assert_eq!(
            Poll::Pending,
            outbound_receiver.poll_recv(&mut context),
            "no made up messages"
        );
    }

    #[test]
    fn streaming_concurrent() {
        let waker = noop_waker();
        let mut context = Context::from_waker(&waker);

        let (inbound_sender, mut outbound_receiver, mut server) = test_server(3);
        // "test" messages at and above 1000 are streaming. Stream has responses n=0..n
        let _ = inbound_sender.send(Message {
            id: 1000,
            code: 0,
            n: 2,
        });
        let _ = inbound_sender.send(Message {
            id: 1001,
            code: 0,
            n: 2,
        });
        let _ = inbound_sender.send(Message {
            id: 1002,
            code: 0,
            n: 2,
        });

        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );
        assert_eq!(3, server.outstanding_streaming_rpcs.len());

        let mut messages = vec![
            poll_next(&mut outbound_receiver, &mut context),
            poll_next(&mut outbound_receiver, &mut context),
            poll_next(&mut outbound_receiver, &mut context),
        ];
        assert_eq!(
            Poll::Pending,
            outbound_receiver.poll_recv(&mut context),
            "outbound buffer is only 3. It is unknown if any of the rpcs are complete"
        );
        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );
        messages.push(poll_next(&mut outbound_receiver, &mut context));
        messages.push(poll_next(&mut outbound_receiver, &mut context));
        messages.push(poll_next(&mut outbound_receiver, &mut context));
        assert_eq!(Poll::Pending, outbound_receiver.poll_recv(&mut context), "though we only defined 6 messages, the server sends an End message for each gracefully ended stream");
        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );
        messages.push(poll_next(&mut outbound_receiver, &mut context));
        messages.push(poll_next(&mut outbound_receiver, &mut context));
        messages.push(poll_next(&mut outbound_receiver, &mut context));

        // The messages may be intermixed per-rpc, but they must be mutually in order per-rpc.
        // It is a weak assertion to sort these, because that would allow _reordered streams_ to pass the test.
        let first_rpc: Vec<_> = messages
            .iter()
            .filter(|message| message.id == 1000)
            .cloned()
            .collect();
        let second_rpc: Vec<_> = messages
            .iter()
            .filter(|message| message.id == 1001)
            .cloned()
            .collect();
        let third_rpc: Vec<_> = messages
            .iter()
            .filter(|message| message.id == 1002)
            .cloned()
            .collect();

        assert_eq!(
            vec![
                Message {
                    id: 1000,
                    code: 0,
                    n: 0
                },
                Message {
                    id: 1000,
                    code: 0,
                    n: 1
                },
                Message {
                    id: 1000,
                    code: ProtosocketControlCode::End.as_u8() as u32,
                    n: 0
                },
            ],
            first_rpc,
        );
        assert_eq!(
            vec![
                Message {
                    id: 1001,
                    code: 0,
                    n: 0
                },
                Message {
                    id: 1001,
                    code: 0,
                    n: 1
                },
                Message {
                    id: 1001,
                    code: ProtosocketControlCode::End.as_u8() as u32,
                    n: 0
                },
            ],
            second_rpc,
        );
        assert_eq!(
            vec![
                Message {
                    id: 1002,
                    code: 0,
                    n: 0
                },
                Message {
                    id: 1002,
                    code: 0,
                    n: 1
                },
                Message {
                    id: 1002,
                    code: ProtosocketControlCode::End.as_u8() as u32,
                    n: 0
                },
            ],
            third_rpc,
        );
        // server may have 0-3 pending rpcs, but they should all complete with the next poll.
        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );
        assert_eq!(
            0,
            server.outstanding_streaming_rpcs.len(),
            "all rpcs should be completed"
        );
        assert_eq!(
            Poll::Pending,
            outbound_receiver.poll_recv(&mut context),
            "no made up messages"
        );
    }

    // This test makes sure that the server drops a unary rpc when it asked to do so.
    #[test]
    fn unary_client_cancellation() {
        let waker = noop_waker();
        let mut context = Context::from_waker(&waker);

        let (inbound_sender, mut outbound_receiver, mut server) = test_server(3);

        let _ = inbound_sender.send(Message {
            id: HANGING_UNARY_MESSAGE,
            code: 0,
            n: 1,
        });
        assert!(pin!(&mut server).poll(&mut context).is_pending());

        assert_eq!(
            1,
            server.outstanding_unary_rpcs.len(),
            "it will never complete"
        );

        let _ = inbound_sender.send(Message {
            id: HANGING_UNARY_MESSAGE,
            code: ProtosocketControlCode::Cancel.as_u8() as u32,
            n: 0,
        });

        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );
        assert_eq!(
            0,
            server.outstanding_unary_rpcs.len(),
            "all rpcs should be completed"
        );
        assert_eq!(
            Poll::Pending,
            outbound_receiver.poll_recv(&mut context),
            "no made up messages"
        );
    }

    // This test makes sure that the server drops a streaming rpc when it asked to do so.
    #[test]
    fn streaming_client_cancellation() {
        let waker = noop_waker();
        let mut context = Context::from_waker(&waker);

        let (inbound_sender, mut outbound_receiver, mut server) = test_server(3);

        let _ = inbound_sender.send(Message {
            id: HANGING_STREAMING_MESSAGE,
            code: 0,
            n: 1,
        });
        assert!(pin!(&mut server).poll(&mut context).is_pending());

        assert_eq!(
            1,
            server.outstanding_streaming_rpcs.len(),
            "it will never complete"
        );

        let _ = inbound_sender.send(Message {
            id: HANGING_STREAMING_MESSAGE,
            code: ProtosocketControlCode::Cancel.as_u8() as u32,
            n: 0,
        });

        assert!(
            pin!(&mut server).poll(&mut context).is_pending(),
            "server should be pending forever"
        );
        assert_eq!(
            0,
            server.outstanding_streaming_rpcs.len(),
            "all rpcs should be completed"
        );
        assert_eq!(
            Poll::Pending,
            outbound_receiver.poll_recv(&mut context),
            "no made up messages"
        );
    }
}