1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
// Protocol Buffers - Google's data interchange format
// Copyright 2023 Google LLC. All rights reserved.
//
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file or at
// https://developers.google.com/open-source/licenses/bsd
#include <stdlib.h>
#include <gtest/gtest.h>
#include "upb/base/string_view.h"
#include "upb/base/upcast.h"
#include "upb/mem/arena.h"
#include "upb/mem/arena.hpp"
#include "upb/message/utf8_test.upb.h"
#include "upb/message/utf8_test.upb_minitable.h"
#include "upb/message/utf8_test_proto2.upb.h"
#include "upb/message/utf8_test_proto2.upb_minitable.h"
#include "upb/wire/decode.h"
namespace {
const char bad_utf8[] = "\xff";
static char* GetBadUtf8Payload(upb_Arena* arena, size_t* size) {
upb_test_TestUtf8Bytes* msg = upb_test_TestUtf8Bytes_new(arena);
upb_test_TestUtf8Bytes_set_data(msg, upb_StringView_FromString(bad_utf8));
char* data = upb_test_TestUtf8Bytes_serialize(msg, arena, size);
EXPECT_TRUE(data != nullptr);
return data;
}
TEST(Utf8Test, BytesFieldDoesntValidate) {
upb::Arena arena;
size_t size;
char* data = GetBadUtf8Payload(arena.ptr(), &size);
upb_test_TestUtf8Bytes* msg2 =
upb_test_TestUtf8Bytes_parse(data, size, arena.ptr());
// Parse succeeds, because the bytes field does not validate UTF-8.
ASSERT_TRUE(msg2 != nullptr);
}
TEST(Utf8Test, Proto3FieldValidates) {
upb::Arena arena;
size_t size;
char* data = GetBadUtf8Payload(arena.ptr(), &size);
upb_test_TestUtf8Proto3String* msg =
upb_test_TestUtf8Proto3String_new(arena.ptr());
upb_DecodeStatus status = upb_Decode(
data, size, UPB_UPCAST(msg), &upb_0test__TestUtf8Proto3String_msg_init,
nullptr, 0, arena.ptr());
// Parse fails, because proto3 string fields validate UTF-8.
ASSERT_EQ(kUpb_DecodeStatus_BadUtf8, status);
}
TEST(Utf8Test, RepeatedProto3FieldValidates) {
upb::Arena arena;
size_t size;
char* data = GetBadUtf8Payload(arena.ptr(), &size);
upb_test_TestUtf8RepeatedProto3String* msg =
upb_test_TestUtf8RepeatedProto3String_new(arena.ptr());
upb_DecodeStatus status =
upb_Decode(data, size, UPB_UPCAST(msg),
&upb_0test__TestUtf8RepeatedProto3String_msg_init, nullptr, 0,
arena.ptr());
// Parse fails, because proto3 string fields validate UTF-8.
ASSERT_EQ(kUpb_DecodeStatus_BadUtf8, status);
}
TEST(Utf8Test, Proto2BytesValidates) {
upb::Arena arena;
size_t size;
char* data = GetBadUtf8Payload(arena.ptr(), &size);
upb_test_TestUtf8Proto2Bytes* msg =
upb_test_TestUtf8Proto2Bytes_new(arena.ptr());
upb_DecodeStatus status;
status = upb_Decode(data, size, UPB_UPCAST(msg),
&upb_0test__TestUtf8Proto2Bytes_msg_init, nullptr, 0,
arena.ptr());
// Parse succeeds, because proto2 bytes fields don't validate UTF-8.
ASSERT_EQ(kUpb_DecodeStatus_Ok, status);
}
TEST(Utf8Test, Proto2RepeatedBytesValidates) {
upb::Arena arena;
size_t size;
char* data = GetBadUtf8Payload(arena.ptr(), &size);
upb_test_TestUtf8RepeatedProto2Bytes* msg =
upb_test_TestUtf8RepeatedProto2Bytes_new(arena.ptr());
upb_DecodeStatus status;
status = upb_Decode(data, size, UPB_UPCAST(msg),
&upb_0test__TestUtf8RepeatedProto2Bytes_msg_init, nullptr,
0, arena.ptr());
// Parse succeeds, because proto2 bytes fields don't validate UTF-8.
ASSERT_EQ(kUpb_DecodeStatus_Ok, status);
}
TEST(Utf8Test, Proto2StringValidates) {
upb::Arena arena;
size_t size;
char* data = GetBadUtf8Payload(arena.ptr(), &size);
upb_test_TestUtf8Proto2String* msg =
upb_test_TestUtf8Proto2String_new(arena.ptr());
upb_DecodeStatus status;
status = upb_Decode(data, size, UPB_UPCAST(msg),
&upb_0test__TestUtf8Proto2String_msg_init, nullptr, 0,
arena.ptr());
// Parse succeeds, because proto2 string fields don't validate UTF-8.
ASSERT_EQ(kUpb_DecodeStatus_Ok, status);
}
TEST(Utf8Test, Proto2FieldFailsValidation) {
upb::Arena arena;
size_t size;
char* data = GetBadUtf8Payload(arena.ptr(), &size);
upb_test_TestUtf8Proto2String* msg =
upb_test_TestUtf8Proto2String_new(arena.ptr());
upb_DecodeStatus status;
status = upb_Decode(data, size, UPB_UPCAST(msg),
&upb_0test__TestUtf8Proto2String_msg_init, nullptr, 0,
arena.ptr());
// Parse fails, because we pass in kUpb_DecodeOption_AlwaysValidateUtf8 to
// force validation of proto2 string fields.
status = upb_Decode(data, size, UPB_UPCAST(msg),
&upb_0test__TestUtf8Proto2String_msg_init, nullptr,
kUpb_DecodeOption_AlwaysValidateUtf8, arena.ptr());
ASSERT_EQ(kUpb_DecodeStatus_BadUtf8, status);
}
TEST(Utf8Test, Proto2RepeatedFieldFailsValidation) {
upb::Arena arena;
size_t size;
char* data = GetBadUtf8Payload(arena.ptr(), &size);
upb_test_TestUtf8RepeatedProto2String* msg =
upb_test_TestUtf8RepeatedProto2String_new(arena.ptr());
upb_DecodeStatus status;
status = upb_Decode(data, size, UPB_UPCAST(msg),
&upb_0test__TestUtf8RepeatedProto2String_msg_init,
nullptr, 0, arena.ptr());
// Parse fails, because we pass in kUpb_DecodeOption_AlwaysValidateUtf8 to
// force validation of proto2 string fields.
status =
upb_Decode(data, size, UPB_UPCAST(msg),
&upb_0test__TestUtf8RepeatedProto2String_msg_init, nullptr,
kUpb_DecodeOption_AlwaysValidateUtf8, arena.ptr());
ASSERT_EQ(kUpb_DecodeStatus_BadUtf8, status);
}
// begin:google_only
// TEST(Utf8Test, Proto3MixedFieldValidates) {
// upb::Arena arena;
// size_t size;
// char* data = GetBadUtf8Payload(arena.ptr(), &size);
//
// upb_test_TestUtf8Proto3StringMixed* msg =
// upb_test_TestUtf8Proto3StringMixed_new(arena.ptr());
//
// upb_DecodeStatus status = upb_Decode(
// data, size, UPB_UPCAST(msg),
// &upb_0test__TestUtf8Proto3StringMixed_msg_init, nullptr, 0, arena.ptr());
//
// // Parse fails, because proto3 string fields validate UTF-8.
// ASSERT_EQ(kUpb_DecodeStatus_BadUtf8, status);
// }
//
// TEST(Utf8Test, EnforceUtf8Options) {
// upb::Arena arena;
// size_t size;
// char* data = GetBadUtf8Payload(arena.ptr(), &size);
// upb_test_TestUtf8Proto3StringEnforceUtf8False* msg2 =
// upb_test_TestUtf8Proto3StringEnforceUtf8False_parse(data, size,
// arena.ptr());
//
// // Parse succeeds, because enforce_utf8=false inhibits utf-8 validation.
// ASSERT_TRUE(msg2 != nullptr);
// }
//
// TEST(Utf8Test, RepeatedEnforceUtf8Options) {
// upb::Arena arena;
// size_t size;
// char* data = GetBadUtf8Payload(arena.ptr(), &size);
// upb_test_TestUtf8RepeatedProto3StringEnforceUtf8False* msg2 =
// upb_test_TestUtf8RepeatedProto3StringEnforceUtf8False_parse(data, size,
// arena.ptr());
//
// // Parse succeeds, because enforce_utf8=false inhibits utf-8 validation.
// ASSERT_TRUE(msg2 != nullptr);
// }
//
// TEST(Utf8Test, EnforceUtf8OptionsMixed) {
// upb::Arena arena;
// size_t size;
// char* data = GetBadUtf8Payload(arena.ptr(), &size);
// upb_test_TestUtf8Proto3StringEnforceUtf8FalseMixed* msg2 =
// upb_test_TestUtf8Proto3StringEnforceUtf8FalseMixed_parse(data, size,
// arena.ptr());
//
// // Parse succeeds, because enforce_utf8=false inhibits utf-8 validation.
// ASSERT_TRUE(msg2 != nullptr);
// }
// end:google_only
} // namespace