proto_core 0.60.0

Core proto APIs.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
use proto_core::{
    ProtoConfig, ProtoEnvironment, Tool, ToolContext, ToolSpec, flow::resolve::Resolver,
    load_tool_from_locator,
};
use starbase_sandbox::create_empty_sandbox;
use std::path::Path;
use version_spec::{UnresolvedVersionSpec, VersionSpec};

async fn create_node(_root: &Path) -> Tool {
    load_tool_from_locator(
        ToolContext::parse("node").unwrap(),
        ProtoEnvironment::new().unwrap(),
        ProtoConfig::default()
            .builtin_plugins()
            .tools
            .get("node")
            .unwrap(),
    )
    .await
    .unwrap()
}

// The mocked tool implements `resolve_version`, mapping the aliases
// "stable" -> 5.0.0, "unstable" -> 6.0.0-rc.1, and "legacy" -> 4.10.15,
// while `load_versions` returns 1.0.0 through 5.10.15 plus 6.0.0 pre-releases
async fn create_mocked_tool(root: &Path) -> Tool {
    load_tool_from_locator(
        ToolContext::parse("protostar").unwrap(),
        ProtoEnvironment::new_testing(root).unwrap(),
        ProtoConfig::default()
            .builtin_plugins()
            .tools
            .get("protostar")
            .unwrap(),
    )
    .await
    .unwrap()
}

mod resolver {
    use super::*;

    mod resolve_version {
        use super::*;

        #[tokio::test(flavor = "multi_thread")]
        async fn returns_already_resolved() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut spec = ToolSpec::new_resolved(VersionSpec::parse("20.0.0").unwrap());

            let result = Resolver::new(&tool)
                .resolve_version(&mut spec, false)
                .await
                .unwrap();

            assert_eq!(result, VersionSpec::parse("20.0.0").unwrap());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn resolves_exact_semantic_version() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut spec = ToolSpec::parse("20.0.0").unwrap();

            let result = Resolver::new(&tool)
                .resolve_version(&mut spec, false)
                .await
                .unwrap();

            assert_eq!(result, VersionSpec::parse("20.0.0").unwrap());
            assert!(spec.is_resolved());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn resolves_partial_version_to_highest() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut spec = ToolSpec::parse("18").unwrap();

            let result = Resolver::new(&tool)
                .resolve_version(&mut spec, false)
                .await
                .unwrap();

            // Should resolve to the highest 18.x.x
            let resolved = result.to_string();
            assert!(
                resolved.starts_with("18."),
                "Expected 18.x.x, got {resolved}"
            );
            assert!(spec.is_resolved());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn resolves_latest_alias() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut spec = ToolSpec::parse("latest").unwrap();

            let result = Resolver::new(&tool)
                .resolve_version(&mut spec, false)
                .await
                .unwrap();

            // Should resolve to some concrete version
            assert!(spec.is_resolved());
            let resolved = result.to_string();
            assert!(
                !resolved.is_empty() && resolved != "latest",
                "Expected concrete version, got {resolved}"
            );
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn canary_short_circuits() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut spec = ToolSpec::new(UnresolvedVersionSpec::Canary);

            // Canary should resolve immediately even with short_circuit=false
            let result = Resolver::new(&tool)
                .resolve_version(&mut spec, false)
                .await
                .unwrap();

            assert_eq!(result, VersionSpec::Canary);
            assert!(spec.is_resolved());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn fully_qualified_short_circuits_when_enabled() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut spec = ToolSpec::parse("20.0.0").unwrap();

            // With short_circuit=true, should return without loading remote versions
            let result = Resolver::new(&tool)
                .resolve_version(&mut spec, true)
                .await
                .unwrap();

            assert_eq!(result, VersionSpec::parse("20.0.0").unwrap());
            assert!(spec.is_resolved());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn does_not_short_circuit_partial_versions() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut spec = ToolSpec::parse("20").unwrap();

            // Even with short_circuit=true, partial versions must be resolved
            let result = Resolver::new(&tool)
                .resolve_version(&mut spec, true)
                .await
                .unwrap();

            let resolved = result.to_string();
            assert!(
                resolved.starts_with("20."),
                "Expected 20.x.x, got {resolved}"
            );
            assert!(spec.is_resolved());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn resolves_alias_remapped_by_plugin() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            let mut spec = ToolSpec::parse("stable").unwrap();

            let result = Resolver::new(&tool)
                .resolve_version(&mut spec, false)
                .await
                .unwrap();

            assert_eq!(result, VersionSpec::parse("5.0.0").unwrap());
            assert!(spec.is_resolved());
            assert_eq!(
                spec.get_resolved_version(),
                VersionSpec::parse("5.0.0").unwrap()
            );
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn resolves_requirement_to_highest_from_list() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            let mut spec = ToolSpec::parse("5").unwrap();

            let result = Resolver::new(&tool)
                .resolve_version(&mut spec, false)
                .await
                .unwrap();

            assert_eq!(result, VersionSpec::parse("5.10.15").unwrap());
            assert!(spec.is_resolved());
        }
    }

    mod resolve_version_candidate {
        use super::*;

        #[tokio::test(flavor = "multi_thread")]
        async fn resolves_aliases_remapped_by_plugin() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            for (alias, expected) in [
                ("stable", "5.0.0"),
                ("unstable", "6.0.0-rc.1"),
                ("legacy", "4.10.15"),
            ] {
                let result = Resolver::new(&tool)
                    .resolve_version_candidate(
                        &UnresolvedVersionSpec::parse(alias).unwrap(),
                        false,
                        false,
                    )
                    .await
                    .unwrap();

                assert_eq!(
                    result,
                    VersionSpec::parse(expected).unwrap(),
                    "alias: {alias}"
                );
            }
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn resolves_latest_alias_from_list() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            // The plugin resolver doesn't handle "latest",
            // so it falls through to the loaded version list
            let result = Resolver::new(&tool)
                .resolve_version_candidate(
                    &UnresolvedVersionSpec::parse("latest").unwrap(),
                    false,
                    false,
                )
                .await
                .unwrap();

            assert_eq!(result, VersionSpec::parse("5.10.15").unwrap());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn short_circuits_fully_qualified_without_validation() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            // This version doesn't exist in the version list,
            // but short circuiting trusts it as-is
            let result = Resolver::new(&tool)
                .resolve_version_candidate(
                    &UnresolvedVersionSpec::parse("999.999.999").unwrap(),
                    true,
                    false,
                )
                .await
                .unwrap();

            assert_eq!(result, VersionSpec::parse("999.999.999").unwrap());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn validates_fully_qualified_when_not_short_circuited() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            let result = Resolver::new(&tool)
                .resolve_version_candidate(
                    &UnresolvedVersionSpec::parse("999.999.999").unwrap(),
                    false,
                    false,
                )
                .await;

            assert!(result.is_err());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn resolves_canary_without_validation() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            // Canary short circuits even when short_circuit=false
            let result = Resolver::new(&tool)
                .resolve_version_candidate(&UnresolvedVersionSpec::Canary, false, false)
                .await
                .unwrap();

            assert_eq!(result, VersionSpec::Canary);
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn errors_on_unknown_alias() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            let result = Resolver::new(&tool)
                .resolve_version_candidate(
                    &UnresolvedVersionSpec::parse("nonexistent").unwrap(),
                    false,
                    false,
                )
                .await;

            assert!(result.is_err());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn errors_on_scoped_requirement_without_scoped_versions() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            // A scoped requirement only matches versions with the same
            // scope, and the mocked version list has none
            let result = Resolver::new(&tool)
                .resolve_version_candidate(
                    &UnresolvedVersionSpec::parse("temurin-5").unwrap(),
                    false,
                    false,
                )
                .await;

            assert!(result.is_err());
        }
    }

    mod resolve_version_from_list {
        use super::*;

        #[tokio::test(flavor = "multi_thread")]
        async fn resolves_from_loaded_versions() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut resolver = Resolver::new(&tool);
            let candidate = UnresolvedVersionSpec::parse("20").unwrap();
            resolver.load_versions(&candidate).await.unwrap();

            let result = resolver
                .resolve_version_from_list(&candidate, false)
                .await
                .unwrap();

            let resolved = result.to_string();
            assert!(
                resolved.starts_with("20."),
                "Expected 20.x.x, got {resolved}"
            );
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn returns_none_on_unknown_version() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut resolver = Resolver::new(&tool);
            // Load versions for a real range first
            let candidate = UnresolvedVersionSpec::parse("20").unwrap();
            resolver.load_versions(&candidate).await.unwrap();

            // Try to resolve a version that doesn't exist
            let bad_candidate = UnresolvedVersionSpec::parse("999.999.999").unwrap();
            let result = resolver
                .resolve_version_from_list(&bad_candidate, false)
                .await;

            assert!(result.is_none());
        }
    }

    mod load_versions {
        use super::*;

        #[tokio::test(flavor = "multi_thread")]
        async fn loads_remote_versions() {
            let sandbox = create_empty_sandbox();
            let tool = create_node(sandbox.path()).await;

            let mut resolver = Resolver::new(&tool);
            let initial = UnresolvedVersionSpec::parse("20").unwrap();

            resolver.load_versions(&initial).await.unwrap();

            // After loading, the data resolver should have versions
            let result = resolver.resolve_version_from_list(&initial, false).await;

            assert!(result.is_some());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn caches_versions_without_scope() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            Resolver::new(&tool)
                .load_versions(&UnresolvedVersionSpec::parse("5").unwrap())
                .await
                .unwrap();

            assert!(tool.inventory.dir.join("remote-versions.json").exists());
        }

        #[tokio::test(flavor = "multi_thread")]
        async fn caches_versions_by_scope() {
            let sandbox = create_empty_sandbox();
            let tool = create_mocked_tool(sandbox.path()).await;

            Resolver::new(&tool)
                .load_versions(&UnresolvedVersionSpec::parse("temurin-5").unwrap())
                .await
                .unwrap();

            assert!(
                tool.inventory
                    .dir
                    .join("remote-versions-temurin.json")
                    .exists()
            );
            assert!(!tool.inventory.dir.join("remote-versions.json").exists());
        }
    }
}