proofman-common 1.1.0-alpha

Shared proof/setup contexts, traces, and STARK metadata types for the PIL2 proofman framework
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
use crate::{ProofmanError, ProofmanResult};

pub trait Trace<F>: Send {
    fn num_rows(&self) -> usize;
    fn num_cols(&self) -> usize;
    fn airgroup_id(&self) -> usize;
    fn air_id(&self) -> usize;
    fn commit_id(&self) -> Option<usize>;
    fn get_buffer(&mut self) -> Vec<F>;
    fn is_shared_buffer(&self) -> bool;
    fn is_packed(&self) -> bool;
}

pub trait Values<F>: Send {
    fn get_buffer(&mut self) -> Vec<F>;
}

use rayon::prelude::*;

pub trait TraceRow: Copy + Default + Send {
    const ROW_SIZE: usize;
    const IS_PACKED: bool;
}

/// Compile-time discriminator for the indexed (compact) row variant from `indexed_trace_row!`,
/// plus its index setter. Defaulted (`false` / no-op) so full row types satisfy it for free;
/// the generated indexed row overrides both. Lets a generic filler compile out the
/// instruction-derived columns (`if !R::IS_INDEXED`) and set the index uniformly.
pub trait IndexedFill {
    const IS_INDEXED: bool = false;
    #[inline(always)]
    fn set_row_index(&mut self, _index: u32) {}
}

#[derive(Default)]
pub struct GenericTrace<
    R,
    const NUM_ROWS: usize,
    const AIRGROUP_ID: usize,
    const AIR_ID: usize,
    const COMMIT_ID: usize = 0,
> {
    // Buffer of rows
    pub buffer: Vec<R>,

    // Length of the original Vec<F>. If zero, indicates buffer was created internally and can be dropped normally
    src_buffer_len: usize,

    // Capacity of the original Vec<F>. If zero, indicates buffer was created internally and can be dropped normally
    src_buffer_capacity: usize,

    // Number of bytes per F element in original buffer
    src_element_size: usize,

    // Whether the buffer was created from scratch (false) or over an existing Vec<F> (true) to reuse memory
    pub shared_buffer: bool,
}

impl<R, const NUM_ROWS: usize, const AIRGROUP_ID: usize, const AIR_ID: usize, const COMMIT_ID: usize>
    GenericTrace<R, NUM_ROWS, AIRGROUP_ID, AIR_ID, COMMIT_ID>
{
    pub const NUM_ROWS: usize = NUM_ROWS;
    pub const AIRGROUP_ID: usize = AIRGROUP_ID;
    pub const AIR_ID: usize = AIR_ID;
    pub const COMMIT_ID: usize = COMMIT_ID;
}

impl<R: TraceRow, const NUM_ROWS: usize, const AIRGROUP_ID: usize, const AIR_ID: usize, const COMMIT_ID: usize>
    GenericTrace<R, NUM_ROWS, AIRGROUP_ID, AIR_ID, COMMIT_ID>
{
    pub const ROW_SIZE: usize = R::ROW_SIZE;

    pub fn new() -> Self {
        GenericTrace::with_capacity(NUM_ROWS)
    }
    pub fn new_zeroes() -> Self {
        let num_rows = NUM_ROWS;

        debug_assert!(num_rows >= 2);
        debug_assert!(num_rows & (num_rows - 1) == 0);

        let buffer: Vec<R> = vec![R::default(); num_rows];

        Self { buffer, src_buffer_len: 0, src_buffer_capacity: 0, src_element_size: 0, shared_buffer: false }
    }

    pub fn with_capacity(num_rows: usize) -> Self {
        debug_assert!(num_rows >= 2);
        debug_assert!(num_rows & (num_rows - 1) == 0);

        let mut vec: Vec<std::mem::MaybeUninit<R>> = Vec::with_capacity(num_rows);
        #[allow(unused_mut)]
        let mut buffer: Vec<R> = unsafe {
            vec.set_len(num_rows);
            std::mem::transmute(vec)
        };

        #[cfg(feature = "diagnostic")]
        unsafe {
            let mut ptr = buffer.as_mut_ptr() as *mut u64;
            let expected_len = num_rows;
            for _ in 0..expected_len * R::ROW_SIZE {
                ptr.write(u64::MAX - 1);
                ptr = ptr.add(1);
            }
        }

        Self { buffer, src_buffer_len: 0, src_buffer_capacity: 0, src_element_size: 0, shared_buffer: false }
    }

    pub fn new_from_vec_zeroes<F: Default + Clone + Send>(mut buffer: Vec<F>) -> ProofmanResult<Self> {
        let row_size = R::ROW_SIZE;
        let num_rows = NUM_ROWS;
        let used_len = num_rows * row_size;

        if buffer.len() < used_len {
            // Consumed by value, so this drops `buffer` — a pooled one is lost here. Say so: the
            // pool only reports it later as an unexplained "recovered N of M".
            tracing::error!("new_from_vec_zeroes: buffer too small ({} < {used_len}); dropping it", buffer.len());
            return Err(ProofmanError::InvalidParameters(format!(
                "Provided buffer too small: got {}, expected at least {}",
                buffer.len(),
                used_len
            )));
        }
        buffer[..used_len].par_iter_mut().for_each(|x| {
            *x = <F>::default();
        });

        let ptr = buffer.as_mut_ptr();
        let src_buffer_len = buffer.len();
        let src_buffer_capacity = buffer.capacity();
        let src_element_size = std::mem::size_of::<F>();

        std::mem::forget(buffer);

        let buffer = unsafe { Vec::from_raw_parts(ptr as *mut R, num_rows, num_rows) };

        Ok(Self { buffer, src_buffer_len, src_buffer_capacity, src_element_size, shared_buffer: true })
    }

    pub fn new_from_vec<F>(mut buffer: Vec<F>) -> ProofmanResult<Self> {
        let row_size = R::ROW_SIZE;
        let num_rows = NUM_ROWS;
        let expected_len = num_rows * row_size;

        if buffer.len() < expected_len {
            // Consumed by value, so this drops `buffer` — see new_from_vec_zeroes.
            tracing::error!("new_from_vec: buffer too small ({} < {expected_len}); dropping it", buffer.len());
            return Err(ProofmanError::InvalidParameters(format!(
                "Provided buffer too small: got {}, expected at least {}",
                buffer.len(),
                expected_len
            )));
        }

        debug_assert!(num_rows >= 2);
        debug_assert!(num_rows & (num_rows - 1) == 0);

        if cfg!(feature = "diagnostic") {
            unsafe {
                let mut ptr = buffer.as_mut_ptr() as *mut u64;
                for _ in 0..expected_len {
                    ptr.write(u64::MAX - 1);
                    ptr = ptr.add(1);
                }
            }
        }

        let ptr = buffer.as_mut_ptr();
        let src_buffer_len = buffer.len();
        let src_buffer_capacity = buffer.capacity();
        let src_element_size = std::mem::size_of::<F>();

        std::mem::forget(buffer);

        let buffer = unsafe { Vec::from_raw_parts(ptr as *mut R, num_rows, num_rows) };

        Ok(Self { buffer, src_buffer_len, src_buffer_capacity, src_element_size, shared_buffer: true })
    }

    pub fn par_iter_mut_chunks(&mut self, n: usize) -> impl IndexedParallelIterator<Item = &mut [R]> {
        debug_assert!(n > 0 && (n & (n - 1)) == 0, "n must be a power of two");
        debug_assert!(n <= NUM_ROWS, "n must be less than or equal to NUM_ROWS");
        let chunk_size = NUM_ROWS / n;
        debug_assert!(chunk_size > 0, "Chunk size must be greater than zero");
        self.buffer.par_chunks_mut(chunk_size)
    }

    pub fn get_buffer<F>(&mut self) -> Vec<F> {
        let mut buffer = std::mem::take(&mut self.buffer);

        if !self.shared_buffer {
            // forget before reconstructing over the same allocation, else double-free.
            let len = NUM_ROWS * R::ROW_SIZE;
            let ptr = buffer.as_ptr();
            std::mem::forget(buffer);
            return unsafe { Vec::from_raw_parts(ptr as *mut F, len, len) };
        }

        // Buffer was created from external Vec<F>, restore original metadata
        let ptr = buffer.as_mut_ptr();
        let original_len = self.src_buffer_len;
        let original_capacity = self.src_buffer_capacity;

        std::mem::forget(buffer);

        self.src_buffer_len = 0; // prevent double free
        self.src_buffer_capacity = 0;

        unsafe { Vec::from_raw_parts(ptr as *mut F, original_len, original_capacity) }
    }

    pub const fn num_rows(&self) -> usize {
        NUM_ROWS
    }

    pub const fn airgroup_id(&self) -> usize {
        AIRGROUP_ID
    }

    pub const fn air_id(&self) -> usize {
        AIR_ID
    }

    pub const fn row_size(&self) -> usize {
        R::ROW_SIZE
    }

    pub const fn num_cols(&self) -> usize {
        R::ROW_SIZE
    }

    pub const fn commit_id(&self) -> Option<usize> {
        // Return the commit ID if it's not zero
        if COMMIT_ID == 0 {
            None
        } else {
            Some(COMMIT_ID)
        }
    }

    pub const fn is_shared_buffer(&self) -> bool {
        self.shared_buffer
    }

    pub const fn is_packed(&self) -> bool {
        R::IS_PACKED
    }
}

impl<
        F: Default + Clone + Copy + Send,
        R: TraceRow,
        const NUM_ROWS: usize,
        const AIRGROUP_ID: usize,
        const AIR_ID: usize,
        const COMMIT_ID: usize,
    > crate::trace::Trace<F> for GenericTrace<R, NUM_ROWS, AIRGROUP_ID, AIR_ID, COMMIT_ID>
{
    fn num_rows(&self) -> usize {
        NUM_ROWS
    }

    fn num_cols(&self) -> usize {
        R::ROW_SIZE
    }

    fn airgroup_id(&self) -> usize {
        AIRGROUP_ID
    }

    fn air_id(&self) -> usize {
        AIR_ID
    }

    fn commit_id(&self) -> Option<usize> {
        self.commit_id()
    }

    fn get_buffer(&mut self) -> Vec<F> {
        self.get_buffer()
    }

    fn is_shared_buffer(&self) -> bool {
        self.shared_buffer
    }

    fn is_packed(&self) -> bool {
        R::IS_PACKED
    }
}

impl<R: TraceRow, const NUM_ROWS: usize, const AIRGROUP_ID: usize, const AIR_ID: usize, const COMMIT_ID: usize>
    std::ops::Index<usize> for GenericTrace<R, NUM_ROWS, AIRGROUP_ID, AIR_ID, COMMIT_ID>
{
    type Output = R;

    fn index(&self, index: usize) -> &Self::Output {
        &self.buffer[index]
    }
}

impl<R: TraceRow, const NUM_ROWS: usize, const AIRGROUP_ID: usize, const AIR_ID: usize, const COMMIT_ID: usize>
    std::ops::IndexMut<usize> for GenericTrace<R, NUM_ROWS, AIRGROUP_ID, AIR_ID, COMMIT_ID>
{
    fn index_mut(&mut self, index: usize) -> &mut Self::Output {
        &mut self.buffer[index]
    }
}

impl<R, const NUM_ROWS: usize, const AIRGROUP_ID: usize, const AIR_ID: usize, const COMMIT_ID: usize> Drop
    for GenericTrace<R, NUM_ROWS, AIRGROUP_ID, AIR_ID, COMMIT_ID>
{
    fn drop(&mut self) {
        if !self.shared_buffer || self.src_buffer_len == 0 {
            // Buffer was created internally, drop normally
            // The Vec<R> will handle its own cleanup
        } else {
            // Buffer was created from external Vec<F>, need to restore original metadata
            let src_buffer_len = self.src_buffer_len * self.src_element_size;
            let src_buffer_capacity = self.src_buffer_capacity * self.src_element_size;

            // Take ownership of the buffer to prevent double-drop
            let buffer = std::mem::take(&mut self.buffer);
            let ptr = buffer.as_ptr();
            std::mem::forget(buffer);

            // Reconstruct the original Vec<F> with correct length and capacity
            unsafe {
                // NOTE: This is safe because we are restoring the original buffer
                let _original_buffer = Vec::from_raw_parts(ptr as *mut u8, src_buffer_len, src_buffer_capacity);
                // _original_buffer will be dropped automatically here
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use proofman_macros::trace;
    use crate as common;

    // A simple TraceRow implementation for tests
    #[derive(Copy, Clone, Default)]
    struct SampleTestRow;
    impl TraceRow for SampleTestRow {
        const ROW_SIZE: usize = 4;
        const IS_PACKED: bool = false;
    }

    // Helper to build a flat buffer of F (u64 here) with sequential numbers
    fn make_buffer(len: usize) -> Vec<u64> {
        (0..len as u64).collect()
    }

    type SampleTrace = GenericTrace<SampleTestRow, 16, 2, 7>; // 16 rows, row_size 4 => flat 64 elements

    #[test]
    fn new_zeroes_initializes_rows() {
        let t = SampleTrace::new_zeroes();

        assert_eq!(t.num_rows(), 16);
        assert_eq!(t.row_size(), SampleTestRow::ROW_SIZE);
        assert!(!t.is_shared_buffer());
        assert_eq!(t.buffer.len(), 16);
    }

    #[test]
    fn with_capacity_uninitialized_layout() {
        let t = SampleTrace::new();
        assert_eq!(t.buffer.len(), 16);
    }

    #[test]
    fn new_from_vec_zeroes_sets_all_zero_and_marks_shared() {
        // Provide larger buffer than needed to ensure slicing works
        let buf = vec![123u64; 16 * SampleTestRow::ROW_SIZE + 10];
        let mut t = GenericTrace::<SampleTestRow, 16, 0, 0>::new_from_vec_zeroes(buf.clone()).unwrap();
        assert!(t.is_shared_buffer());
        assert_eq!(t.buffer.len(), 16);
        // Convert back to flat representation safely via get_buffer()
        let flat: Vec<u64> = t.get_buffer();
        // get_buffer() returns the original buffer with original length (74 elements)
        assert_eq!(flat.len(), 16 * SampleTestRow::ROW_SIZE + 10);
        // Only the first 64 elements (used portion) should be zeroed
        assert!(
            flat[..16 * SampleTestRow::ROW_SIZE].iter().all(|&x| x == 0),
            "expected used portion to be zeroed after zero-initialization"
        );
        // The remaining elements should retain original values (123)
        assert!(
            flat[16 * SampleTestRow::ROW_SIZE..].iter().all(|&x| x == 123),
            "expected unused portion to retain original values"
        );
    }

    #[test]
    fn new_from_vec_keeps_shared_flag() {
        let flat_len = 16 * SampleTestRow::ROW_SIZE;
        let buf = make_buffer(flat_len);
        let t = GenericTrace::<SampleTestRow, 16, 2, 7>::new_from_vec(buf).unwrap();
        assert!(t.is_shared_buffer());
        assert_eq!(t.airgroup_id(), 2);
        assert_eq!(t.air_id(), 7);
        assert_eq!(t.commit_id(), None);
    }

    #[test]
    fn from_vec_alias() {
        let flat_len = 16 * SampleTestRow::ROW_SIZE;
        let buf = make_buffer(flat_len);
        let t = GenericTrace::<SampleTestRow, 16, 0, 0>::new_from_vec(buf).unwrap();
        assert!(t.is_shared_buffer());
    }

    #[test]
    fn par_iter_mut_chunks_power_of_two_partitions() {
        let mut t = SampleTrace::new_zeroes();
        // Write distinct sentinel per chunk using 4 chunks
        t.par_iter_mut_chunks(4).enumerate().for_each(|(i, chunk)| {
            for row in chunk.iter_mut() {
                *row = SampleTestRow;
            }
            // store sentinel by writing to first element of chunk if we could
            // (We cannot access internal fields of row; this test ensures iteration doesn't panic.)
            assert!(!chunk.is_empty());
            assert!(i < 4);
        });
    }

    #[test]
    #[should_panic]
    fn par_iter_mut_chunks_panics_non_power_of_two() {
        let mut t = SampleTrace::new_zeroes();
        let _ = t.par_iter_mut_chunks(3); // not power of two
    }

    #[test]
    #[should_panic]
    fn par_iter_mut_chunks_panics_too_large() {
        let mut t = SampleTrace::new_zeroes();
        let _ = t.par_iter_mut_chunks(32); // greater than NUM_ROWS
    }

    #[test]
    fn get_buffer_converts_back_to_flat() {
        let flat_len = 16 * SampleTestRow::ROW_SIZE;
        let buf = make_buffer(flat_len);
        let mut t = GenericTrace::<SampleTestRow, 16, 0, 0>::new_from_vec(buf.clone()).unwrap();
        let recovered: Vec<u64> = t.get_buffer();
        assert_eq!(recovered.len(), flat_len);
        // We can't guarantee ordering semantics without knowing row representation layout, but we can at least
        // check capacity/length match expectation.
        assert_eq!(recovered.capacity(), flat_len);
    }

    #[test]
    fn check() {
        trace!(TraceRow, MyTrace<F> { a: F, b:F}, 0, 0, 8, 0);

        assert_eq!(TraceRow::<usize>::ROW_SIZE, 2);

        let mut trace = MyTrace::new();
        let num_rows = trace.num_rows();

        // Set values
        for i in 0..num_rows {
            trace[i].a = i;
            trace[i].b = i * 10;
        }

        // Check values
        for i in 0..num_rows {
            assert_eq!(trace[i].a, i);
            assert_eq!(trace[i].b, i * 10);
        }
    }

    #[test]
    fn check_array() {
        trace!(TraceRow, MyTrace<F> { a: F, b: [F; 3], c: F }, 0, 0, 8, 0);

        assert_eq!(TraceRow::<usize>::ROW_SIZE, 5);
        let mut trace = MyTrace::new();
        let num_rows = trace.num_rows();

        // Set values
        for i in 0..num_rows {
            trace[i].a = i;
            trace[i].b[0] = i * 10;
            trace[i].b[1] = i * 20;
            trace[i].b[2] = i * 30;
            trace[i].c = i * 40;
        }

        let buffer = trace.get_buffer();

        // Check values
        for i in 0..num_rows {
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE], i);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 1], i * 10);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 2], i * 20);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 3], i * 30);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 4], i * 40);
        }
    }

    #[test]
    fn check_multi_array() {
        trace!(TraceRow, MyTrace<F> { a: [[F;3]; 2], b: F }, 0, 0, 8, 0);

        assert_eq!(TraceRow::<usize>::ROW_SIZE, 7);

        let mut trace = MyTrace::new();
        let num_rows = trace.num_rows();

        // Set values
        for i in 0..num_rows {
            trace[i].a[0][0] = i;
            trace[i].a[0][1] = i * 10;
            trace[i].a[0][2] = i * 20;
            trace[i].a[1][0] = i * 30;
            trace[i].a[1][1] = i * 40;
            trace[i].a[1][2] = i * 50;
            trace[i].b = i + 3;
        }

        let buffer = trace.get_buffer();

        // Check values
        for i in 0..num_rows {
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE], i);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 1], i * 10);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 2], i * 20);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 3], i * 30);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 4], i * 40);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 5], i * 50);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 6], i + 3);
        }
    }

    #[test]
    fn check_multi_array_2() {
        trace!(TraceRow, MyTrace<F> { a: [[F;3]; 2], b: F, c: [F; 2] }, 0, 0, 8, 0);

        assert_eq!(TraceRow::<usize>::ROW_SIZE, 9);

        let mut trace = MyTrace::new();
        let num_rows = trace.num_rows();

        // Set values
        for i in 0..num_rows {
            trace[i].a[0][0] = i;
            trace[i].a[0][1] = i * 10;
            trace[i].a[0][2] = i * 20;
            trace[i].a[1][0] = i * 30;
            trace[i].a[1][1] = i * 40;
            trace[i].a[1][2] = i * 50;
            trace[i].b = i + 3;
            trace[i].c[0] = i + 9;
            trace[i].c[1] = i + 2;
        }

        let buffer = trace.get_buffer();

        // Check values
        for i in 0..num_rows {
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE], i);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 1], i * 10);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 2], i * 20);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 3], i * 30);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 4], i * 40);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 5], i * 50);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 6], i + 3);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 7], i + 9);
            assert_eq!(buffer[i * TraceRow::<usize>::ROW_SIZE + 8], i + 2);
        }
    }
}