prek 0.5.2

A fast Git hook manager written in Rust, designed as a drop-in alternative to pre-commit, reimagined.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
use assert_cmd::assert::OutputAssertExt;
use assert_fs::assert::PathAssert;
use assert_fs::fixture::{FileWriteStr, PathChild, PathCreateDir};
use prek_consts::env_vars::EnvVars;
use url::Url;

use crate::common::{TestEnv, cmd_snapshot, remove_bin_from_path};

#[test]
fn exec_uses_installed_node_environment() -> anyhow::Result<()> {
    let context = TestEnv::new()
        .with_file(
            "node-env-tool/package.json",
            indoc::indoc! {r#"
        {
          "name": "node-env-tool",
          "version": "1.0.0",
          "bin": {
            "node-env-tool": "cli.js"
          }
        }
    "#},
        )
        .with_executable_file(
            "node-env-tool/cli.js",
            indoc::indoc! {r#"
        #!/usr/bin/env node
        console.log("exec node env ok");
    "#},
        )
        .init_git();
    let package = context.child("node-env-tool");

    let dependency = serde_json::to_string(package.path())?;
    context.write_config(indoc::formatdoc! {r"
        repos:
          - repo: local
            hooks:
              - id: node
                name: node
                language: node
                entry: command-that-must-not-run
                additional_dependencies: [{dependency}]
    "});

    cmd_snapshot!(context, context.exec().args([
        "node",
        "--",
        "node-env-tool",
    ]), @r"
    success: true
    exit_code: 0
    ----- stdout -----
    exec node env ok

    ----- stderr -----
    ");

    Ok(())
}

/// Test `language_version` parsing and auto downloading works correctly.
/// We use `setup-node` action to install node 20 in CI, so node 19 should be downloaded by prek.
#[cfg(feature = "ci")]
#[test]
fn language_version() -> anyhow::Result<()> {
    let context = TestEnv::new()
        .with_config(indoc::indoc! {r"
        repos:
          - repo: local
            hooks:
              - id: node
                name: node
                language: node
                entry: node -p 'process.version'
                language_version: '20'
                always_run: true
              - id: node
                name: node
                language: node
                entry: node -p 'process.version'
                language_version: node20
                always_run: true
              - id: node
                name: node
                language: node
                entry: node -p 'process.version'
                language_version: '19' # will auto download
                always_run: true
              - id: node
                name: node
                language: node
                entry: node -p 'process.version'
                language_version: node19
                always_run: true
              - id: node
                name: node
                language: node
                entry: node -p 'process.version'
                language_version: '<20'
                always_run: true
              - id: node
                name: node
                language: node
                entry: node -p 'process.version'
                language_version: 'lts/iron' # node 20
                always_run: true
    "})
        .init_git();

    let node_dir = context.home_dir().child("tools").child("node");
    node_dir.assert(predicates::path::missing());

    let context = context.with_filter(r"v(\d+)\.\d+.\d+", "v$1.X.X");

    cmd_snapshot!(context, context.run().arg("-v"), @r#"
    success: true
    exit_code: 0
    ----- stdout -----
    node.....................................................................Passed
    - hook id: node
    - duration: [TIME]

      v20.X.X
    node.....................................................................Passed
    - hook id: node
    - duration: [TIME]

      v20.X.X
    node.....................................................................Passed
    - hook id: node
    - duration: [TIME]

      v19.X.X
    node.....................................................................Passed
    - hook id: node
    - duration: [TIME]

      v19.X.X
    node.....................................................................Passed
    - hook id: node
    - duration: [TIME]

      v19.X.X
    node.....................................................................Passed
    - hook id: node
    - duration: [TIME]

      v20.X.X

    ----- stderr -----
    "#);

    // Check that only node 19 is installed.
    let installed_versions = node_dir
        .read_dir()?
        .flatten()
        .filter_map(|d| {
            let filename = d.file_name().to_string_lossy().into_owned();
            if filename.starts_with('.') {
                None
            } else {
                Some(filename)
            }
        })
        .collect::<Vec<_>>();

    assert_eq!(
        installed_versions.len(),
        1,
        "Expected only one node version to be installed, but found: {installed_versions:?}"
    );
    assert!(
        installed_versions.iter().any(|v| v.starts_with("19")),
        "Expected node v19 to be installed, but found: {installed_versions:?}"
    );

    Ok(())
}

/// Test that `additional_dependencies` are installed correctly.
#[test]
fn additional_dependencies() {
    let context = TestEnv::new()
        .with_config(indoc::indoc! {r#"
        repos:
          - repo: local
            hooks:
              - id: node
                name: node
                language: node
                entry: cowsay Hello World!
                additional_dependencies: ["cowsay"]
                always_run: true
                verbose: true
                pass_filenames: false
    "#})
        .init_git();

    cmd_snapshot!(context, context.run(), @r"
    success: true
    exit_code: 0
    ----- stdout -----
    node.....................................................................Passed
    - hook id: node
    - duration: [TIME]

      ______________
      < Hello World! >
       --------------
              \   ^__^
               \  (oo)/_______
                  (__)\       )\/\
                      ||----w |
                      ||     ||

    ----- stderr -----
    ");

    // Run again to check `health_check` works correctly.
    cmd_snapshot!(context, context.run(), @r"
    success: true
    exit_code: 0
    ----- stdout -----
    node.....................................................................Passed
    - hook id: node
    - duration: [TIME]

      ______________
      < Hello World! >
       --------------
              \   ^__^
               \  (oo)/_______
                  (__)\       )\/\
                      ||----w |
                      ||     ||

    ----- stderr -----
    ");
}

/// Test that remote Node packages with runtime dependencies are prepared through npm's Git
/// package path before installation.
///
/// This runs on every supported npm version. In particular, npm 11.9 through
/// 11.12 must not receive `--allow-git=root` because npm's missing `_isRoot`
/// propagation bug rejects root-level Git dependencies with EALLOWGIT:
/// <https://github.com/npm/cli/issues/9189>
#[test]
fn remote_package_is_installed_from_git() {
    let context = TestEnv::new().init_git();
    let hook_repo = context
        .create_hook_repo(
            "remote-node-hook",
            indoc::indoc! {r"
                - id: remote-node-hook
                  name: remote-node-hook
                  language: node
                  entry: remote-node-hook
                  always_run: true
                  pass_filenames: false
            "},
        )
        .with_file(
            "package.json",
            indoc::indoc! {r#"
                {
                  "name": "remote-node-hook",
                  "version": "1.0.0",
                  "bin": {
                    "remote-node-hook": "cli.js"
                  },
                  "dependencies": {
                    "is-number": "7.0.0"
                  }
                }
            "#},
        )
        .with_executable_file(
            "cli.js",
            indoc::indoc! {r#"
        #!/usr/bin/env node
        const isNumber = require("is-number");
        if (!isNumber(42)) process.exit(1);
        console.log("remote hook ok");
    "#},
        )
        .build();

    context.write_config(indoc::formatdoc! {r"
        repos:
          - repo: {}
            rev: v1.0.0
            hooks:
              - id: remote-node-hook
                verbose: true
    ", hook_repo});
    context.git().add(".");

    cmd_snapshot!(context, context.run().env(EnvVars::PREK_HOME, ".prek-cache"), @r"
    success: true
    exit_code: 0
    ----- stdout -----
    remote-node-hook.........................................................Passed
    - hook id: remote-node-hook
    - duration: [TIME]

      remote hook ok

    ----- stderr -----
    ");
}

/// A remote Node package's `prepare` script must be able to use its dev dependencies.
///
/// This models packages such as google/gts: the executable is generated by `prepare`,
/// the build tool is a dev dependency, and generated output is not committed. Installing
/// the checkout as a folder runs `prepare` before that dev dependency exists and fails.
/// Installing it as a Git package makes npm prepare a temporary clone after installing
/// its development dependencies.
#[test]
fn remote_prepare_uses_dev_dependencies() {
    let context = TestEnv::new().init_git();
    let hook_repo = context
        .create_hook_repo(
            "prepared-node-hook",
            indoc::indoc! {r"
                - id: prepared-node-hook
                  name: prepared-node-hook
                  language: node
                  entry: prepared-node-hook
                  always_run: true
                  pass_filenames: false
            "},
        )
        .with_file(
            "package.json",
            indoc::indoc! {r#"
                {
                  "name": "prepared-node-hook",
                  "version": "1.0.0",
                  "bin": {
                    "prepared-node-hook": "dist/cli.js"
                  },
                  "files": [
                    "dist"
                  ],
                  "scripts": {
                    "prepare": "tsc"
                  },
                  "devDependencies": {
                    "typescript": "5.6.3"
                  }
                }
            "#},
        )
        .with_file(
            "tsconfig.json",
            indoc::indoc! {r#"
                {
                  "compilerOptions": {
                    "module": "CommonJS",
                    "outDir": "dist",
                    "target": "ES2020"
                  },
                  "include": [
                    "src"
                  ]
                }
            "#},
        )
        .with_file(".gitignore", "dist/\nnode_modules/\n")
        .with_file(
            "src/cli.ts",
            indoc::indoc! {r#"
                #!/usr/bin/env node
                console.log("prepared hook ok");
        "#},
        )
        .build();

    context.write_config(indoc::formatdoc! {r"
        repos:
          - repo: {}
            rev: v1.0.0
            hooks:
              - id: prepared-node-hook
                verbose: true
    ", hook_repo});
    context.git().add(".");

    cmd_snapshot!(context, context.run(), @r"
    success: true
    exit_code: 0
    ----- stdout -----
    prepared-node-hook.......................................................Passed
    - hook id: prepared-node-hook
    - duration: [TIME]

      prepared hook ok

    ----- stderr -----
    ");
}

/// Test that lowercase npm config inherited from `npm exec` cannot redirect installs.
#[test]
fn additional_dependencies_ignore_inherited_npm_config_prefix() -> anyhow::Result<()> {
    let context = TestEnv::new()
        .with_file(
            "prefix-fixture/package.json",
            indoc::indoc! {r#"
        {
          "name": "prek-prefix-fixture",
          "version": "1.0.0",
          "bin": {
            "prek-prefix-fixture": "cli.js"
          }
        }
    "#},
        )
        .with_executable_file(
            "prefix-fixture/cli.js",
            indoc::indoc! {r#"
        #!/usr/bin/env node
        console.log("prefix fixture ok")
    "#},
        )
        .init_git();
    let package_dir = context.child("prefix-fixture");

    let dependency = serde_json::to_string(package_dir.path())?;
    context.write_config(indoc::formatdoc! {r"
        repos:
          - repo: local
            hooks:
              - id: node
                name: node
                language: node
                entry: prek-prefix-fixture
                additional_dependencies: [{dependency}]
                always_run: true
                verbose: true
                pass_filenames: false
    "});

    context.git().add(".");

    let fake_prefix = context.home_dir().child("fake-prefix");
    fake_prefix.create_dir_all()?;
    let global_npmrc = fake_prefix.child("global-npmrc");
    let user_npmrc = fake_prefix.child("user-npmrc");
    global_npmrc.write_str("prefix=${HOME}/global-npmrc-prefix\n")?;
    user_npmrc.write_str("//registry.example.test/:_authToken=fake-token\n")?;

    cmd_snapshot!(context,
        context
            .run()
            .env("npm_config_prefix", fake_prefix.path())
            .env("npm_config_global_prefix", fake_prefix.path())
            .env("npm_config_local_prefix", fake_prefix.path())
            .env("npm_config_globalconfig", global_npmrc.path())
            .env("npm_config_userconfig", user_npmrc.path())
            .env("npm_config_cache", fake_prefix.child("cache").path()),
        @r#"
    success: true
    exit_code: 0
    ----- stdout -----
    node.....................................................................Passed
    - hook id: node
    - duration: [TIME]

      prefix fixture ok

    ----- stderr -----
    "#
    );

    fake_prefix
        .child("lib")
        .child("node_modules")
        .assert(predicates::path::missing());

    Ok(())
}

/// Test that npm install works without system node in PATH.
/// Regression test for #1492: `install()` must use the provisioned toolchain.
#[test]
fn additional_dependencies_without_system_node() -> anyhow::Result<()> {
    let context = TestEnv::new()
        .with_config(indoc::indoc! {r#"
        repos:
          - repo: local
            hooks:
              - id: node
                name: node
                language: node
                entry: cowsay Hello
                additional_dependencies: ["cowsay"]
                always_run: true
                pass_filenames: false
    "#})
        .init_git();

    let new_path = remove_bin_from_path("node", None)?;

    cmd_snapshot!(context, context.run().env("PATH", new_path), @r"
    success: true
    exit_code: 0
    ----- stdout -----
    node.....................................................................Passed

    ----- stderr -----
    ");

    Ok(())
}

/// Test that `npm.cmd` can be found on Windows.
#[test]
fn npm_version() {
    let context = TestEnv::new()
        .with_config(indoc::indoc! {r"
        repos:
          - repo: local
            hooks:
              - id: npm-version
                name: npm-version
                language: system
                entry: npm --version
                always_run: true
                pass_filenames: false
                verbose: true
    "})
        .init_git();

    let context = context.with_filter(r"\d+\.\d+\.\d+", "[NPM_VERSION]");

    cmd_snapshot!(context, context.run(), @r"
    success: true
    exit_code: 0
    ----- stdout -----
    npm-version..............................................................Passed
    - hook id: npm-version
    - duration: [TIME]

      [NPM_VERSION]

    ----- stderr -----
    ");
}

#[test]
fn node_install_preserves_global_git_config_and_isolates_repository() -> anyhow::Result<()> {
    let context = TestEnv::new().init_git();

    // Installing this additional dependency forces npm to invoke Git during environment setup.
    let dependency_repo = context.create_repo("sentinel-node-dependency").with_file(
        "package.json",
        indoc::indoc! {r#"
        {
          "name": "sentinel-node-dependency",
          "version": "1.0.0"
        }
    "#},
    );
    dependency_repo
        .git()
        .add(".")
        .commit("Add sentinel Node dependency");

    let hook_repo = context
        .create_hook_repo(
            "sentinel-node-hook",
            indoc::indoc! {r"
        - id: sentinel-node
          name: sentinel-node
          entry: sentinel-node-tool
          language: node
          always_run: true
          pass_filenames: false
    "},
        )
        .with_file(
            "package.json",
            indoc::indoc! {r#"
        {
          "name": "sentinel-node-tool",
          "version": "1.0.0",
          "bin": {
            "sentinel-node-tool": "cli.js"
          }
        }
    "#},
        )
        .with_executable_file(
            "cli.js",
            indoc::indoc! {r#"
        #!/usr/bin/env node
        console.log("sentinel node ok");
    "#},
        )
        .build();

    context.write_config(indoc::formatdoc! {r"
        repos:
          - repo: {repo}
            rev: v1.0.0
            hooks:
              - id: sentinel-node
                additional_dependencies:
                  - git+file:///prek-node-git-dependency
    ", repo = hook_repo});
    context.git().add(".");

    // The regression corrupts the calling repository's index, so capture it before npm runs.
    let staged_before = context
        .git()
        .command()
        .args(["ls-files", "--stage"])
        .assert()
        .success()
        .get_output()
        .stdout
        .clone();

    let dependency_url = Url::from_file_path(dependency_repo.path().path())
        .map_err(|()| anyhow::anyhow!("Failed to create dependency repository URL"))?;
    let global_gitconfig = context.child("global.gitconfig");
    // Keep the dependency local while requiring npm's Git subprocess to inherit global config.
    context
        .git()
        .command()
        .args(["config", "--file"])
        .arg(global_gitconfig.path())
        .arg(format!("url.{dependency_url}.insteadOf"))
        .arg("file:///prek-node-git-dependency")
        .assert()
        .success();

    let git_dir = context.child(".git");
    // Simulate the repository-local variables Git exports to hooks from a linked worktree.
    context
        .run()
        .arg("--all-files")
        .env(EnvVars::GIT_DIR, git_dir.path())
        .env("GIT_INDEX_FILE", git_dir.child("index").path())
        .env("GIT_CONFIG_GLOBAL", global_gitconfig.path())
        .env(EnvVars::GIT_TERMINAL_PROMPT, "0")
        .assert()
        .success();

    // Success proves the URL rewrite survived; an unchanged index proves repository isolation.
    let staged_after = context
        .git()
        .command()
        .args(["ls-files", "--stage"])
        .assert()
        .success()
        .get_output()
        .stdout
        .clone();
    assert_eq!(staged_after, staged_before);

    Ok(())
}