pre-commit-sort 1.0.0

Sort pre-commit files
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
use indoc::{formatdoc, indoc};
use pre_commit_sort::{ConfigHook, DeclareHook, Local, Meta, PreCommitConfig, Remote};

#[test]
fn test_serialize() {
    // Just test the serialization with an example .pre-commit-config.yaml
    let mut example = PreCommitConfig::new();

    let mut pre_commit = Remote::new(
        "https://github.com/pre-commit/pre-commit-hooks".to_string(),
        "v2.3.0".to_string(),
    );
    for hook in ["check-yaml", "end-of-file-fixer", "trailing-whitespaces"] {
        pre_commit.add_hook(ConfigHook::new(hook.to_string()));
    }
    example.add_remote(pre_commit);

    let mut black = Remote::new(
        "https://github.com/psf/black".to_string(),
        "22.10.0".to_string(),
    );
    black.add_hook(ConfigHook::new("black".to_string()));
    example.add_remote(black);

    let yaml = indoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v2.3.0
          hooks:
          - id: check-yaml
          - id: end-of-file-fixer
          - id: trailing-whitespaces
        - repo: https://github.com/psf/black
          rev: 22.10.0
          hooks:
          - id: black
        "};
    assert_eq!(yaml_serde::to_string(&example).unwrap(), yaml);
}

#[test]
fn test_sort() {
    let mut example = PreCommitConfig::new();

    // psf/black is added before pre-commit/pre-commit, but it should be put at the end on .sort()
    let mut black = Remote::new(
        "https://github.com/psf/black".to_string(),
        "22.10.0".to_string(),
    );
    black.add_hook(ConfigHook::new("black".to_string()));
    example.add_remote(black);

    let mut pre_commit = Remote::new(
        "https://github.com/pre-commit/pre-commit-hooks".to_string(),
        "v2.3.0".to_string(),
    );
    for hook in ["end-of-file-fixer", "check-yaml", "trailing-whitespaces"] {
        pre_commit.add_hook(ConfigHook::new(hook.to_string()));
    }
    example.add_remote(pre_commit);

    let yaml = indoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v2.3.0
          hooks:
          - id: check-yaml
          - id: end-of-file-fixer
          - id: trailing-whitespaces
        - repo: https://github.com/psf/black
          rev: 22.10.0
          hooks:
          - id: black
        "};
    assert_ne!(yaml_serde::to_string(&example).unwrap(), yaml);
    example.sort();
    assert_eq!(yaml_serde::to_string(&example).unwrap(), yaml);
}

#[test]
fn test_deserialize() {
    // Just test the deserialization with an example .pre-commit-config.yaml
    let mut example = PreCommitConfig::new();

    let mut pre_commit = Remote::new(
        "https://github.com/pre-commit/pre-commit-hooks".to_string(),
        "v2.3.0".to_string(),
    );
    for hook in ["check-yaml", "end-of-file-fixer", "trailing-whitespaces"] {
        pre_commit.add_hook(ConfigHook::new(hook.to_string()));
    }
    example.add_remote(pre_commit);

    let mut black = Remote::new(
        "https://github.com/psf/black".to_string(),
        "22.10.0".to_string(),
    );
    black.add_hook(ConfigHook::new("black".to_string()));
    example.add_remote(black);

    let yaml = indoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v2.3.0
          hooks:
          - id: check-yaml
          - id: end-of-file-fixer
          - id: trailing-whitespaces
        - repo: https://github.com/psf/black
          rev: 22.10.0
          hooks:
          - id: black
        "};
    assert_eq!(example, yaml_serde::from_str(yaml).unwrap());
}

#[test]
fn test_dedup() {
    let mut example = PreCommitConfig::new();

    let mut pre_commit = Remote::new(
        "https://github.com/pre-commit/pre-commit-hooks".to_string(),
        "v2.3.0".to_string(),
    );
    for hook in ["check-yaml", "end-of-file-fixer", "trailing-whitespaces"] {
        pre_commit.add_hook(ConfigHook::new(hook.to_string()));
    }
    example.add_remote(pre_commit);

    let mut black = Remote::new(
        "https://github.com/psf/black".to_string(),
        "22.10.0".to_string(),
    );
    black.add_hook(ConfigHook::new("black".to_string()));
    // Add black twice. The second should be removed after .sort()
    example.add_remote(black.clone());
    example.add_remote(black);

    let yaml = indoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v2.3.0
          hooks:
          - id: check-yaml
          - id: end-of-file-fixer
          - id: trailing-whitespaces
        - repo: https://github.com/psf/black
          rev: 22.10.0
          hooks:
          - id: black
        "};
    assert_ne!(yaml_serde::to_string(&example).unwrap(), yaml);
    example.sort();
    assert_eq!(yaml_serde::to_string(&example).unwrap(), yaml);
}

#[test]
fn test_install() {
    let mut example = PreCommitConfig::new();

    let mut pre_commit = Remote::new(
        "https://github.com/pre-commit/pre-commit-hooks".to_string(),
        "v2.3.0".to_string(),
    );
    for hook in ["check-yaml", "end-of-file-fixer", "trailing-whitespaces"] {
        pre_commit.add_hook(ConfigHook::new(hook.to_string()));
    }
    example.add_remote(pre_commit);

    let mut black = Remote::new(
        "https://github.com/psf/black".to_string(),
        "22.10.0".to_string(),
    );
    black.add_hook(ConfigHook::new("black".to_string()));
    example.add_remote(black);

    // This should add pre-commit-sort to the repos list
    example.install();

    const VERSION: &str = env!("CARGO_PKG_VERSION");
    const REPO: &str = env!("CARGO_PKG_REPOSITORY");
    const NAME: &str = env!("CARGO_PKG_NAME");
    let yaml = formatdoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v2.3.0
          hooks:
          - id: check-yaml
          - id: end-of-file-fixer
          - id: trailing-whitespaces
        - repo: https://github.com/psf/black
          rev: 22.10.0
          hooks:
          - id: black
        - repo: {REPO}
          rev: v{VERSION}
          hooks:
          - id: {NAME}
        "};
    assert_eq!(yaml_serde::to_string(&example).unwrap(), yaml);
}

#[test]
fn test_dedup_rev() {
    let mut example = PreCommitConfig::new();

    let mut pre_commit = Remote::new(
        "https://github.com/pre-commit/pre-commit-hooks".to_string(),
        "v2.3.0".to_string(),
    );
    for hook in ["check-yaml", "end-of-file-fixer", "trailing-whitespaces"] {
        pre_commit.add_hook(ConfigHook::new(hook.to_string()));
    }
    example.add_remote(pre_commit);

    let mut black = Remote::new(
        "https://github.com/psf/black".to_string(),
        "22.10.0".to_string(),
    );
    black.add_hook(ConfigHook::new("black".to_string()));
    example.add_remote(black);

    // Add another black, but on a older version
    // This one should be cleaned out after the .sort() call
    let mut black = Remote::new(
        "https://github.com/psf/black".to_string(),
        "20.1.0".to_string(),
    );
    black.add_hook(ConfigHook::new("black".to_string()));
    example.add_remote(black);

    let yaml = indoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v2.3.0
          hooks:
          - id: check-yaml
          - id: end-of-file-fixer
          - id: trailing-whitespaces
        - repo: https://github.com/psf/black
          rev: 22.10.0
          hooks:
          - id: black
        "};
    assert_ne!(yaml_serde::to_string(&example).unwrap(), yaml);
    example.sort();
    assert_eq!(yaml_serde::to_string(&example).unwrap(), yaml);
}

#[test]
fn test_local() {
    // local repos don't have rev
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v2.3.0
          hooks:
          - id: check-yaml
          - id: end-of-file-fixer
          - id: trailing-whitespaces
        - repo: https://github.com/psf/black
          rev: 22.10.0
          hooks:
          - id: black
        - repo: local
          hooks:
          - id: some-id
            name: some-name
            entry: some entry
            language: rust
        "};
    let mut example = PreCommitConfig::new();

    let mut pre_commit = Remote::new(
        "https://github.com/pre-commit/pre-commit-hooks".to_string(),
        "v2.3.0".to_string(),
    );
    for hook in ["check-yaml", "end-of-file-fixer", "trailing-whitespaces"] {
        pre_commit.add_hook(ConfigHook::new(hook.to_string()));
    }
    example.add_remote(pre_commit);

    let mut black = Remote::new(
        "https://github.com/psf/black".to_string(),
        "22.10.0".to_string(),
    );
    black.add_hook(ConfigHook::new("black".to_string()));
    example.add_remote(black);

    let mut local = Local::new();
    let hook = DeclareHook::new(
        "some-id".to_string(),
        "some-name".to_string(),
        "some entry".to_string(),
        "rust".to_string(),
    );
    local.add_hook(hook);
    example.add_local(local);

    assert_eq!(yaml_serde::to_string(&example).unwrap(), yaml);
    assert_eq!(example, yaml_serde::from_str(yaml).unwrap());
}

#[test]
fn test_meta() {
    // meta repos don't have rev
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v2.3.0
          hooks:
          - id: check-yaml
          - id: end-of-file-fixer
          - id: trailing-whitespaces
        - repo: https://github.com/psf/black
          rev: 22.10.0
          hooks:
          - id: black
        - repo: local
          hooks:
          - id: some-id
            name: some-name
            entry: some entry
            language: rust
        - repo: meta
          hooks:
          - id: check-useless-excludes
        "};
    let mut example = PreCommitConfig::new();

    let mut pre_commit = Remote::new(
        "https://github.com/pre-commit/pre-commit-hooks".to_string(),
        "v2.3.0".to_string(),
    );
    for hook in ["check-yaml", "end-of-file-fixer", "trailing-whitespaces"] {
        pre_commit.add_hook(ConfigHook::new(hook.to_string()));
    }
    example.add_remote(pre_commit);

    let mut black = Remote::new(
        "https://github.com/psf/black".to_string(),
        "22.10.0".to_string(),
    );
    black.add_hook(ConfigHook::new("black".to_string()));
    example.add_remote(black);

    let mut local = Local::new();
    let hook = DeclareHook::new(
        "some-id".to_string(),
        "some-name".to_string(),
        "some entry".to_string(),
        "rust".to_string(),
    );
    local.add_hook(hook);
    example.add_local(local);

    let mut meta = Meta::new();
    let hook = ConfigHook::new("check-useless-excludes".to_string());
    meta.add_hook(hook);
    example.add_meta(meta);

    assert_eq!(yaml_serde::to_string(&example).unwrap(), yaml);
    assert_eq!(example, yaml_serde::from_str(yaml).unwrap());
}

#[test]
fn test_stages_array_parsing_flow() {
    // This test verifies that the `stages` field parses correctly
    // when using flow sequence (inline array) syntax.
    //
    // See: https://pre-commit.com/#pre-commit-configyaml---hooks
    // The `stages` field should accept an array of stage names.
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/crate-ci/committed
          rev: v1.1.8
          hooks:
          - id: committed
            stages: [commit-msg]
        "};

    let result: Result<PreCommitConfig, _> = yaml_serde::from_str(yaml);
    assert!(
        result.is_ok(),
        "Failed to parse valid pre-commit config with stages array (flow): {:?}",
        result.err()
    );
}

#[test]
fn test_stages_array_parsing_block() {
    // This test verifies that the `stages` field parses correctly
    // when using block sequence (multi-line) syntax.
    // This is the format commonly used in real pre-commit config files.
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/crate-ci/committed
          rev: v1.1.8
          hooks:
          - id: committed
            stages:
            - commit-msg
        "};

    let result: Result<PreCommitConfig, _> = yaml_serde::from_str(yaml);
    assert!(
        result.is_ok(),
        "Failed to parse valid pre-commit config with stages array (block): {:?}",
        result.err()
    );
}

#[test]
fn test_types_array_parsing_flow() {
    // This test demonstrates a bug where the `types` field fails to parse
    // when using flow sequence (inline array) syntax.
    // The `types` field in ConfigHook is typed as Option<String> but should
    // be Option<Vec<String>> to handle array values like `types: [python]`.
    //
    // See: https://pre-commit.com/#pre-commit-configyaml---hooks
    // The `types` field should accept an array of file types.
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/psf/black
          rev: 23.1.0
          hooks:
          - id: black
            types: [python]
        "};

    // This should parse successfully, but currently fails because
    // `types` is typed as Option<String> instead of Option<Vec<String>>
    let result: Result<PreCommitConfig, _> = yaml_serde::from_str(yaml);
    assert!(
        result.is_ok(),
        "Failed to parse valid pre-commit config with types array (flow): {:?}",
        result.err()
    );
}

#[test]
fn test_types_array_parsing_block() {
    // This test uses block sequence (multi-line) syntax for the `types` field.
    // This is the format commonly used in real pre-commit config files.
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/psf/black
          rev: 23.1.0
          hooks:
          - id: black
            types:
            - python
        "};

    let result: Result<PreCommitConfig, _> = yaml_serde::from_str(yaml);
    assert!(
        result.is_ok(),
        "Failed to parse valid pre-commit config with types array (block): {:?}",
        result.err()
    );
}

#[test]
fn test_types_or_array_parsing_flow() {
    // This test demonstrates a bug where the `types_or` field fails to parse
    // when using flow sequence (inline array) syntax.
    // The `types_or` field in ConfigHook is typed as Option<String> but should
    // be Option<Vec<String>> to handle array values like `types_or: [python, pyi]`.
    //
    // See: https://pre-commit.com/#pre-commit-configyaml---hooks
    // The `types_or` field should accept an array of file types (OR logic).
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/psf/black
          rev: 23.1.0
          hooks:
          - id: black
            types_or: [python, pyi]
        "};

    // This should parse successfully, but currently fails because
    // `types_or` is typed as Option<String> instead of Option<Vec<String>>
    let result: Result<PreCommitConfig, _> = yaml_serde::from_str(yaml);
    assert!(
        result.is_ok(),
        "Failed to parse valid pre-commit config with types_or array (flow): {:?}",
        result.err()
    );
}

#[test]
fn test_types_or_array_parsing_block() {
    // This test uses block sequence (multi-line) syntax for the `types_or` field.
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/psf/black
          rev: 23.1.0
          hooks:
          - id: black
            types_or:
            - python
            - pyi
        "};

    let result: Result<PreCommitConfig, _> = yaml_serde::from_str(yaml);
    assert!(
        result.is_ok(),
        "Failed to parse valid pre-commit config with types_or array (block): {:?}",
        result.err()
    );
}

#[test]
fn test_exclude_types_array_parsing_flow() {
    // This test demonstrates a bug where the `exclude_types` field fails to parse
    // when using flow sequence (inline array) syntax.
    // The `exclude_types` field in ConfigHook is typed as Option<String> but should
    // be Option<Vec<String>> to handle array values like `exclude_types: [markdown]`.
    //
    // See: https://pre-commit.com/#pre-commit-configyaml---hooks
    // The `exclude_types` field should accept an array of file types to exclude.
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v4.4.0
          hooks:
          - id: trailing-whitespace
            exclude_types: [markdown, rst]
        "};

    // This should parse successfully, but currently fails because
    // `exclude_types` is typed as Option<String> instead of Option<Vec<String>>
    let result: Result<PreCommitConfig, _> = yaml_serde::from_str(yaml);
    assert!(
        result.is_ok(),
        "Failed to parse valid pre-commit config with exclude_types array (flow): {:?}",
        result.err()
    );
}

#[test]
fn test_exclude_types_array_parsing_block() {
    // This test uses block sequence (multi-line) syntax for the `exclude_types` field.
    let yaml = indoc! {"
        repos:
        - repo: https://github.com/pre-commit/pre-commit-hooks
          rev: v4.4.0
          hooks:
          - id: trailing-whitespace
            exclude_types:
            - markdown
            - rst
        "};

    let result: Result<PreCommitConfig, _> = yaml_serde::from_str(yaml);
    assert!(
        result.is_ok(),
        "Failed to parse valid pre-commit config with exclude_types array (block): {:?}",
        result.err()
    );
}