powerio-dist 0.7.2

Multiconductor distribution network model and lossless converters for OpenDSS, PMD JSON, and BMOPF JSON.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
//! Typed model from the vendored fixtures, checked against the OpenDSS
//! engine's own bus and node sets (dumped with opendssdirect 0.9.4 via
//! `dss.Circuit.AllBusNames()` and `dss.Bus.Nodes()` per bus after a
//! Redirect; tools/solve_dss.py documents the staging to reuse when the
//! engine changes).

use std::collections::BTreeMap;
use std::path::PathBuf;

use powerio_dist::dss::{parse_dss_file, write_dss};
use powerio_dist::{
    Configuration, CoordinateSpace, CoordsKind, DistNetwork, IbrPrimeMover, IbrTopology,
    ReactivePowerReference, ReactivePowerUnit, WindingConn,
};

fn fixture(rel: &str) -> PathBuf {
    PathBuf::from(env!("CARGO_MANIFEST_DIR"))
        .join("../tests/data/dist")
        .join(rel)
}

fn parse(rel: &str) -> DistNetwork {
    parse_dss_file(fixture(rel)).expect("fixture parses")
}

fn temp_case_dir(name: &str) -> PathBuf {
    let dir = std::env::temp_dir().join(format!("powerio-{name}-{}", std::process::id()));
    let _ = std::fs::remove_dir_all(&dir);
    std::fs::create_dir_all(&dir).unwrap();
    dir
}

/// Bus id (lowercased) → phase terminal names, excluding the materialized
/// grounded neutral, matching what the engine reports as the bus's nodes.
fn phase_terminals(net: &DistNetwork) -> BTreeMap<String, Vec<String>> {
    net.buses
        .iter()
        .map(|b| {
            (
                b.id.to_ascii_lowercase(),
                b.terminals
                    .iter()
                    .filter(|t| !b.grounded.contains(t))
                    .cloned()
                    .collect(),
            )
        })
        .collect()
}

#[test]
fn buscoords_promote_to_locations_and_write_a_sidecar() {
    let dir = temp_case_dir("dss-geo");
    std::fs::write(
        dir.join("master.dss"),
        "\
New Circuit.geo basekv=12.47 pu=1 phases=3 bus1=a
New Line.l1 bus1=a.1.2.3 bus2=b.1.2.3 phases=3 r1=0.1 x1=0.2 length=1 units=km
New Load.ld bus1=b.1.2.3 phases=3 conn=wye kv=7.2 kw=10 kvar=1
Buscoords coords.csv
",
    )
    .unwrap();
    std::fs::write(dir.join("coords.csv"), "a,-80,35\nb,-80.5,35.25\n").unwrap();

    let net = parse_dss_file(dir.join("master.dss")).unwrap();
    let geo = net.geo.as_ref().expect("geo metadata");
    assert_eq!(geo.space, CoordinateSpace::Unknown);
    assert_eq!(geo.kind, Some(CoordsKind::Source));
    assert!(
        net.warnings
            .iter()
            .any(|w| w.contains("fit longitude/latitude ranges")),
        "{:?}",
        net.warnings
    );
    let a = net.buses.iter().find(|b| b.id == "a").unwrap();
    assert_eq!(a.location.unwrap().x.to_bits(), (-80.0f64).to_bits());
    assert_eq!(a.location.unwrap().y.to_bits(), 35.0f64.to_bits());
    assert!(!a.extras.contains_key("x"));
    assert!(!a.extras.contains_key("y"));

    let out = write_dss(&net);
    assert!(out.text.contains("Buscoords buscoords.csv"), "{}", out.text);
    assert_eq!(out.sidecars.len(), 1);
    assert_eq!(out.sidecars[0].path, "buscoords.csv");
    assert!(out.sidecars[0].text.contains("a,-80,35"));
    assert!(out.sidecars[0].text.contains("b,-80.5,35.25"));

    let out_dir = temp_case_dir("dss-geo-out");
    std::fs::write(out_dir.join("master.dss"), &out.text).unwrap();
    for sidecar in &out.sidecars {
        std::fs::write(out_dir.join(&sidecar.path), &sidecar.text).unwrap();
    }
    let reparsed = parse_dss_file(out_dir.join("master.dss")).unwrap();
    let b = reparsed.buses.iter().find(|b| b.id == "b").unwrap();
    assert_eq!(b.location.unwrap().x.to_bits(), (-80.5f64).to_bits());
    assert_eq!(b.location.unwrap().y.to_bits(), 35.25f64.to_bits());
}

#[test]
fn ieee13_matches_the_engine_bus_map() {
    let net = parse("opendss/ieee13/IEEE13Nodeckt.dss");
    // dss.Circuit.AllBusNames() + dss.Bus.Nodes() on the same fixture.
    let expected: BTreeMap<String, Vec<String>> = [
        ("611", vec!["3"]),
        ("632", vec!["1", "2", "3"]),
        ("633", vec!["1", "2", "3"]),
        ("634", vec!["1", "2", "3"]),
        ("645", vec!["2", "3"]),
        ("646", vec!["2", "3"]),
        ("650", vec!["1", "2", "3"]),
        ("652", vec!["1"]),
        ("670", vec!["1", "2", "3"]),
        ("671", vec!["1", "2", "3"]),
        ("675", vec!["1", "2", "3"]),
        ("680", vec!["1", "2", "3"]),
        ("684", vec!["1", "3"]),
        ("692", vec!["1", "2", "3"]),
        ("rg60", vec!["1", "2", "3"]),
        ("sourcebus", vec!["1", "2", "3"]),
    ]
    .into_iter()
    .map(|(k, v)| (k.to_string(), v.into_iter().map(String::from).collect()))
    .collect();
    assert_eq!(phase_terminals(&net), expected);

    assert_eq!(net.name.as_deref(), Some("IEEE13Nodeckt"));
    assert_eq!(net.sources.len(), 1);
    assert_eq!(net.transformers.len(), 5);
    assert_eq!(net.loads.len(), 15);
    assert_eq!(net.switches.len(), 1);
    assert_eq!(net.shunts.len(), 2);
    assert_eq!(net.lines.len(), 11); // 12 line objects minus the switch

    // Source: 115 kV, pu=1.0001, 30 degrees.
    let vs = &net.sources[0];
    assert_eq!(vs.bus, "SourceBus");
    let vln = 115_000.0 / 3f64.sqrt() * 1.0001;
    assert!((vs.v_magnitude[0] - vln).abs() < 1e-6);
    assert!((vs.v_angle[0] - 30f64.to_radians()).abs() < 1e-12);
    assert!((vs.v_angle[1] - (-90f64).to_radians()).abs() < 1e-12);

    // Line 650632: mtx601 (ohm per mile), 2000 ft. r11 = 0.3465/1609.344
    // ohm/m; length = 2000*0.3048 m. Product must match the engine.
    let line = net.lines.iter().find(|l| l.name == "650632").unwrap();
    assert!((line.length - 2000.0 * 0.3048).abs() < 1e-9);
    let code = net.linecode(&line.linecode).unwrap();
    let r11_total = code.r_series[0][0] * line.length;
    assert!((r11_total - 0.3465 * 2000.0 / 5280.0).abs() < 1e-9);

    // The switch line 671692 carries its ampacity.
    let sw = &net.switches[0];
    assert_eq!(sw.name, "671692");
    assert!(!sw.open);

    // Bus coordinates promote out of extras into the typed field.
    let b = net.bus("611").unwrap();
    assert!(b.location.is_some());
    assert!(!b.extras.contains_key("x"));
    assert!(!b.extras.contains_key("y"));

    // Load 671 is 3 phase delta: 1155 kW total, 660 kvar.
    let l671 = net.loads.iter().find(|l| l.name == "671").unwrap();
    assert_eq!(l671.configuration, Configuration::Delta);
    assert_eq!(l671.terminal_map, vec!["1", "2", "3"]);
    let p: f64 = l671.p_nom.iter().sum();
    assert!((p - 1_155_000.0).abs() < 1e-6);

    // Load 611 is single phase wye on node 3 with grounded return.
    let l611 = net.loads.iter().find(|l| l.name == "611").unwrap();
    assert_eq!(l611.configuration, Configuration::SinglePhase);
    assert_eq!(l611.terminal_map, vec!["3", "4"]);
    let b611 = net.bus("611").unwrap();
    assert_eq!(b611.grounded, vec!["4"]);

    // Substation transformer: delta primary, wye secondary.
    let sub = net
        .transformers
        .iter()
        .find(|t| t.name.eq_ignore_ascii_case("sub"))
        .unwrap();
    assert_eq!(sub.windings.len(), 2);
    assert_eq!(sub.windings[0].conn, WindingConn::Delta);
    assert_eq!(sub.windings[1].conn, WindingConn::Wye);
    assert!((sub.windings[0].v_ref - 115_000.0).abs() < 1e-9);
    assert!((sub.windings[1].v_ref - 4160.0).abs() < 1e-9);
}

#[test]
fn ieee34_and_ieee123_bus_counts_match_the_engine() {
    let net34 = parse("opendss/ieee34/ieee34Mod1.dss");
    assert_eq!(net34.buses.len(), 37);
    let t34 = phase_terminals(&net34);
    assert_eq!(t34["810"], vec!["2"]);
    assert_eq!(t34["864"], vec!["1"]);
    assert_eq!(t34["890"], vec!["1", "2", "3"]);

    let net123 = parse("opendss/ieee123/IEEE123Master.dss");
    assert_eq!(net123.buses.len(), 132);
    let t123 = phase_terminals(&net123);
    assert_eq!(t123["25r"], vec!["1", "3"]);
    assert_eq!(t123["36"], vec!["1", "2"]);
    assert_eq!(t123["94_open"], vec!["1"]);
    assert_eq!(net123.loads.len(), 91);
}

#[test]
fn defaults_materialize_with_provenance() {
    let net = parse("micro/defaults_degenerate.dss");

    // New Line.l_default bus1=sourcebus bus2=b2: every electrical value is
    // the constructor default, materialized and recorded.
    let line = net.lines.iter().find(|l| l.name == "l_default").unwrap();
    assert!((line.length - 1.0).abs() < 1e-12);
    let code = net.linecode(&line.linecode).unwrap();
    // Sequence defaults: diag (2*0.058 + 0.1784)/3, off diag (0.1784-0.058)/3.
    assert!((code.r_series[0][0] - 0.098_133_333_333_333_33).abs() < 1e-12);
    assert!((code.r_series[0][1] - 0.040_133_333_333_333_33).abs() < 1e-12);
    assert!((code.x_series[0][0] - 0.2153).abs() < 1e-12);
    let d = &net.defaulted["line.l_default"];
    assert!(d.contains(&"length") && d.contains(&"r1"));

    // New Load.ld_default bus1=b2: kv, kw, pf all defaulted.
    let load = net.loads.iter().find(|l| l.name == "ld_default").unwrap();
    let p: f64 = load.p_nom.iter().sum();
    let q: f64 = load.q_nom.iter().sum();
    assert!((p - 10_000.0).abs() < 1e-9);
    // q = kw * tan(acos(0.88))
    assert!((q - 10_000.0 * 0.88f64.acos().tan()).abs() < 1e-6);
    let d = &net.defaulted["load.ld_default"];
    assert!(d.contains(&"kv") && d.contains(&"kw") && d.contains(&"pf"));

    // New Transformer.t_default buses=(b2, b3): 12.47 kV / 1000 kVA wye-wye.
    let t = net
        .transformers
        .iter()
        .find(|t| t.name == "t_default")
        .unwrap();
    assert_eq!(t.windings.len(), 2);
    assert!((t.windings[0].v_ref - 12_470.0).abs() < 1e-9);
    assert!((t.windings[0].s_rating - 1_000_000.0).abs() < 1e-9);
    assert_eq!(t.windings[0].conn, WindingConn::Wye);
    assert!((t.xsc_pct[0] - 7.0).abs() < 1e-12);
    let d = &net.defaulted["transformer.t_default"];
    assert!(d.contains(&"kv") && d.contains(&"kva") && d.contains(&"xhl"));

    // The default circuit source.
    let vs = &net.sources[0];
    assert!((vs.v_magnitude[0] - 115_000.0 / 3f64.sqrt()).abs() < 1e-9);
    assert_eq!(vs.bus, "sourcebus");
}

#[test]
fn micro_transformers_type_correctly() {
    let net = parse("micro/xfmr_center_tap.dss");
    let t = net.transformers.iter().find(|t| t.name == "t1").unwrap();
    assert_eq!(t.windings.len(), 3);
    assert_eq!(t.phases, 1);
    assert!((t.windings[0].v_ref - 7200.0).abs() < 1e-9);
    assert!((t.windings[1].v_ref - 120.0).abs() < 1e-9);
    // Winding 2 is secondary.1.0, winding 3 is secondary.0.2 (reversed).
    assert_eq!(t.windings[1].terminal_map, vec!["1", "4"]);
    assert_eq!(t.windings[2].terminal_map, vec!["4", "2"]);
    assert_eq!(t.xsc_pct.len(), 3);

    let net = parse("micro/xfmr_wye_delta.dss");
    let t = net.transformers.iter().find(|t| t.name == "t1").unwrap();
    assert_eq!(t.windings[0].conn, WindingConn::Wye);
    assert_eq!(t.windings[1].conn, WindingConn::Delta);
    // Delta side lists only the phase conductors.
    assert_eq!(t.windings[1].terminal_map, vec!["1", "2", "3"]);
    // Wye side default neutral is grounded.
    assert_eq!(t.windings[0].terminal_map, vec!["1", "2", "3", "4"]);
}

#[test]
fn switch_states_follow_swtcontrol() {
    let net = parse("micro/switch.dss");
    let closed = net.switches.iter().find(|s| s.name == "sw_closed").unwrap();
    let open = net.switches.iter().find(|s| s.name == "sw_open").unwrap();
    assert!(!closed.open);
    assert!(open.open);
}

#[test]
fn swtcontrol_last_action_or_state_wins() {
    use powerio_dist::parse_dss_str;
    let base = "New Circuit.c basekv=12.47\nNew Line.sw bus1=sourcebus bus2=b2 switch=y\n";
    // The later `state` overrides the earlier `action`.
    let net = parse_dss_str(&format!(
        "{base}New SwtControl.s1 SwitchedObj=Line.sw action=close state=open"
    ));
    assert!(net.switches[0].open);
    // Source order reversed: `action` wins.
    let net = parse_dss_str(&format!(
        "{base}New SwtControl.s1 SwitchedObj=Line.sw state=open action=close"
    ));
    assert!(!net.switches[0].open);
    // `normal` applies only when neither action nor state is written.
    let net = parse_dss_str(&format!(
        "{base}New SwtControl.s1 SwitchedObj=Line.sw normal=open"
    ));
    assert!(net.switches[0].open);
    let net = parse_dss_str(&format!(
        "{base}New SwtControl.s1 SwitchedObj=Line.sw normal=open action=close"
    ));
    assert!(!net.switches[0].open);
}

#[test]
#[allow(clippy::float_cmp)]
fn four_wire_line_keeps_the_neutral() {
    let net = parse("micro/fourwire_linecode.dss");
    let line = net.lines.iter().find(|l| l.name == "l1").unwrap();
    assert_eq!(line.terminal_map_from, vec!["1", "2", "3", "4"]);
    assert_eq!(line.terminal_map_to, vec!["1", "2", "3", "4"]);
    let code = net.linecode("lc4").unwrap();
    assert_eq!(code.n_conductors, 4);
    // km units: 0.211 ohm/km = 2.11e-4 ohm/m on the diagonal.
    assert!((code.r_series[0][0] - 0.211e-3).abs() < 1e-12);
    assert_eq!(code.i_max.as_ref().unwrap()[0], 240.0);
    // The load on phase 1 returns through terminal 4, not ground.
    let la = net.loads.iter().find(|l| l.name == "la").unwrap();
    assert_eq!(la.terminal_map, vec!["1", "4"]);
}

/// BMOPFTools#332: a line without `phases=` takes its conductor count from
/// the referenced linecode (FetchLineCode assigns NPhases), so a 4-wire bus
/// list keeps the neutral and the map length matches the 4x4 matrices.
#[test]
fn line_conductor_count_follows_linecode() {
    use powerio_dist::parse_dss_str;
    let base = "Clear\n\
                New Circuit.c basekv=0.4 pu=1.0 phases=3 bus1=src\n\
                New Linecode.4w nphases=4 units=m\n\
                ~ rmatrix=[0.5|0.02 0.5|0.02 0.02 0.5|0.02 0.02 0.02 0.5]\n";

    let net = parse_dss_str(&format!(
        "{base}New Line.l1 bus1=src.1.2.3.4 bus2=lb.1.2.3.4 linecode=4w length=500 units=m\n"
    ));
    let l = &net.lines[0];
    assert_eq!(l.terminal_map_from, vec!["1", "2", "3", "4"]);
    assert_eq!(l.terminal_map_to, vec!["1", "2", "3", "4"]);
    let lb = net.buses.iter().find(|b| b.id == "lb").unwrap();
    assert_eq!(lb.terminals, vec!["1", "2", "3", "4"]);

    // No bus dot list: all four conductors default to nodes 1..=4.
    let net = parse_dss_str(&format!(
        "{base}New Line.l1 bus1=src bus2=lb linecode=4w length=500 units=m\n"
    ));
    assert_eq!(net.lines[0].terminal_map_to, vec!["1", "2", "3", "4"]);

    // Properties apply in order; the later of `phases=`/`linecode=` wins.
    let net = parse_dss_str(&format!(
        "{base}New Line.l1 bus1=src.1.2.3.4 bus2=lb.1.2.3.4 linecode=4w phases=3 length=500 units=m\n"
    ));
    assert_eq!(net.lines[0].terminal_map_to, vec!["1", "2", "3"]);
    let net = parse_dss_str(&format!(
        "{base}New Line.l1 bus1=src.1.2.3.4 bus2=lb.1.2.3.4 phases=3 linecode=4w length=500 units=m\n"
    ));
    assert_eq!(net.lines[0].terminal_map_to, vec!["1", "2", "3", "4"]);

    // A switch's linecode is ignored for impedance yet still fixes the
    // conductor count.
    let net = parse_dss_str(&format!(
        "{base}New Line.s1 bus1=src.1.2.3.4 bus2=lb.1.2.3.4 linecode=4w switch=yes\n"
    ));
    assert_eq!(net.switches[0].terminal_map_to, vec!["1", "2", "3", "4"]);
    assert_eq!(net.switches[0].i_max.as_ref().unwrap().len(), 4);
}

#[test]
fn pvsystem_and_invcontrol_type_to_ibr_profile() {
    use powerio_dist::parse_dss_str;
    let net = parse_dss_str(
        "New Circuit.c basekv=0.416 phases=3 bus1=sourcebus\n\
         New PVSystem.pv1 bus1=loadbus.1.2.3.4 phases=3 conn=wye kv=0.416 kva=30 pmpp=24 \
             irradiance=1 %pmpp=100 kvarMax=12 kvarMaxAbs=9 WattPriority=No \
             VarFollowInverter=Yes %PminNoVars=10 %PminkvarMax=50\n\
         New XYcurve.vv npts=4 Xarray=[0.92 0.98 1.02 1.08] Yarray=[0.44 0 0 -0.44]\n\
         New InvControl.ivc DERList=[PVSystem.pv1] mode=VOLTVAR vvc_curve1=vv \
             RefReactivePower=VARMAX voltage_curvex_ref=rated monVoltageCalc=AVG\n",
    );

    assert_eq!(net.ibrs.len(), 1, "{:?}", net.warnings);
    assert_eq!(net.control_profiles.len(), 1);
    let ibr = &net.ibrs[0];
    assert_eq!(ibr.name, "pv1");
    assert_eq!(ibr.bus, "loadbus");
    assert_eq!(ibr.terminal_map, vec!["1", "2", "3", "4"]);
    assert_eq!(ibr.topology, IbrTopology::FourLeg);
    assert_eq!(ibr.prime_mover, IbrPrimeMover::Pv);
    assert_eq!(ibr.s_max, vec![10_000.0; 3]);
    assert_eq!(ibr.p_avail, Some(24_000.0));
    assert_eq!(ibr.p_max.as_deref(), Some(&[8_000.0, 8_000.0, 8_000.0][..]));
    assert_eq!(ibr.q_max.as_deref(), Some(&[4_000.0, 4_000.0, 4_000.0][..]));
    assert_eq!(
        ibr.q_min.as_deref(),
        Some(&[-3_000.0, -3_000.0, -3_000.0][..])
    );
    assert_eq!(ibr.control_profile.as_deref(), Some("ivc"));
    assert!(!ibr.extras.contains_key("%pminnovars"));
    assert!(!ibr.extras.contains_key("%pminkvarmax"));

    let profile = &net.control_profiles[0];
    let vv = profile.volt_var.as_ref().expect("volt var profile");
    let base_v = 416.0 / 3f64.sqrt();
    let expected = [0.92, 0.98, 1.02, 1.08].map(|v| v * base_v);
    for (actual, expected) in vv.breakpoints.iter().zip(expected) {
        assert!((actual - expected).abs() < 1e-9, "{actual} != {expected}");
    }
    assert_eq!(vv.q_limits, vec![-0.44, 0.44]);
    assert_eq!(vv.q_unit, Some(ReactivePowerUnit::VaFraction));
    assert_eq!(vv.q_ref, Some(ReactivePowerReference::VarMax));
    assert_eq!(vv.p_min_for_q, Some(10.0));
    assert_eq!(vv.p_min_for_q_max, Some(50.0));
    assert!(
        net.untyped
            .iter()
            .all(|o| !matches!(o.class.as_str(), "pvsystem" | "xycurve" | "invcontrol")),
        "{:?}",
        net.untyped
    );
}

#[test]
fn ten_conductor_linecode_types() {
    let net = parse("micro/linecode_10x10.dss");
    let code = net.linecode("lc10").unwrap();
    assert_eq!(code.n_conductors, 10);
    assert_eq!(code.r_series.len(), 10);
    assert!((code.r_series[9][9] - 0.25e-3).abs() < 1e-12);
    let line = net.lines.iter().find(|l| l.name == "l10").unwrap();
    assert_eq!(line.terminal_map_to.len(), 10);
}

#[test]
#[allow(clippy::float_cmp)]
fn grounding_reactor_types_as_an_inductive_shunt() {
    use powerio_dist::parse_dss_str;
    let net = parse_dss_str(
        "New Circuit.c basekv=4.16\n\
         New Reactor.rx bus1=b2 phases=3 kvar=900 kv=4.16\n",
    );
    let sh = net
        .shunts
        .iter()
        .find(|s| s.name.eq_ignore_ascii_case("rx"))
        .expect("reactor typed as a shunt");
    // Inductive: the diagonal susceptance is negative, the capacitor's mirror.
    let v_phase = 4.16e3 / 3f64.sqrt();
    let expected = -900e3 / 3.0 / (v_phase * v_phase);
    assert!((sh.b[0][0] - expected).abs() < 1e-12, "{}", sh.b[0][0]);
    assert_eq!(sh.g[0][0], 0.0);
    // No silent loss: nothing falls through to the untyped layer.
    assert!(net.untyped.is_empty(), "{:?}", net.untyped);
}

#[test]
fn reactor_defaults_are_materialized_and_recorded() {
    use powerio_dist::parse_dss_str;
    let net = parse_dss_str("New Circuit.c basekv=12.47\nNew Reactor.rd bus1=b2\n");
    assert!(net.shunts.iter().any(|s| s.name.eq_ignore_ascii_case("rd")));
    let recorded = net
        .defaulted
        .iter()
        .find(|(k, _)| k.eq_ignore_ascii_case("reactor.rd"))
        .map(|(_, v)| v)
        .expect("defaults recorded for the reactor");
    assert!(recorded.contains(&"kvar"), "{recorded:?}");
    assert!(recorded.contains(&"kv"), "{recorded:?}");
}

#[test]
#[allow(clippy::float_cmp)]
fn grounding_impedance_reactors_type_as_conductive_shunts() {
    use powerio_dist::parse_dss_str;
    let net = parse_dss_str(
        "New Circuit.c basekv=0.4\n\
         New Reactor.tx_busgrounding_B179 phases=1 bus1=B179.4 bus2=B179.0 r=0.3 x=0.0\n\
         New Reactor.loadbusgrounding_B3230 phases=1 bus1=B3230.4 bus2=B3230.0 r=10.0 x=0.0\n\
         New Reactor.loadbusgrounding_B2656 phases=1 bus1=B2656.4 bus2=B2656.0 r=10.0 x=0.0\n",
    );
    assert_eq!(net.shunts.len(), 3, "{:?}", net.warnings);
    assert!(
        net.untyped
            .iter()
            .all(|o| !o.class.eq_ignore_ascii_case("reactor"))
    );
    let first = net
        .shunts
        .iter()
        .find(|s| s.name == "tx_busgrounding_B179")
        .unwrap();
    assert_eq!(first.bus, "B179");
    assert_eq!(first.terminal_map, vec!["4"]);
    assert_eq!(first.g[0][0], 1.0 / 0.3);
    assert_eq!(first.b[0][0], 0.0);
    let second = net
        .shunts
        .iter()
        .find(|s| s.name == "loadbusgrounding_B3230")
        .unwrap();
    assert_eq!(second.terminal_map, vec!["4"]);
    assert_eq!(second.g[0][0], 0.1);
    assert_eq!(second.b[0][0], 0.0);
}

#[test]
fn grounding_reactor_with_rx_uses_admittance_inverse() {
    use powerio_dist::parse_dss_str;
    let net = parse_dss_str(
        "New Circuit.c basekv=4.16\nNew Reactor.rz bus1=b2.1 bus2=b2.0 phases=1 r=3 x=4\n",
    );
    let sh = net.shunts.iter().find(|s| s.name == "rz").unwrap();
    assert!((sh.g[0][0] - 0.12).abs() < 1e-12, "{}", sh.g[0][0]);
    assert!((sh.b[0][0] + 0.16).abs() < 1e-12, "{}", sh.b[0][0]);
}

#[test]
fn grounding_reactor_bus2_uses_the_dss_fill_rule() {
    use powerio_dist::parse_dss_str;
    let net = parse_dss_str(
        "New Circuit.c basekv=4.16\n\
         New Reactor.rz bus1=b2.1.2.3 bus2=b2.0 phases=3 r=3 x=4\n",
    );
    assert!(net.untyped.iter().any(|o| o.name == "rz"));
    assert!(net.shunts.iter().all(|s| s.name != "rz"));
    assert!(
        net.warnings
            .iter()
            .any(|w| w.contains("reactor rz") && w.contains("series"))
    );

    let net = parse_dss_str(
        "New Circuit.c basekv=4.16\n\
         New Reactor.rz bus1=b2.1.2.3 bus2=b2.0.0.0 phases=3 r=3 x=4\n",
    );
    let sh = net.shunts.iter().find(|s| s.name == "rz").unwrap();
    assert_eq!(sh.terminal_map, vec!["1", "2", "3"]);
}

#[test]
#[allow(clippy::float_cmp)]
fn default_phase_single_terminal_reactor_preserves_physical_neutral() {
    let net = parse("micro/neutral_grounding_reactor.dss");
    assert!(
        net.untyped
            .iter()
            .all(|o| !o.name.eq_ignore_ascii_case("source_neutral")),
        "{:?}",
        net.warnings
    );

    let source = net
        .buses
        .iter()
        .find(|b| b.id.eq_ignore_ascii_case("sourcebus"))
        .unwrap();
    assert_eq!(source.terminals, vec!["1", "2", "3", "4", "5"]);
    assert_eq!(source.grounded, vec!["5"]);

    let vs = &net.sources[0];
    assert_eq!(vs.terminal_map, vec!["1", "2", "3", "5"]);

    let line = net.lines.iter().find(|l| l.name == "l1").unwrap();
    assert_eq!(line.terminal_map_from, vec!["1", "2", "3", "4"]);

    let sh = net
        .shunts
        .iter()
        .find(|s| s.name == "source_neutral")
        .unwrap();
    assert_eq!(sh.terminal_map, vec!["4"]);
    assert!((sh.g[0][0] - 1000.0).abs() < 1e-9, "{}", sh.g[0][0]);
    assert_eq!(sh.b[0][0], 0.0);

    let out = write_dss(&net);
    assert!(out.warnings.is_empty(), "{:?}", out.warnings);
    assert!(out.text.contains("New Line.l1 bus1=sourcebus.1.2.3.4"));
    assert!(
        out.text
            .contains("New Reactor.source_neutral bus1=sourcebus.4 bus2=sourcebus.0 phases=1"),
        "{}",
        out.text
    );
}

#[test]
fn zero_impedance_grounding_reactor_stays_untyped() {
    use powerio_dist::parse_dss_str;
    let net = parse_dss_str(
        "New Circuit.c basekv=4.16\nNew Reactor.rz bus1=b2.1 bus2=b2.0 phases=1 r=0 x=0\n",
    );
    assert!(net.untyped.iter().any(|o| o.name == "rz"));
    assert!(net.shunts.iter().all(|s| s.name != "rz"));
    assert!(net.warnings.iter().any(|w| w.contains("zero impedance")));
}

#[test]
fn grounding_reactor_with_unparseable_rx_stays_untyped() {
    use powerio_dist::parse_dss_str;
    // A non-numeric `r` fails to evaluate; substituting 0 would emit a lossless
    // grounding reactor, so the object stays untyped with a warning instead.
    let net = parse_dss_str(
        "New Circuit.c basekv=4.16\n\
         New Reactor.rz bus1=b2.1 bus2=b2.0 phases=1 r=notanumber x=4\n",
    );
    assert!(net.untyped.iter().any(|o| o.name == "rz"));
    assert!(net.shunts.iter().all(|s| s.name != "rz"));
    assert!(
        net.warnings
            .iter()
            .any(|w| w.contains("reactor rz") && w.contains("does not evaluate"))
    );
}

#[test]
fn delta_capacitor_and_reactor_type_as_shunt_matrices() {
    use powerio_dist::parse_dss_str;
    let net = parse_dss_str(
        "New Circuit.c basekv=4.16\n\
         New Capacitor.capd bus1=b2.1.2.3 phases=3 conn=delta kvar=900 kv=4.16\n\
         New Reactor.rxd bus1=b3.1.2.3 phases=3 conn=delta kvar=600 kv=4.16\n",
    );
    assert_eq!(net.shunts.len(), 2, "{:?}", net.warnings);
    assert!(
        net.untyped
            .iter()
            .all(|o| o.name != "capd" && o.name != "rxd")
    );
    let cap = net.shunts.iter().find(|s| s.name == "capd").unwrap();
    assert_eq!(cap.terminal_map, vec!["1", "2", "3"]);
    assert!(cap.b[0][0] > 0.0, "{:?}", cap.b);
    assert!(cap.b[0][1] < 0.0, "{:?}", cap.b);
    assert!((cap.b[0][0] + cap.b[0][1] + cap.b[0][2]).abs() < 1e-12);
    let rx = net.shunts.iter().find(|s| s.name == "rxd").unwrap();
    assert!(rx.b[0][0] < 0.0, "{:?}", rx.b);
    assert!(rx.b[0][1] > 0.0, "{:?}", rx.b);
}

#[test]
fn series_and_non_ground_impedance_reactors_stay_untyped() {
    use powerio_dist::parse_dss_str;
    // Series reactor (bus2): deferred, like the series capacitor.
    let net = parse_dss_str(
        "New Circuit.c basekv=4.16\nNew Reactor.rs bus1=b2 bus2=b3 phases=3 kvar=900 kv=4.16\n",
    );
    assert!(net.untyped.iter().any(|o| o.name == "rs"));
    assert!(net.shunts.iter().all(|s| s.name != "rs"));
    assert!(
        net.warnings
            .iter()
            .any(|w| w.contains("reactor rs") && w.contains("series"))
    );
    // Impedance form without an explicit ground return is not a shunt.
    let net =
        parse_dss_str("New Circuit.c basekv=4.16\nNew Reactor.rz bus1=b2 phases=3 r=0.1 x=5\n");
    assert!(net.untyped.iter().any(|o| o.name == "rz"));
    assert!(
        net.warnings
            .iter()
            .any(|w| w.contains("reactor rz") && w.contains("impedance form"))
    );
    // `parallel` and `rp` are modifiers, not an impedance SpecType: a kvar
    // reactor that also sets them still types as an inductive shunt.
    let net = parse_dss_str(
        "New Circuit.c basekv=4.16\n\
         New Reactor.rmod bus1=b2 phases=3 kvar=900 kv=4.16 parallel=yes rp=1000\n",
    );
    assert!(net.shunts.iter().any(|s| s.name == "rmod"));
    assert!(net.untyped.iter().all(|o| o.name != "rmod"));
}

#[test]
fn regcontrol_warns_and_keeps_taps() {
    let net = parse("opendss/ieee13/IEEE13Nodeckt.dss");
    assert!(
        net.warnings
            .iter()
            .any(|w| w.contains("regcontrol") && w.contains("Reg1"))
    );
    let reg1 = net
        .transformers
        .iter()
        .find(|t| t.name.eq_ignore_ascii_case("reg1"))
        .unwrap();
    assert_eq!(reg1.phases, 1);
}