1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288
//! Convexity checking for portgraphs.
//!
//! This is based on a [`ConvexChecker`] object that is expensive to create
//! (linear in the size of the graph), but can be reused to check multiple
//! subgraphs for convexity quickly.
use std::collections::BTreeSet;
use bitvec::bitvec;
use bitvec::vec::BitVec;
use crate::algorithms::toposort;
use crate::{Direction, LinkView, NodeIndex, PortIndex, SecondaryMap, UnmanagedDenseMap};
use super::TopoSort;
/// A pre-computed datastructure for fast convexity checking.
pub struct ConvexChecker<G> {
graph: G,
// The nodes in topological order
topsort_nodes: Vec<NodeIndex>,
// The index of a node in the topological order (the inverse of topsort_nodes)
topsort_ind: UnmanagedDenseMap<NodeIndex, usize>,
// A temporary datastructure used during `is_convex`
causal: CausalVec,
}
impl<G> ConvexChecker<G>
where
G: LinkView + Copy,
{
/// Create a new ConvexChecker.
pub fn new(graph: G) -> Self {
let inputs = graph
.nodes_iter()
.filter(|&n| graph.input_neighbours(n).count() == 0);
let topsort: TopoSort<_> = toposort(graph, inputs, Direction::Outgoing);
let topsort_nodes: Vec<_> = topsort.collect();
let mut topsort_ind = UnmanagedDenseMap::with_capacity(graph.node_count());
for (i, &n) in topsort_nodes.iter().enumerate() {
topsort_ind.set(n, i);
}
let causal = CausalVec::new(topsort_nodes.len());
Self {
graph,
topsort_nodes,
topsort_ind,
causal,
}
}
/// The graph on which convexity queries can be made.
pub fn graph(&self) -> G {
self.graph
}
/// Whether the subgraph induced by the node set is convex.
///
/// An induced subgraph is convex if there is no node that is both in the
/// past and in the future of another node of the subgraph.
///
/// This function requires mutable access to `self` because it uses a
/// temporary datastructure within the object.
///
/// ## Arguments
///
/// - `nodes`: The nodes inducing a subgraph of `self.graph()`.
///
/// ## Algorithm
///
/// Each node in the "vicinity" of the subgraph will be assigned a causal
/// property, either of being in the past or in the future of the subgraph.
/// It can then be checked whether there is a node in the past that is also
/// in the future, violating convexity.
///
/// Currently, the "vicinity" of a subgraph is defined as the set of nodes
/// that are in the interval between the first and last node of the subgraph
/// in some topological order. In the worst case this will traverse every
/// node in the graph and can be improved on in the future.
pub fn is_node_convex(&mut self, nodes: impl IntoIterator<Item = NodeIndex>) -> bool {
let nodes: BTreeSet<_> = nodes.into_iter().map(|n| self.topsort_ind[n]).collect();
let min_ind = *nodes.first().unwrap();
let max_ind = *nodes.last().unwrap();
for ind in min_ind..=max_ind {
let n = self.topsort_nodes[ind];
let mut in_inds = {
let in_neighs = self.graph.input_neighbours(n);
in_neighs
.map(|n| self.topsort_ind[n])
.filter(|&ind| ind >= min_ind)
};
if nodes.contains(&ind) {
if in_inds.any(|ind| self.causal.get(ind) == Causal::Future) {
// There is a node in the past that is also in the future!
return false;
}
self.causal.set(ind, Causal::Past);
} else {
let ind_causal = match in_inds
.any(|ind| nodes.contains(&ind) || self.causal.get(ind) == Causal::Future)
{
true => Causal::Future,
false => Causal::Past,
};
self.causal.set(ind, ind_causal);
}
}
true
}
/// Whether a subgraph is convex.
///
/// A subgraph is convex if there is no path between two nodes of the
/// sugraph that has an edge outside of the subgraph.
///
/// Equivalently, we check the following two conditions:
/// - There is no node that is both in the past and in the future of
/// another node of the subgraph (convexity on induced subgraph),
/// - There is no edge from an output port to an input port.
///
/// This function requires mutable access to `self` because it uses a
/// temporary datastructure within the object.
///
/// ## Arguments
///
/// - `nodes`: The nodes of the subgraph of `self.graph`,
/// - `inputs`: The input ports of the subgraph of `self.graph`. These must
/// be [`Direction::Incoming`] ports of a node in `nodes`,
/// - `outputs`: The output ports of the subgraph of `self.graph`. These
/// must be [`Direction::Outgoing`] ports of a node in `nodes`.
///
/// Any edge between two nodes of the subgraph that does not have an explicit
/// input or output port is considered within the subgraph.
pub fn is_convex(
&mut self,
nodes: impl IntoIterator<Item = NodeIndex>,
inputs: impl IntoIterator<Item = PortIndex>,
outputs: impl IntoIterator<Item = PortIndex>,
) -> bool {
let pre_outputs: BTreeSet<_> = outputs
.into_iter()
.filter_map(|p| Some(self.graph.port_link(p)?.into()))
.collect();
if inputs.into_iter().any(|p| pre_outputs.contains(&p)) {
return false;
}
self.is_node_convex(nodes)
}
}
/// Whether a node is in the past or in the future of a subgraph.
#[derive(Default, Clone, Debug, PartialEq, Eq)]
enum Causal {
#[default]
Past,
Future,
}
/// A memory-efficient substitute for `Vec<Causal>`.
struct CausalVec(BitVec);
impl From<bool> for Causal {
fn from(b: bool) -> Self {
match b {
true => Self::Future,
false => Self::Past,
}
}
}
impl From<Causal> for bool {
fn from(c: Causal) -> Self {
match c {
Causal::Past => false,
Causal::Future => true,
}
}
}
impl CausalVec {
fn new(len: usize) -> Self {
Self(bitvec![0; len])
}
fn set(&mut self, index: usize, causal: Causal) {
self.0.set(index, causal.into());
}
fn get(&self, index: usize) -> Causal {
self.0[index].into()
}
}
#[cfg(test)]
mod tests {
use crate::{LinkMut, NodeIndex, PortGraph, PortMut, PortView};
use super::ConvexChecker;
fn graph() -> (PortGraph, [NodeIndex; 7]) {
let mut g = PortGraph::new();
let i1 = g.add_node(0, 2);
let i2 = g.add_node(0, 1);
let i3 = g.add_node(0, 1);
let n1 = g.add_node(2, 2);
g.link_nodes(i1, 0, n1, 0).unwrap();
g.link_nodes(i2, 0, n1, 1).unwrap();
let n2 = g.add_node(2, 2);
g.link_nodes(i1, 1, n2, 0).unwrap();
g.link_nodes(i3, 0, n2, 1).unwrap();
let o1 = g.add_node(2, 0);
g.link_nodes(n1, 0, o1, 0).unwrap();
g.link_nodes(n2, 0, o1, 1).unwrap();
let o2 = g.add_node(2, 0);
g.link_nodes(n1, 1, o2, 0).unwrap();
g.link_nodes(n2, 1, o2, 1).unwrap();
(g, [i1, i2, i3, n1, n2, o1, o2])
}
#[test]
fn induced_convexity_test() {
let (g, [i1, i2, i3, n1, n2, o1, o2]) = graph();
let mut checker = ConvexChecker::new(&g);
assert!(checker.is_node_convex([i1, i2, i3]));
assert!(checker.is_node_convex([i1, n2]));
assert!(!checker.is_node_convex([i1, n2, o2]));
assert!(!checker.is_node_convex([i1, n2, o1]));
assert!(checker.is_node_convex([i1, n2, o1, n1]));
assert!(checker.is_node_convex([i1, n2, o2, n1]));
assert!(checker.is_node_convex([i1, i3, n2]));
assert!(!checker.is_node_convex([i1, i3, o2]));
}
#[test]
fn edge_convexity_test() {
let (g, [i1, i2, _, n1, n2, _, o2]) = graph();
let mut checker = ConvexChecker::new(&g);
assert!(checker.is_convex(
[i1, n2],
[g.input(n2, 1).unwrap()],
[
g.output(i1, 0).unwrap(),
g.output(n2, 0).unwrap(),
g.output(n2, 1).unwrap()
]
));
assert!(checker.is_convex(
[i2, n1, o2],
[g.input(n1, 0).unwrap(), g.input(o2, 1).unwrap()],
[g.output(n1, 0).unwrap(),]
));
assert!(!checker.is_convex(
[i2, n1, o2],
[
g.input(n1, 0).unwrap(),
g.input(o2, 1).unwrap(),
g.input(o2, 0).unwrap()
],
[g.output(n1, 0).unwrap(), g.output(n1, 1).unwrap()]
));
}
#[test]
fn dangling_input() {
let mut g = PortGraph::new();
let n = g.add_node(1, 1);
let mut checker = ConvexChecker::new(&g);
assert!(checker.is_node_convex([n]));
}
#[test]
fn disconnected_graph() {
let mut g = PortGraph::new();
let n = g.add_node(1, 1);
g.add_node(1, 1);
let mut checker = ConvexChecker::new(&g);
assert!(checker.is_node_convex([n]));
}
}