1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
//! Athena Dialect
//!
//! AWS Athena-specific transformations based on sqlglot patterns.
//! Athena routes between Hive (DDL) and Trino (DML) engines:
//!
//! - **Hive** (backticks): CREATE EXTERNAL TABLE, CREATE TABLE (no AS SELECT),
//! ALTER, DROP (except VIEW), DESCRIBE, SHOW
//! - **Trino** (double quotes): CREATE VIEW, CREATE TABLE AS SELECT, DROP VIEW,
//! SELECT, INSERT, UPDATE, DELETE, MERGE
use super::{DialectImpl, DialectType};
use crate::error::Result;
use crate::expressions::{
AggFunc, Case, Cast, DataType, Expression, Function, LikeOp, UnaryFunc, VarArgFunc,
};
use crate::generator::{GeneratorConfig, IdentifierQuoteStyle};
use crate::tokens::TokenizerConfig;
/// Athena dialect (based on Trino for DML operations)
pub struct AthenaDialect;
impl DialectImpl for AthenaDialect {
fn dialect_type(&self) -> DialectType {
DialectType::Athena
}
fn tokenizer_config(&self) -> TokenizerConfig {
let mut config = TokenizerConfig::default();
// Athena uses double quotes for identifiers (Trino-style for DML)
config.identifiers.insert('"', '"');
// Also supports backticks (Hive-style for DDL)
config.identifiers.insert('`', '`');
config.nested_comments = false;
// Athena/Hive supports backslash escapes in string literals (e.g., \' for escaped quote)
config.string_escapes.push('\\');
config
}
fn generator_config(&self) -> GeneratorConfig {
// Default config uses Trino style (double quotes)
GeneratorConfig {
identifier_quote: '"',
identifier_quote_style: IdentifierQuoteStyle::DOUBLE_QUOTE,
dialect: Some(DialectType::Athena),
schema_comment_with_eq: false,
..Default::default()
}
}
fn generator_config_for_expr(&self, expr: &Expression) -> GeneratorConfig {
if should_use_hive_engine(expr) {
// Hive mode: backticks for identifiers
GeneratorConfig {
identifier_quote: '`',
identifier_quote_style: IdentifierQuoteStyle::BACKTICK,
dialect: Some(DialectType::Athena),
schema_comment_with_eq: false,
..Default::default()
}
} else {
// Trino mode: double quotes for identifiers
GeneratorConfig {
identifier_quote: '"',
identifier_quote_style: IdentifierQuoteStyle::DOUBLE_QUOTE,
dialect: Some(DialectType::Athena),
schema_comment_with_eq: false,
..Default::default()
}
}
}
fn transform_expr(&self, expr: Expression) -> Result<Expression> {
match expr {
// IFNULL -> COALESCE in Athena
Expression::IfNull(f) => Ok(Expression::Coalesce(Box::new(VarArgFunc {
original_name: None,
expressions: vec![f.this, f.expression],
inferred_type: None,
}))),
// NVL -> COALESCE in Athena
Expression::Nvl(f) => Ok(Expression::Coalesce(Box::new(VarArgFunc {
original_name: None,
expressions: vec![f.this, f.expression],
inferred_type: None,
}))),
// Coalesce with original_name (e.g., IFNULL parsed as Coalesce) -> clear original_name
Expression::Coalesce(mut f) => {
f.original_name = None;
Ok(Expression::Coalesce(f))
}
// TryCast stays as TryCast (Athena/Trino supports TRY_CAST)
Expression::TryCast(c) => Ok(Expression::TryCast(c)),
// SafeCast -> TRY_CAST in Athena
Expression::SafeCast(c) => Ok(Expression::TryCast(c)),
// ILike -> LOWER() LIKE LOWER() (Trino doesn't support ILIKE)
Expression::ILike(op) => {
let lower_left = Expression::Lower(Box::new(UnaryFunc::new(op.left.clone())));
let lower_right = Expression::Lower(Box::new(UnaryFunc::new(op.right.clone())));
Ok(Expression::Like(Box::new(LikeOp {
left: lower_left,
right: lower_right,
escape: op.escape,
quantifier: op.quantifier.clone(),
inferred_type: None,
})))
}
// CountIf -> SUM(CASE WHEN condition THEN 1 ELSE 0 END)
Expression::CountIf(f) => {
let case_expr = Expression::Case(Box::new(Case {
operand: None,
whens: vec![(f.this.clone(), Expression::number(1))],
else_: Some(Expression::number(0)),
comments: Vec::new(),
inferred_type: None,
}));
Ok(Expression::Sum(Box::new(AggFunc {
ignore_nulls: None,
having_max: None,
this: case_expr,
distinct: f.distinct,
filter: f.filter,
order_by: Vec::new(),
name: None,
limit: None,
inferred_type: None,
})))
}
// EXPLODE -> UNNEST in Athena
Expression::Explode(f) => Ok(Expression::Unnest(Box::new(
crate::expressions::UnnestFunc {
this: f.this,
expressions: Vec::new(),
with_ordinality: false,
alias: None,
offset_alias: None,
},
))),
// ExplodeOuter -> UNNEST in Athena
Expression::ExplodeOuter(f) => Ok(Expression::Unnest(Box::new(
crate::expressions::UnnestFunc {
this: f.this,
expressions: Vec::new(),
with_ordinality: false,
alias: None,
offset_alias: None,
},
))),
// Generic function transformations
Expression::Function(f) => self.transform_function(*f),
// Generic aggregate function transformations
Expression::AggregateFunction(f) => self.transform_aggregate_function(f),
// Cast transformations
Expression::Cast(c) => self.transform_cast(*c),
// Pass through everything else
_ => Ok(expr),
}
}
}
impl AthenaDialect {
fn transform_function(&self, f: Function) -> Result<Expression> {
let name_upper = f.name.to_uppercase();
match name_upper.as_str() {
// IFNULL -> COALESCE
"IFNULL" if f.args.len() == 2 => Ok(Expression::Coalesce(Box::new(VarArgFunc {
original_name: None,
expressions: f.args,
inferred_type: None,
}))),
// NVL -> COALESCE
"NVL" if f.args.len() == 2 => Ok(Expression::Coalesce(Box::new(VarArgFunc {
original_name: None,
expressions: f.args,
inferred_type: None,
}))),
// ISNULL -> COALESCE
"ISNULL" if f.args.len() == 2 => Ok(Expression::Coalesce(Box::new(VarArgFunc {
original_name: None,
expressions: f.args,
inferred_type: None,
}))),
// GETDATE -> CURRENT_TIMESTAMP
"GETDATE" => Ok(Expression::CurrentTimestamp(
crate::expressions::CurrentTimestamp {
precision: None,
sysdate: false,
},
)),
// NOW -> CURRENT_TIMESTAMP
"NOW" => Ok(Expression::CurrentTimestamp(
crate::expressions::CurrentTimestamp {
precision: None,
sysdate: false,
},
)),
// RAND -> RANDOM in Athena
"RAND" => Ok(Expression::Function(Box::new(Function::new(
"RANDOM".to_string(),
vec![],
)))),
// GROUP_CONCAT -> LISTAGG in Athena (Trino-style)
"GROUP_CONCAT" if !f.args.is_empty() => Ok(Expression::Function(Box::new(
Function::new("LISTAGG".to_string(), f.args),
))),
// STRING_AGG -> LISTAGG in Athena
"STRING_AGG" if !f.args.is_empty() => Ok(Expression::Function(Box::new(
Function::new("LISTAGG".to_string(), f.args),
))),
// SUBSTR -> SUBSTRING
"SUBSTR" => Ok(Expression::Function(Box::new(Function::new(
"SUBSTRING".to_string(),
f.args,
)))),
// LEN -> LENGTH
"LEN" if f.args.len() == 1 => Ok(Expression::Length(Box::new(UnaryFunc::new(
f.args.into_iter().next().unwrap(),
)))),
// CHARINDEX -> STRPOS in Athena (with swapped args)
"CHARINDEX" if f.args.len() >= 2 => {
let mut args = f.args;
let substring = args.remove(0);
let string = args.remove(0);
Ok(Expression::Function(Box::new(Function::new(
"STRPOS".to_string(),
vec![string, substring],
))))
}
// INSTR -> STRPOS
"INSTR" if f.args.len() >= 2 => Ok(Expression::Function(Box::new(Function::new(
"STRPOS".to_string(),
f.args,
)))),
// LOCATE -> STRPOS in Athena (with swapped args)
"LOCATE" if f.args.len() >= 2 => {
let mut args = f.args;
let substring = args.remove(0);
let string = args.remove(0);
Ok(Expression::Function(Box::new(Function::new(
"STRPOS".to_string(),
vec![string, substring],
))))
}
// ARRAY_LENGTH -> CARDINALITY in Athena
"ARRAY_LENGTH" if f.args.len() == 1 => Ok(Expression::Function(Box::new(
Function::new("CARDINALITY".to_string(), f.args),
))),
// SIZE -> CARDINALITY in Athena
"SIZE" if f.args.len() == 1 => Ok(Expression::Function(Box::new(Function::new(
"CARDINALITY".to_string(),
f.args,
)))),
// TO_DATE -> CAST to DATE or DATE_PARSE
"TO_DATE" if !f.args.is_empty() => {
if f.args.len() == 1 {
Ok(Expression::Cast(Box::new(Cast {
this: f.args.into_iter().next().unwrap(),
to: DataType::Date,
trailing_comments: Vec::new(),
double_colon_syntax: false,
format: None,
default: None,
inferred_type: None,
})))
} else {
Ok(Expression::Function(Box::new(Function::new(
"DATE_PARSE".to_string(),
f.args,
))))
}
}
// TO_TIMESTAMP -> CAST or DATE_PARSE
"TO_TIMESTAMP" if !f.args.is_empty() => {
if f.args.len() == 1 {
Ok(Expression::Cast(Box::new(Cast {
this: f.args.into_iter().next().unwrap(),
to: DataType::Timestamp {
precision: None,
timezone: false,
},
trailing_comments: Vec::new(),
double_colon_syntax: false,
format: None,
default: None,
inferred_type: None,
})))
} else {
Ok(Expression::Function(Box::new(Function::new(
"DATE_PARSE".to_string(),
f.args,
))))
}
}
// strftime -> DATE_FORMAT in Athena
"STRFTIME" if f.args.len() >= 2 => {
let mut args = f.args;
let format = args.remove(0);
let date = args.remove(0);
Ok(Expression::Function(Box::new(Function::new(
"DATE_FORMAT".to_string(),
vec![date, format],
))))
}
// TO_CHAR -> DATE_FORMAT in Athena
"TO_CHAR" if f.args.len() >= 2 => Ok(Expression::Function(Box::new(Function::new(
"DATE_FORMAT".to_string(),
f.args,
)))),
// GET_JSON_OBJECT -> JSON_EXTRACT_SCALAR in Athena
"GET_JSON_OBJECT" if f.args.len() == 2 => Ok(Expression::Function(Box::new(
Function::new("JSON_EXTRACT_SCALAR".to_string(), f.args),
))),
// COLLECT_LIST -> ARRAY_AGG
"COLLECT_LIST" if !f.args.is_empty() => Ok(Expression::Function(Box::new(
Function::new("ARRAY_AGG".to_string(), f.args),
))),
// Pass through everything else
_ => Ok(Expression::Function(Box::new(f))),
}
}
fn transform_aggregate_function(
&self,
f: Box<crate::expressions::AggregateFunction>,
) -> Result<Expression> {
let name_upper = f.name.to_uppercase();
match name_upper.as_str() {
// COUNT_IF -> SUM(CASE WHEN...)
"COUNT_IF" if !f.args.is_empty() => {
let condition = f.args.into_iter().next().unwrap();
let case_expr = Expression::Case(Box::new(Case {
operand: None,
whens: vec![(condition, Expression::number(1))],
else_: Some(Expression::number(0)),
comments: Vec::new(),
inferred_type: None,
}));
Ok(Expression::Sum(Box::new(AggFunc {
ignore_nulls: None,
having_max: None,
this: case_expr,
distinct: f.distinct,
filter: f.filter,
order_by: Vec::new(),
name: None,
limit: None,
inferred_type: None,
})))
}
// ANY_VALUE -> ARBITRARY in Athena (Trino)
"ANY_VALUE" if !f.args.is_empty() => Ok(Expression::Function(Box::new(Function::new(
"ARBITRARY".to_string(),
f.args,
)))),
// GROUP_CONCAT -> LISTAGG in Athena
"GROUP_CONCAT" if !f.args.is_empty() => Ok(Expression::Function(Box::new(
Function::new("LISTAGG".to_string(), f.args),
))),
// STRING_AGG -> LISTAGG in Athena
"STRING_AGG" if !f.args.is_empty() => Ok(Expression::Function(Box::new(
Function::new("LISTAGG".to_string(), f.args),
))),
// Pass through everything else
_ => Ok(Expression::AggregateFunction(f)),
}
}
fn transform_cast(&self, c: Cast) -> Result<Expression> {
// Athena type mappings are handled in the generator
Ok(Expression::Cast(Box::new(c)))
}
}
/// Determine if an expression should be generated using Hive engine (backticks)
/// or Trino engine (double quotes).
///
/// Hive is used for:
/// - CREATE EXTERNAL TABLE
/// - CREATE TABLE (without AS SELECT)
/// - CREATE SCHEMA / CREATE DATABASE
/// - ALTER statements
/// - DROP statements (except DROP VIEW)
/// - DESCRIBE / SHOW statements
///
/// Trino is used for everything else (DML, CREATE VIEW, etc.)
fn should_use_hive_engine(expr: &Expression) -> bool {
match expr {
// CREATE TABLE: Hive if EXTERNAL or no AS SELECT
Expression::CreateTable(ct) => {
// CREATE EXTERNAL TABLE → Hive
if let Some(ref modifier) = ct.table_modifier {
if modifier.to_uppercase() == "EXTERNAL" {
return true;
}
}
// CREATE TABLE ... AS SELECT → Trino
// CREATE TABLE (without query) → Hive
ct.as_select.is_none()
}
// CREATE VIEW → Trino
Expression::CreateView(_) => false,
// CREATE SCHEMA / DATABASE → Hive
Expression::CreateSchema(_) => true,
Expression::CreateDatabase(_) => true,
// ALTER statements → Hive
Expression::AlterTable(_) => true,
Expression::AlterView(_) => true,
Expression::AlterIndex(_) => true,
Expression::AlterSequence(_) => true,
// DROP VIEW → Trino (because CREATE VIEW is Trino)
Expression::DropView(_) => false,
// Other DROP statements → Hive
Expression::DropTable(_) => true,
Expression::DropSchema(_) => true,
Expression::DropDatabase(_) => true,
Expression::DropIndex(_) => true,
Expression::DropFunction(_) => true,
Expression::DropProcedure(_) => true,
Expression::DropSequence(_) => true,
// DESCRIBE / SHOW → Hive
Expression::Describe(_) => true,
Expression::Show(_) => true,
// Everything else (SELECT, INSERT, UPDATE, DELETE, MERGE, etc.) → Trino
_ => false,
}
}