pointbreak 0.6.0

Durable terminal code review for changes humans and coding agents collaborate on together
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149

use serde::{Deserialize, Serialize};

use super::kind::EventType;
use super::payload::{BodyContentType, EventPayload};
use super::type_code::type_code;
use crate::model::{
    RevisionId, TrackId, ValidationCheckId, ValidationStatus, ValidationTarget, ValidationTrigger,
};

#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct ValidationCheckRecordedPayload {
    pub validation_check_id: ValidationCheckId,
    pub target: ValidationTarget,
    pub check_name: String,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub command: Option<String>,
    pub status: ValidationStatus,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub exit_code: Option<i64>,
    pub trigger: ValidationTrigger,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub source_fingerprint: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub summary: Option<String>,
    #[serde(default, skip_serializing_if = "BodyContentType::is_text_plain")]
    pub summary_content_type: BodyContentType,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub summary_artifact_path: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub summary_byte_size: Option<u64>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub summary_content_hash: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub started_at: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub completed_at: Option<String>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub log_artifact_content_hashes: Vec<String>,
}

impl ValidationCheckRecordedPayload {
    pub fn idempotency_key(
        revision_id: &RevisionId,
        track_id: &TrackId,
        source_key: &str,
    ) -> String {
        format!(
            "{}:{}:{}:{}",
            type_code(EventType::ValidationCheckRecorded),
            revision_id.as_str(),
            track_id.as_str(),
            source_key
        )
    }
}

impl EventPayload for ValidationCheckRecordedPayload {
    fn event_type(&self) -> EventType {
        EventType::ValidationCheckRecorded
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::model::{
        RevisionId, TrackId, ValidationCheckId, ValidationStatus, ValidationTarget,
        ValidationTrigger,
    };

    fn fixture_payload() -> ValidationCheckRecordedPayload {
        ValidationCheckRecordedPayload {
            validation_check_id: ValidationCheckId::new("validation:sha256:ghi"),
            target: ValidationTarget::Revision {
                revision_id: RevisionId::new("review-unit:sha256:def"),
            },
            check_name: "cargo test".to_owned(),
            command: None,
            status: ValidationStatus::Passed,
            exit_code: Some(0),
            trigger: ValidationTrigger::Manual,
            source_fingerprint: None,
            summary: None,
            summary_content_type: Default::default(),
            summary_artifact_path: None,
            summary_byte_size: None,
            summary_content_hash: None,
            started_at: None,
            completed_at: None,
            log_artifact_content_hashes: vec![],
        }
    }

    #[test]
    fn validation_check_recorded_payload_round_trips_and_uses_expected_wire_keys() {
        let payload = fixture_payload();

        let value = serde_json::to_value(&payload).unwrap();
        assert!(value.get("validationCheckId").is_some());
        assert!(value.get("checkName").is_some());
        assert_eq!(value["status"], "passed");
        assert_eq!(value["trigger"], "manual");
        assert!(value.get("logArtifactContentHashes").is_none());
        assert!(value.get("summary").is_none());

        let back: ValidationCheckRecordedPayload = serde_json::from_value(value).unwrap();
        assert_eq!(back, payload);
    }

    #[test]
    fn validation_idempotency_key_is_revision_track_and_source_scoped() {
        let key = ValidationCheckRecordedPayload::idempotency_key(
            &RevisionId::new("review-unit:sha256:def"),
            &TrackId::new("agent:codex"),
            "validation:sha256:ghi",
        );

        assert_eq!(
            key,
            format!(
                "{}:review-unit:sha256:def:agent:codex:validation:sha256:ghi",
                type_code(EventType::ValidationCheckRecorded)
            )
        );
    }

    #[test]
    fn validation_event_payload_and_target_are_path_free() {
        let payload = fixture_payload();
        let key = ValidationCheckRecordedPayload::idempotency_key(
            &RevisionId::new("review-unit:sha256:def"),
            &TrackId::new("agent:codex"),
            payload.validation_check_id.as_str(),
        );
        let serialized = serde_json::to_string(&payload).unwrap();

        for needle in ["/Users/", "worktreeRoot", ".git", ".shore/data"] {
            assert!(
                !serialized.contains(needle),
                "payload leaked path token {needle}"
            );
            assert!(
                !key.contains(needle),
                "idempotency key leaked path token {needle}"
            );
        }
    }
}