pointbreak 0.5.0

Durable terminal code review for changes humans and coding agents collaborate on together
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140

mod support;
use serde_json::Value;
use support::git_repo::GitRepo;
use support::shore_env;

const ENDORSER: &str = "actor:git-email:kevin@swiber.dev";

fn captured_event_id(repo: &std::path::Path) -> String {
    pointbreak::session::read_events(repo)
        .unwrap()
        .iter()
        .find(|e| e.event_type == pointbreak::session::event::EventType::WorkObjectProposed)
        .expect("a captured review unit")
        .event_id
        .as_str()
        .to_owned()
}

/// Drive the full chain through the real `shore` binary: init a key, optionally
/// enroll it under the ENDORSER and attest kind/roles, capture UNSIGNED (so the
/// detached endorsement carrier is never deduped against an inline member), then
/// endorse as the ENDORSER (signed by the minted key).
fn endorsed_repo(home: &str, enroll: bool, attest: bool) -> (GitRepo, String) {
    assert!(
        shore_env(
            ["key", "init", "--name", "default"],
            &[("SHORE_HOME", home)]
        )
        .status
        .success()
    );
    let repo = GitRepo::new();
    repo.write("src/lib.rs", "pub fn v() -> u32 { 1 }\n");
    repo.commit_all("base");
    repo.write("src/lib.rs", "pub fn v() -> u32 { 2 }\n");
    let repo_arg = repo.path().to_str().unwrap().to_owned();

    if enroll {
        // Bind the default key's did:key to the ENDORSER (reader trust config).
        assert!(
            shore_env(
                [
                    "key", "enroll", "default", "--actor", ENDORSER, "--repo", &repo_arg
                ],
                &[("SHORE_HOME", home)],
            )
            .status
            .success()
        );
    }
    if attest {
        assert!(
            shore_env(
                [
                    "identity", "attest", ENDORSER, "--kind", "human", "--role", "reviewer",
                    "--repo", &repo_arg,
                ],
                &[],
            )
            .status
            .success()
        );
    }
    // Capture as the git committer (shore-tests), UNSIGNED so there is no inline member
    // the detached endorsement carrier could be deduped against.
    assert!(
        shore_env(
            ["capture", "--repo", &repo_arg],
            &[("SHORE_HOME", home), ("SHORE_SIGNING", "off")],
        )
        .status
        .success()
    );
    let target = captured_event_id(repo.path());
    // Endorse as the ENDORSER, signed by default → attestingSigner = the enrolled did:key.
    assert!(
        shore_env(
            ["endorse", &target, "--repo", &repo_arg],
            &[("SHORE_HOME", home), ("SHORE_ACTOR_ID", ENDORSER)],
        )
        .status
        .success()
    );
    (repo, target)
}

fn endorsement_for_target<'a>(doc: &'a Value, target: &str) -> &'a Value {
    doc["entries"]
        .as_array()
        .unwrap()
        .iter()
        .find(|e| e["eventId"] == target)
        .expect("the endorsed entry")
        .get("endorsements")
        .and_then(|e| e.get(0))
        .expect("an endorsement readback")
}

#[test]
fn enrolled_endorser_reads_endorsement_trusted_with_endorser() {
    let home = tempfile::tempdir().unwrap();
    let (repo, target) = endorsed_repo(home.path().to_str().unwrap(), true, false);
    let out = shore_env(
        ["history", "--repo", repo.path().to_str().unwrap()],
        &[("SHORE_HOME", home.path().to_str().unwrap())],
    );
    let doc: Value = serde_json::from_slice(&out.stdout).unwrap();
    let endorsement = endorsement_for_target(&doc, &target);
    assert_eq!(endorsement["classification"], "endorsement-trusted");
    assert_eq!(endorsement["endorser"], ENDORSER);
}

#[test]
fn unenrolled_signer_reads_unknown_endorser() {
    let home = tempfile::tempdir().unwrap();
    let (repo, target) = endorsed_repo(home.path().to_str().unwrap(), false, false);
    let out = shore_env(
        ["history", "--repo", repo.path().to_str().unwrap()],
        &[("SHORE_HOME", home.path().to_str().unwrap())],
    );
    let doc: Value = serde_json::from_slice(&out.stdout).unwrap();
    let endorsement = endorsement_for_target(&doc, &target);
    assert_eq!(endorsement["classification"], "unknown_endorser");
    assert!(endorsement.get("endorser").is_none() || endorsement["endorser"].is_null());
}

#[test]
fn attested_kind_and_roles_surface_in_enrichment() {
    let home = tempfile::tempdir().unwrap();
    let (repo, target) = endorsed_repo(home.path().to_str().unwrap(), true, true);
    let out = shore_env(
        ["history", "--repo", repo.path().to_str().unwrap()],
        &[("SHORE_HOME", home.path().to_str().unwrap())],
    );
    let doc: Value = serde_json::from_slice(&out.stdout).unwrap();
    let endorsement = endorsement_for_target(&doc, &target);
    assert_eq!(endorsement["classification"], "endorsement-trusted");
    assert_eq!(endorsement["endorserAttributes"]["kind"], "human");
    assert_eq!(endorsement["endorserAttributes"]["roles"][0], "reviewer");
}