pointbreak 0.10.0

Durable terminal code review for changes humans and coding agents collaborate on together
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
use serde::{Deserialize, Serialize};

use super::kind::EventType;
use super::payload::EventPayload;
use super::task::SourceSpeaker;
use super::{subject_id, type_code};
use crate::error::{Result, ShoreError};
use crate::model::{
    EngagementId, ObjectId, ReviewEndpoint, RevisionId, RevisionSource, TargetRef, WorkObjectId,
};

/// The git provenance of a revision: the resolved source selector and endpoint
/// pair the revision's object was captured from. Absent (`None` on the parent
/// `Revision`) for a non-git object, where there is no commit/tree pair to
/// record. Identity-neutral: provenance feeds the revision id, not the
/// content-only object id.
#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct GitProvenance {
    pub source: RevisionSource,
    pub base: ReviewEndpoint,
    pub target: ReviewEndpoint,
}

/// A revision: a concrete position over a content-only object, plus optional git
/// provenance. The `object_id` is a reference to the content-addressed object
/// (stored once, shared by clones with identical content); the revision id is
/// the position that supersession references.
#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct Revision {
    pub id: RevisionId,
    pub object_id: ObjectId,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub git_provenance: Option<GitProvenance>,
}

/// The proposed work object of a generative move, tagged by domain. The arm must
/// match the addressed subject's domain (a review subject carries a `Revision`,
/// a task subject a `TaskAttempt`).
#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(
    rename_all = "snake_case",
    rename_all_fields = "camelCase",
    tag = "kind"
)]
pub enum WorkObjectProposal {
    Revision {
        revision: Revision,
        /// Human-authored label for distinguishing this capture from other
        /// revisions in discovery surfaces. Descriptive only: it is carried by
        /// the proposal event and does not participate in revision identity.
        #[serde(default, skip_serializing_if = "Option::is_none")]
        summary: Option<String>,
        /// Content hash of the stored object artifact this revision's object
        /// was captured into. A binding fact about the artifact (not part of
        /// revision identity); the artifact-transfer layer resolves the
        /// object artifact by it.
        object_artifact_content_hash: String,
        /// The revisions this one supersedes (an evolution forward-pointer). Sorted
        /// and deduped before hashing, so set-equal inputs converge byte-for-byte;
        /// empty (a root revision) serializes to nothing, leaving an existing root
        /// capture's payload hash unchanged. References a revision position, never
        /// the revision's content object.
        #[serde(default, skip_serializing_if = "Vec::is_empty")]
        supersedes: Vec<RevisionId>,
    },
    TaskAttempt {
        task_attempt_id: WorkObjectId,
        project_path: String,
        claude_session_uuid: String,
        initial_prompt_hash: String,
        #[serde(skip_serializing_if = "Option::is_none")]
        predecessor: Option<WorkObjectId>,
        #[serde(skip_serializing_if = "Option::is_none")]
        base_state_fingerprint: Option<String>,
        #[serde(skip_serializing_if = "Option::is_none")]
        source_speaker: Option<SourceSpeaker>,
    },
}

/// The generative move payload, domain-neutral over the review and task
/// verticals. Carries the shared write-time-derived `engagement_id` hint and the
/// tagged proposed work object. This is an advisory proposal, never an
/// instruction.
#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct WorkObjectProposedPayload {
    pub engagement_id: EngagementId,
    pub work_object: WorkObjectProposal,
}

impl WorkObjectProposedPayload {
    pub(crate) fn idempotency_key(subject: &TargetRef) -> Result<String> {
        let subject_id = subject_id(subject)?.ok_or_else(|| {
            ShoreError::Message("work object proposed subject must have an id".to_owned())
        })?;
        Ok(format!(
            "{}:{subject_id}",
            type_code(EventType::WorkObjectProposed)
        ))
    }
}

impl EventPayload for WorkObjectProposedPayload {
    fn event_type(&self) -> EventType {
        EventType::WorkObjectProposed
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::model::{CommitRangeCaptureMode, JournalId, WorktreeCaptureMode};

    fn git_provenance() -> GitProvenance {
        GitProvenance {
            source: RevisionSource::GitWorktree {
                mode: WorktreeCaptureMode::CombinedHeadToWorkingTree,
                include_untracked: true,
                pathspecs: Vec::new(),
            },
            base: ReviewEndpoint::GitCommit {
                commit_oid: "abc".to_owned(),
                tree_oid: "def".to_owned(),
            },
            target: ReviewEndpoint::GitWorkingTree {
                worktree_root: "/repo".to_owned(),
            },
        }
    }

    fn revision_payload() -> WorkObjectProposedPayload {
        WorkObjectProposedPayload {
            engagement_id: EngagementId::new("engagement:sha256:e"),
            work_object: WorkObjectProposal::Revision {
                revision: Revision {
                    id: RevisionId::new("rev:sha256:r"),
                    object_id: ObjectId::new("obj:sha256:o"),
                    git_provenance: Some(git_provenance()),
                },
                summary: None,
                object_artifact_content_hash: "sha256:artifact".to_owned(),
                supersedes: vec![],
            },
        }
    }

    #[test]
    fn revision_arm_round_trips_and_tags_with_kind() {
        let payload = revision_payload();
        assert_eq!(
            serde_json::to_string(&payload).unwrap(),
            r#"{"engagementId":"engagement:sha256:e","workObject":{"kind":"revision","revision":{"id":"rev:sha256:r","objectId":"obj:sha256:o","gitProvenance":{"source":{"kind":"git_worktree","mode":"combined_head_to_working_tree","includeUntracked":true},"base":{"kind":"git_commit","commitOid":"abc","treeOid":"def"},"target":{"kind":"git_working_tree","worktreeRoot":"/repo"}}},"objectArtifactContentHash":"sha256:artifact"}}"#
        );
        let json = serde_json::to_value(&payload).unwrap();

        assert_eq!(json["engagementId"], "engagement:sha256:e");
        assert_eq!(json["workObject"]["kind"], "revision");
        assert_eq!(json["workObject"]["revision"]["id"], "rev:sha256:r");
        assert_eq!(json["workObject"]["revision"]["objectId"], "obj:sha256:o");
        assert_eq!(
            json["workObject"]["objectArtifactContentHash"],
            "sha256:artifact"
        );
        assert!(json["workObject"].get("summary").is_none());
        assert_eq!(
            json["workObject"]["revision"]["gitProvenance"]["source"]["kind"],
            "git_worktree"
        );

        let parsed: WorkObjectProposedPayload = serde_json::from_value(json).unwrap();
        assert_eq!(parsed, payload);
    }

    #[test]
    fn revision_arm_round_trips_an_optional_summary() {
        let mut payload = revision_payload();
        let WorkObjectProposal::Revision { summary, .. } = &mut payload.work_object else {
            unreachable!("fixture is a revision proposal");
        };
        *summary = Some("Make revision discovery readable".to_owned());

        let json = serde_json::to_value(&payload).unwrap();
        assert_eq!(
            json["workObject"]["summary"],
            "Make revision discovery readable"
        );
        let parsed: WorkObjectProposedPayload = serde_json::from_value(json).unwrap();
        assert_eq!(parsed, payload);
    }

    #[test]
    fn revision_arm_omits_git_provenance_when_absent() {
        let payload = WorkObjectProposedPayload {
            engagement_id: EngagementId::new("engagement:sha256:e"),
            work_object: WorkObjectProposal::Revision {
                revision: Revision {
                    id: RevisionId::new("rev:sha256:r"),
                    object_id: ObjectId::new("obj:sha256:o"),
                    git_provenance: None,
                },
                summary: None,
                object_artifact_content_hash: "sha256:artifact".to_owned(),
                supersedes: vec![],
            },
        };
        assert_eq!(
            serde_json::to_string(&payload).unwrap(),
            r#"{"engagementId":"engagement:sha256:e","workObject":{"kind":"revision","revision":{"id":"rev:sha256:r","objectId":"obj:sha256:o"},"objectArtifactContentHash":"sha256:artifact"}}"#
        );
        let json = serde_json::to_value(&payload).unwrap();
        assert!(
            json["workObject"]["revision"]
                .get("gitProvenance")
                .is_none()
        );

        let parsed: WorkObjectProposedPayload = serde_json::from_value(json).unwrap();
        assert_eq!(parsed, payload);
    }

    #[test]
    fn revision_arm_serializes_object_artifact_content_hash() {
        // The capture payload names the stored object artifact's content hash
        // under the object vocabulary; the legacy `snapshotArtifactContentHash`
        // key is retired.
        let payload = revision_payload();
        let json = serde_json::to_value(&payload).unwrap();
        assert_eq!(
            json["workObject"]["objectArtifactContentHash"],
            "sha256:artifact"
        );
        assert!(
            json["workObject"]
                .get("snapshotArtifactContentHash")
                .is_none()
        );
    }

    #[test]
    fn task_attempt_arm_serializes_base_state_fingerprint() {
        let payload = WorkObjectProposedPayload {
            engagement_id: EngagementId::new("engagement:sha256:t"),
            work_object: WorkObjectProposal::TaskAttempt {
                task_attempt_id: WorkObjectId::new("task-attempt:sha256:a"),
                project_path: "/repo".to_owned(),
                claude_session_uuid: "uuid-1".to_owned(),
                initial_prompt_hash: "sha256:prompt".to_owned(),
                predecessor: None,
                base_state_fingerprint: Some("sha256:base".to_owned()),
                source_speaker: None,
            },
        };
        let json = serde_json::to_value(&payload).unwrap();
        assert_eq!(json["workObject"]["baseStateFingerprint"], "sha256:base");
        assert!(json["workObject"].get("baseSnapshotFingerprint").is_none());
    }

    #[test]
    fn task_attempt_arm_round_trips_and_tags_with_kind() {
        let payload = WorkObjectProposedPayload {
            engagement_id: EngagementId::new("engagement:sha256:t"),
            work_object: WorkObjectProposal::TaskAttempt {
                task_attempt_id: WorkObjectId::new("task-attempt:sha256:a"),
                project_path: "/repo".to_owned(),
                claude_session_uuid: "uuid-1".to_owned(),
                initial_prompt_hash: "sha256:prompt".to_owned(),
                predecessor: None,
                base_state_fingerprint: None,
                source_speaker: Some(SourceSpeaker::Agent),
            },
        };
        let json = serde_json::to_value(&payload).unwrap();

        assert_eq!(json["workObject"]["kind"], "task_attempt");
        assert_eq!(json["workObject"]["taskAttemptId"], "task-attempt:sha256:a");
        assert_eq!(json["workObject"]["sourceSpeaker"], "agent");
        assert!(json["workObject"].get("predecessor").is_none());

        let parsed: WorkObjectProposedPayload = serde_json::from_value(json).unwrap();
        assert_eq!(parsed, payload);
    }

    #[test]
    fn scoped_provenance_serializes_pathspecs_inside_the_source() {
        let mut provenance = git_provenance();
        provenance.source = RevisionSource::GitWorktree {
            mode: WorktreeCaptureMode::CombinedHeadToWorkingTree,
            include_untracked: true,
            pathspecs: vec!["packages/foo".to_owned()],
        };
        let payload = WorkObjectProposedPayload {
            engagement_id: EngagementId::new("engagement:sha256:e"),
            work_object: WorkObjectProposal::Revision {
                revision: Revision {
                    id: RevisionId::new("rev:sha256:r"),
                    object_id: ObjectId::new("obj:sha256:o"),
                    git_provenance: Some(provenance),
                },
                summary: None,
                object_artifact_content_hash: "sha256:artifact".to_owned(),
                supersedes: vec![],
            },
        };
        let json = serde_json::to_value(&payload).unwrap();
        assert_eq!(
            json["workObject"]["revision"]["gitProvenance"]["source"]["pathspecs"][0],
            "packages/foo"
        );
        let parsed: WorkObjectProposedPayload = serde_json::from_value(json).unwrap();
        assert_eq!(parsed, payload);
    }

    #[test]
    fn unscoped_provenance_payload_omits_pathspecs() {
        // The revision_payload() helper is unscoped; its serialized source must
        // carry no pathspecs key, keeping existing payload hashes and
        // signatures stable.
        let json = serde_json::to_value(revision_payload()).unwrap();
        assert!(
            json["workObject"]["revision"]["gitProvenance"]["source"]
                .get("pathspecs")
                .is_none()
        );
    }

    #[test]
    fn unused_range_mode_is_constructible() {
        // Keep the commit-range mode import exercised for provenance shaping.
        let _ = CommitRangeCaptureMode::BaseTreeToTargetTree;
    }

    #[test]
    fn payload_reports_work_object_proposed_event_type() {
        assert_eq!(
            revision_payload().event_type(),
            EventType::WorkObjectProposed
        );
    }

    #[test]
    fn empty_supersedes_is_omitted_from_serialization() {
        // A root revision (no supersedes) serializes with no `supersedes` key, so
        // an existing root capture's payload hash is unchanged by the new field.
        let payload = revision_payload();
        let json = serde_json::to_value(&payload).unwrap();
        assert!(json["workObject"].get("supersedes").is_none());
    }

    #[test]
    fn non_empty_supersedes_round_trips_as_an_array() {
        let payload = WorkObjectProposedPayload {
            engagement_id: EngagementId::new("engagement:sha256:e"),
            work_object: WorkObjectProposal::Revision {
                revision: Revision {
                    id: RevisionId::new("rev:sha256:r"),
                    object_id: ObjectId::new("obj:sha256:o"),
                    git_provenance: None,
                },
                summary: None,
                object_artifact_content_hash: "sha256:artifact".to_owned(),
                supersedes: vec![
                    RevisionId::new("rev:sha256:a"),
                    RevisionId::new("rev:sha256:b"),
                ],
            },
        };
        let json = serde_json::to_value(&payload).unwrap();
        assert_eq!(json["workObject"]["supersedes"][0], "rev:sha256:a");
        assert_eq!(json["workObject"]["supersedes"][1], "rev:sha256:b");

        let parsed: WorkObjectProposedPayload = serde_json::from_value(json).unwrap();
        assert_eq!(parsed, payload);
    }

    #[test]
    fn set_equal_supersedes_converge_to_one_payload_hash() {
        use crate::session::event::{EventTarget, ShoreEvent, Writer};
        use crate::session::workflow::util::sorted_unique;

        fn event_with_supersedes(supersedes: Vec<RevisionId>) -> ShoreEvent {
            let revision_id = RevisionId::new("rev:sha256:x");
            ShoreEvent::new(
                EventType::WorkObjectProposed,
                format!("work_object_proposed:{}", revision_id.as_str()),
                EventTarget::for_revision(
                    JournalId::new("journal:default"),
                    revision_id.clone(),
                    None,
                )
                .unwrap(),
                Writer::shore_local("test"),
                WorkObjectProposedPayload {
                    engagement_id: EngagementId::new("engagement:sha256:e"),
                    work_object: WorkObjectProposal::Revision {
                        revision: Revision {
                            id: revision_id,
                            object_id: ObjectId::new("obj:sha256:o"),
                            git_provenance: None,
                        },
                        summary: None,
                        object_artifact_content_hash: "sha256:artifact".to_owned(),
                        supersedes,
                    },
                },
                "2026-06-04T00:00:00Z",
            )
            .unwrap()
        }

        let a = event_with_supersedes(sorted_unique(vec![
            RevisionId::new("rev:sha256:b"),
            RevisionId::new("rev:sha256:a"),
            RevisionId::new("rev:sha256:b"),
        ]));
        let b = event_with_supersedes(sorted_unique(vec![
            RevisionId::new("rev:sha256:a"),
            RevisionId::new("rev:sha256:b"),
        ]));
        assert_eq!(a.payload_hash, b.payload_hash);
    }
}