1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
//! Accurate dead code analyzer using cargo/rustc integration
//!
//! This module provides accurate dead code detection by leveraging
//! the Rust compiler's built-in dead code analysis, replacing the
//! previous heuristic-based approach that produced false positives.
//!
//! ## Performance (CB-128 O(1) Caching)
//!
//! Uses git tree-hash for O(1) cache invalidation:
//! - Cache hit: ~5ms (read JSON from .pmat/dead-code-cache/)
//! - Cache miss: ~30-60s (full cargo check with -W dead_code)
//!
//! Cache is invalidated when:
//! - Git tree hash changes (code modified)
//! - PMAT version changes
//! - Cache file is missing or corrupted
#![cfg_attr(coverage_nightly, coverage(off))]
use anyhow::{Context, Result};
use serde::{Deserialize, Serialize};
use serde_json::Value;
use std::collections::HashMap;
use std::path::{Path, PathBuf};
use std::process::Command;
/// Shape of `AccurateDeadCodeReport` this build can read out of a cache entry.
///
/// The cache was keyed on (tree hash, pmat version) alone, so a cache written
/// by an EARLIER BUILD OF THE SAME VERSION was accepted whole. When
/// `FileDeadCode::unreachable_items` was added, those entries deserialised it as
/// empty via `#[serde(default)]` and `--include-unreachable` reported nothing at
/// all on any tree with a warm cache — the flag would have looked inert again,
/// for a reason nothing in the report disclosed. Bump this whenever the cached
/// report gains or changes a field.
/// 3: `DeadCodeKind::Suppressed` was removed. A cache entry written by an
/// earlier build carries `"Suppressed"` kinds, which this build cannot
/// deserialise — and if it could, it would restore exactly the erased-kind
/// report (`dead_functions: 0` over six dead functions) that removing the
/// variant fixed.
pub const DEAD_CODE_CACHE_SCHEMA: u32 = 3;
/// Cached dead code result with metadata for O(1) invalidation
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CachedDeadCodeResult {
/// Shape of the cached report; entries that do not match this build's
/// `DEAD_CODE_CACHE_SCHEMA` are a miss. `0` for entries written before the
/// field existed.
#[serde(default)]
pub report_schema: u32,
/// Git tree hash when this cache was computed
pub tree_hash: String,
/// PMAT version that computed this cache
pub pmat_version: String,
/// Timestamp of cache computation
pub timestamp: chrono::DateTime<chrono::Utc>,
/// The actual dead code report
pub report: AccurateDeadCodeReport,
}
/// Dead code analysis result with accurate metrics
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct AccurateDeadCodeReport {
/// Files with dead code
pub files_with_dead_code: Vec<FileDeadCode>,
/// Total dead code items
pub total_dead_items: usize,
/// Accurate dead code percentage
pub dead_code_percentage: f64,
/// Total lines analyzed
pub total_lines: usize,
/// Source files actually scanned: `.rs` files walked, minus ignored/hidden
/// dirs and minus the trees this run was configured to skip.
#[serde(default)]
pub total_files: usize,
/// Every `.rs` file the walk saw, including the test/example/bench trees
/// `total_files` leaves out. The two differ exactly when the scan was
/// narrowed, and that difference is the only record of the narrowing a
/// consumer gets -- without it a default run reports all zeros over files
/// it never opened.
#[serde(default)]
pub project_files: usize,
/// Dead lines count
pub dead_lines: usize,
/// Summary by type
pub dead_by_type: HashMap<String, usize>,
}
#[derive(Debug, Clone, Serialize, Deserialize)]
/// File dead code.
pub struct FileDeadCode {
pub file_path: PathBuf,
pub dead_items: Vec<DeadItem>,
/// Statements rustc reported as `unreachable_code`, kept OUT of
/// `dead_items`.
///
/// They are a different finding from "never used": unreachable code is
/// reachable-from-nowhere code inside a live item. Mixing them into
/// `dead_items` would move `total_dead_items`, `dead_by_type`,
/// `file_dead_percentage` and every estimated line count, so a default run
/// would change; they are carried alongside and surfaced only by
/// `analyze dead-code --include-unreachable`.
///
/// The flag reached `DeadCodeAnalysisConfig` and stopped there, and the one
/// site that honours it (`analysis_ranking.rs`) is reachable only from the
/// MCP tool — so the CLI printed "Unreachable blocks: 0" for a file with
/// four statements after a `return` while the MCP equivalent was live.
#[serde(default)]
pub unreachable_items: Vec<DeadItem>,
pub file_dead_percentage: f64,
/// Physical lines in the file, counted while computing
/// `file_dead_percentage`. `None` when the file could not be read.
///
/// The consumer used to substitute the literal `100` for every file
/// (`FileDeadCodeMetrics.total_lines`), so a 1287-line file and a 370-line
/// file both reported `total_lines: 100` next to a `dead_percentage`
/// computed from the real count — 24 dead lines "of 100" printed as 6.49%.
/// The count is measured here, once, and carried instead of re-invented.
#[serde(default)]
pub total_lines: Option<usize>,
}
#[derive(Debug, Clone, Serialize, Deserialize)]
/// Dead item.
pub struct DeadItem {
pub name: String,
pub kind: DeadCodeKind,
pub line: usize,
pub column: usize,
pub message: String,
}
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
/// Dead code kind.
pub enum DeadCodeKind {
Function,
Method,
Struct,
Enum,
Variant,
Field,
Constant,
Static,
Module,
Trait,
TypeAlias,
// There is deliberately no `Suppressed` variant. Layer 1 (the scan for
// explicit `allow(dead_code)` admissions) used to tag every item it found
// with one, which erased the item's real kind: "suppressed" is a category
// `count_dead_items_by_kind` and `dead_by_type` know nothing about, so a
// suppressed function could not increment `dead_functions`, could not be
// typed `function` in the report, and was billed the 2-line "anything else"
// estimate instead of a function's 5. How an item was DISCOVERED is
// provenance and belongs in `DeadItem::message`; WHAT it is belongs in
// `kind`, and one must not overwrite the other.
/// rustc's `unreachable_code` lint: a statement that can never execute.
///
/// Only ever stored in `FileDeadCode::unreachable_items`, never in
/// `dead_items`, so no existing counter can see it.
UnreachableCode,
Other(String),
}
/// Cargo-based dead code analyzer for accurate detection with O(1) caching
pub struct CargoDeadCodeAnalyzer {
project_path: PathBuf,
exclude_tests: bool,
exclude_examples: bool,
exclude_benches: bool,
max_depth: usize,
/// Enable caching (default: true)
use_cache: bool,
/// Force cache refresh even if valid
force_refresh: bool,
/// How long the analysis may run before the `cargo check` child is killed.
///
/// This was a hardcoded `Duration::from_secs(90)` inside `analyze()`, so
/// `analyze dead-code --timeout 300` was silently capped at 90 even once the
/// timer worked. The caller that has a user-facing budget owns it;
/// [`DEFAULT_ANALYSIS_TIMEOUT_SECS`] is the default for callers that do not.
timeout: std::time::Duration,
}
/// How long a dead-code analysis may run before its `cargo check` child is
/// killed, for any caller that does not name its own budget.
///
/// #929 CONSEQUENCE. The budget only started binding when the blocking
/// `Command::output()` was replaced by a child this analyzer can kill, and the
/// moment it bound, every default that had never been tested became a real
/// failure mode: the CLI shipped 60s and this constructor shipped 90s for the
/// SAME work, so `pmat analyze dead-code -p .` on this repo exited 5 at 60.4s
/// where the same command used to run 245s to completion.
///
/// 900s is what the measurement supports, not a round number: this repo takes
/// 245s for a COLD `cargo check` (67.6s warm), and a monorepo several times its
/// size on a slower machine is the case the default has to survive, since the
/// first run after a dependency bump is always cold. The result is cached, so
/// the budget is paid once. A caller that wants a tighter bound passes
/// [`CargoDeadCodeAnalyzer::with_timeout`]; the CLI's `--timeout` does exactly
/// that.
///
/// One constant, so the library default and the CLI default cannot drift apart
/// again the way 90 and 60 did.
pub const DEFAULT_ANALYSIS_TIMEOUT_SECS: u64 = 900;
impl CargoDeadCodeAnalyzer {
/// Create a new analyzer for the given project path
#[provable_contracts_macros::contract("pmat-core.yaml", equation = "path_exists")]
pub fn new(project_path: impl AsRef<Path>) -> Self {
Self {
project_path: project_path.as_ref().to_path_buf(),
exclude_tests: true,
// `--include-tests` is the only scope flag the CLI (and MCP) ever
// exposes, so defaulting these two to `true` did not narrow the
// default report — it made `examples/` and `benches/` unreachable
// from EVERY invocation, with no flag able to put them back and
// `--include 'examples/**'` returning an empty list because the
// glob ran over a set the tree had already been cut from. They are
// ordinary first-party source that ships with the crate, so they
// stay in scope; only the test tree is gated.
exclude_examples: false,
exclude_benches: false,
max_depth: 8,
use_cache: true,
force_refresh: false,
timeout: std::time::Duration::from_secs(DEFAULT_ANALYSIS_TIMEOUT_SECS),
}
}
/// How long this analysis may run before `cargo check` is killed.
///
/// Readable so the shipped default is testable: it was a literal inside
/// `new()` that nothing could observe, which is how it came to disagree
/// with the CLI's own default (#929).
#[must_use]
pub fn timeout(&self) -> std::time::Duration {
self.timeout
}
/// Set how long the analysis may run before `cargo check` is killed.
#[must_use]
#[provable_contracts_macros::contract("pmat-core.yaml", equation = "check_compliance")]
pub fn with_timeout(mut self, timeout: std::time::Duration) -> Self {
self.timeout = timeout;
self
}
/// Include test code in analysis
#[must_use]
#[provable_contracts_macros::contract("pmat-core.yaml", equation = "check_compliance")]
pub fn include_tests(mut self) -> Self {
self.exclude_tests = false;
self
}
/// Include example code in analysis
#[must_use]
#[provable_contracts_macros::contract("pmat-core.yaml", equation = "check_compliance")]
pub fn include_examples(mut self) -> Self {
self.exclude_examples = false;
self
}
/// Include benchmark code in analysis
#[must_use]
#[provable_contracts_macros::contract("pmat-core.yaml", equation = "check_compliance")]
pub fn include_benches(mut self) -> Self {
self.exclude_benches = false;
self
}
/// Set maximum directory traversal depth
#[must_use]
#[provable_contracts_macros::contract("pmat-core.yaml", equation = "check_compliance")]
pub fn with_max_depth(mut self, max_depth: usize) -> Self {
self.max_depth = max_depth;
self
}
/// Disable caching (force fresh analysis every time)
#[must_use]
#[provable_contracts_macros::contract("pmat-core.yaml", equation = "check_compliance")]
pub fn without_cache(mut self) -> Self {
self.use_cache = false;
self
}
/// Force cache refresh even if cache is valid
#[must_use]
#[provable_contracts_macros::contract("pmat-core.yaml", equation = "check_compliance")]
pub fn force_refresh(mut self) -> Self {
self.force_refresh = true;
self
}
}
/// Public API for backward compatibility
#[provable_contracts_macros::contract("pmat-core.yaml", equation = "path_exists")]
pub async fn analyze_dead_code(project_path: impl AsRef<Path>) -> Result<AccurateDeadCodeReport> {
let analyzer = CargoDeadCodeAnalyzer::new(project_path);
analyzer.analyze().await
}
// Include implementation files
include!("cargo_dead_code_analyzer/cache_operations.rs");
include!("cargo_dead_code_analyzer/analysis.rs");
include!("cargo_dead_code_analyzer/parsing.rs");
include!("cargo_dead_code_analyzer/tests.rs");
#[cfg(test)]
#[path = "cargo_dead_code_analyzer/dead_line_bound_tests.rs"]
mod dead_line_bound_tests;
#[cfg(test)]
#[path = "cargo_dead_code_analyzer/cargo_target_scope_tests.rs"]
mod cargo_target_scope_tests;