pmat 3.16.0

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
#![cfg_attr(coverage_nightly, coverage(off))]
use crate::handlers::tools::handle_tool_call;
use crate::models::mcp::{McpRequest, ToolCallParams};
use crate::stateless_server::StatelessTemplateServer;
use serde_json::{json, Value};
use std::sync::Arc;

fn create_test_server() -> Arc<StatelessTemplateServer> {
    Arc::new(StatelessTemplateServer::new().unwrap())
}

fn create_tool_request(tool_name: &str, arguments: Value) -> McpRequest {
    let params = ToolCallParams {
        name: tool_name.to_string(),
        arguments,
    };

    McpRequest {
        jsonrpc: "2.0".to_string(),
        id: json!(1),
        method: "tools/call".to_string(),
        params: Some(serde_json::to_value(params).unwrap()),
    }
}

#[tokio::test]
async fn test_claude_code_rust_cli_workflow() {
    let server = create_test_server();

    // Step 1: List templates for Rust (simulating Claude Code's first action)
    let request = create_tool_request(
        "list_templates",
        json!({
            "toolchain": "rust"
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.result.is_some());
    assert!(response.error.is_none());

    let result = response.result.unwrap();
    let templates = result["templates"].as_array().unwrap();
    assert_eq!(templates.len(), 3); // Makefile, README, and .gitignore for Rust

    // Step 2: Try scaffold_project (simulating Claude Code's scaffold attempt)
    let request = create_tool_request(
        "scaffold_project",
        json!({
            "toolchain": "rust",
            "templates": ["makefile", "readme", "gitignore"],
            "parameters": {
                "project_name": "my-rust-cli",
                "author_name": "Your Name",
                "author_email": "your.email@example.com",
                "description": "A Rust CLI application"
            }
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.result.is_some());
    assert!(response.error.is_none());

    let result = response.result.unwrap();
    let generated = result["generated"].as_array().unwrap();
    assert_eq!(generated.len(), 3);

    // Verify each generated file
    for file in generated {
        let template_type = file["template"].as_str().unwrap();
        let filename = file["filename"].as_str().unwrap();
        let content = file["content"].as_str().unwrap();

        match template_type {
            "makefile" => {
                assert_eq!(filename, "my-rust-cli/Makefile");
                assert!(content.contains("my-rust-cli"));
                assert!(content.contains("cargo build"));
            }
            "readme" => {
                assert_eq!(filename, "my-rust-cli/README.md");
                assert!(content.contains("my-rust-cli"));
                assert!(content.contains("A Rust CLI application"));
            }
            "gitignore" => {
                assert_eq!(filename, "my-rust-cli/.gitignore");
                // The Rust gitignore template uses template variables with defaults
                // It may show "Build artifacts" section header or the actual patterns
                assert!(content.contains("target/") || content.contains("Build artifacts"));
            }
            _ => panic!("Unexpected template type: {template_type}"),
        }
    }

    // Step 3: Test individual generate_template call (simulating Claude Code's fallback)
    let request = create_tool_request(
        "generate_template",
        json!({
            "resource_uri": "template://makefile/rust/cli",
            "parameters": {
                "project_name": "my-rust-cli"
            }
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.result.is_some());
    assert!(response.error.is_none());

    let result = response.result.unwrap();
    let content = result["content"][0]["text"].as_str().unwrap();
    assert!(content.contains("my-rust-cli"));
    assert!(content.contains("Rust CLI Binary Makefile"));
}

#[tokio::test]
async fn test_claude_code_all_languages_scaffold() {
    let server = create_test_server();

    let test_cases = create_scaffold_test_cases();

    for (toolchain, project_name, description) in test_cases {
        test_toolchain_scaffolding(&server, toolchain, project_name, description).await;
    }
}

fn create_scaffold_test_cases() -> Vec<(&'static str, &'static str, &'static str)> {
    vec![
        ("rust", "my-rust-project", "A Rust project"),
        ("deno", "my-deno-project", "A Deno TypeScript project"),
        ("python-uv", "my-python-project", "A Python UV project"),
    ]
}

async fn test_toolchain_scaffolding(
    server: &Arc<StatelessTemplateServer>,
    toolchain: &str,
    project_name: &str,
    description: &str,
) {
    let request = create_scaffold_request(toolchain, project_name, description);
    let response = handle_tool_call(server.clone(), request).await;

    validate_scaffold_response(&response, toolchain);

    let result = response.result.unwrap();
    let generated = result["generated"].as_array().unwrap();

    assert_eq!(generated.len(), 3, "Wrong number of files for {toolchain}");
    verify_generated_files(generated, toolchain, project_name, description);
}

fn create_scaffold_request(toolchain: &str, project_name: &str, description: &str) -> McpRequest {
    create_tool_request(
        "scaffold_project",
        json!({
            "toolchain": toolchain,
            "templates": ["makefile", "readme", "gitignore"],
            "parameters": {
                "project_name": project_name,
                "description": description,
                "author_name": "Test Author"
            }
        }),
    )
}

fn validate_scaffold_response(response: &crate::models::mcp::McpResponse, toolchain: &str) {
    assert!(
        response.result.is_some(),
        "Failed for toolchain: {toolchain}"
    );
    assert!(response.error.is_none(), "Error for toolchain: {toolchain}");
}

fn verify_generated_files(
    generated: &[Value],
    toolchain: &str,
    project_name: &str,
    description: &str,
) {
    let mut file_flags = GeneratedFileFlags::new();

    for file in generated {
        process_generated_file(file, &mut file_flags, toolchain, project_name, description);
    }

    file_flags.assert_all_files_present(toolchain);
}

struct GeneratedFileFlags {
    has_makefile: bool,
    has_readme: bool,
    has_gitignore: bool,
}

impl GeneratedFileFlags {
    fn new() -> Self {
        Self {
            has_makefile: false,
            has_readme: false,
            has_gitignore: false,
        }
    }

    fn assert_all_files_present(&self, toolchain: &str) {
        assert!(self.has_makefile, "Missing Makefile for {toolchain}");
        assert!(self.has_readme, "Missing README for {toolchain}");
        assert!(self.has_gitignore, "Missing .gitignore for {toolchain}");
    }
}

fn process_generated_file(
    file: &Value,
    flags: &mut GeneratedFileFlags,
    toolchain: &str,
    project_name: &str,
    description: &str,
) {
    match file["template"].as_str().unwrap() {
        "makefile" => {
            flags.has_makefile = true;
            verify_makefile(file, toolchain, project_name);
        }
        "readme" => {
            flags.has_readme = true;
            verify_readme(file, project_name, description);
        }
        "gitignore" => {
            flags.has_gitignore = true;
            verify_gitignore(file, toolchain, project_name);
        }
        _ => {}
    }
}

fn verify_makefile(file: &Value, toolchain: &str, project_name: &str) {
    assert_eq!(
        file["filename"].as_str().unwrap(),
        &format!("{project_name}/Makefile")
    );
    let content = file["content"].as_str().unwrap();
    assert!(content.contains(project_name));

    verify_makefile_toolchain_specific(content, toolchain);
}

fn verify_makefile_toolchain_specific(content: &str, toolchain: &str) {
    match toolchain {
        "rust" => assert!(content.contains("cargo")),
        "deno" => assert!(content.contains("deno")),
        "python-uv" => assert!(content.contains("uv")),
        _ => {}
    }
}

fn verify_readme(file: &Value, project_name: &str, description: &str) {
    assert_eq!(
        file["filename"].as_str().unwrap(),
        &format!("{project_name}/README.md")
    );
    let content = file["content"].as_str().unwrap();
    assert!(content.contains(project_name));
    assert!(content.contains(description));
}

fn verify_gitignore(file: &Value, toolchain: &str, project_name: &str) {
    assert_eq!(
        file["filename"].as_str().unwrap(),
        &format!("{project_name}/.gitignore")
    );
    let content = file["content"].as_str().unwrap();

    verify_gitignore_patterns(content, toolchain);
}

fn verify_gitignore_patterns(content: &str, toolchain: &str) {
    match toolchain {
        "rust" => assert!(content.contains("/target/")),
        "deno" => assert!(content.contains("deno.lock")),
        "python-uv" => assert!(content.contains("__pycache__")),
        _ => {}
    }
}

#[tokio::test]
async fn test_claude_code_error_scenarios() {
    let server = create_test_server();

    // Test 1: Invalid template URI (simulating Claude Code's initial error)
    let request = create_tool_request(
        "generate_template",
        json!({
            "resource_uri": "template://readme/rust/invalid-variant", // Wrong variant
            "parameters": {
                "project_name": "test-project"
            }
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.error.is_some());
    assert_eq!(response.error.unwrap().code, -32001);

    // Test 2: Missing required parameters
    let request = create_tool_request(
        "generate_template",
        json!({
            "resource_uri": "template://makefile/rust/cli",
            "parameters": {} // Missing project_name
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.error.is_some());

    // Test 3: Invalid toolchain in scaffold
    let request = create_tool_request(
        "scaffold_project",
        json!({
            "toolchain": "invalid-toolchain",
            "templates": ["makefile"],
            "parameters": {
                "project_name": "test"
            }
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.result.is_some());
    let result = response.result.unwrap();
    let generated = result["generated"].as_array().unwrap();
    assert!(generated.is_empty()); // Should not generate any files for invalid toolchain
}

#[tokio::test]
async fn test_claude_code_search_templates() {
    let server = create_test_server();

    // Test searching for README templates (simulating Claude Code's search)
    let request = create_tool_request(
        "search_templates",
        json!({
            "query": "readme",
            "toolchain": "rust"
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.result.is_some());
    assert!(response.error.is_none());

    let result = response.result.unwrap();
    let templates = result["templates"].as_array().unwrap();
    assert_eq!(templates.len(), 1); // Only Rust README
    assert_eq!(
        templates[0]["uri"].as_str().unwrap(),
        "template://readme/rust/cli"
    );
}

#[tokio::test]
async fn test_naming_convention_critical_requirement() {
    let server = create_test_server();

    // Test that all generated templates use correct "pmat" naming
    let test_cases = vec![
        ("rust", "test-rust-project", "A Rust CLI project"),
        ("deno", "test-deno-project", "A Deno TypeScript project"),
        ("python-uv", "test-python-project", "A Python UV project"),
    ];

    for (toolchain, project_name, description) in test_cases {
        // Generate all templates for the toolchain
        let request = create_tool_request(
            "scaffold_project",
            json!({
                "toolchain": toolchain,
                "templates": ["makefile", "readme", "gitignore"],
                "parameters": {
                    "project_name": project_name,
                    "description": description,
                    "author_name": "Test Author",
                    "author_email": "test@example.com",
                    "github_username": "testuser"
                }
            }),
        );

        let response = handle_tool_call(server.clone(), request).await;
        assert!(
            response.result.is_some(),
            "Failed for toolchain: {toolchain}"
        );
        assert!(response.error.is_none(), "Error for toolchain: {toolchain}");

        let result = response.result.unwrap();
        let generated = result["generated"].as_array().unwrap();

        // Check each generated file for naming violations
        for file in generated {
            let content = file["content"].as_str().unwrap();
            let filename = file["filename"].as_str().unwrap();

            // Critical: Check for old naming patterns that must not exist
            assert!(
                !content.contains("mcp-agent-toolkit") || content.contains("pmat"),
                "Found incorrect 'mcp-agent-toolkit' (without paiml- prefix) in {filename} for toolchain {toolchain}"
            );

            assert!(
                !content.contains("paiml-agent-toolkit"),
                "Found incorrect 'paiml-agent-toolkit' (missing -mcp-) in {filename} for toolchain {toolchain}"
            );

            assert!(
                !content.contains("mcp_server_stateless"),
                "Found old binary name 'mcp_server_stateless' in {filename} for toolchain {toolchain}"
            );

            assert!(
                !content.contains("mcp-server-"),
                "Found old artifact pattern 'mcp-server-' in {filename} for toolchain {toolchain}"
            );

            // Positive test: Ensure proper naming is used where appropriate
            if file["template"].as_str().unwrap() == "readme" {
                // README should mention the toolkit name
                assert!(
                    content.contains("pmat")
                        || content.contains("PAIML MCP Agent Toolkit")
                        || !content.to_lowercase().contains("toolkit"), // If no toolkit mention, that's ok
                    "README should use correct project name in {filename} for toolchain {toolchain}"
                );
            }
        }
    }
}

#[tokio::test]
async fn test_naming_convention_in_individual_templates() {
    let server = create_test_server();

    // Test individual template generation for naming compliance
    let template_uris = vec![
        "template://makefile/rust/cli",
        "template://makefile/deno/cli",
        "template://makefile/python-uv/cli",
        "template://readme/rust/cli",
        "template://readme/deno/cli",
        "template://readme/python-uv/cli",
        "template://gitignore/rust/cli",
        "template://gitignore/deno/cli",
        "template://gitignore/python-uv/cli",
    ];

    for uri in template_uris {
        let request = create_tool_request(
            "generate_template",
            json!({
                "resource_uri": uri,
                "parameters": {
                    "project_name": "test-project",
                    "description": "Test project for naming validation",
                    "author_name": "Test Author",
                    "author_email": "test@example.com",
                    "github_username": "testuser"
                }
            }),
        );

        let response = handle_tool_call(server.clone(), request).await;

        // Some URIs might not exist, that's ok for this test
        if response.result.is_some() {
            let result = response.result.unwrap();
            let content = result["content"][0]["text"].as_str().unwrap();

            // Apply same naming convention checks
            assert!(
                !content.contains("mcp-agent-toolkit") || content.contains("pmat"),
                "Found incorrect 'mcp-agent-toolkit' in template {uri}"
            );

            assert!(
                !content.contains("paiml-agent-toolkit"),
                "Found incorrect 'paiml-agent-toolkit' in template {uri}"
            );

            assert!(
                !content.contains("mcp_server_stateless"),
                "Found old binary name in template {uri}"
            );

            assert!(
                !content.contains("mcp-server-"),
                "Found old artifact pattern in template {uri}"
            );
        }
    }
}

#[tokio::test]
async fn test_server_info_naming_convention() {
    let server = create_test_server();

    // Test server info command returns correct naming
    let request = create_tool_request("get_server_info", json!({}));

    let response = handle_tool_call(server.clone(), request).await;

    if response.result.is_some() {
        let result = response.result.unwrap();
        let info_str = serde_json::to_string(&result).unwrap();

        // Server info should not contain old names
        assert!(
            !info_str.contains("mcp-agent-toolkit") || info_str.contains("pmat"),
            "Server info contains incorrect 'mcp-agent-toolkit' naming"
        );

        assert!(
            !info_str.contains("paiml-agent-toolkit"),
            "Server info contains incorrect 'paiml-agent-toolkit' naming"
        );

        assert!(
            !info_str.contains("mcp_server_stateless"),
            "Server info contains old binary name"
        );
    }
}

#[tokio::test]
async fn test_ast_context_generation() {
    let server = create_test_server();

    // Create a temporary directory with some Rust files for testing
    let temp_dir = tempfile::tempdir().unwrap();
    let temp_path = temp_dir.path();

    // Create a simple Rust file with various AST elements
    let test_file_content = r#"
use std::collections::HashMap;

pub mod utils {
    /// Helper.
    pub fn helper() {}
}

#[derive(Debug, Clone)]
/// Test struct.
pub struct TestStruct {
    field1: String,
    field2: i32,
}

/// Test enum.
pub enum TestEnum {
    Variant1,
    Variant2(String),
}

/// Trait defining Test trait behavior.
pub trait TestTrait {
    fn method(&self);
}

impl TestTrait for TestStruct {
    fn method(&self) {
        println!("Implementation");
    }
}

pub async fn async_function() -> Result<(), Box<dyn std::error::Error>> {
    Ok(())
}

fn private_function() {
    // Private function
}
"#;

    // Write test file
    std::fs::write(temp_path.join("test.rs"), test_file_content).unwrap();

    // Create a Cargo.toml file
    let cargo_toml = r#"
[package]
name = "test-project"
version = "0.1.0"
edition = "2021"

[dependencies]
tokio = "1.0"
serde = "1.0"
"#;
    std::fs::write(temp_path.join("Cargo.toml"), cargo_toml).unwrap();

    // Test AST context generation via MCP tool
    let request = create_tool_request(
        "generate_template",
        json!({
            "resource_uri": "template://context/rust/ast",
            "parameters": {
                "project_path": temp_path.to_str().unwrap()
            }
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.result.is_some());
    assert!(response.error.is_none());

    let result = response.result.unwrap();
    let content = result["content"][0]["text"].as_str().unwrap();

    // Debug output to see what's actually generated
    eprintln!("Generated content:\n{content}");

    // Verify the content contains expected elements
    assert!(content.contains("# Project Context: rust Project"));
    assert!(content.contains("## Summary"));
    assert!(content.contains("Files analyzed: 1"));
    // Note: Our simple AST parser counts functions at top level, not inside modules
    assert!(content.contains("Functions: 2")); // async_function, private_function (helper is inside a module)
    assert!(content.contains("Structs: 1")); // TestStruct
    assert!(content.contains("Enums: 1")); // TestEnum
    assert!(content.contains("Traits: 1")); // TestTrait
    assert!(content.contains("Implementations: 1")); // impl TestTrait for TestStruct

    // Check dependencies section
    assert!(content.contains("## Dependencies"));
    assert!(content.contains("- tokio"));
    assert!(content.contains("- serde"));

    // Check file analysis section
    assert!(content.contains("## Files"));
    assert!(content.contains("test.rs"));

    // Check specific AST items
    assert!(content.contains("**Modules:**"));
    assert!(content.contains("`pub mod utils`"));

    assert!(content.contains("**Structs:**"));
    assert!(content.contains("`pub struct TestStruct` (2 fields)"));

    assert!(content.contains("**Enums:**"));
    assert!(content.contains("`pub enum TestEnum` (2 variants)"));

    assert!(content.contains("**Traits:**"));
    assert!(content.contains("`pub trait TestTrait`"));

    assert!(content.contains("**Functions:**"));
    assert!(content.contains("`pub async fn async_function`"));
    assert!(content.contains("`private fn private_function`"));

    assert!(content.contains("**Implementations:**"));
    assert!(content.contains("`impl TestTrait for TestStruct`"));

    // Verify the generated filename
    assert_eq!(result["filename"].as_str().unwrap(), "CONTEXT.md");

    // Test with invalid toolchain
    let request = create_tool_request(
        "generate_template",
        json!({
            "resource_uri": "template://context/invalid/ast",
            "parameters": {
                "project_path": temp_path.to_str().unwrap()
            }
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.error.is_some());

    // Test with non-existent path
    let request = create_tool_request(
        "generate_template",
        json!({
            "resource_uri": "template://context/rust/ast",
            "parameters": {
                "project_path": "/non/existent/path"
            }
        }),
    );

    let response = handle_tool_call(server.clone(), request).await;
    assert!(response.result.is_some()); // Should still succeed but with 0 files analyzed

    let result = response.result.unwrap();
    let content = result["content"][0]["text"].as_str().unwrap();
    assert!(content.contains("Files analyzed: 0"));
}