pmat 3.16.0

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
    // ==========================================================================
    // Helper functions
    // ==========================================================================

    /// Creates a temporary directory for testing
    fn create_test_dir() -> TempDir {
        tempfile::tempdir().expect("Failed to create temp directory")
    }

    /// Creates a temporary file with content
    fn create_test_file(dir: &TempDir, name: &str, content: &str) -> PathBuf {
        let path = dir.path().join(name);
        std::fs::write(&path, content).expect("Failed to write test file");
        path
    }

    // ==========================================================================
    // ContractCliHandler::new tests
    // ==========================================================================

    #[test]
    fn test_contract_cli_handler_new_succeeds() {
        let result = ContractCliHandler::new();
        assert!(result.is_ok(), "ContractCliHandler::new() should succeed");
    }

    #[test]
    fn test_contract_cli_handler_new_creates_valid_handler() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        // Verify the service is accessible (field exists)
        let _ = &handler.service;
    }

    // ==========================================================================
    // ContractCliHandler::handle_command tests - non-Analyze commands
    // ==========================================================================

    #[tokio::test]
    async fn test_handle_command_generate_returns_ok() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let cmd = Commands::Generate {
            category: "rust".to_string(),
            template: "cli".to_string(),
            params: vec![],
            output: None,
            create_dirs: false,
        };

        let result = handler.handle_command(cmd).await;
        assert!(result.is_ok(), "Generate command should return Ok");
    }

    #[tokio::test]
    async fn test_handle_command_list_returns_ok() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let cmd = Commands::List {
            toolchain: None,
            category: None,
            format: crate::cli::OutputFormat::Table,
        };

        let result = handler.handle_command(cmd).await;
        assert!(result.is_ok(), "List command should return Ok");
    }

    #[tokio::test]
    async fn test_handle_command_search_returns_ok() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let cmd = Commands::Search {
            query: "test".to_string(),
            toolchain: None,
            limit: 10,
        };

        let result = handler.handle_command(cmd).await;
        assert!(result.is_ok(), "Search command should return Ok");
    }

    #[tokio::test]
    async fn test_handle_command_validate_returns_ok() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let cmd = Commands::Validate {
            uri: "rust/cli".to_string(),
            params: vec![],
        };

        let result = handler.handle_command(cmd).await;
        assert!(result.is_ok(), "Validate command should return Ok");
    }

    // ==========================================================================
    // ContractCliHandler::output_result tests
    // ==========================================================================

    #[test]
    fn test_output_result_with_string_value() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::Value::String("Test output".to_string());
        let temp_dir = create_test_dir();

        let cmd = AnalyzeCommands::Complexity {
            path: temp_dir.path().to_path_buf(),
            project_path: None,
            file: None,
            files: vec![],
            toolchain: None,
            format: crate::cli::ComplexityOutputFormat::Summary,
            output: None,
            max_cyclomatic: None,
            max_cognitive: None,
            include: vec![],
            watch: false,
            top_files: 10,
            fail_on_violation: false,
            timeout: 60,
            ml: false,
        };

        let output = handler.output_result(result, &cmd);
        assert!(
            output.is_ok(),
            "output_result should succeed with string value"
        );
    }

    #[test]
    fn test_output_result_with_json_object() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::json!({
            "key": "value",
            "count": 42
        });
        let temp_dir = create_test_dir();

        let cmd = AnalyzeCommands::Satd {
            path: temp_dir.path().to_path_buf(),
            format: crate::cli::SatdOutputFormat::Summary,
            severity: None,
            critical_only: false,
            include_tests: false,
            strict: false,
            evolution: false,
            days: 30,
            metrics: false,
            output: None,
            top_files: 10,
            fail_on_violation: false,
            timeout: 60,
            include: vec![],
            exclude: vec![],
            extended: false,
        };

        let output = handler.output_result(result, &cmd);
        assert!(
            output.is_ok(),
            "output_result should succeed with JSON object"
        );
    }

    #[test]
    fn test_output_result_with_output_file() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::json!({"status": "ok"});
        let temp_dir = create_test_dir();
        let output_path = temp_dir.path().join("output.json");

        let cmd = AnalyzeCommands::DeadCode {
            path: temp_dir.path().to_path_buf(),
            format: crate::cli::DeadCodeOutputFormat::Json,
            top_files: Some(10),
            include_unreachable: false,
            min_dead_lines: 10,
            include_tests: false,
            output: Some(output_path.clone()),
            fail_on_violation: false,
            max_percentage: 15.0,
            timeout: 60,
            include: vec![],
            exclude: vec![],
            max_depth: 8,
        };

        let output = handler.output_result(result, &cmd);
        assert!(
            output.is_ok(),
            "output_result should succeed with output file"
        );
        assert!(output_path.exists(), "Output file should be created");

        let content = std::fs::read_to_string(&output_path).expect("Should read file");
        assert!(content.contains("status"), "File should contain result");
    }

    #[test]
    fn test_output_result_null_value() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::Value::Null;
        let temp_dir = create_test_dir();

        let cmd = AnalyzeCommands::Tdg {
            path: temp_dir.path().to_path_buf(),
            threshold: 1.5,
            top_files: 10,
            format: crate::cli::TdgOutputFormat::Table,
            include_components: false,
            output: None,
            critical_only: false,
            verbose: false,
            ml: false,
        };

        let output = handler.output_result(result, &cmd);
        assert!(
            output.is_ok(),
            "output_result should succeed with null value"
        );
    }

    #[test]
    fn test_output_result_array_value() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::json!([1, 2, 3, "test"]);
        let temp_dir = create_test_dir();

        let cmd = AnalyzeCommands::LintHotspot {
            path: PathBuf::from("."),
            project_path: Some(temp_dir.path().to_path_buf()),
            file: None,
            format: crate::cli::LintHotspotOutputFormat::Summary,
            max_density: 5.0,
            min_confidence: 0.8,
            enforce: false,
            dry_run: false,
            enforcement_metadata: false,
            output: None,
            perf: false,
            clippy_flags: "-W warnings".to_string(),
            top_files: 10,
            include: vec![],
            exclude: vec![],
        };

        let output = handler.output_result(result, &cmd);
        assert!(
            output.is_ok(),
            "output_result should succeed with array value"
        );
    }

    #[test]
    fn test_output_result_with_other_command_type() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::Value::String("result".to_string());
        let temp_dir = create_test_dir();

        // Using Churn command which falls into the _ => &None branch
        let cmd = AnalyzeCommands::Churn {
            path: PathBuf::from("."),
            project_path: Some(temp_dir.path().to_path_buf()),
            days: 30,
            format: crate::models::churn::ChurnOutputFormat::Summary,
            output: None,
            top_files: 10,
            include: vec![],
            exclude: vec![],
        };

        let output = handler.output_result(result, &cmd);
        assert!(
            output.is_ok(),
            "output_result should succeed with Churn command"
        );
    }

    // ==========================================================================
    // output_result - output file path extraction tests
    // ==========================================================================

    #[test]
    fn test_output_result_complexity_output_path() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::json!({"test": true});
        let temp_dir = create_test_dir();
        let output_path = temp_dir.path().join("complexity.json");

        let cmd = AnalyzeCommands::Complexity {
            path: temp_dir.path().to_path_buf(),
            project_path: None,
            file: None,
            files: vec![],
            toolchain: None,
            format: crate::cli::ComplexityOutputFormat::Json,
            output: Some(output_path.clone()),
            max_cyclomatic: None,
            max_cognitive: None,
            include: vec![],
            watch: false,
            top_files: 10,
            fail_on_violation: false,
            timeout: 60,
            ml: false,
        };

        let output = handler.output_result(result, &cmd);
        assert!(output.is_ok());
        assert!(output_path.exists());
    }

    #[test]
    fn test_output_result_satd_output_path() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::json!({"satd": []});
        let temp_dir = create_test_dir();
        let output_path = temp_dir.path().join("satd.json");

        let cmd = AnalyzeCommands::Satd {
            path: temp_dir.path().to_path_buf(),
            format: crate::cli::SatdOutputFormat::Json,
            severity: None,
            critical_only: false,
            include_tests: false,
            strict: false,
            evolution: false,
            days: 30,
            metrics: false,
            output: Some(output_path.clone()),
            top_files: 10,
            fail_on_violation: false,
            timeout: 60,
            include: vec![],
            exclude: vec![],
            extended: false,
        };

        let output = handler.output_result(result, &cmd);
        assert!(output.is_ok());
        assert!(output_path.exists());
    }

    #[test]
    fn test_output_result_tdg_output_path() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::json!({"tdg_scores": []});
        let temp_dir = create_test_dir();
        let output_path = temp_dir.path().join("tdg.json");

        let cmd = AnalyzeCommands::Tdg {
            path: temp_dir.path().to_path_buf(),
            threshold: 1.5,
            top_files: 10,
            format: crate::cli::TdgOutputFormat::Json,
            include_components: false,
            output: Some(output_path.clone()),
            critical_only: false,
            verbose: false,
            ml: false,
        };

        let output = handler.output_result(result, &cmd);
        assert!(output.is_ok());
        assert!(output_path.exists());
    }

    #[test]
    fn test_output_result_lint_hotspot_output_path() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let result = serde_json::json!({"hotspots": []});
        let temp_dir = create_test_dir();
        let output_path = temp_dir.path().join("lint.json");

        let cmd = AnalyzeCommands::LintHotspot {
            path: PathBuf::from("."),
            project_path: Some(temp_dir.path().to_path_buf()),
            file: None,
            format: crate::cli::LintHotspotOutputFormat::Json,
            max_density: 5.0,
            min_confidence: 0.8,
            enforce: false,
            dry_run: false,
            enforcement_metadata: false,
            output: Some(output_path.clone()),
            perf: false,
            clippy_flags: "-W warnings".to_string(),
            top_files: 10,
            include: vec![],
            exclude: vec![],
        };

        let output = handler.output_result(result, &cmd);
        assert!(output.is_ok());
        assert!(output_path.exists());
    }

    // ==========================================================================
    // AsAny trait implementation tests
    // ==========================================================================

    #[test]
    fn test_as_any_trait_returns_self() {
        // Test that the AsAny trait is implemented correctly
        let temp_dir = create_test_dir();
        let complexity_contract = AnalyzeComplexityContract {
            base: super::super::BaseAnalysisContract {
                path: temp_dir.path().to_path_buf(),
                format: super::super::OutputFormat::Table,
                output: None,
                top_files: Some(10),
                include_tests: false,
                timeout: 60,
            },
            max_cyclomatic: None,
            max_cognitive: None,
            max_halstead: None,
        };

        // Test that the contract validates correctly
        let validation_result = complexity_contract.validate();
        assert!(validation_result.is_ok());
    }

    // ==========================================================================
    // handle_analyze_command tests - deprecation warnings
    // ==========================================================================

    #[tokio::test]
    #[ignore = "requires full service integration"]
    async fn test_handle_analyze_command_prints_deprecation_warnings() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let temp_dir = create_test_dir();

        // Create a Complexity command with deprecated project_path
        let cmd = AnalyzeCommands::Complexity {
            path: PathBuf::from("."),
            project_path: Some(temp_dir.path().to_path_buf()),
            file: None,
            files: vec![],
            toolchain: None,
            format: crate::cli::ComplexityOutputFormat::Summary,
            output: None,
            max_cyclomatic: None,
            max_cognitive: None,
            include: vec![],
            watch: false,
            top_files: 10,
            fail_on_violation: false,
            timeout: 60,
            ml: false,
        };

        // This should succeed and print deprecation warning (captured in stderr)
        let result = handler.handle_analyze_command(cmd).await;
        assert!(result.is_ok());
    }

    // ==========================================================================
    // handle_analyze_command - standard mode fallback tests
    // ==========================================================================

    #[tokio::test]
    async fn test_handle_analyze_command_churn_standard_mode() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let temp_dir = create_test_dir();

        let cmd = AnalyzeCommands::Churn {
            path: PathBuf::from("."),
            project_path: Some(temp_dir.path().to_path_buf()),
            days: 30,
            format: crate::models::churn::ChurnOutputFormat::Summary,
            output: None,
            top_files: 10,
            include: vec![],
            exclude: vec![],
        };

        // Churn falls into the standard mode path
        let result = handler.handle_analyze_command(cmd).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_handle_analyze_command_dag_standard_mode() {
        let handler = ContractCliHandler::new().expect("Handler creation should succeed");
        let temp_dir = create_test_dir();

        let cmd = AnalyzeCommands::Dag {
            dag_type: crate::cli::DagType::FullDependency,
            path: PathBuf::from("."),
            project_path: Some(temp_dir.path().to_path_buf()),
            output: None,
            max_depth: None,
            target_nodes: None,
            filter_external: false,
            show_complexity: false,
            include_duplicates: false,
            include_dead_code: false,
            enhanced: false,
        };

        let result = handler.handle_analyze_command(cmd).await;
        assert!(result.is_ok());
    }