pmat 3.16.0

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
//! Test stability analysis handler
//!
//! Runs tests multiple times to detect flaky tests and
//! timeout-sensitive tests with high duration variance.

use anyhow::Result;
use std::collections::HashMap;
use std::path::Path;
use std::time::Instant;

/// Per-test timing data
#[derive(Debug, serde::Serialize)]
struct TestResult {
    name: String,
    pass_count: usize,
    fail_count: usize,
    pass_rate: f64,
    durations_ms: Vec<f64>,
    mean_ms: f64,
    p95_ms: f64,
    max_ms: f64,
    variance_ratio: f64,
    classification: String,
    recommendation: String,
}

/// Full stability analysis result
#[derive(Debug, serde::Serialize)]
struct StabilityAnalysis {
    total_tests: usize,
    runs: usize,
    stable_count: usize,
    flaky_count: usize,
    timeout_sensitive_count: usize,
    flaky_tests: Vec<TestResult>,
    timeout_sensitive_tests: Vec<TestResult>,
    total_duration_secs: f64,
}

/// Handle the test-stability command
pub async fn handle_test_stability(
    path: &Path,
    runs: usize,
    filter: Option<&str>,
    format: &crate::cli::enums::OutputFormat,
    output: Option<&Path>,
) -> Result<()> {
    use crate::cli::colors as c;
    let is_json = matches!(format, crate::cli::enums::OutputFormat::Json);

    if !is_json {
        println!("{}\n", c::header("Test Stability Analysis"));
        println!(
            "  {}Runs:{} {}  {}Filter:{} {}\n",
            c::BOLD,
            c::RESET,
            c::number(&runs.to_string()),
            c::BOLD,
            c::RESET,
            c::dim(filter.unwrap_or("(all)")),
        );
    }

    let start = Instant::now();
    let analysis = run_stability_analysis(path, runs, filter)?;
    let total_time = start.elapsed();

    let analysis = StabilityAnalysis {
        total_duration_secs: total_time.as_secs_f64(),
        ..analysis
    };

    let formatted = match format {
        crate::cli::enums::OutputFormat::Json => serde_json::to_string_pretty(&analysis)?,
        _ => format_text(&analysis),
    };

    if let Some(output_path) = output {
        std::fs::write(output_path, &formatted)?;
        eprintln!(
            "{} Written to: {}",
            c::pass(""),
            c::path(&output_path.display().to_string())
        );
    } else {
        println!("{formatted}");
    }

    Ok(())
}

/// Run the stability analysis
fn run_stability_analysis(
    path: &Path,
    runs: usize,
    filter: Option<&str>,
) -> Result<StabilityAnalysis> {
    use crate::cli::colors as c;

    // Collect per-test results across runs
    let mut test_results: HashMap<String, Vec<(bool, f64)>> = HashMap::new();

    for run in 1..=runs {
        eprintln!("  {}Run {}/{}{}...", c::BOLD, run, runs, c::RESET,);

        let results = run_test_suite(path, filter)?;
        for (name, passed, duration_ms) in results {
            test_results
                .entry(name)
                .or_default()
                .push((passed, duration_ms));
        }
    }

    // Analyze results
    let total_tests = test_results.len();
    let mut flaky_tests = Vec::new();
    let mut timeout_sensitive_tests = Vec::new();

    for (name, results) in &test_results {
        let pass_count = results.iter().filter(|(p, _)| *p).count();
        let fail_count = results.len() - pass_count;
        let pass_rate = pass_count as f64 / results.len() as f64;

        let durations: Vec<f64> = results.iter().map(|(_, d)| *d).collect();
        let mean = durations.iter().sum::<f64>() / durations.len() as f64;
        let max = durations.iter().cloned().fold(0.0f64, f64::max);

        let mut sorted_durations = durations.clone();
        sorted_durations.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));
        let p95_idx =
            ((sorted_durations.len() as f64 * 0.95) as usize).min(sorted_durations.len() - 1);
        let p95 = sorted_durations[p95_idx];

        let variance_ratio = if mean > 0.0 { max / mean } else { 1.0 };

        let is_flaky = pass_rate < 1.0 && pass_rate > 0.0;
        let is_timeout_sensitive = variance_ratio > 2.0 && mean > 100.0; // >100ms mean, >2x variance

        let (classification, recommendation) = if is_flaky {
            (
                "Flaky".to_string(),
                format!(
                    "Pass rate: {:.0}%. Consider adding retry logic or investigating non-determinism",
                    pass_rate * 100.0
                ),
            )
        } else if is_timeout_sensitive {
            (
                "Timeout-Sensitive".to_string(),
                format!(
                    "High variance ({:.1}x). Recommend adaptive timeout: {:.0}ms (2x P95)",
                    variance_ratio,
                    p95 * 2.0
                ),
            )
        } else {
            ("Stable".to_string(), String::new())
        };

        let test_result = TestResult {
            name: name.clone(),
            pass_count,
            fail_count,
            pass_rate,
            durations_ms: durations,
            mean_ms: mean,
            p95_ms: p95,
            max_ms: max,
            variance_ratio,
            classification,
            recommendation,
        };

        if is_flaky {
            flaky_tests.push(test_result);
        } else if is_timeout_sensitive {
            timeout_sensitive_tests.push(test_result);
        }
    }

    // Sort by severity
    flaky_tests.sort_by(|a, b| {
        a.pass_rate
            .partial_cmp(&b.pass_rate)
            .unwrap_or(std::cmp::Ordering::Equal)
    });
    timeout_sensitive_tests.sort_by(|a, b| {
        b.variance_ratio
            .partial_cmp(&a.variance_ratio)
            .unwrap_or(std::cmp::Ordering::Equal)
    });

    let stable_count = total_tests - flaky_tests.len() - timeout_sensitive_tests.len();

    Ok(StabilityAnalysis {
        total_tests,
        runs,
        stable_count,
        flaky_count: flaky_tests.len(),
        timeout_sensitive_count: timeout_sensitive_tests.len(),
        flaky_tests,
        timeout_sensitive_tests,
        total_duration_secs: 0.0, // filled in by caller
    })
}

/// Run the test suite once and parse results
fn run_test_suite(path: &Path, filter: Option<&str>) -> Result<Vec<(String, bool, f64)>> {
    let mut args = vec!["test".to_string(), "--lib".to_string()];

    if let Some(f) = filter {
        args.push(f.to_string());
    }

    args.push("--".to_string());
    args.push("--test-threads=4".to_string());

    let start = std::time::Instant::now();
    let output = std::process::Command::new("cargo")
        .args(&args)
        .current_dir(path)
        .env("RUST_MIN_STACK", "8388608")
        .output()?;
    let elapsed_ms = start.elapsed().as_secs_f64() * 1000.0;

    let stdout = String::from_utf8_lossy(&output.stdout);
    let stderr = String::from_utf8_lossy(&output.stderr);
    let mut results = Vec::new();

    // Parse text test output (stable Rust compatible)
    parse_text_test_output(&stdout, &mut results);

    // Also check stderr (cargo test puts some output there)
    if results.is_empty() {
        parse_text_test_output(&stderr, &mut results);
    }

    // If we got results but no timing, estimate from total elapsed
    if !results.is_empty() && results.iter().all(|(_, _, d)| *d == 0.0) {
        let per_test = elapsed_ms / results.len() as f64;
        for r in &mut results {
            r.2 = per_test;
        }
    }

    Ok(results)
}

/// Fallback parser for text test output
fn parse_text_test_output(output: &str, results: &mut Vec<(String, bool, f64)>) {
    for line in output.lines() {
        let line = line.trim();
        if line.starts_with("test ") && (line.ends_with("... ok") || line.ends_with("... FAILED")) {
            let passed = line.ends_with("... ok");
            let name = line
                .strip_prefix("test ")
                .unwrap_or(line)
                .trim_end_matches(" ... ok")
                .trim_end_matches(" ... FAILED")
                .to_string();
            // No timing info available in text mode
            results.push((name, passed, 0.0));
        }
    }
}

/// Format results as colorized text
fn format_text(analysis: &StabilityAnalysis) -> String {
    use crate::cli::colors as c;
    use std::fmt::Write;

    let mut out = String::new();

    let _ = writeln!(out, "{}", c::subheader("Summary"));
    let _ = writeln!(
        out,
        "  {}Total tests:{} {}",
        c::BOLD,
        c::RESET,
        c::number(&analysis.total_tests.to_string())
    );
    let _ = writeln!(
        out,
        "  {}Stable:{} {} ({:.1}%)",
        c::BOLD,
        c::RESET,
        c::number(&analysis.stable_count.to_string()),
        analysis.stable_count as f64 / analysis.total_tests.max(1) as f64 * 100.0,
    );

    if analysis.flaky_count > 0 {
        let _ = writeln!(
            out,
            "  {}Flaky:{} {}{}{}",
            c::BOLD,
            c::RESET,
            c::RED,
            analysis.flaky_count,
            c::RESET,
        );
    }
    if analysis.timeout_sensitive_count > 0 {
        let _ = writeln!(
            out,
            "  {}Timeout-sensitive:{} {}{}{}",
            c::BOLD,
            c::RESET,
            c::YELLOW,
            analysis.timeout_sensitive_count,
            c::RESET,
        );
    }
    let _ = writeln!(
        out,
        "  {}Duration:{} {:.1}s\n",
        c::BOLD,
        c::RESET,
        analysis.total_duration_secs,
    );

    if !analysis.flaky_tests.is_empty() {
        let _ = writeln!(out, "{}\n", c::subheader("Flaky Tests"));
        for test in &analysis.flaky_tests {
            let _ = writeln!(out, "  {} {}", c::fail(""), c::label(&test.name),);
            let _ = writeln!(
                out,
                "     Pass rate: {}{:.0}%{}  Mean: {:.0}ms  Max: {:.0}ms",
                c::RED,
                test.pass_rate * 100.0,
                c::RESET,
                test.mean_ms,
                test.max_ms,
            );
            let _ = writeln!(out, "     {}", c::dim(&test.recommendation));
            let _ = writeln!(out);
        }
    }

    if !analysis.timeout_sensitive_tests.is_empty() {
        let _ = writeln!(out, "{}\n", c::subheader("Timeout-Sensitive Tests"));
        for test in &analysis.timeout_sensitive_tests {
            let _ = writeln!(out, "  {} {}", c::warn(""), c::label(&test.name),);
            let _ = writeln!(
                out,
                "     Variance: {}{:.1}x{}  Mean: {:.0}ms  P95: {:.0}ms  Max: {:.0}ms",
                c::YELLOW,
                test.variance_ratio,
                c::RESET,
                test.mean_ms,
                test.p95_ms,
                test.max_ms,
            );
            let _ = writeln!(out, "     {}", c::dim(&test.recommendation));
            let _ = writeln!(out);
        }
    }

    if analysis.flaky_count == 0 && analysis.timeout_sensitive_count == 0 {
        let _ = writeln!(out, "  {}", c::pass("All tests are stable"));
    }

    out
}

#[cfg_attr(coverage_nightly, coverage(off))]
#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_parse_text_test_output_ok() {
        let mut results = Vec::new();
        parse_text_test_output("test my_test ... ok", &mut results);
        assert_eq!(results.len(), 1);
        assert_eq!(results[0].0, "my_test");
        assert!(results[0].1);
    }

    #[test]
    fn test_parse_text_test_output_failed() {
        let mut results = Vec::new();
        parse_text_test_output("test my_test ... FAILED", &mut results);
        assert_eq!(results.len(), 1);
        assert!(!results[0].1);
    }

    #[test]
    fn test_parse_text_test_output_mixed() {
        let output = "test a ... ok\ntest b ... FAILED\ntest c ... ok\n";
        let mut results = Vec::new();
        parse_text_test_output(output, &mut results);
        assert_eq!(results.len(), 3);
        assert!(results[0].1);
        assert!(!results[1].1);
        assert!(results[2].1);
    }

    #[test]
    fn test_format_text_empty() {
        let analysis = StabilityAnalysis {
            total_tests: 100,
            runs: 3,
            stable_count: 100,
            flaky_count: 0,
            timeout_sensitive_count: 0,
            flaky_tests: vec![],
            timeout_sensitive_tests: vec![],
            total_duration_secs: 10.0,
        };
        let text = format_text(&analysis);
        assert!(text.contains("All tests are stable"));
    }

    #[test]
    fn test_format_text_with_flaky() {
        let analysis = StabilityAnalysis {
            total_tests: 100,
            runs: 3,
            stable_count: 99,
            flaky_count: 1,
            timeout_sensitive_count: 0,
            flaky_tests: vec![TestResult {
                name: "test_flaky_one".to_string(),
                pass_count: 2,
                fail_count: 1,
                pass_rate: 0.67,
                durations_ms: vec![100.0, 200.0, 150.0],
                mean_ms: 150.0,
                p95_ms: 200.0,
                max_ms: 200.0,
                variance_ratio: 1.33,
                classification: "Flaky".to_string(),
                recommendation: "Investigate non-determinism".to_string(),
            }],
            timeout_sensitive_tests: vec![],
            total_duration_secs: 30.0,
        };
        let text = format_text(&analysis);
        assert!(text.contains("test_flaky_one"));
        assert!(text.contains("Flaky"));
    }

    // ── Wave 39 PR21: cover the timeout-sensitive + combined branches ──

    fn make_timeout_sensitive_test(name: &str) -> TestResult {
        TestResult {
            name: name.to_string(),
            pass_count: 3,
            fail_count: 0,
            pass_rate: 1.0,
            durations_ms: vec![50.0, 200.0, 600.0],
            mean_ms: 283.3,
            p95_ms: 580.0,
            max_ms: 600.0,
            variance_ratio: 2.12,
            classification: "Timeout-Sensitive".to_string(),
            recommendation: "Recommend adaptive timeout: 1160ms (2x P95)".to_string(),
        }
    }

    #[test]
    fn test_format_text_with_timeout_sensitive_only() {
        // Exercises the timeout_sensitive_tests block (line 340-356).
        let analysis = StabilityAnalysis {
            total_tests: 100,
            runs: 3,
            stable_count: 99,
            flaky_count: 0,
            timeout_sensitive_count: 1,
            flaky_tests: vec![],
            timeout_sensitive_tests: vec![make_timeout_sensitive_test("slow_test")],
            total_duration_secs: 30.0,
        };
        let text = format_text(&analysis);
        assert!(text.contains("Timeout-Sensitive Tests"));
        assert!(text.contains("slow_test"));
        assert!(text.contains("Variance"));
        // PIN: variance_ratio formatted with 1 decimal + "x" suffix.
        assert!(text.contains("2.1x"));
    }

    #[test]
    fn test_format_text_with_both_flaky_and_timeout_sensitive() {
        // Hits both blocks (flaky_tests AND timeout_sensitive_tests).
        let analysis = StabilityAnalysis {
            total_tests: 100,
            runs: 3,
            stable_count: 98,
            flaky_count: 1,
            timeout_sensitive_count: 1,
            flaky_tests: vec![TestResult {
                name: "flaky_a".to_string(),
                pass_count: 1,
                fail_count: 2,
                pass_rate: 0.33,
                durations_ms: vec![100.0],
                mean_ms: 100.0,
                p95_ms: 100.0,
                max_ms: 100.0,
                variance_ratio: 1.0,
                classification: "Flaky".to_string(),
                recommendation: "retry".to_string(),
            }],
            timeout_sensitive_tests: vec![make_timeout_sensitive_test("slow_b")],
            total_duration_secs: 60.0,
        };
        let text = format_text(&analysis);
        assert!(text.contains("flaky_a"));
        assert!(text.contains("slow_b"));
        assert!(text.contains("Flaky Tests"));
        assert!(text.contains("Timeout-Sensitive Tests"));
        // "All tests are stable" should NOT appear when there are flaky/timeout tests.
        assert!(!text.contains("All tests are stable"));
    }

    #[test]
    fn test_format_text_summary_includes_run_counts_and_duration() {
        let analysis = StabilityAnalysis {
            total_tests: 250,
            runs: 5,
            stable_count: 250,
            flaky_count: 0,
            timeout_sensitive_count: 0,
            flaky_tests: vec![],
            timeout_sensitive_tests: vec![],
            total_duration_secs: 47.3,
        };
        let text = format_text(&analysis);
        assert!(text.contains("Total tests:"));
        assert!(text.contains("250"));
        assert!(text.contains("Stable:"));
        // PIN: Duration uses `.1` decimal format with "s" suffix.
        assert!(text.contains("47.3s"));
        // PIN: stable percent computed as `stable / total.max(1) * 100`.
        assert!(text.contains("100.0%"));
    }

    #[test]
    fn test_format_text_handles_zero_total_tests_via_max_1() {
        // PIN: total_tests.max(1) prevents div/0 when no tests run.
        let analysis = StabilityAnalysis {
            total_tests: 0,
            runs: 1,
            stable_count: 0,
            flaky_count: 0,
            timeout_sensitive_count: 0,
            flaky_tests: vec![],
            timeout_sensitive_tests: vec![],
            total_duration_secs: 0.0,
        };
        let text = format_text(&analysis);
        // Should not panic.
        assert!(text.contains("Total tests:"));
        assert!(text.contains("All tests are stable"));
    }

    // ── parse_text_test_output edge cases ───────────────────────────────────

    #[test]
    fn test_parse_text_test_output_empty_input() {
        let mut results = Vec::new();
        parse_text_test_output("", &mut results);
        assert!(results.is_empty());
    }

    #[test]
    fn test_parse_text_test_output_no_test_lines() {
        let mut results = Vec::new();
        parse_text_test_output(
            "running 0 tests\ntest result: ok. 0 passed; 0 failed\n",
            &mut results,
        );
        assert!(results.is_empty());
    }

    #[test]
    fn test_parse_text_test_output_ignored_test_not_collected() {
        // PIN: the parser only matches `... ok` and `... FAILED`; ignored tests
        // (`... ignored`) are NOT collected.
        let mut results = Vec::new();
        parse_text_test_output("test ignored_one ... ignored", &mut results);
        assert!(results.is_empty());
    }

    #[test]
    fn test_parse_text_test_output_test_names_with_dots() {
        // PIN: trim_end_matches strips " ... ok" / " ... FAILED" suffix from
        // the entire string. Name with dots in module path survives.
        let mut results = Vec::new();
        parse_text_test_output("test foo::bar::test_baz ... ok", &mut results);
        assert_eq!(results.len(), 1);
        assert_eq!(results[0].0, "foo::bar::test_baz");
        assert!(results[0].1);
    }

    #[test]
    fn test_parse_text_test_output_zero_duration_for_text_mode() {
        // PIN: text mode has no timing info → duration always 0.0.
        let mut results = Vec::new();
        parse_text_test_output("test t ... ok", &mut results);
        assert_eq!(results[0].2, 0.0);
    }

    #[test]
    fn test_parse_text_test_output_appends_to_existing_results() {
        // PIN: parse_text_test_output APPENDS to the &mut Vec (does not clear).
        let mut results = vec![("preexisting".to_string(), true, 5.0)];
        parse_text_test_output("test new_test ... ok", &mut results);
        assert_eq!(results.len(), 2);
        assert_eq!(results[0].0, "preexisting");
        assert_eq!(results[1].0, "new_test");
    }
}