pmat 3.15.0

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144

    // =========================================================================
    // detect_barrier_issues tests (32.3% covered -> targeting uncovered branches)
    // =========================================================================

    // --- detect_barrier_issues: basic barrier detection ---

    #[test]
    fn test_barrier_syncthreads_no_early_return() {
        let content = "void kernel() {\n    __syncthreads();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 1);
        assert_eq!(analysis.barrier_safety.safe_barriers, 1);
        assert!(analysis.barrier_safety.unsafe_barriers.is_empty());
        assert!((analysis.barrier_safety.safety_score - 1.0).abs() < f64::EPSILON);
    }

    #[test]
    fn test_barrier_syncwarp_no_early_return() {
        let content = "void kernel() {\n    __syncwarp();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 1);
        assert_eq!(analysis.barrier_safety.safe_barriers, 1);
        assert!(analysis.barrier_safety.unsafe_barriers.is_empty());
    }

    #[test]
    fn test_barrier_bar_sync_no_early_return() {
        let content = "void kernel() {\n    bar.sync;\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 1);
        assert_eq!(analysis.barrier_safety.safe_barriers, 1);
    }

    #[test]
    fn test_barrier_syncthreads_with_early_return_in_scope() {
        // return; at brace_depth == 0 before __syncthreads => unsafe
        let content = "void kernel() {\n    if (tid > N) return;\n    __syncthreads();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 1);
        assert_eq!(analysis.barrier_safety.unsafe_barriers.len(), 1);
        assert_eq!(analysis.barrier_safety.unsafe_barriers[0].barrier_type, "__syncthreads");
        assert!(analysis.barrier_safety.unsafe_barriers[0].issue.contains("PARITY-114"));
    }

    #[test]
    fn test_barrier_syncwarp_with_early_return_in_scope() {
        let content = "void kernel() {\n    return;\n    __syncwarp();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 1);
        assert_eq!(analysis.barrier_safety.unsafe_barriers.len(), 1);
        assert_eq!(analysis.barrier_safety.unsafe_barriers[0].barrier_type, "__syncwarp");
    }

    #[test]
    fn test_barrier_bar_sync_with_early_return_in_scope() {
        let content = "void kernel() {\n    return;\n    bar.sync;\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 1);
        assert_eq!(analysis.barrier_safety.unsafe_barriers.len(), 1);
        assert_eq!(analysis.barrier_safety.unsafe_barriers[0].barrier_type, "bar.sync");
    }

    #[test]
    fn test_barrier_early_return_in_nested_scope_not_detected() {
        // return is inside a nested block (brace_depth != 0),
        // so the reverse scan should NOT flag it.
        let content = "void kernel() {\n    {\n        return;\n    }\n    __syncthreads();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 1);
        // The return is in inner scope - reverse scan will see } then {, depth goes to -1 and breaks
        assert_eq!(analysis.barrier_safety.safe_barriers, 1);
    }

    #[test]
    fn test_barrier_early_exit_before_barrier() {
        let content = "void kernel() {\n    exit;\n    __syncthreads();\n}";
        let analysis = analyze_cuda_barriers(content);
        // "exit" triggers the before_barrier check but the reverse scan looks for "return;" or "return "
        // exit alone does not match return pattern, so it goes to safe path
        assert_eq!(analysis.barrier_safety.total_barriers, 1);
    }

    #[test]
    fn test_barrier_multiple_barriers_mixed_safety() {
        let content = "void kernel() {\n    __syncthreads();\n    return;\n    __syncwarp();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 2);
        // First barrier: no return before it => safe
        // Second barrier: return before it at depth 0 => unsafe
        assert_eq!(analysis.barrier_safety.safe_barriers, 1);
        assert_eq!(analysis.barrier_safety.unsafe_barriers.len(), 1);
        assert_eq!(analysis.barrier_safety.unsafe_barriers[0].barrier_type, "__syncwarp");
    }

    #[test]
    fn test_barrier_safety_score_partial() {
        // 2 barriers, 1 safe, 1 unsafe => safety_score = 0.5
        let content = "void kernel() {\n    __syncthreads();\n    return;\n    __syncthreads();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 2);
        assert!((analysis.barrier_safety.safety_score - 0.5).abs() < f64::EPSILON);
    }

    #[test]
    fn test_barrier_no_barriers_zero_score() {
        let content = "void kernel() {\n    int x = 1;\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 0);
        assert_eq!(analysis.barrier_safety.safe_barriers, 0);
        // safety_score stays default (0.0) when no barriers
        assert!((analysis.barrier_safety.safety_score - 0.0).abs() < f64::EPSILON);
    }

    #[test]
    fn test_barrier_defect_added_for_unsafe_barrier() {
        let content = "void kernel() {\n    return;\n    __syncthreads();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert!(has_defect(&analysis, "PARITY-114"));
    }

    #[test]
    fn test_barrier_no_defect_for_safe_barrier() {
        let content = "void kernel() {\n    __syncthreads();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert!(!has_defect(&analysis, "PARITY-114"));
    }

    #[test]
    fn test_barrier_return_with_value_before_barrier() {
        // "return 0" has "return " which should also trigger
        let content = "void kernel() {\n    return 0;\n    __syncthreads();\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.unsafe_barriers.len(), 1);
    }

    #[test]
    fn test_barrier_many_safe_barriers() {
        let content = "void kernel() {\n    __syncthreads();\n    __syncwarp();\n    bar.sync;\n}";
        let analysis = analyze_cuda_barriers(content);
        assert_eq!(analysis.barrier_safety.total_barriers, 3);
        assert_eq!(analysis.barrier_safety.safe_barriers, 3);
        assert!(analysis.barrier_safety.unsafe_barriers.is_empty());
        assert!((analysis.barrier_safety.safety_score - 1.0).abs() < f64::EPSILON);
    }