pmat 3.15.0

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298

// CB-600 Lua Best Practices tests Part 1: Helpers, CB-600 Implicit Globals, CB-601 Nil-Unsafe Access
// Included from tests.rs via include!() - shares parent module scope

// =========================================================================
// Helper function tests
// =========================================================================

#[test]
fn test_is_lua_test_file() {
    assert!(is_lua_test_file(std::path::Path::new("foo_test.lua")));
    assert!(is_lua_test_file(std::path::Path::new("bar_spec.lua")));
    assert!(is_lua_test_file(std::path::Path::new("test_baz.lua")));
    assert!(is_lua_test_file(std::path::Path::new("tests/util.lua")));
    assert!(is_lua_test_file(std::path::Path::new("spec/helper.lua")));
    assert!(!is_lua_test_file(std::path::Path::new("app.lua")));
    assert!(!is_lua_test_file(std::path::Path::new("module.lua")));
}

#[test]
fn test_compute_lua_production_lines_filters_comments() {
    let content = "-- comment\nlocal x = 1\n--[[ block\ncomment ]]\nlocal y = 2\n";
    let lines = compute_lua_production_lines(content);
    assert_eq!(lines.len(), 2);
    assert_eq!(lines[0].1, "local x = 1");
    assert_eq!(lines[1].1, "local y = 2");
}

#[test]
fn test_walkdir_lua_files_skips_git() {
    let temp = TempDir::new().unwrap();
    let git_dir = temp.path().join(".git");
    fs::create_dir_all(&git_dir).unwrap();
    fs::write(git_dir.join("hook.lua"), "local x = 1").unwrap();
    fs::write(temp.path().join("app.lua"), "local y = 2").unwrap();
    let files = walkdir_lua_files(temp.path());
    assert_eq!(files.len(), 1);
    assert!(files[0].file_name().unwrap() == "app.lua");
}

// =========================================================================
// CB-600: Implicit Globals
// =========================================================================

#[test]
fn test_cb600_detects_implicit_global() {
    let temp = TempDir::new().unwrap();
    fs::write(temp.path().join("app.lua"), "counter = 0\nlocal x = 1\n").unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert_eq!(violations.len(), 1);
    assert_eq!(violations[0].pattern_id, "CB-600");
    assert!(violations[0].description.contains("counter"));
}

#[test]
fn test_cb600_skips_local_vars() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "local counter = 0\nlocal name = 'test'\n",
    )
    .unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(violations.is_empty());
}

#[test]
fn test_cb600_skips_std_globals() {
    let temp = TempDir::new().unwrap();
    fs::write(temp.path().join("app.lua"), "print = custom_print\n").unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(violations.is_empty());
}

#[test]
fn test_cb600_skips_table_field_assignment() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "M.name = 'test'\nself.value = 42\ntbl[key] = true\n",
    )
    .unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(violations.is_empty());
}

#[test]
fn test_cb600_skips_table_constructor_fields() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "local t = {\n  id = id,\n  name = name,\n  score = 100,\n}\n",
    )
    .unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(
        violations.is_empty(),
        "table constructor fields are not globals: {:?}",
        violations
    );
}

#[test]
fn test_cb600_skips_inline_table_constructor() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "local t = { id = id, name = name }\n",
    )
    .unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(
        violations.is_empty(),
        "inline table constructor fields are not globals: {:?}",
        violations
    );
}

#[test]
fn test_cb600_skips_test_files() {
    let temp = TempDir::new().unwrap();
    fs::write(temp.path().join("app_test.lua"), "counter = 0\n").unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(violations.is_empty());
}

#[test]
fn test_cb600_no_lua_files_empty() {
    let temp = TempDir::new().unwrap();
    fs::write(temp.path().join("app.rs"), "fn main() {}").unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(violations.is_empty());
}

#[test]
fn test_cb600_skips_function_params() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "function M.levenshtein(a, b)\n  a = a or \"\"\n  b = b or \"\"\nend\n",
    )
    .unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(
        violations.is_empty(),
        "function params should not be flagged: {:?}",
        violations
    );
}

#[test]
fn test_cb600_skips_for_loop_vars() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "for i = 1, 10 do\n  i = i + 1\nend\nfor k, v in pairs(t) do\n  k = tostring(k)\nend\n",
    )
    .unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(
        violations.is_empty(),
        "for-loop vars should not be flagged: {:?}",
        violations
    );
}

#[test]
fn test_cb600_skips_local_decl_reassignment() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "local result = 0\nresult = result + 1\n",
    )
    .unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(
        violations.is_empty(),
        "local var reassignment should not be flagged: {:?}",
        violations
    );
}

#[test]
fn test_cb600_skips_multi_local_decl() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "local a, b = 1, 2\na = a + 1\nb = b + 1\n",
    )
    .unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert!(
        violations.is_empty(),
        "multi-local reassignment should not be flagged: {:?}",
        violations
    );
}

#[test]
fn test_cb600_still_detects_true_globals() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "function foo(x)\n  x = x + 1\nend\nglobal_thing = 42\n",
    )
    .unwrap();
    let violations = detect_cb600_implicit_globals(temp.path());
    assert_eq!(violations.len(), 1, "true global should still be caught");
    assert!(violations[0].description.contains("global_thing"));
}

// =========================================================================
// CB-601: Nil-Unsafe Access
// =========================================================================

#[test]
fn test_cb601_detects_chained_call() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "local name = get_user().name\n",
    )
    .unwrap();
    let violations = detect_cb601_nil_unsafe_access(temp.path());
    assert_eq!(violations.len(), 1);
    assert_eq!(violations[0].pattern_id, "CB-601");
    assert!(violations[0].description.contains("chained"));
}

#[test]
fn test_cb601_detects_deep_chain() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "local x = config.server.host.port\n",
    )
    .unwrap();
    let violations = detect_cb601_nil_unsafe_access(temp.path());
    assert_eq!(violations.len(), 1);
    assert!(violations[0].description.contains("deep field"));
}

#[test]
fn test_cb601_shallow_access_passes() {
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        "local x = config.host\nlocal y = tbl.key\n",
    )
    .unwrap();
    let violations = detect_cb601_nil_unsafe_access(temp.path());
    assert!(violations.is_empty());
}

#[test]
fn test_cb601_string_key_with_dots_not_false_positive() {
    // ["H.N.S.W."] and ["C.I.C.D."] are string-literal table keys,
    // not deep field access chains
    let temp = TempDir::new().unwrap();
    fs::write(
        temp.path().join("app.lua"),
        concat!(
            "local corrections = {}\n",
            "corrections[\"H.N.S.W.\"] = \"HNSW\"\n",
            "corrections[\"C.I.C.D.\"] = \"CICD\"\n",
            "corrections['R.A.G.'] = \"RAG\"\n",
        ),
    )
    .unwrap();
    let violations = detect_cb601_nil_unsafe_access(temp.path());
    assert!(
        violations.is_empty(),
        "Dots inside string-literal table keys should not be flagged: {:?}",
        violations
    );
}

#[test]
fn test_cb601_real_deep_chain_still_detected() {
    // Ensure real deep chains are still caught after the string fix
    let temp = TempDir::new().unwrap();
    fs::write(temp.path().join("app.lua"), "local x = a.b.c.d\n").unwrap();
    let violations = detect_cb601_nil_unsafe_access(temp.path());
    assert_eq!(violations.len(), 1);
    assert!(violations[0].description.contains("deep field"));
}

#[test]
fn test_count_consecutive_field_access_skips_strings() {
    // Dots inside strings don't count
    assert!(count_consecutive_field_access("tbl[\"H.N.S.W.\"] = 1") < 4);
    assert!(count_consecutive_field_access("x['a.b.c.d.e'] = 1") < 4);
    // Real chains still count
    assert_eq!(count_consecutive_field_access("a.b.c.d"), 4);
    assert_eq!(count_consecutive_field_access("a.b.c"), 3);
    // Mixed: bracket access counts as 1 level but its contents don't add depth
    assert!(count_consecutive_field_access("tbl[\"key\"].field") < 4);
}