pmat 3.14.0

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
#![cfg_attr(coverage_nightly, coverage(off))]
//! Integration tests for handle_analyze_defects async handler

use super::handler::handle_analyze_defects;
use super::output::print_text_report;
use super::types::*;
use crate::services::defect_detector::Severity;
use tempfile::TempDir;

// =========================================================================
// handle_analyze_defects integration tests
// =========================================================================

#[tokio::test]
async fn test_handle_analyze_defects_empty_dir() {
    let temp_dir = TempDir::new().expect("temp dir");

    let result =
        handle_analyze_defects(Some(temp_dir.path()), None, None, OutputFormat::Text).await;

    assert!(result.is_ok());
    assert_eq!(result.unwrap(), 0); // No critical defects
}

#[tokio::test]
async fn test_handle_analyze_defects_no_defects() {
    let temp_dir = TempDir::new().expect("temp dir");

    // Create a clean Rust file (no .unwrap() calls)
    let src_dir = temp_dir.path().join("src");
    std::fs::create_dir_all(&src_dir).expect("create dir");
    std::fs::write(
        src_dir.join("main.rs"),
        r#"
fn main() {
    let x = Some(42);
    if let Some(val) = x {
        println!("Value: {}", val);
    }
}
"#,
    )
    .expect("write");

    let result =
        handle_analyze_defects(Some(temp_dir.path()), None, None, OutputFormat::Json).await;

    assert!(result.is_ok());
    assert_eq!(result.unwrap(), 0);
}

#[tokio::test]
async fn test_handle_analyze_defects_with_critical_defects() {
    let temp_dir = TempDir::new().expect("temp dir");

    // Create a file with .unwrap() calls (critical defect)
    let src_dir = temp_dir.path().join("src");
    std::fs::create_dir_all(&src_dir).expect("create dir");
    std::fs::write(
        src_dir.join("main.rs"),
        r#"
fn main() {
    let x = Some(42).unwrap();
    println!("Value: {}", x);
}
"#,
    )
    .expect("write");

    let result =
        handle_analyze_defects(Some(temp_dir.path()), None, None, OutputFormat::Text).await;

    assert!(result.is_ok());
    // Result depends on file system detection
    assert!(result.unwrap() >= 0);
}

#[tokio::test]
async fn test_handle_analyze_defects_specific_file() {
    let temp_dir = TempDir::new().expect("temp dir");

    let src_dir = temp_dir.path().join("src");
    std::fs::create_dir_all(&src_dir).expect("create dir");

    // Create two files, only scan one
    std::fs::write(src_dir.join("clean.rs"), "fn clean() { let x = Some(42); }").expect("write");
    std::fs::write(
        src_dir.join("dirty.rs"),
        "fn dirty() { let x = Some(42).unwrap(); }",
    )
    .expect("write");

    // Scan only the clean file
    let clean_file = src_dir.join("clean.rs");
    let result = handle_analyze_defects(
        Some(temp_dir.path()),
        Some(clean_file.as_path()),
        None,
        OutputFormat::Json,
    )
    .await;

    assert!(result.is_ok());
    assert_eq!(result.unwrap(), 0); // Clean file has no defects
}

#[tokio::test]
async fn test_handle_analyze_defects_severity_filter() {
    let temp_dir = TempDir::new().expect("temp dir");

    let src_dir = temp_dir.path().join("src");
    std::fs::create_dir_all(&src_dir).expect("create dir");
    std::fs::write(
        src_dir.join("main.rs"),
        "fn main() { let x = Some(42).unwrap(); }",
    )
    .expect("write");

    // Filter for only High severity (unwrap is Critical, so should be filtered out)
    let result = handle_analyze_defects(
        Some(temp_dir.path()),
        None,
        Some(Severity::High),
        OutputFormat::Text,
    )
    .await;

    assert!(result.is_ok());
    // After filtering, no critical defects remain in the filtered list
    assert_eq!(result.unwrap(), 0);
}

#[tokio::test]
async fn test_handle_analyze_defects_default_path() {
    // Test with None path (should use ".")
    let result = handle_analyze_defects(None, None, None, OutputFormat::Junit).await;

    // Should succeed (may or may not find defects depending on cwd)
    assert!(result.is_ok());
}

#[tokio::test]
async fn test_handle_analyze_defects_json_format() {
    let temp_dir = TempDir::new().expect("temp dir");

    let src_dir = temp_dir.path().join("src");
    std::fs::create_dir_all(&src_dir).expect("create dir");
    std::fs::write(src_dir.join("main.rs"), "fn main() {}").expect("write");

    let result =
        handle_analyze_defects(Some(temp_dir.path()), None, None, OutputFormat::Json).await;

    assert!(result.is_ok());
}

#[tokio::test]
async fn test_handle_analyze_defects_junit_format() {
    let temp_dir = TempDir::new().expect("temp dir");

    let src_dir = temp_dir.path().join("src");
    std::fs::create_dir_all(&src_dir).expect("create dir");
    std::fs::write(src_dir.join("main.rs"), "fn main() {}").expect("write");

    let result =
        handle_analyze_defects(Some(temp_dir.path()), None, None, OutputFormat::Junit).await;

    assert!(result.is_ok());
}

#[tokio::test]
async fn test_handle_analyze_defects_unreadable_file() {
    let temp_dir = TempDir::new().expect("temp dir");

    let src_dir = temp_dir.path().join("src");
    std::fs::create_dir_all(&src_dir).expect("create dir");

    // Create a valid file
    std::fs::write(src_dir.join("main.rs"), "fn main() {}").expect("write");

    // The handler gracefully handles unreadable files (skips them)
    let result =
        handle_analyze_defects(Some(temp_dir.path()), None, None, OutputFormat::Text).await;

    assert!(result.is_ok());
}

#[tokio::test]
async fn test_handle_analyze_defects_filter_critical() {
    let temp_dir = TempDir::new().expect("temp dir");

    let src_dir = temp_dir.path().join("src");
    std::fs::create_dir_all(&src_dir).expect("create dir");
    std::fs::write(
        src_dir.join("main.rs"),
        "fn main() { let x = Some(42).unwrap(); }",
    )
    .expect("write");

    // Filter for Critical severity (should keep the unwrap defect)
    let result = handle_analyze_defects(
        Some(temp_dir.path()),
        None,
        Some(Severity::Critical),
        OutputFormat::Json,
    )
    .await;

    assert!(result.is_ok());
    // Result depends on file system detection - may find 0 or more defects
    assert!(result.unwrap() >= 0);
}

// =========================================================================
// Nested directory and multi-file tests
// =========================================================================

#[tokio::test]
async fn test_handle_analyze_defects_nested_directories() {
    let temp_dir = TempDir::new().expect("temp dir");

    // Create nested directory structure
    let deep_dir = temp_dir.path().join("src").join("nested").join("deep");
    std::fs::create_dir_all(&deep_dir).expect("create dir");
    std::fs::write(
        deep_dir.join("module.rs"),
        "fn deep() { let x = Some(1).unwrap(); }",
    )
    .expect("write");

    let result =
        handle_analyze_defects(Some(temp_dir.path()), None, None, OutputFormat::Text).await;

    assert!(result.is_ok());
    // Result depends on file system detection
    assert!(result.unwrap() >= 0);
}

#[tokio::test]
async fn test_handle_analyze_defects_multiple_files_with_defects() {
    let temp_dir = TempDir::new().expect("temp dir");

    let src_dir = temp_dir.path().join("src");
    std::fs::create_dir_all(&src_dir).expect("create dir");

    // Create multiple files with defects
    std::fs::write(src_dir.join("file1.rs"), "fn f1() { Some(1).unwrap(); }").expect("write");
    std::fs::write(
        src_dir.join("file2.rs"),
        "fn f2() { Some(2).unwrap(); Some(3).unwrap(); }",
    )
    .expect("write");
    std::fs::write(src_dir.join("file3.rs"), "fn f3() { let x = 1; }").expect("write");

    let result =
        handle_analyze_defects(Some(temp_dir.path()), None, None, OutputFormat::Json).await;

    assert!(result.is_ok());
    // Result depends on file system detection
    assert!(result.unwrap() >= 0);
}

// =========================================================================
// print_text_report with all severity levels
// =========================================================================

#[test]
fn test_print_text_report_with_high_and_medium() {
    use crate::services::defect_detector::{DefectInstance, DefectPattern, Severity};

    let report = DefectReport {
        summary: DefectSummary {
            total_files_scanned: 10,
            files_with_defects: 2,
            total_defects: 2,
            by_severity: SeverityCount {
                critical: 0,
                high: 1,
                medium: 1,
                low: 0,
            },
        },
        defects: vec![
            DefectPattern {
                id: "HIGH-001".to_string(),
                name: "High Issue".to_string(),
                severity: Severity::High,
                fix_recommendation: "Fix soon".to_string(),
                bad_example: "bad()".to_string(),
                good_example: "good()".to_string(),
                evidence_description: "High evidence".to_string(),
                evidence_url: None,
                instances: vec![DefectInstance {
                    file: "src/lib.rs".to_string(),
                    line: 10,
                    column: 1,
                    code_snippet: "bad()".to_string(),
                }],
            },
            DefectPattern {
                id: "MED-001".to_string(),
                name: "Medium Issue".to_string(),
                severity: Severity::Medium,
                fix_recommendation: "Fix when possible".to_string(),
                bad_example: "meh()".to_string(),
                good_example: "better()".to_string(),
                evidence_description: "Medium evidence".to_string(),
                evidence_url: None,
                instances: vec![DefectInstance {
                    file: "src/util.rs".to_string(),
                    line: 20,
                    column: 5,
                    code_snippet: "meh()".to_string(),
                }],
            },
        ],
        exit_code: 0,
        has_critical_defects: false,
    };

    // Just ensure it doesn't panic
    print_text_report(&report);
}

#[test]
fn test_print_text_report_many_instances() {
    use crate::services::defect_detector::{DefectInstance, DefectPattern, Severity};

    // Create a defect with more than 10 instances to test truncation
    let instances: Vec<DefectInstance> = (0..15)
        .map(|i| DefectInstance {
            file: format!("src/file{}.rs", i),
            line: i + 1,
            column: 1,
            code_snippet: "bad()".to_string(),
        })
        .collect();

    let report = DefectReport {
        summary: DefectSummary {
            total_files_scanned: 15,
            files_with_defects: 15,
            total_defects: 15,
            by_severity: SeverityCount {
                critical: 15,
                high: 0,
                medium: 0,
                low: 0,
            },
        },
        defects: vec![DefectPattern {
            id: "CRIT-001".to_string(),
            name: "Many instances".to_string(),
            severity: Severity::Critical,
            fix_recommendation: "Fix all".to_string(),
            bad_example: "bad()".to_string(),
            good_example: "good()".to_string(),
            evidence_description: "Evidence".to_string(),
            evidence_url: None,
            instances,
        }],
        exit_code: 1,
        has_critical_defects: true,
    };

    // Tests the truncation logic (shows first 10, then "... (N more)")
    print_text_report(&report);
}

#[test]
fn test_print_text_report_all_severity_levels() {
    use crate::services::defect_detector::{DefectInstance, DefectPattern, Severity};

    let report = DefectReport {
        summary: DefectSummary {
            total_files_scanned: 4,
            files_with_defects: 4,
            total_defects: 4,
            by_severity: SeverityCount {
                critical: 1,
                high: 1,
                medium: 1,
                low: 1,
            },
        },
        defects: vec![
            DefectPattern {
                id: "CRIT-001".to_string(),
                name: "Critical".to_string(),
                severity: Severity::Critical,
                fix_recommendation: "Fix".to_string(),
                bad_example: "bad".to_string(),
                good_example: "good".to_string(),
                evidence_description: "Evidence".to_string(),
                evidence_url: None,
                instances: vec![DefectInstance {
                    file: "c.rs".to_string(),
                    line: 1,
                    column: 1,
                    code_snippet: "bad".to_string(),
                }],
            },
            DefectPattern {
                id: "HIGH-001".to_string(),
                name: "High".to_string(),
                severity: Severity::High,
                fix_recommendation: "Fix".to_string(),
                bad_example: "bad".to_string(),
                good_example: "good".to_string(),
                evidence_description: "Evidence".to_string(),
                evidence_url: None,
                instances: vec![DefectInstance {
                    file: "h.rs".to_string(),
                    line: 1,
                    column: 1,
                    code_snippet: "bad".to_string(),
                }],
            },
            DefectPattern {
                id: "MED-001".to_string(),
                name: "Medium".to_string(),
                severity: Severity::Medium,
                fix_recommendation: "Fix".to_string(),
                bad_example: "bad".to_string(),
                good_example: "good".to_string(),
                evidence_description: "Evidence".to_string(),
                evidence_url: None,
                instances: vec![DefectInstance {
                    file: "m.rs".to_string(),
                    line: 1,
                    column: 1,
                    code_snippet: "bad".to_string(),
                }],
            },
            DefectPattern {
                id: "LOW-001".to_string(),
                name: "Low".to_string(),
                severity: Severity::Low,
                fix_recommendation: "Fix".to_string(),
                bad_example: "bad".to_string(),
                good_example: "good".to_string(),
                evidence_description: "Evidence".to_string(),
                evidence_url: None,
                instances: vec![DefectInstance {
                    file: "l.rs".to_string(),
                    line: 1,
                    column: 1,
                    code_snippet: "bad".to_string(),
                }],
            },
        ],
        exit_code: 1,
        has_critical_defects: true,
    };

    // Should print all severity levels (Critical, High, Medium - Low is not printed separately)
    print_text_report(&report);
}