pmat 3.11.0

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
// EXTREME TDD: Intent Classifier Tests (RED Phase)
//
// Test-Driven Development for distinguishing hallucination fixes from planned iterations
// Specification: Section 2.1 - Multi-Signal Temporal Analysis
// Target: <5% false positive rate

use pmat::red_team::{CommitInfo, CommitIntent, IntentClassifier, TestChanges};

// Helper function to create test commits
fn create_commit(
    message: &str,
    timestamp_seconds: i64,
    files: Vec<&str>,
    issue_num: Option<u32>,
    issue_created: Option<i64>,
    branch: &str,
    added_tests: usize,
    fixed_tests: usize,
) -> CommitInfo {
    CommitInfo {
        message: message.to_string(),
        timestamp_seconds,
        modified_files: files.iter().map(|s| s.to_string()).collect(),
        issue_number: issue_num,
        issue_created_timestamp: issue_created,
        branch: branch.to_string(),
        test_changes: TestChanges {
            added_tests,
            fixed_tests,
            modified_test_files: vec![],
        },
    }
}

// RED Test 1: Hallucination fix detected via "fix" keyword
#[test]
fn test_detect_hallucination_fix_via_keyword() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: All tests passing",
        1000,
        vec!["src/lib.rs"],
        None,
        None,
        "feature/auth",
        0,
        0,
    );

    let followup = create_commit(
        "fix: Actually fix failing tests",
        2000,
        vec!["src/lib.rs"],
        None,
        None,
        "feature/auth",
        0,
        5, // Fixed 5 tests
    );

    let result = classifier.classify(&original, &followup);

    assert_eq!(result.intent, CommitIntent::HallucinationFix);
    assert!(result.confidence > 0.5);
}

// RED Test 2: Planned iteration detected via "refactor" keyword
#[test]
fn test_detect_planned_iteration_via_keyword() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Complete user authentication",
        1000,
        vec!["src/auth.rs"],
        None,
        None,
        "feature/auth",
        0,
        0,
    );

    let followup = create_commit(
        "refactor: Improve authentication error handling",
        2000,
        vec!["src/auth.rs"],
        None,
        None,
        "feature/auth",
        3, // Added 3 tests
        0,
    );

    let result = classifier.classify(&original, &followup);

    assert_eq!(result.intent, CommitIntent::PlannedIteration);
    assert!(result.confidence > 0.5);
}

// RED Test 3: Issue created AFTER original commit = hallucination
#[test]
fn test_issue_created_after_commit_indicates_hallucination() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Bug-free implementation",
        1000,
        vec!["src/lib.rs"],
        None,
        None,
        "master",
        0,
        0,
    );

    let followup = create_commit(
        "fix: Resolve issue #42",
        5000,
        vec!["src/lib.rs"],
        Some(42),
        Some(2000), // Issue created at 2000, after original commit at 1000
        "master",
        0,
        1,
    );

    let result = classifier.classify(&original, &followup);

    assert_eq!(result.intent, CommitIntent::HallucinationFix);
    assert!(result.confidence > 0.7); // High confidence from issue tracker signal
}

// RED Test 4: Pre-existing issue = planned work
#[test]
fn test_preexisting_issue_indicates_planned_work() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Implement feature X",
        5000,
        vec!["src/feature_x.rs"],
        None,
        None,
        "feature/x",
        0,
        0,
    );

    let followup = create_commit(
        "feat: Add error handling for feature X (closes #42)",
        10000,
        vec!["src/feature_x.rs"],
        Some(42),
        Some(1000), // Issue created at 1000, before original commit at 5000
        "feature/x",
        2,
        0,
    );

    let result = classifier.classify(&original, &followup);

    assert_eq!(result.intent, CommitIntent::PlannedIteration);
    assert!(result.confidence > 0.6);
}

// RED Test 5: High file overlap (>80%) = hallucination fix
#[test]
fn test_high_file_overlap_indicates_hallucination_fix() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Complete module implementation",
        1000,
        vec!["src/mod1.rs", "src/mod2.rs", "src/mod3.rs"],
        None,
        None,
        "feature/module",
        0,
        0,
    );

    let followup = create_commit(
        "fix: Correct module logic",        // Hallucination keyword
        1000 + (100 * 3600),                // After grace period
        vec!["src/mod1.rs", "src/mod2.rs"], // 100% of followup files overlap
        None,
        None,
        "hotfix/module-bug", // Different branch
        0,
        2, // Fixed tests
    );

    let result = classifier.classify(&original, &followup);

    // High overlap + hallucination signals = hallucination fix
    assert_eq!(result.intent, CommitIntent::HallucinationFix);
}

// RED Test 6: Low file overlap (<20%) = planned iteration
#[test]
fn test_low_file_overlap_indicates_planned_iteration() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Complete module A",
        1000,
        vec!["src/mod_a.rs"],
        None,
        None,
        "feature/modules",
        0,
        0,
    );

    let followup = create_commit(
        "feat: Add module B",
        2000,
        vec![
            "src/mod_b.rs",
            "src/mod_c.rs",
            "src/mod_d.rs",
            "src/mod_e.rs",
            "src/mod_f.rs",
        ],
        None,
        None,
        "feature/modules",
        10, // Added tests
        0,
    );

    let result = classifier.classify(&original, &followup);

    // 0% overlap suggests new work
    assert_eq!(result.intent, CommitIntent::PlannedIteration);
}

// RED Test 7: More test fixes than additions = hallucination
#[test]
fn test_test_fixes_indicate_hallucination() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "test: All tests passing",
        1000,
        vec!["tests/integration.rs"],
        None,
        None,
        "master",
        0,
        0,
    );

    let followup = create_commit(
        "test: Fix test failures",
        2000,
        vec!["tests/integration.rs"],
        None,
        None,
        "master",
        1,  // Added 1 test
        10, // Fixed 10 tests
    );

    let result = classifier.classify(&original, &followup);

    assert_eq!(result.intent, CommitIntent::HallucinationFix);
}

// RED Test 8: More test additions than fixes = planned iteration
#[test]
fn test_test_additions_indicate_planned_iteration() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Basic feature implementation",
        1000,
        vec!["src/feature.rs"],
        None,
        None,
        "feature/new",
        0,
        0,
    );

    let followup = create_commit(
        "test: Expand test coverage",
        2000,
        vec!["tests/feature_tests.rs"],
        None,
        None,
        "feature/new",
        15, // Added 15 tests
        2,  // Fixed 2 tests
    );

    let result = classifier.classify(&original, &followup);

    assert_eq!(result.intent, CommitIntent::PlannedIteration);
}

// RED Test 9: Within 48-hour grace period = planned iteration
#[test]
fn test_grace_period_indicates_planned_iteration() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Complete feature X",
        1000,
        vec!["src/feature_x.rs"],
        None,
        None,
        "feature/x",
        0,
        0,
    );

    let followup = create_commit(
        "refactor: Improve error handling in feature X", // Iteration keyword
        1000 + (24 * 3600), // 24 hours later (within 48-hour grace period)
        vec!["src/feature_x.rs", "src/feature_x_errors.rs"], // Some overlap, some new
        None,
        None,
        "feature/x", // Same branch
        5,           // Adding tests
        0,
    );

    let result = classifier.classify(&original, &followup);

    // Grace period + iteration signals should favor planned iteration
    assert_eq!(result.intent, CommitIntent::PlannedIteration);
}

// RED Test 10: After grace period + different branch = hallucination
#[test]
fn test_after_grace_period_different_branch_indicates_hallucination() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Complete feature X",
        1000,
        vec!["src/feature_x.rs"],
        None,
        None,
        "feature/x",
        0,
        0,
    );

    let followup = create_commit(
        "fix: Bug in feature X",
        1000 + (72 * 3600), // 72 hours later (after 48-hour grace period)
        vec!["src/feature_x.rs"],
        None,
        None,
        "hotfix/feature-x-bug", // Different branch
        0,
        3,
    );

    let result = classifier.classify(&original, &followup);

    // After grace period + different branch suggests hallucination fix
    assert_eq!(result.intent, CommitIntent::HallucinationFix);
}

// RED Test 11: Same branch (within grace period) = planned iteration
#[test]
fn test_same_branch_indicates_planned_iteration() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Initial implementation",
        1000,
        vec!["src/lib.rs"],
        None,
        None,
        "feature/new-module",
        0,
        0,
    );

    let followup = create_commit(
        "feat: Add error handling",
        2000,
        vec!["src/lib.rs"],
        None,
        None,
        "feature/new-module", // Same branch
        3,
        0,
    );

    let result = classifier.classify(&original, &followup);

    // Same branch suggests related planned work
    assert_eq!(result.intent, CommitIntent::PlannedIteration);
}

// RED Test 12: Mixed signals = uncertain
#[test]
fn test_mixed_signals_result_in_uncertain() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: New feature",
        1000,
        vec!["src/feature.rs"],
        None,
        None,
        "feature/new",
        0,
        0,
    );

    let followup = create_commit(
        "chore: Update code", // Neutral keyword
        1000 + (100 * 3600),  // After grace period
        vec!["src/other.rs"], // No file overlap
        None,
        None,
        "master", // Different branch
        5,        // Equal additions
        5,        // and fixes
    );

    let result = classifier.classify(&original, &followup);

    // Conflicting signals should result in uncertain
    assert_eq!(result.intent, CommitIntent::Uncertain);
}

// RED Test 13: All signals agree on hallucination = high confidence
#[test]
fn test_unanimous_hallucination_signals_high_confidence() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: All tests passing, bug-free",
        1000,
        vec!["src/lib.rs", "src/mod.rs"],
        None,
        None,
        "master",
        0,
        0,
    );

    let followup = create_commit(
        "fix: Critical bug in lib.rs (fixes #123)",
        1000 + (100 * 3600),              // After grace period
        vec!["src/lib.rs", "src/mod.rs"], // 100% overlap
        Some(123),
        Some(5000),            // Issue created after original commit
        "hotfix/critical-bug", // Different branch
        0,
        10, // Fixed many tests
    );

    let result = classifier.classify(&original, &followup);

    assert_eq!(result.intent, CommitIntent::HallucinationFix);
    assert!(result.confidence > 0.75); // High confidence when all signals agree
}

// RED Test 14: Confidence score is between 0 and 1
#[test]
fn test_confidence_score_bounds() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Some feature",
        1000,
        vec!["src/lib.rs"],
        None,
        None,
        "feature/test",
        0,
        0,
    );

    let followup = create_commit(
        "refactor: Improve code",
        2000,
        vec!["src/lib.rs"],
        None,
        None,
        "feature/test",
        1,
        0,
    );

    let result = classifier.classify(&original, &followup);

    assert!(result.confidence >= 0.0);
    assert!(result.confidence <= 1.0);
}

// RED Test 15: Classification includes all 5 signals
#[test]
fn test_classification_includes_all_signals() {
    let classifier = IntentClassifier::new();

    let original = create_commit(
        "feat: Feature complete",
        1000,
        vec!["src/lib.rs"],
        None,
        None,
        "feature/test",
        0,
        0,
    );

    let followup = create_commit(
        "fix: Bug fix",
        2000,
        vec!["src/lib.rs"],
        None,
        None,
        "feature/test",
        0,
        1,
    );

    let result = classifier.classify(&original, &followup);

    // Should have 5 signals:
    // 1. commit_message, 2. issue_linkage, 3. code_churn, 4. test_changes, 5. temporal_context
    assert_eq!(result.signals.len(), 5);

    let signal_names: Vec<_> = result
        .signals
        .iter()
        .map(|s| s.signal_name.as_str())
        .collect();
    assert!(signal_names.contains(&"commit_message"));
    assert!(signal_names.contains(&"issue_linkage"));
    assert!(signal_names.contains(&"code_churn"));
    assert!(signal_names.contains(&"test_changes"));
    assert!(signal_names.contains(&"temporal_context"));
}