pmat 3.11.0

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225

// StructuralComplexityScorer implementation methods and Scorer trait impl
// Included from complexity.rs - shares parent module scope

impl StructuralComplexityScorer {
    pub fn new() -> Self {
        Self
    }

    fn calculate_cyclomatic_complexity(&self, root: Node) -> u32 {
        let mut complexity = 1;

        walk_tree(root, |node| {
            match node.kind() {
                "if_statement" | "if_expression" | "while_statement" | "while_expression" |
                "for_statement" | "for_expression" | "match_expression" | "match_arm" |
                "conditional_expression" | "ternary_expression" => {
                    complexity += 1;
                }
                "binary_expression" => {
                    let op = node.child_by_field_name("operator");
                    if let Some(op_node) = op {
                        let op_text = op_node.kind();
                        if op_text == "&&" || op_text == "||" {
                            complexity += 1;
                        }
                    }
                }
                _ => {}
            }
        });

        complexity
    }

    fn calculate_nesting_depth(&self, root: Node) -> usize {
        let mut max_nesting = 0;

        fn check_nesting(node: Node, current_depth: usize, max: &mut usize) {
            let new_depth = if matches!(
                node.kind(),
                "if_statement" | "while_statement" | "for_statement" |
                "block" | "match_expression" | "function_item" | "impl_item"
            ) {
                current_depth + 1
            } else {
                current_depth
            };

            *max = (*max).max(new_depth);

            let mut cursor = node.walk();
            for child in node.children(&mut cursor) {
                check_nesting(child, new_depth, max);
            }
        }

        check_nesting(root, 0, &mut max_nesting);
        max_nesting
    }

    fn count_branches(&self, root: Node) -> usize {
        count_nodes_of_kind(root, "if_statement") +
        count_nodes_of_kind(root, "match_expression") +
        count_nodes_of_kind(root, "while_statement") +
        count_nodes_of_kind(root, "for_statement")
    }

    /// Extract all function nodes from the tree
    fn extract_functions(&self, root: Node) -> Vec<Node> {
        let mut functions = Vec::new();

        walk_tree(root, |node| {
            // Match function declarations across languages
            match node.kind() {
                "function_item" |           // Rust: fn foo() {}
                "function_declaration" |    // TypeScript/JavaScript: function foo() {}
                "function_definition" |     // Python/C/C++: def foo(): / void foo() {}
                "method_declaration" |      // Java/C#: public void foo() {}
                "arrow_function" |          // TypeScript/JavaScript: const foo = () => {}
                "lambda_expression" => {    // C#/Python: x => x + 1
                    functions.push(node);
                }
                _ => {}
            }
        });

        functions
    }

    /// Fallback to file-level analysis when no functions are detected
    #[allow(clippy::cast_possible_truncation)]
    fn score_file_level(&self, root: Node, config: &TdgConfig, tracker: &mut PenaltyTracker, mut points: f32) -> Result<f32> {
        let cyclomatic = self.calculate_cyclomatic_complexity(root);
        if cyclomatic > config.thresholds.max_cyclomatic_complexity {
            let excess = (cyclomatic - config.thresholds.max_cyclomatic_complexity) as f32;
            let penalty = config.penalties.complexity_penalty_base.apply(excess, 2.0).min(15.0);

            if let Some(applied) = tracker.apply(
                format!("high_cyclomatic_{}", cyclomatic),
                MetricCategory::StructuralComplexity,
                penalty,
                format!("High cyclomatic complexity: {}", cyclomatic)
            ) {
                points -= applied;
            }
        }

        let max_nesting = self.calculate_nesting_depth(root);
        if max_nesting > config.thresholds.max_nesting_depth as usize {
            let penalty = ((max_nesting - config.thresholds.max_nesting_depth as usize) as f32).min(5.0);

            if let Some(applied) = tracker.apply(
                format!("deep_nesting_{}", max_nesting),
                MetricCategory::StructuralComplexity,
                penalty,
                format!("Deep nesting: {} levels", max_nesting)
            ) {
                points -= applied;
            }
        }

        let branch_count = self.count_branches(root);
        if branch_count > 20 {
            let penalty = ((branch_count - 20) as f32 * 0.1).min(5.0);

            if let Some(applied) = tracker.apply(
                format!("many_branches_{}", branch_count),
                MetricCategory::StructuralComplexity,
                penalty,
                format!("Too many branches: {}", branch_count)
            ) {
                points -= applied;
            }
        }

        Ok(points.max(0.0))
    }
}

impl Scorer for StructuralComplexityScorer {
    #[allow(clippy::cast_possible_truncation)]
    fn score(&self, tree: &Tree, _source: &str, _language: Language, config: &TdgConfig, tracker: &mut PenaltyTracker) -> Result<f32> {
        let mut points = config.weights.structural_complexity;
        let root = tree.root_node();

        // Extract all functions from the tree
        let functions = self.extract_functions(root);

        if functions.is_empty() {
            // Fallback to file-level analysis if no functions found
            return self.score_file_level(root, config, tracker, points);
        }

        // Per-function analysis (Toyota Way: <10 complexity per function)
        let mut high_complexity_count = 0;
        let mut total_complexity = 0u32;

        for function in &functions {
            let complexity = self.calculate_cyclomatic_complexity(*function);
            total_complexity += complexity;

            // Toyota Way threshold: 10
            if complexity > 10 {
                high_complexity_count += 1;
                let excess = (complexity - 10) as f32;
                // Penalize each function that exceeds threshold
                let penalty = (excess * 0.5).min(3.0); // Max 3 points per function

                if let Some(applied) = tracker.apply(
                    format!("high_function_complexity_{}", complexity),
                    MetricCategory::StructuralComplexity,
                    penalty,
                    format!("Function complexity {} exceeds Toyota Way limit (10)", complexity)
                ) {
                    points -= applied;
                }
            }
        }

        // Give credit for good function decomposition
        let avg_complexity = total_complexity as f32 / functions.len() as f32;
        if functions.len() > 10 && avg_complexity < 8.0 {
            // Bonus: Many small functions with low average complexity
            let bonus = (functions.len() as f32 * 0.1).min(5.0);
            points = (points + bonus).min(config.weights.structural_complexity);
        }

        // Penalize if majority of functions are complex
        if high_complexity_count as f32 / functions.len() as f32 > 0.3 {
            let penalty = ((high_complexity_count as f32 / functions.len() as f32) * 10.0).min(8.0);
            if let Some(applied) = tracker.apply(
                "majority_complex_functions".to_string(),
                MetricCategory::StructuralComplexity,
                penalty,
                format!("{}% of functions exceed complexity limit",
                    (high_complexity_count as f32 / functions.len() as f32 * 100.0) as u32)
            ) {
                points -= applied;
            }
        }

        // Check nesting depth across all functions
        for function in &functions {
            let nesting = self.calculate_nesting_depth(*function);
            if nesting > config.thresholds.max_nesting_depth as usize {
                let penalty = ((nesting - config.thresholds.max_nesting_depth as usize) as f32 * 0.5).min(2.0);

                if let Some(applied) = tracker.apply(
                    format!("deep_nesting_in_function_{}", nesting),
                    MetricCategory::StructuralComplexity,
                    penalty,
                    format!("Deep nesting in function: {} levels", nesting)
                ) {
                    points -= applied;
                }
            }
        }

        Ok(points.max(0.0))
    }

    fn category(&self) -> MetricCategory {
        MetricCategory::StructuralComplexity
    }
}