pmat 3.11.0

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389

#![cfg_attr(coverage_nightly, coverage(off))]
//! Endpoint-specific tests for HTTP server

#[cfg_attr(coverage_nightly, coverage(off))]
#[cfg(test)]
mod endpoint_tests {
    use super::super::openapi::generate_openapi_spec;
    use super::super::router::create_router;
    use axum::{
        body::Body,
        http::{Request, StatusCode},
    };
    use serde_json::{json, Value};
    use tower::ServiceExt;

    // ==========================================================================
    // Test: analyze_complexity endpoint - invalid params
    // ==========================================================================

    #[tokio::test]
    async fn test_analyze_complexity_invalid_json() {
        let router = create_router().expect("Failed to create router");

        // Path to non-existent directory should fail validation
        let request = Request::builder()
            .uri("/api/analyze/complexity")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(
                r#"{"path": "/nonexistent/path/that/does/not/exist/1234567890"}"#,
            ))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    #[tokio::test]
    async fn test_analyze_complexity_malformed_json() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/analyze/complexity")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(r#"not json at all"#))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        // Should fail due to JSON parsing
        assert!(response.status().is_client_error() || response.status().is_server_error());
    }

    // ==========================================================================
    // Test: analyze_satd endpoint - invalid params
    // ==========================================================================

    #[tokio::test]
    async fn test_analyze_satd_invalid_params() {
        let router = create_router().expect("Failed to create router");

        // Path to non-existent directory should fail validation
        let request = Request::builder()
            .uri("/api/analyze/satd")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(
                r#"{"path": "/nonexistent/path/that/does/not/exist/satd"}"#,
            ))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    // ==========================================================================
    // Test: analyze_dead_code endpoint - invalid params
    // ==========================================================================

    #[tokio::test]
    async fn test_analyze_dead_code_invalid_params() {
        let router = create_router().expect("Failed to create router");

        // Path to non-existent directory should fail validation
        let request = Request::builder()
            .uri("/api/analyze/dead-code")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(
                r#"{"path": "/nonexistent/path/that/does/not/exist/deadcode"}"#,
            ))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    // ==========================================================================
    // Test: analyze_tdg endpoint - invalid params
    // ==========================================================================

    #[tokio::test]
    async fn test_analyze_tdg_invalid_params() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/analyze/tdg")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(r#"{"threshold": "not a number"}"#))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    // ==========================================================================
    // Test: analyze_lint_hotspot endpoint - invalid params
    // ==========================================================================

    #[tokio::test]
    async fn test_analyze_lint_hotspot_invalid_params() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/analyze/lint-hotspot")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(r#"{"max_density": "invalid"}"#))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    // ==========================================================================
    // Test: quality_gate endpoint - invalid params
    // ==========================================================================

    #[tokio::test]
    async fn test_quality_gate_invalid_params() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/quality-gate")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(r#"{"profile": 123}"#))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    // ==========================================================================
    // Test: refactor_auto endpoint - invalid params
    // ==========================================================================

    #[tokio::test]
    async fn test_refactor_auto_invalid_params() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/refactor/auto")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(r#"{"file": 123}"#))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    // ==========================================================================
    // Test: backward compatibility mapping through endpoints
    // ==========================================================================

    #[tokio::test]
    async fn test_backward_compat_project_path_mapping() {
        let router = create_router().expect("Failed to create router");

        // Use project_path (old parameter) instead of path
        let request = Request::builder()
            .uri("/api/analyze/complexity")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(
                r#"{"project_path": "/nonexistent/path", "format": "json"}"#,
            ))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        // Path doesn't exist, but we should get to the validation step
        // (meaning backward compat mapping worked)
        let status = response.status();
        assert!(
            status == StatusCode::BAD_REQUEST || status == StatusCode::INTERNAL_SERVER_ERROR,
            "Expected 400 or 500, got {}",
            status
        );
    }

    // ==========================================================================
    // Test: endpoint with valid path but non-existent file
    // ==========================================================================

    #[tokio::test]
    async fn test_analyze_complexity_with_nonexistent_path() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/analyze/complexity")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(
                r#"{"path": "/this/path/does/not/exist/xyz123", "format": "json"}"#,
            ))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        let status = response.status();
        // Should fail due to non-existent path
        assert!(
            status == StatusCode::BAD_REQUEST || status == StatusCode::INTERNAL_SERVER_ERROR,
            "Expected error status, got {}",
            status
        );
    }

    // ==========================================================================
    // Test: multiple error scenarios
    // ==========================================================================

    #[tokio::test]
    async fn test_empty_body_request() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/analyze/complexity")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::empty())
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        // Should fail due to empty body
        assert!(response.status().is_client_error() || response.status().is_server_error());
    }

    #[tokio::test]
    async fn test_null_body_request() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/analyze/satd")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from("null"))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        // Should fail due to null body
        assert!(response.status().is_client_error() || response.status().is_server_error());
    }

    // ==========================================================================
    // Test: contract with valid structure but invalid values
    // ==========================================================================

    #[tokio::test]
    async fn test_analyze_dead_code_invalid_max_percentage() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/analyze/dead-code")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(
                r#"{"path": "/tmp", "max_percentage": 150.0, "include_unreachable": false, "min_dead_lines": 0, "fail_on_violation": false}"#,
            ))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        // Invalid percentage should trigger validation error
        let status = response.status();
        assert!(
            status == StatusCode::BAD_REQUEST || status == StatusCode::INTERNAL_SERVER_ERROR,
            "Expected error for invalid max_percentage, got {}",
            status
        );
    }

    #[tokio::test]
    async fn test_analyze_tdg_negative_threshold() {
        let router = create_router().expect("Failed to create router");

        let request = Request::builder()
            .uri("/api/analyze/tdg")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(
                r#"{"path": "/tmp", "threshold": -1.0, "include_components": false, "critical_only": false}"#,
            ))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        let status = response.status();
        assert!(
            status == StatusCode::BAD_REQUEST || status == StatusCode::INTERNAL_SERVER_ERROR,
            "Expected error for negative threshold, got {}",
            status
        );
    }

    // ==========================================================================
    // Test: Response body contains error key for errors
    // ==========================================================================

    #[tokio::test]
    async fn test_error_response_has_error_key() {
        let router = create_router().expect("Failed to create router");

        // Path to non-existent directory should fail validation and return error
        let request = Request::builder()
            .uri("/api/analyze/complexity")
            .method("POST")
            .header("content-type", "application/json")
            .body(Body::from(
                r#"{"path": "/nonexistent/path/that/does/not/exist/error_test"}"#,
            ))
            .unwrap();

        let response = router.oneshot(request).await.unwrap();
        let body = axum::body::to_bytes(response.into_body(), 4096)
            .await
            .unwrap();
        let json: Value = serde_json::from_slice(&body).unwrap();

        assert!(
            json.get("error").is_some(),
            "Error response should have 'error' key"
        );
    }

    // ==========================================================================
    // Property tests for OpenAPI spec consistency
    // ==========================================================================

    #[test]
    fn test_openapi_all_paths_have_post_summary() {
        let spec = generate_openapi_spec();
        let paths = spec["paths"].as_object().unwrap();

        for (path, methods) in paths {
            if let Some(post) = methods.get("post") {
                assert!(
                    post.get("summary").is_some(),
                    "Path {} POST should have summary",
                    path
                );
            }
        }
    }

    #[test]
    fn test_openapi_all_post_endpoints_require_body() {
        let spec = generate_openapi_spec();
        let paths = spec["paths"].as_object().unwrap();

        for (path, methods) in paths {
            if let Some(post) = methods.get("post") {
                let request_body = post.get("requestBody");
                assert!(
                    request_body.is_some(),
                    "Path {} POST should have requestBody",
                    path
                );
                if let Some(rb) = request_body {
                    assert_eq!(
                        rb.get("required"),
                        Some(&json!(true)),
                        "Path {} requestBody should be required",
                        path
                    );
                }
            }
        }
    }
}