1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
//! Integration tests for complexity threshold filtering
//!
//! These tests verify that the --max-cyclomatic and --max-cognitive flags
//! properly filter files based on their function complexity thresholds.
//! This addresses GitHub issue #32.
use assert_cmd::Command;
use predicates::prelude::*;
use std::fs;
use tempfile::TempDir;
/// Create a test file with known complexity values
fn create_test_file(dir: &TempDir, name: &str, complexity: u16) -> std::path::PathBuf {
let path = dir.path().join(name);
let content = match complexity {
1..=5 => {
// Simple function (complexity 1)
String::from(
r#"
fn simple_function(x: i32) -> i32 {
x + 1
}
"#,
)
}
6..=10 => {
// Medium complexity function (complexity ~8)
String::from(
r#"
fn medium_function(x: i32) -> i32 {
if x > 0 {
if x > 10 {
if x > 20 {
x * 3
} else {
x * 2
}
} else {
x + 1
}
} else if x < 0 {
if x < -10 {
-x * 2
} else {
-x
}
} else {
0
}
}
"#,
)
}
11..=15 => {
// Higher complexity function (complexity ~14)
String::from(
r#"
fn high_function(x: i32) -> i32 {
if x > 0 {
if x > 10 {
if x > 20 {
if x > 30 {
x * 4
} else {
x * 3
}
} else {
x * 2
}
} else if x > 5 {
x + 10
} else {
x + 1
}
} else if x < 0 {
if x < -10 {
if x < -20 {
-x * 3
} else {
-x * 2
}
} else {
-x
}
} else {
match x {
0 => 0,
_ => unreachable!(),
}
}
}
"#,
)
}
16..=20 => {
// Very high complexity function (complexity ~16)
String::from(
r#"
fn very_high_function(x: i32) -> i32 {
if x > 0 {
if x > 10 {
if x > 20 {
if x > 30 {
if x > 40 {
x * 5
} else {
x * 4
}
} else {
x * 3
}
} else {
x * 2
}
} else if x > 5 {
if x > 7 {
x + 20
} else {
x + 10
}
} else {
x + 1
}
} else if x < 0 {
if x < -10 {
if x < -20 {
if x < -30 {
-x * 4
} else {
-x * 3
}
} else {
-x * 2
}
} else {
-x
}
} else {
match x {
0 => 0,
_ => unreachable!(),
}
}
}
"#,
)
}
21..=25 => {
// Extremely high complexity function (complexity ~25)
let if_statements = (0..15)
.map(|i| format!(" if x == {} {{\n return {};\n }}", i, i * 2))
.collect::<Vec<_>>()
.join("\n");
format!(
r#"
fn extremely_complex_function(x: i32) -> i32 {{
{}
x
}}
"#,
if_statements
)
}
_ => {
// Ultra high complexity function - generate many linear if statements
let if_statements = (0..complexity.saturating_sub(1))
.map(|i| format!(" if x == {} {{\n return {};\n }}", i, i * 2))
.collect::<Vec<_>>()
.join("\n");
format!(
r#"
fn ultra_complex_function(x: i32) -> i32 {{
{}
x
}}
"#,
if_statements
)
}
};
fs::write(&path, content).unwrap();
path
}
#[test]
fn test_max_cyclomatic_filters_correctly() {
let temp_dir = TempDir::new().unwrap();
// Create test files with different complexity levels
create_test_file(&temp_dir, "simple.rs", 3);
create_test_file(&temp_dir, "medium.rs", 10);
create_test_file(&temp_dir, "complex.rs", 25);
create_test_file(&temp_dir, "very_complex.rs", 40);
// Test with threshold of 20 - should only show complex.rs and very_complex.rs
let mut cmd = Command::cargo_bin("pmat").unwrap();
cmd.current_dir(&temp_dir).args([
"analyze",
"complexity",
"--max-cyclomatic",
"20",
"--format",
"json",
]);
let output = cmd.output().unwrap();
let stdout = String::from_utf8(output.stdout).unwrap();
// Files with complexity <= 20 should NOT appear
assert!(
!stdout.contains("simple.rs"),
"simple.rs should be filtered out"
);
assert!(
!stdout.contains("medium.rs"),
"medium.rs should be filtered out"
);
// Files with complexity > 20 should appear
assert!(
stdout.contains("complex.rs"),
"complex.rs should be included"
);
assert!(
stdout.contains("very_complex.rs"),
"very_complex.rs should be included"
);
}
#[test]
fn test_max_cyclomatic_with_top_files() {
let temp_dir = TempDir::new().unwrap();
// Create 5 files with varying complexity
create_test_file(&temp_dir, "file1.rs", 5); // Below threshold
create_test_file(&temp_dir, "file2.rs", 15); // Below threshold
create_test_file(&temp_dir, "file3.rs", 25); // Above threshold
create_test_file(&temp_dir, "file4.rs", 35); // Above threshold
create_test_file(&temp_dir, "file5.rs", 45); // Above threshold
// Test with threshold of 20 and top-files of 2
// Should show only file4.rs and file5.rs (the top 2 files above threshold)
let mut cmd = Command::cargo_bin("pmat").unwrap();
cmd.current_dir(&temp_dir).args([
"analyze",
"complexity",
"--max-cyclomatic",
"20",
"--top-files",
"2",
"--format",
"json",
]);
let output = cmd.output().unwrap();
let stdout = String::from_utf8(output.stdout).unwrap();
// Files below threshold should not appear
assert!(
!stdout.contains("file1.rs"),
"file1.rs should be filtered out"
);
assert!(
!stdout.contains("file2.rs"),
"file2.rs should be filtered out"
);
// Only top 2 files above threshold should appear
assert!(
!stdout.contains("file3.rs"),
"file3.rs should be excluded by top-files limit"
);
assert!(stdout.contains("file4.rs"), "file4.rs should be included");
assert!(stdout.contains("file5.rs"), "file5.rs should be included");
}
#[test]
fn test_exact_threshold_boundary() {
let temp_dir = TempDir::new().unwrap();
// Create files at and around the threshold
create_test_file(&temp_dir, "below.rs", 14);
create_test_file(&temp_dir, "exact.rs", 15);
create_test_file(&temp_dir, "above.rs", 16);
// Test with threshold of 15
let mut cmd = Command::cargo_bin("pmat").unwrap();
cmd.current_dir(&temp_dir).args([
"analyze",
"complexity",
"--max-cyclomatic",
"15",
"--format",
"json",
]);
let output = cmd.output().unwrap();
let stdout = String::from_utf8(output.stdout).unwrap();
// Functions at or below threshold should not appear
assert!(
!stdout.contains("below.rs"),
"below.rs (14) should be filtered out"
);
assert!(
!stdout.contains("exact.rs"),
"exact.rs (15) should be filtered out"
);
// Only functions above threshold should appear
assert!(
stdout.contains("above.rs"),
"above.rs (16) should be included"
);
}
#[test]
fn test_no_files_above_threshold() {
let temp_dir = TempDir::new().unwrap();
// Create only simple files
create_test_file(&temp_dir, "simple1.rs", 3);
create_test_file(&temp_dir, "simple2.rs", 5);
create_test_file(&temp_dir, "simple3.rs", 8);
// Test with high threshold - no files should match
let mut cmd = Command::cargo_bin("pmat").unwrap();
cmd.current_dir(&temp_dir)
.args(["analyze", "complexity", "--max-cyclomatic", "50"]);
cmd.assert()
.success()
.stdout(predicate::str::contains("**Files analyzed**: 0"));
}