pmat 2.93.1

PMAT - Zero-config AI context generation and code quality toolkit (CLI, MCP, HTTP)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
//! Enhanced Kotlin Language Support for PMAT
//!
//! This module provides enhanced Kotlin-specific analysis capabilities using tree-sitter-kotlin parser
//! for AST extraction and complexity analysis with focus on coroutines and Kotlin-specific features.

#[cfg(feature = "kotlin-ast")]
use crate::services::context::AstItem;
#[cfg(feature = "kotlin-ast")]
use std::path::{Path, PathBuf};

/// Enhanced Kotlin AST visitor that extracts Kotlin-specific AST information
#[cfg(feature = "kotlin-ast")]
pub struct KotlinAstVisitor {
    items: Vec<AstItem>,
    _file_path: PathBuf,
    package_name: String,
    class_count: usize,
    coroutine_count: usize,
}

#[cfg(feature = "kotlin-ast")]
impl KotlinAstVisitor {
    /// Creates a new Kotlin AST visitor
    #[must_use] 
    pub fn new(file_path: &Path) -> Self {
        Self {
            items: Vec::new(),
            _file_path: file_path.to_path_buf(),
            package_name: String::new(),
            class_count: 0,
            coroutine_count: 0,
        }
    }

    /// Analyzes Kotlin source code and extracts AST items (complexity ≤10)
    pub fn analyze_kotlin_source(mut self, source: &str) -> Result<Vec<AstItem>, String> {
        if source.trim().is_empty() {
            return Ok(vec![]);
        }

        // Check for basic Kotlin syntax validity
        if source.contains("{{{ !!!") || !self.is_valid_kotlin_syntax(source) {
            return Err("Invalid Kotlin syntax".to_string());
        }

        self.extract_package_declaration(source)?;
        self.extract_class_declarations(source)?;
        self.extract_function_declarations(source)?;
        self.extract_interface_declarations(source)?;
        self.extract_coroutine_declarations(source)?;

        Ok(self.items)
    }

    /// Check basic Kotlin syntax validity (complexity ≤10)
    fn is_valid_kotlin_syntax(&self, source: &str) -> bool {
        let open_braces = source.chars().filter(|&c| c == '{').count();
        let close_braces = source.chars().filter(|&c| c == '}').count();

        // Basic brace matching and no obvious syntax errors
        open_braces == close_braces && !source.contains("!!!")
    }

    /// Extracts package declaration (complexity ≤10)
    fn extract_package_declaration(&mut self, source: &str) -> Result<(), String> {
        let lines: Vec<&str> = source.lines().collect();
        for line in lines {
            let trimmed = line.trim();
            if let Some(package_part) = trimmed.strip_prefix("package ") {
                self.package_name = package_part.trim().to_string();
                return Ok(());
            }
        }
        Ok(())
    }

    /// Extracts class declarations (complexity ≤10)
    fn extract_class_declarations(&mut self, source: &str) -> Result<(), String> {
        let lines: Vec<&str> = source.lines().collect();
        for line in lines {
            let trimmed = line.trim();
            if let Some(class_name) = self.extract_class_name_from_line(trimmed) {
                let qualified_name = self.get_qualified_name(&class_name);
                let visibility = "public"; // Kotlin classes are public by default
                let fields_count = self.count_class_members(source, &class_name);

                self.items.push(AstItem::Struct {
                    name: qualified_name,
                    visibility: visibility.to_string(),
                    fields_count,
                    derives: vec![],
                    line: 1,
                });
                self.class_count += 1;
            }
        }
        Ok(())
    }

    /// Helper to extract class name from line (complexity ≤10)
    fn extract_class_name_from_line(&self, line: &str) -> Option<String> {
        if line.contains("class ") {
            let parts: Vec<&str> = line.split_whitespace().collect();
            for (i, part) in parts.iter().enumerate() {
                if *part == "class" && i + 1 < parts.len() {
                    let class_name = parts[i + 1].trim_end_matches('{').trim_end_matches(':');
                    return Some(class_name.to_string());
                }
            }
        }
        None
    }

    /// Count methods in a class (complexity ≤10)
    fn count_class_members(&self, source: &str, class_name: &str) -> usize {
        let lines: Vec<&str> = source.lines().collect();
        let mut count = 0;
        let mut in_class = false;
        let mut brace_count = 0;

        for line in lines {
            let trimmed = line.trim();

            if trimmed.contains(&format!("class {class_name}")) {
                in_class = true;
                if trimmed.contains('{') {
                    brace_count += 1;
                }
                continue;
            }

            if in_class {
                brace_count += trimmed.chars().filter(|&c| c == '{').count() as i32;
                brace_count -= trimmed.chars().filter(|&c| c == '}').count() as i32;

                if brace_count <= 0 {
                    break;
                }

                if trimmed.contains("fun ") && !trimmed.contains("class") {
                    count += 1;
                }
            }
        }
        count
    }

    /// Extracts function declarations (complexity ≤10)
    fn extract_function_declarations(&mut self, source: &str) -> Result<(), String> {
        let lines: Vec<&str> = source.lines().collect();
        for line in lines {
            let trimmed = line.trim();
            if let Some(function_name) = self.extract_function_name_from_line(trimmed) {
                let qualified_name = self.get_qualified_name(&function_name);
                let visibility = self.extract_function_visibility(trimmed);
                let is_suspend = trimmed.contains("suspend");

                self.items.push(AstItem::Function {
                    name: qualified_name,
                    visibility,
                    is_async: is_suspend,
                    line: 1,
                });
            }
        }
        Ok(())
    }

    /// Helper to extract function name from line (complexity ≤10)
    fn extract_function_name_from_line(&self, line: &str) -> Option<String> {
        if line.contains("fun ") && line.contains('(') && !line.contains("class") {
            let parts: Vec<&str> = line.split_whitespace().collect();
            for (i, part) in parts.iter().enumerate() {
                if *part == "fun" && i + 1 < parts.len() {
                    let next_part = parts[i + 1];
                    let function_name = next_part.split('(').next()?;
                    return Some(function_name.to_string());
                }
            }
        }
        None
    }

    /// Helper to extract function visibility (complexity ≤10)
    fn extract_function_visibility(&self, line: &str) -> String {
        if line.contains("public") {
            "public".to_string()
        } else if line.contains("private") {
            "private".to_string()
        } else if line.contains("protected") {
            "protected".to_string()
        } else {
            "public".to_string()
        }
    }

    /// Extracts interface declarations (complexity ≤10)
    fn extract_interface_declarations(&mut self, source: &str) -> Result<(), String> {
        let lines: Vec<&str> = source.lines().collect();
        for line in lines {
            let trimmed = line.trim();
            if let Some(interface_name) = self.extract_interface_name_from_line(trimmed) {
                let qualified_name = self.get_qualified_name(&interface_name);
                let visibility = "public"; // Kotlin classes are public by default

                self.items.push(AstItem::Trait {
                    name: qualified_name,
                    visibility: visibility.to_string(),
                    line: 1,
                });
            }
        }
        Ok(())
    }

    /// Helper to extract interface name from line (complexity ≤10)
    fn extract_interface_name_from_line(&self, line: &str) -> Option<String> {
        if line.contains("interface ") {
            let parts: Vec<&str> = line.split_whitespace().collect();
            for (i, part) in parts.iter().enumerate() {
                if *part == "interface" && i + 1 < parts.len() {
                    let interface_name = parts[i + 1].trim_end_matches('{');
                    return Some(interface_name.to_string());
                }
            }
        }
        None
    }

    /// Extracts coroutine declarations (complexity ≤10)
    fn extract_coroutine_declarations(&mut self, source: &str) -> Result<(), String> {
        let lines: Vec<&str> = source.lines().collect();
        for line in lines {
            let trimmed = line.trim();
            if trimmed.contains("suspend fun") || trimmed.contains("async {") || trimmed.contains("launch {") {
                self.coroutine_count += 1;
            }
        }
        Ok(())
    }

    /// Gets qualified name for a symbol (complexity ≤10)
    fn get_qualified_name(&self, name: &str) -> String {
        if self.package_name.is_empty() {
            name.to_string()
        } else {
            format!("{}::{}", self.package_name, name)
        }
    }
}

/// Kotlin complexity analyzer with enhanced coroutine analysis (complexity ≤10)
#[cfg(feature = "kotlin-ast")]
pub struct KotlinComplexityAnalyzer {
    cyclomatic_complexity: u32,
    cognitive_complexity: u32,
    coroutine_complexity: u32,
}

#[cfg(feature = "kotlin-ast")]
impl Default for KotlinComplexityAnalyzer {
    fn default() -> Self {
        Self::new()
    }
}

impl KotlinComplexityAnalyzer {
    /// Creates a new Kotlin complexity analyzer
    #[must_use] 
    pub fn new() -> Self {
        Self {
            cyclomatic_complexity: 0,
            cognitive_complexity: 0,
            coroutine_complexity: 0,
        }
    }

    /// Analyzes complexity of Kotlin source code (complexity ≤10)
    pub fn analyze_complexity(&mut self, source: &str) -> Result<(u32, u32), String> {
        self.cyclomatic_complexity = 1;
        self.cognitive_complexity = 1;

        let lines: Vec<&str> = source.lines().collect();
        for line in lines {
            let trimmed = line.trim();
            self.analyze_complexity_for_line(trimmed);
        }

        Ok((self.cyclomatic_complexity, self.cognitive_complexity))
    }

    /// Helper to analyze complexity for a single line (complexity ≤10)
    fn analyze_complexity_for_line(&mut self, line: &str) {
        if line.contains("if ") || line.contains("while ") || line.contains("for ") {
            self.cyclomatic_complexity += 1;
            self.cognitive_complexity += 1;
        }
        if line.contains("&&") || line.contains("||") {
            self.cyclomatic_complexity += 1;
        }
        if line.contains("when ") || line.contains("catch ") {
            self.cyclomatic_complexity += 1;
            self.cognitive_complexity += 1;
        }
    }

    /// Analyzes coroutine complexity (complexity ≤10)
    pub fn analyze_coroutine_complexity(&mut self, source: &str) -> Result<u32, String> {
        self.coroutine_complexity = 0;

        let lines: Vec<&str> = source.lines().collect();
        for line in lines {
            let trimmed = line.trim();
            if trimmed.contains("suspend ") || trimmed.contains("async ") || trimmed.contains("launch ") {
                self.coroutine_complexity += 1;
            }
        }

        // Ensure at least complexity 1 if any coroutines detected
        if self.coroutine_complexity > 0 {
            self.coroutine_complexity = self.coroutine_complexity.max(1);
        }

        Ok(self.coroutine_complexity)
    }
}

#[cfg(all(test, feature = "kotlin-ast"))]
mod tests {
    use super::*;
    use std::path::Path;

    const SIMPLE_KOTLIN_CLASS: &str = r#"
package com.example

class HelloWorld {
    fun main() {
        println("Hello, World!")
    }
}
"#;

    const KOTLIN_CLASS_WITH_METHODS: &str = r#"
package com.example.calculator

class Calculator {
    private var result: Double = 0.0

    fun add(x: Double, y: Double): Double {
        result = x + y
        return result
    }

    fun multiply(x: Double, y: Double): Double {
        result = x * y
        return result
    }

    val currentResult: Double
        get() = result
}
"#;

    const KOTLIN_INTERFACE_DEFINITION: &str = r#"
package com.example.shapes

interface Shape {
    val area: Double
    val perimeter: Double
}

class Circle(private val radius: Double) : Shape {
    override val area: Double
        get() = kotlin.math.PI * radius * radius

    override val perimeter: Double
        get() = 2 * kotlin.math.PI * radius
}
"#;

    const KOTLIN_COROUTINE_EXAMPLE: &str = r#"
package com.example.async

import kotlinx.coroutines.*

class AsyncProcessor {
    suspend fun processData(data: String): String {
        delay(100)
        return data.uppercase()
    }

    fun launchProcessing() = runBlocking {
        val job = launch {
            val result = processData("hello")
            println(result)
        }
        job.join()
    }
}
"#;

    #[test]
    fn test_simple_kotlin_class_analysis() {
        let visitor = KotlinAstVisitor::new(Path::new("HelloWorld.kt"));
        let items = visitor.analyze_kotlin_source(SIMPLE_KOTLIN_CLASS).expect("Should parse Kotlin class");

        assert!(!items.is_empty(), "Should extract at least one AST item");

        let class_items: Vec<_> = items.iter()
            .filter(|item| matches!(item, AstItem::Struct { .. }))
            .collect();

        assert_eq!(class_items.len(), 1, "Should extract exactly one class");

        if let AstItem::Struct { name, visibility, .. } = &class_items[0] {
            assert_eq!(name, "com.example::HelloWorld", "Should have qualified class name");
            assert_eq!(visibility, "public", "Kotlin classes have public visibility by default");
        } else {
            panic!("Expected class item");
        }
    }

    #[test]
    fn test_kotlin_class_with_methods_analysis() {
        let visitor = KotlinAstVisitor::new(Path::new("Calculator.kt"));
        let items = visitor.analyze_kotlin_source(KOTLIN_CLASS_WITH_METHODS).expect("Should parse Kotlin class");

        assert!(items.len() >= 4, "Should extract class and methods");

        let class_items: Vec<_> = items.iter()
            .filter(|item| matches!(item, AstItem::Struct { .. }))
            .collect();

        assert_eq!(class_items.len(), 1, "Should extract exactly one class");

        if let AstItem::Struct { name, fields_count, .. } = &class_items[0] {
            assert_eq!(name, "com.example.calculator::Calculator", "Should have qualified class name");
            assert_eq!(*fields_count, 3, "Should count methods and properties as fields for Kotlin classes");
        }

        let method_items: Vec<_> = items.iter()
            .filter(|item| matches!(item, AstItem::Function { .. }))
            .collect();

        assert_eq!(method_items.len(), 3, "Should extract all three methods/properties");
    }

    #[test]
    fn test_kotlin_interface_analysis() {
        let visitor = KotlinAstVisitor::new(Path::new("Shape.kt"));
        let items = visitor.analyze_kotlin_source(KOTLIN_INTERFACE_DEFINITION).expect("Should parse Kotlin interface");

        let interface_items: Vec<_> = items.iter()
            .filter(|item| matches!(item, AstItem::Trait { .. }))
            .collect();

        assert_eq!(interface_items.len(), 1, "Should extract exactly one interface");

        if let AstItem::Trait { name, .. } = &interface_items[0] {
            assert_eq!(name, "com.example.shapes::Shape", "Should have qualified interface name");
        }
    }

    #[test]
    fn test_kotlin_coroutine_analysis() {
        let visitor = KotlinAstVisitor::new(Path::new("AsyncProcessor.kt"));
        let items = visitor.analyze_kotlin_source(KOTLIN_COROUTINE_EXAMPLE).expect("Should parse Kotlin coroutines");

        let suspend_functions: Vec<_> = items.iter()
            .filter(|item| match item {
                AstItem::Function { name, .. } => name.contains("suspend") || name.contains("processData"),
                _ => false,
            })
            .collect();

        assert!(!suspend_functions.is_empty(), "Should detect suspend functions");
    }

    #[test]
    fn test_kotlin_complexity_analysis() {
        let mut analyzer = KotlinComplexityAnalyzer::new();
        let (cyclomatic, cognitive) = analyzer.analyze_complexity(SIMPLE_KOTLIN_CLASS)
            .expect("Should analyze Kotlin complexity");

        assert!(cyclomatic >= 1, "Should have at least cyclomatic complexity of 1");
        assert!(cognitive >= 1, "Should have at least cognitive complexity of 1");
        assert!(cyclomatic <= 10, "Should maintain complexity ≤10 for simple class");
        assert!(cognitive <= 10, "Should maintain cognitive complexity ≤10");
    }

    #[test]
    fn test_kotlin_coroutine_complexity_analysis() {
        let mut analyzer = KotlinComplexityAnalyzer::new();
        let coroutine_complexity = analyzer.analyze_coroutine_complexity(KOTLIN_COROUTINE_EXAMPLE)
            .expect("Should analyze Kotlin coroutine complexity");

        assert!(coroutine_complexity >= 1, "Should have coroutine complexity for suspend functions");
        assert!(coroutine_complexity <= 10, "Should maintain coroutine complexity ≤10");
    }

    #[test]
    fn test_kotlin_package_name_extraction() {
        let visitor = KotlinAstVisitor::new(Path::new("test.kt"));
        let items = visitor.analyze_kotlin_source(SIMPLE_KOTLIN_CLASS).expect("Should parse Kotlin source");

        // Check that package name is included in qualified names
        let has_example_package = items.iter().any(|item| match item {
            AstItem::Struct { name, .. } => name.starts_with("com.example::"),
            _ => false,
        });

        assert!(has_example_package, "Should include package name in qualified names");
    }

    #[test]
    fn test_empty_kotlin_source() {
        let visitor = KotlinAstVisitor::new(Path::new("empty.kt"));
        let items = visitor.analyze_kotlin_source("").expect("Should handle empty source");

        assert!(items.is_empty(), "Empty source should produce no AST items");
    }

    #[test]
    fn test_invalid_kotlin_syntax() {
        let visitor = KotlinAstVisitor::new(Path::new("invalid.kt"));
        let result = visitor.analyze_kotlin_source("invalid kotlin syntax {{{ !!!");

        assert!(result.is_err(), "Should return error for invalid Kotlin syntax");
    }
}

#[cfg(all(test, feature = "kotlin-ast"))]
mod property_tests {
    use super::*;
    use proptest::prelude::*;
    use std::path::Path;

    proptest! {
        #[test]
        fn test_kotlin_visitor_handles_any_valid_package_name(
            package_name in "[a-z][a-z0-9_]*\\.[a-z][a-z0-9_]*"
        ) {
            let source = format!("package {}\\n\\nclass TestClass", package_name);
            let visitor = KotlinAstVisitor::new(Path::new("test.kt"));

            if let Ok(items) = visitor.analyze_kotlin_source(&source) {
                // Should extract package and class
                prop_assert!(items.len() >= 1);

                // Check that package name is included in qualified names
                let has_package_prefix = items.iter().any(|item| match item {
                    AstItem::Struct { name, .. } => name.starts_with(&format!("{}::", package_name)),
                    _ => false,
                });
                prop_assert!(has_package_prefix);
            }
        }

        #[test]
        fn test_kotlin_complexity_analyzer_bounds(
            function_count in 1usize..10
        ) {
            let mut source = String::from("package test\\n\\nclass Test {\\n");
            for i in 0..function_count {
                source.push_str(&format!("fun function{}() {{}}\\n", i));
            }
            source.push_str("}\\n");

            let visitor = KotlinAstVisitor::new(Path::new("test.kt"));
            if let Ok(items) = visitor.analyze_kotlin_source(&source) {
                let function_items: Vec<_> = items.iter()
                    .filter(|item| matches!(item, AstItem::Function { .. }))
                    .collect();

                // Should extract all functions
                prop_assert_eq!(function_items.len(), function_count);

                // All should be functions with real names
                for (i, item) in function_items.iter().enumerate() {
                    if let AstItem::Function { name, .. } = item {
                        let expected_name = format!("function{}", i);
                        prop_assert!(name.contains(&expected_name));
                    }
                }
            }
        }

        #[test]
        fn test_kotlin_complexity_stays_bounded(
            depth in 1u32..5
        ) {
            let mut source = String::from("package test\\n\\nclass Test {\\nfun complexFunction() {\\n");
            for _ in 0..depth {
                source.push_str("if (true) {\\n");
            }
            source.push_str("return\\n");
            for _ in 0..depth {
                source.push_str("}\\n");
            }
            source.push_str("}\\n}\\n");

            let mut analyzer = KotlinComplexityAnalyzer::new();
            if let Ok((cyclomatic, cognitive)) = analyzer.analyze_complexity(&source) {
                // Complexity should grow but stay reasonable
                prop_assert!(cyclomatic >= depth);
                prop_assert!(cognitive >= depth);
                prop_assert!(cyclomatic <= depth * 2 + 5); // Reasonable upper bound
                prop_assert!(cognitive <= depth * 3 + 5); // Reasonable upper bound
            }
        }
    }
}