pleme-linker 0.3.0

Nix-native JavaScript package manager
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
//! npm registry resolution and deps.nix generation

use anyhow::{Context, Result};
use chrono::Utc;
use futures::future::join_all;
use semver::{Version, VersionReq};
use std::collections::HashSet;
use std::fs;

use crate::cli::ResolveArgs;
use crate::types::{
    NpmAlias, NpmPackageMetadata, NpmVersionInfo, ResolutionContext, ResolvedPackage,
    WorkspacePackageRef,
};
use crate::utils::escape_nix_string;

/// Maximum number of concurrent metadata fetches
const MAX_CONCURRENT_FETCHES: usize = 32;

/// Run the resolve command
pub async fn run_resolve(args: ResolveArgs) -> Result<()> {
    println!("pleme-linker resolve: Resolving dependencies");
    println!("  Project:  {}", args.project.display());
    println!("  Registry: {}", args.registry);
    println!("  Platform: {}", args.platform);
    println!();

    // Read package.json
    let package_json_path = args.project.join("package.json");
    let package_json_content = fs::read_to_string(&package_json_path)
        .with_context(|| format!("Failed to read {}", package_json_path.display()))?;
    let package_json: serde_json::Value = serde_json::from_str(&package_json_content)
        .with_context(|| "Failed to parse package.json")?;

    // Initialize resolution context
    let mut ctx = ResolutionContext::new(args.registry.clone(), args.platform.clone());

    // Queue root dependencies
    let mut dep_count = 0;
    if let Some(deps) = package_json.get("dependencies").and_then(|d| d.as_object()) {
        for (name, version) in deps {
            let version_str = version.as_str().unwrap_or("*");

            // Collect workspace/file dependencies (local packages)
            if version_str.starts_with("workspace:")
                || version_str.starts_with("file:")
                || version_str.starts_with("link:")
            {
                let relative_path = if version_str.starts_with("file:") {
                    version_str.strip_prefix("file:").unwrap_or(version_str).to_string()
                } else if version_str.starts_with("link:") {
                    version_str.strip_prefix("link:").unwrap_or(version_str).to_string()
                } else {
                    "*".to_string()
                };

                ctx.workspace_packages.push(WorkspacePackageRef {
                    name: name.clone(),
                    relative_path,
                });
                println!("  Found workspace dependency: {} -> {}", name, version_str);
                continue;
            }

            ctx.queue.push_back((name.clone(), version_str.to_string(), false));
            ctx.queued.insert(format!("{}@{}", name, version_str));
            dep_count += 1;
        }
    }

    if args.include_dev {
        if let Some(deps) = package_json
            .get("devDependencies")
            .and_then(|d| d.as_object())
        {
            for (name, version) in deps {
                let version_str = version.as_str().unwrap_or("*");

                // Skip workspace/file dependencies
                if version_str.starts_with("workspace:")
                    || version_str.starts_with("file:")
                    || version_str.starts_with("link:")
                {
                    continue;
                }

                let key = format!("{}@{}", name, version_str);
                if !ctx.queued.contains(&key) {
                    ctx.queue.push_back((name.clone(), version_str.to_string(), false));
                    ctx.queued.insert(key);
                    dep_count += 1;
                }
            }
        }
    }

    println!("  Found {} direct dependencies", dep_count);
    println!();
    println!("Resolving dependency tree (parallel fetching, {} concurrent)...", MAX_CONCURRENT_FETCHES);

    // Parallel resolution loop
    let mut resolved_count = 0;

    while !ctx.queue.is_empty() {
        // Collect batch of packages to fetch metadata for
        let mut batch: Vec<(String, String, bool, String)> = Vec::new(); // (name, constraint, is_optional, target_package)
        let mut packages_to_fetch: HashSet<String> = HashSet::new();

        // Take up to MAX_CONCURRENT_FETCHES items from queue
        while let Some((name, constraint, is_optional)) = ctx.queue.pop_front() {
            let (actual_name, actual_constraint, target_package) =
                if let Some(alias) = parse_npm_alias(&constraint) {
                    (name.clone(), alias.target_constraint.clone(), alias.target_package.clone())
                } else {
                    (name.clone(), constraint.clone(), name.clone())
                };

            // Skip if already satisfied
            if is_satisfied(&ctx, &actual_name, &actual_constraint) {
                continue;
            }

            // Skip if we already have metadata cached
            if !ctx.metadata_cache.contains_key(&target_package) {
                packages_to_fetch.insert(target_package.clone());
            }

            batch.push((name, constraint, is_optional, target_package));

            if packages_to_fetch.len() >= MAX_CONCURRENT_FETCHES {
                break;
            }
        }

        if batch.is_empty() {
            continue;
        }

        // Fetch all metadata in parallel
        if !packages_to_fetch.is_empty() {
            let fetch_results = fetch_metadata_batch(&ctx.client, &ctx.registry, &packages_to_fetch).await;

            // Store fetched metadata in cache
            for (name, result) in fetch_results {
                match result {
                    Ok(metadata) => {
                        ctx.metadata_cache.insert(name, metadata);
                    }
                    Err(e) => {
                        // Mark all packages depending on this as failed
                        for (batch_name, batch_constraint, is_optional, target) in &batch {
                            if target == &name && !*is_optional {
                                ctx.failed.push((batch_name.clone(), batch_constraint.clone(), e.clone()));
                            }
                        }
                    }
                }
            }
        }

        // Process batch with cached metadata
        for (name, constraint, is_optional, target_package) in batch {
            let (actual_name, actual_constraint, _) =
                if let Some(alias) = parse_npm_alias(&constraint) {
                    (name.clone(), alias.target_constraint.clone(), alias.target_package.clone())
                } else {
                    (name.clone(), constraint.clone(), name.clone())
                };

            let metadata = match ctx.metadata_cache.get(&target_package) {
                Some(m) => m.clone(),
                None => {
                    if !is_optional {
                        // Already logged in fetch phase
                    }
                    continue;
                }
            };

            let version_info = match resolve_version(&metadata, &actual_constraint) {
                Some(v) => v.clone(),
                None => {
                    if !is_optional {
                        ctx.failed.push((
                            name.clone(),
                            constraint.clone(),
                            format!("No version satisfies constraint {}", actual_constraint),
                        ));
                    }
                    continue;
                }
            };

            // Skip platform-incompatible packages
            if !is_platform_compatible(&version_info, &ctx.platform) {
                continue;
            }

            let key = format!("{}@{}", actual_name, version_info.version);
            if ctx.resolved.contains_key(&key) {
                continue;
            }

            // Get integrity hash
            let integrity = version_info
                .dist
                .integrity
                .clone()
                .or_else(|| version_info.dist.shasum.as_ref().map(|s| format!("sha1-{}", s)))
                .unwrap_or_default();

            // Collect all dependencies
            let mut dep_keys = Vec::new();
            for (dep_name, dep_constraint) in &version_info.dependencies {
                let dep_key = queue_dependency(&mut ctx, dep_name, dep_constraint, false);
                if let Some(k) = dep_key {
                    dep_keys.push(k);
                }
            }

            for (dep_name, dep_constraint) in &version_info.optional_dependencies {
                // Queue optional dependencies for resolution
                // Also track them in dep_keys so build.rs can create proper nested
                // symlinks when versions don't match (critical for esbuild platform binaries)
                let dep_key = queue_dependency(&mut ctx, dep_name, dep_constraint, true);
                if let Some(k) = dep_key {
                    dep_keys.push(k);
                }
            }

            for (dep_name, dep_constraint) in &version_info.peer_dependencies {
                queue_dependency(&mut ctx, dep_name, dep_constraint, true);
            }

            // Add to root deps if it's a direct dependency
            let root_key = format!("{}@{}", actual_name, version_info.version);
            if dep_count > 0 && ctx.root_deps.len() < dep_count * 2 {
                ctx.root_deps.push(root_key.clone());
            }

            // Store resolved package
            ctx.resolved.insert(
                key,
                ResolvedPackage {
                    pname: actual_name.clone(),
                    version: version_info.version.clone(),
                    url: version_info.dist.tarball.clone(),
                    integrity,
                    dependencies: dep_keys,
                    has_bin: version_info.bin.as_ref().map(|_| true),
                },
            );

            resolved_count += 1;
        }

        print!("\r  Resolved {} packages...", resolved_count);
        use std::io::Write;
        std::io::stdout().flush().ok();
    }

    println!("\r  Resolved {} packages total     ", ctx.resolved.len());

    // Post-process: Update dependency keys from constraints to resolved versions
    // Before: dependencies = ["jsonfile@^6.0.1"]
    // After:  dependencies = ["jsonfile@6.2.0"]
    let resolved_clone: Vec<(String, ResolvedPackage)> = ctx.resolved.iter()
        .map(|(k, v)| (k.clone(), v.clone()))
        .collect();

    for (_key, pkg) in &mut ctx.resolved {
        let mut updated_deps = Vec::new();
        for dep_constraint_key in &pkg.dependencies {
            // Parse the constraint key to get name and constraint
            let (dep_name, dep_constraint) = if dep_constraint_key.starts_with('@') {
                // Scoped package: @scope/name@constraint
                if let Some(at_pos) = dep_constraint_key[1..].find('@') {
                    let split_pos = at_pos + 1;
                    (
                        dep_constraint_key[..split_pos].to_string(),
                        dep_constraint_key[split_pos + 1..].to_string(),
                    )
                } else {
                    (dep_constraint_key.clone(), "*".to_string())
                }
            } else {
                // Regular package: name@constraint
                if let Some(at_pos) = dep_constraint_key.find('@') {
                    (
                        dep_constraint_key[..at_pos].to_string(),
                        dep_constraint_key[at_pos + 1..].to_string(),
                    )
                } else {
                    (dep_constraint_key.clone(), "*".to_string())
                }
            };

            // Find the resolved version for this dependency
            // Look through all resolved packages to find one that matches the name and constraint
            let mut found_version = None;
            for (_, resolved_pkg) in &resolved_clone {
                if resolved_pkg.pname == dep_name {
                    // Check if this version satisfies the constraint
                    if let Some(req) = parse_version_req(&dep_constraint) {
                        if let Ok(ver) = Version::parse(&resolved_pkg.version) {
                            if req.matches(&ver) {
                                found_version = Some(format!("{}@{}", dep_name, resolved_pkg.version));
                                break;
                            }
                        }
                    }
                }
            }

            if let Some(resolved_key) = found_version {
                updated_deps.push(resolved_key);
            } else {
                // Keep original if no match found (shouldn't happen normally)
                updated_deps.push(dep_constraint_key.clone());
            }
        }
        pkg.dependencies = updated_deps;
    }

    // Report failures
    if !ctx.failed.is_empty() {
        println!();
        println!("Warning: {} packages failed to resolve:", ctx.failed.len());
        for (name, constraint, error) in &ctx.failed {
            println!("  {} @ {}: {}", name, constraint, error);
        }
    }

    // Generate deps.nix
    let output_path = args.output.unwrap_or_else(|| args.project.join("deps.nix"));
    println!();
    println!("Generating {}...", output_path.display());

    let nix_content = generate_deps_nix(&ctx);
    fs::write(&output_path, nix_content)?;

    println!();
    println!("Done!");
    println!("  Output: {}", output_path.display());
    println!("  Packages: {}", ctx.resolved.len());
    println!("  Root dependencies: {}", ctx.root_deps.len());

    Ok(())
}

/// Fetch multiple package metadata from registry in parallel
async fn fetch_metadata_batch(
    client: &reqwest::Client,
    registry: &str,
    packages: &HashSet<String>,
) -> Vec<(String, Result<NpmPackageMetadata, String>)> {
    let futures: Vec<_> = packages
        .iter()
        .map(|name| {
            let client = client.clone();
            let registry = registry.to_string();
            let name = name.clone();
            async move {
                let result = fetch_single_metadata(&client, &registry, &name).await;
                (name, result)
            }
        })
        .collect();

    join_all(futures).await
}

/// Fetch single package metadata from registry
async fn fetch_single_metadata(
    client: &reqwest::Client,
    registry: &str,
    name: &str,
) -> Result<NpmPackageMetadata, String> {
    let url = if name.starts_with('@') {
        let encoded = name.replace('/', "%2f");
        format!("{}/{}", registry, encoded)
    } else {
        format!("{}/{}", registry, name)
    };

    let response = client
        .get(&url)
        .header("Accept", "application/json")
        .send()
        .await
        .map_err(|e| format!("Failed to fetch metadata for {}: {}", name, e))?;

    if !response.status().is_success() {
        return Err(format!(
            "Failed to fetch {}: HTTP {}",
            name,
            response.status()
        ));
    }

    response
        .json()
        .await
        .map_err(|e| format!("Failed to parse metadata for {}: {}", name, e))
}

/// Check if a version constraint is already satisfied
fn is_satisfied(ctx: &ResolutionContext, name: &str, constraint: &str) -> bool {
    let req = match parse_version_req(constraint) {
        Some(r) => r,
        None => return false,
    };

    ctx.resolved.iter().any(|(_key, pkg)| {
        if pkg.pname != name {
            return false;
        }
        if let Ok(version) = Version::parse(&pkg.version) {
            req.matches(&version)
        } else {
            false
        }
    })
}

/// Resolve best matching version
fn resolve_version<'a>(metadata: &'a NpmPackageMetadata, constraint: &str) -> Option<&'a NpmVersionInfo> {
    // Handle "latest" tag
    if constraint == "latest" || constraint == "*" {
        if let Some(latest_version) = metadata.dist_tags.get("latest") {
            return metadata.versions.get(latest_version);
        }
    }

    // Handle explicit tags
    if let Some(version) = metadata.dist_tags.get(constraint) {
        return metadata.versions.get(version);
    }

    // Parse as semver constraint
    let req = parse_version_req(constraint)?;

    // Find best matching version
    let mut best: Option<(&String, &NpmVersionInfo)> = None;
    for (version_str, info) in &metadata.versions {
        if let Ok(version) = Version::parse(version_str) {
            if req.matches(&version) {
                match &best {
                    None => best = Some((version_str, info)),
                    Some((best_str, _)) => {
                        if let Ok(best_ver) = Version::parse(best_str) {
                            if version > best_ver {
                                best = Some((version_str, info));
                            }
                        }
                    }
                }
            }
        }
    }

    best.map(|(_, info)| info)
}

/// Parse version requirement, handling npm-specific formats
fn parse_version_req(constraint: &str) -> Option<VersionReq> {
    let cleaned = constraint
        .trim()
        .trim_start_matches('v')
        .trim_start_matches('=');

    // Handle x-ranges
    let cleaned = cleaned
        .replace(".x", "")
        .replace(".X", "")
        .replace(".*", "");

    // Handle || (or) - take first option
    let cleaned = if let Some(pos) = cleaned.find("||") {
        cleaned[..pos].trim().to_string()
    } else {
        cleaned.to_string()
    };

    // Handle npm hyphen ranges: "1 - 2" -> ">=1, <=2"
    // Must check before space-separated handling
    if let Some(result) = parse_hyphen_range(&cleaned) {
        return Some(result);
    }

    // Handle space-separated ranges: ">=1.0.0 <2.0.0" -> ">=1.0.0, <2.0.0"
    // npm uses spaces to AND constraints together
    if let Some(result) = parse_space_separated_range(&cleaned) {
        return Some(result);
    }

    VersionReq::parse(&cleaned).ok()
}

/// Parse npm hyphen range: "1.2.3 - 2.3.4" -> ">=1.2.3, <=2.3.4"
fn parse_hyphen_range(constraint: &str) -> Option<VersionReq> {
    // Look for " - " pattern (space-hyphen-space)
    let parts: Vec<&str> = constraint.split(" - ").collect();
    if parts.len() == 2 {
        let lower = parts[0].trim();
        let upper = parts[1].trim();

        // Validate both parts look like versions (start with digit)
        if !lower.is_empty() && !upper.is_empty()
           && lower.chars().next().map(|c| c.is_ascii_digit()).unwrap_or(false)
           && upper.chars().next().map(|c| c.is_ascii_digit()).unwrap_or(false)
        {
            // Convert to semver range: >=lower, <=upper
            let semver_range = format!(">={}, <={}", lower, upper);
            return VersionReq::parse(&semver_range).ok();
        }
    }
    None
}

/// Parse space-separated constraints: ">=1.0.0 <2.0.0" -> ">=1.0.0, <2.0.0"
fn parse_space_separated_range(constraint: &str) -> Option<VersionReq> {
    // Split on spaces, but keep operators attached to versions
    let parts: Vec<&str> = constraint.split_whitespace().collect();

    if parts.len() < 2 {
        return None;
    }

    // Check if this looks like space-separated constraints
    // Each part should start with an operator or be a version
    let mut constraints: Vec<String> = Vec::new();
    let mut i = 0;

    while i < parts.len() {
        let part = parts[i];

        // If part starts with operator, it's a complete constraint
        if part.starts_with(">=") || part.starts_with("<=") ||
           part.starts_with('>') || part.starts_with('<') ||
           part.starts_with('^') || part.starts_with('~') {
            constraints.push(part.to_string());
            i += 1;
        }
        // If part is just an operator, combine with next part
        else if (part == ">=" || part == "<=" || part == ">" || part == "<") && i + 1 < parts.len() {
            constraints.push(format!("{}{}", part, parts[i + 1]));
            i += 2;
        }
        // Plain version number - treat as exact match
        else if part.chars().next().map(|c| c.is_ascii_digit()).unwrap_or(false) {
            constraints.push(format!("={}", part));
            i += 1;
        }
        else {
            // Unknown format, bail out
            return None;
        }
    }

    if constraints.len() >= 2 {
        let semver_range = constraints.join(", ");
        return VersionReq::parse(&semver_range).ok();
    }

    None
}

/// Parse npm alias: "npm:package@version"
fn parse_npm_alias(constraint: &str) -> Option<NpmAlias> {
    if !constraint.starts_with("npm:") {
        return None;
    }

    let rest = &constraint[4..];
    let (package, version) = if let Some(at_pos) = rest.rfind('@') {
        if at_pos == 0 {
            // Scoped package like npm:@scope/pkg
            if let Some(second_at) = rest[1..].find('@') {
                let pos = second_at + 1;
                (&rest[..pos], &rest[pos + 1..])
            } else {
                (rest, "*")
            }
        } else {
            (&rest[..at_pos], &rest[at_pos + 1..])
        }
    } else {
        (rest, "*")
    };

    Some(NpmAlias {
        target_package: package.to_string(),
        target_constraint: version.to_string(),
    })
}

/// Check platform compatibility
fn is_platform_compatible(info: &NpmVersionInfo, platform: &str) -> bool {
    if let Some(os_list) = &info.os {
        let blocked = format!("!{}", platform);
        if os_list.iter().any(|os| os == &blocked) {
            return false;
        }
        if !os_list.is_empty()
            && !os_list.iter().any(|os| os == platform || os.starts_with('!'))
        {
            return false;
        }
    }
    true
}

/// Queue a dependency for resolution
fn queue_dependency(
    ctx: &mut ResolutionContext,
    name: &str,
    constraint: &str,
    is_optional: bool,
) -> Option<String> {
    // Skip workspace/file dependencies
    if constraint.starts_with("workspace:")
        || constraint.starts_with("file:")
        || constraint.starts_with("link:")
    {
        return None;
    }

    let key = format!("{}@{}", name, constraint);
    if !ctx.queued.contains(&key) {
        ctx.queue.push_back((name.to_string(), constraint.to_string(), is_optional));
        ctx.queued.insert(key.clone());
    }
    Some(key)
}

/// Generate deps.nix content
fn generate_deps_nix(ctx: &ResolutionContext) -> String {
    let timestamp = Utc::now().format("%Y-%m-%dT%H:%M:%SZ");

    // Sort packages for deterministic output
    let mut packages: Vec<_> = ctx.resolved.iter().collect();
    packages.sort_by(|a, b| a.0.cmp(b.0));

    // Sort root deps
    let mut root_deps = ctx.root_deps.clone();
    root_deps.sort();

    // Sort workspace packages
    let mut workspace_packages = ctx.workspace_packages.clone();
    workspace_packages.sort_by(|a, b| a.name.cmp(&b.name));

    // Generate package entries
    let package_entries: Vec<String> = packages
        .iter()
        .map(|(key, pkg)| {
            let deps_str = if pkg.dependencies.is_empty() {
                String::new()
            } else {
                let deps: Vec<String> = pkg.dependencies.iter().map(|d| format!("\"{}\"", d)).collect();
                format!("\n      dependencies = [ {} ];", deps.join(" "))
            };

            let bin_str = if pkg.has_bin == Some(true) {
                "\n      hasBin = true;"
            } else {
                ""
            };

            format!(
                r#"    "{}" = {{
      pname = "{}";
      version = "{}";
      url = "{}";
      integrity = "{}";{}{}
    }};"#,
                key,
                escape_nix_string(&pkg.pname),
                pkg.version,
                escape_nix_string(&pkg.url),
                escape_nix_string(&pkg.integrity),
                deps_str,
                bin_str
            )
        })
        .collect();

    let root_deps_str: Vec<String> = root_deps.iter().map(|d| format!("    \"{}\"", d)).collect();

    // Generate workspace packages section
    let workspace_section = if workspace_packages.is_empty() {
        String::new()
    } else {
        let workspace_entries: Vec<String> = workspace_packages
            .iter()
            .map(|wp| {
                format!(
                    r#"    {{ name = "{}"; path = "{}"; }}"#,
                    escape_nix_string(&wp.name),
                    escape_nix_string(&wp.relative_path)
                )
            })
            .collect();

        format!(
            r#"

  # Workspace packages (local file: dependencies)
  # These are built from source by pleme-linker build-project
  workspacePackages = [
{}
  ];"#,
            workspace_entries.join("\n")
        )
    };

    format!(
        r#"# Generated by pleme-linker resolve
# DO NOT EDIT - regenerate with: pleme-linker resolve --project .
#
# This file IS the lockfile. It contains:
# - All resolved packages with exact versions
# - Tarball URLs and integrity hashes (from npm registry)
# - Dependency relationships
# - Workspace packages (local file: dependencies)
#
# Nix uses fetchurl to download each package (cached in Attic),
# then pleme-linker build assembles node_modules.
{{
  # Metadata
  generatedAt = "{timestamp}";
  resolverVersion = "0.3.0";
  packageCount = {package_count};

  # Root dependencies (direct deps from package.json)
  rootDependencies = [
{root_deps}
  ];

  # All resolved packages
  packages = {{
{packages}
  }};{workspace_section}
}}
"#,
        timestamp = timestamp,
        package_count = packages.len(),
        root_deps = root_deps_str.join("\n"),
        packages = package_entries.join("\n\n"),
        workspace_section = workspace_section
    )
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_parse_hyphen_range() {
        // "1 - 2" should become ">=1, <=2"
        let result = parse_hyphen_range("1 - 2");
        assert!(result.is_some(), "Should parse hyphen range '1 - 2'");

        // "1.2.3 - 2.3.4" should become ">=1.2.3, <=2.3.4"
        let result = parse_hyphen_range("1.2.3 - 2.3.4");
        assert!(result.is_some(), "Should parse hyphen range '1.2.3 - 2.3.4'");

        // Not a hyphen range
        let result = parse_hyphen_range(">=1.0.0");
        assert!(result.is_none(), "Should not parse non-hyphen range");
    }

    #[test]
    fn test_parse_space_separated_range() {
        // ">=1.0.0 <2.0.0" should become ">=1.0.0, <2.0.0"
        let result = parse_space_separated_range(">=1.0.0 <2.0.0");
        assert!(result.is_some(), "Should parse space-separated range '>=1.0.0 <2.0.0'");

        // ">=3.1.1 <6" - real example from npm packages
        let result = parse_space_separated_range(">=3.1.1 <6");
        assert!(result.is_some(), "Should parse space-separated range '>=3.1.1 <6'");

        // ">=0.5 0" - another npm format
        let result = parse_space_separated_range(">=0.5 <1");
        assert!(result.is_some(), "Should parse space-separated range '>=0.5 <1'");

        // Single constraint should not be parsed
        let result = parse_space_separated_range(">=1.0.0");
        assert!(result.is_none(), "Should not parse single constraint");
    }

    #[test]
    fn test_parse_version_req_npm_formats() {
        // Test that parse_version_req handles the problematic npm formats

        // Hyphen range
        let result = parse_version_req("1 - 2");
        assert!(result.is_some(), "parse_version_req should handle '1 - 2'");

        // Space-separated constraints
        let result = parse_version_req(">=3.1.1 <6");
        assert!(result.is_some(), "parse_version_req should handle '>=3.1.1 <6'");

        // Standard semver (should still work)
        let result = parse_version_req("^1.0.0");
        assert!(result.is_some(), "parse_version_req should handle '^1.0.0'");

        let result = parse_version_req(">=1.0.0");
        assert!(result.is_some(), "parse_version_req should handle '>=1.0.0'");

        let result = parse_version_req("~1.0.0");
        assert!(result.is_some(), "parse_version_req should handle '~1.0.0'");
    }
}