pkboost 2.2.0

Shannon-guided gradient boosting for extreme class imbalance with adaptive drift detection. Outperforms XGBoost/LightGBM on imbalanced data.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
// This is the main "living" model that can adapt to data drift in real-time
// The idea is to detect when the model starts failing and trigger a metamorphosis
// to prune bad trees and grow new ones on recent data

use crate::adversarial::{AdversarialEnsemble, Vulnerability};
use crate::metabolism::FeatureMetabolism;
use crate::metrics::calculate_pr_auc;
use crate::model::OptimizedPKBoostShannon;
use crate::optimized_data::TransposedData;
use crate::tree::{OptimizedTreeShannon, TreeParams};
use ndarray::{Array1, Array2, ArrayView1, ArrayView2};
use rayon::prelude::*;
use std::collections::VecDeque;
use std::time::Instant;

// State machine for the model - tracks if we're doing ok or need to adapt
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum SystemState {
    Normal,                           // everything's fine
    Alert { checks_in_alert: usize }, // performance is degrading
    Metamorphosis,                    // time to rebuild parts of the model
}

#[derive(Debug, Clone, Copy, PartialEq)]
pub enum MetamorphosisStrategy {
    Conservative,
    DataAware,
    FeatureAware,
}

pub struct DriftAnalyzer {
    feature_volatility: Vec<f64>,
    minority_class_error_rate: f64,
}

impl DriftAnalyzer {
    pub fn new(n_features: usize) -> Self {
        Self {
            feature_volatility: vec![0.0; n_features],
            minority_class_error_rate: 0.0,
        }
    }

    pub fn update(
        &mut self,
        recent_x: &VecDeque<Vec<f64>>,
        recent_y: &VecDeque<f64>,
        vulnerabilities: &VecDeque<Vulnerability>,
    ) {
        if recent_x.is_empty() {
            return;
        }

        let mut minority_errors = 0;
        let mut minority_total = 0;
        for (i, &true_y) in recent_y.iter().enumerate() {
            if true_y > 0.5 {
                minority_total += 1;
                for vuln in vulnerabilities.iter().take(1000) {
                    if vuln.sample_idx == i && vuln.error > 0.3 {
                        minority_errors += 1;
                        break;
                    }
                }
            }
        }
        self.minority_class_error_rate = if minority_total > 0 {
            minority_errors as f64 / minority_total as f64
        } else {
            0.0
        };

        let n_features = recent_x.get(0).map(|r| r.len()).unwrap_or(0);
        for feat_idx in 0..n_features {
            let mut vals: Vec<f64> = recent_x
                .iter()
                .filter_map(|row| row.get(feat_idx).copied().filter(|v| !v.is_nan()))
                .collect();
            if vals.is_empty() {
                continue;
            }
            vals.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));
            let median = vals[vals.len() / 2];
            let variance: f64 =
                vals.iter().map(|v| (v - median).powi(2)).sum::<f64>() / vals.len() as f64;
            self.feature_volatility[feat_idx] = variance.sqrt();
        }
    }

    pub fn select_strategy(&self) -> MetamorphosisStrategy {
        let avg_volatility = self.feature_volatility.iter().sum::<f64>()
            / self.feature_volatility.len().max(1) as f64;
        let corruption_score =
            ((avg_volatility / 10.0).min(1.0) * self.minority_class_error_rate * 2.0).min(1.0);
        let concept_drift_score = if avg_volatility < 3.0 && self.minority_class_error_rate > 0.3 {
            0.8
        } else {
            0.0
        };

        if corruption_score > 0.6 && corruption_score > concept_drift_score {
            MetamorphosisStrategy::FeatureAware
        } else if concept_drift_score > 0.7 {
            MetamorphosisStrategy::DataAware
        } else {
            MetamorphosisStrategy::Conservative
        }
    }
}

pub struct AdversarialLivingBooster {
    primary: OptimizedPKBoostShannon, // main gradient boosting model
    adversary: AdversarialEnsemble,   // tracks where the model is failing
    metabolism: FeatureMetabolism,    // monitors which features are still useful
    state: SystemState,
    alert_trigger_threshold: usize,
    metamorphosis_trigger_threshold: usize,
    vulnerability_alert_threshold: f64,
    vulnerability_metamorphosis_threshold: f64,
    baseline_vulnerability: f64,
    consecutive_vulnerable_checks: usize,
    observations_count: usize,
    metamorphosis_count: usize,   // how many times we've adapted
    recent_x: VecDeque<Vec<f64>>, // rolling buffer of recent samples (keep as Vec for streaming)
    recent_y: VecDeque<f64>,
    buffer_size: usize,
    metamorphosis_cooldown: usize, // dont adapt too frequently
    iterations_since_metamorphosis: usize,
    #[allow(dead_code)]
    drift_analyzer: DriftAnalyzer,
    #[allow(dead_code)]
    last_strategy: MetamorphosisStrategy,
    recent_pr_aucs: VecDeque<f64>,
    baseline_pr_auc: f64,
}

impl AdversarialLivingBooster {
    /// Create new AdversarialLivingBooster from ArrayView2 (zero-copy from Python)
    pub fn new(x_train: ArrayView2<'_, f64>, y_train: ArrayView1<'_, f64>) -> Self {
        let n_features = x_train.ncols();
        let n_samples = x_train.nrows();
        let y_slice = y_train.as_slice().unwrap();

        // figure out how imbalanced the data is - this affects everything
        let pos_ratio = y_slice.iter().sum::<f64>() / y_slice.len() as f64;
        let imbalance_level = if pos_ratio < 0.02 || pos_ratio > 0.98 {
            "extreme"
        } else if pos_ratio < 0.10 || pos_ratio > 0.90 {
            "high"
        } else if pos_ratio < 0.20 || pos_ratio > 0.80 {
            "moderate"
        } else {
            "balanced"
        };

        // Default thresholds (will be calibrated during fit_initial)
        let vuln_alert_threshold = 0.02;
        let vuln_meta_threshold = 0.03;

        // smaller datasets = be more agressive with adaptation
        let (alert_thresh, meta_thresh) = if n_samples < 50_000 {
            (1, 2) // More aggressive for testing
        } else if n_samples < 200_000 {
            (2, 3)
        } else {
            (3, 5) // larger datasets can afford to wait a bit
        };

        // keep a rolling window of recent data for retraining
        let buffer_sz = if n_samples < 50_000 {
            10000
        } else if n_samples < 200_000 {
            15000
        } else {
            20000
        };

        let cooldown = if n_samples < 50_000 {
            5000
        } else if n_samples < 200_000 {
            10000
        } else {
            15000
        };

        println!("\n=== Adaptive Metamorphosis Configuration ===");
        println!("Dataset: {} samples, {} features", n_samples, n_features);
        println!(
            "Positive ratio: {:.1}% ({})",
            pos_ratio * 100.0,
            imbalance_level
        );
        println!("Alert trigger: {} consecutive checks", alert_thresh);
        println!("Metamorphosis trigger: {} checks in alert", meta_thresh);
        println!("Buffer size: {} samples", buffer_sz);
        println!("Cooldown period: {} observations", cooldown);
        println!("Note: Vulnerability thresholds will be calibrated during fit_initial");
        println!("===========================================\n");

        Self {
            primary: OptimizedPKBoostShannon::auto(x_train, y_train),
            adversary: AdversarialEnsemble::new(pos_ratio),
            metabolism: FeatureMetabolism::new(n_features),
            state: SystemState::Normal,
            alert_trigger_threshold: alert_thresh,
            metamorphosis_trigger_threshold: meta_thresh,
            vulnerability_alert_threshold: vuln_alert_threshold,
            vulnerability_metamorphosis_threshold: vuln_meta_threshold,
            baseline_vulnerability: 0.0,
            consecutive_vulnerable_checks: 0,
            observations_count: 0,
            metamorphosis_count: 0,
            recent_x: VecDeque::with_capacity(buffer_sz),
            recent_y: VecDeque::with_capacity(buffer_sz),
            buffer_size: buffer_sz,
            metamorphosis_cooldown: cooldown,
            iterations_since_metamorphosis: 0,
            drift_analyzer: DriftAnalyzer::new(n_features),
            last_strategy: MetamorphosisStrategy::Conservative,
            recent_pr_aucs: VecDeque::with_capacity(5),
            baseline_pr_auc: 0.0,
        }
    }

    /// Initial training with ArrayView2 (zero-copy from Python)
    pub fn fit_initial(
        &mut self,
        x: ArrayView2<'_, f64>,
        y: ArrayView1<'_, f64>,
        eval_set: Option<(ArrayView2<'_, f64>, ArrayView1<'_, f64>)>,
        verbose: bool,
    ) -> Result<(), String> {
        if verbose {
            println!("\n=== INITIAL TRAINING (Adversarial Living Booster) ===");
        }
        self.primary.fit(x, y, eval_set, verbose)?;

        // Calibrate vulnerability thresholds on validation set
        if let Some((x_val, y_val)) = eval_set {
            let y_val_slice = y_val.as_slice().unwrap();
            let calibration = crate::auto_tuner::VulnerabilityCalibration::calibrate_view(
                &self.primary,
                x_val,
                y_val_slice,
            );
            self.baseline_vulnerability = calibration.baseline_vulnerability;
            self.vulnerability_alert_threshold = calibration.alert_threshold;
            self.vulnerability_metamorphosis_threshold = calibration.metamorphosis_threshold;

            // Set baseline PR-AUC for performance tracking
            let val_preds = self.primary.predict_proba(x_val)?;
            self.baseline_pr_auc = calculate_pr_auc(y_val_slice, val_preds.as_slice().unwrap());

            if verbose {
                println!("Baseline PR-AUC: {:.4}", self.baseline_pr_auc);
                println!("Vulnerability thresholds configured based on validation data");
            }
        }

        if verbose {
            println!("Initial training complete. Model ready for streaming.");
        }
        Ok(())
    }

    /// Process new streaming data batch with ArrayView2
    pub fn observe_batch(
        &mut self,
        x: ArrayView2<'_, f64>,
        y: ArrayView1<'_, f64>,
        verbose: bool,
    ) -> Result<(), String> {
        let y_slice = y.as_slice().ok_or("y must be contiguous")?;
        let n_samples = x.nrows();

        self.observations_count += n_samples;
        self.iterations_since_metamorphosis += n_samples;

        // maintain rolling buffer of recent samples
        for i in 0..n_samples {
            if self.recent_x.len() >= self.buffer_size {
                self.recent_x.pop_front();
                self.recent_y.pop_front();
            }
            let row: Vec<f64> = x.row(i).to_vec();
            self.recent_x.push_back(row);
            self.recent_y.push_back(y_slice[i]);
        }

        let primary_preds = self.primary.predict_proba(x)?;
        let preds_slice = primary_preds.as_slice().unwrap();

        // Track PR-AUC for performance-based triggering
        let batch_pr_auc = calculate_pr_auc(y_slice, preds_slice);
        self.recent_pr_aucs.push_back(batch_pr_auc);
        if self.recent_pr_aucs.len() > 5 {
            self.recent_pr_aucs.pop_front();
        }

        // check where the model is screwing up
        for (i, (&pred, &true_y)) in preds_slice.iter().zip(y_slice.iter()).enumerate() {
            let vuln = self.adversary.find_vulnerability(true_y, pred, i);
            self.adversary.record_vulnerability(vuln);
        }

        // track which features are actually being used
        let usage = self.primary.get_feature_usage();
        self.metabolism.update(&usage, self.observations_count);

        // dont trigger metamorphosis too often - need cooldown period
        if self.iterations_since_metamorphosis > self.metamorphosis_cooldown {
            self.update_state(verbose);
        } else if verbose && self.observations_count % 5000 < n_samples {
            println!(
                "In cooldown period: {}/{} observations since last metamorphosis",
                self.iterations_since_metamorphosis, self.metamorphosis_cooldown
            );
        }

        if let SystemState::Metamorphosis = self.state {
            if verbose {
                println!(
                    "\n=== METAMORPHOSIS TRIGGERED at observation {} ===",
                    self.observations_count
                );
            }
            self.execute_metamorphosis(verbose)?;
            self.iterations_since_metamorphosis = 0;
        }

        if verbose && self.observations_count % 5000 < n_samples {
            let vuln_score = self.get_vulnerability_score();
            let dead_features = self.metabolism.get_dead_features();
            println!(
                "Status @ {}: Vuln Score: {:.4}, State: {:?}, Dead Features: {}, Buffer: {}/{}",
                self.observations_count,
                vuln_score,
                self.state,
                dead_features.len(),
                self.recent_x.len(),
                self.buffer_size
            );
        }

        Ok(())
    }

    // state machine logic - decide if we need to go into alert or metamorphosis
    fn update_state(&mut self, verbose: bool) {
        let vuln_score = self.get_vulnerability_score();

        // Performance-based check
        let (performance_degraded, recent_avg) =
            if self.recent_pr_aucs.len() >= 3 && self.baseline_pr_auc > 0.0 {
                let avg: f64 =
                    self.recent_pr_aucs.iter().sum::<f64>() / self.recent_pr_aucs.len() as f64;
                let degradation = (self.baseline_pr_auc - avg) / self.baseline_pr_auc;
                (degradation > 0.10, avg) // 10% drop
            } else {
                (false, 0.0)
            };

        // Trigger if EITHER vulnerability OR performance degraded
        let is_vulnerable = vuln_score > self.vulnerability_alert_threshold || performance_degraded;

        // Reset to Normal only if performance actually recovered (within 5% of baseline)
        let performance_recovered = recent_avg >= self.baseline_pr_auc * 0.95;

        match self.state {
            SystemState::Normal => {
                if is_vulnerable && !performance_recovered {
                    self.consecutive_vulnerable_checks += 1;
                    if self.consecutive_vulnerable_checks >= self.alert_trigger_threshold {
                        if verbose {
                            println!(
                                "-- ALERT: Vulnerability score {:.4} > threshold {:.4} --",
                                vuln_score, self.vulnerability_alert_threshold
                            );
                        }
                        self.state = SystemState::Alert { checks_in_alert: 1 };
                    }
                } else if performance_recovered {
                    self.consecutive_vulnerable_checks = 0;
                }
            }
            SystemState::Alert { checks_in_alert } => {
                if is_vulnerable && performance_degraded {
                    if checks_in_alert + 1 >= self.metamorphosis_trigger_threshold {
                        if verbose {
                            println!("-- METAMORPHOSIS: Vulnerability {:.4} + performance degraded {} checks --",
                                vuln_score, checks_in_alert + 1);
                        }
                        self.state = SystemState::Metamorphosis;
                    } else {
                        self.state = SystemState::Alert {
                            checks_in_alert: checks_in_alert + 1,
                        };
                    }
                } else if performance_recovered {
                    // Only reset to Normal if performance actually recovered
                    if verbose {
                        println!("-- System state returned to NORMAL (performance recovered) --");
                    }
                    self.consecutive_vulnerable_checks = 0;
                    self.state = SystemState::Normal;
                } else {
                    // Stay in Alert but don't increment counter
                    println!("-- Staying in ALERT (performance still degraded) --");
                }
            }
            SystemState::Metamorphosis => {
                // Will be reset after metamorphosis completes
            }
        }
    }

    // the actual metamorphosis - prune bad trees and grow new ones
    fn execute_metamorphosis(&mut self, verbose: bool) -> Result<(), String> {
        let metamorphosis_start = Instant::now();

        // CHECKPOINT: Save state before metamorphosis
        let checkpoint_trees = self.primary.trees.clone();
        let checkpoint_pr_auc = self.baseline_pr_auc;

        let dead_features = self.metabolism.get_dead_features();

        if verbose {
            println!(
                "  - Checkpointing {} trees before metamorphosis",
                checkpoint_trees.len()
            );
            println!("  - Dead features: {:?}", dead_features);
            println!("  - Buffer: {} samples", self.recent_x.len());
        }

        // Only prune if we have dead features, otherwise just retrain
        let pruned_count = if !dead_features.is_empty() {
            let count = self.primary.prune_trees(&dead_features, 0.8);
            if verbose {
                println!("  - Pruned {} trees", count);
            }
            count
        } else {
            0
        };

        // Always add new trees on recent data
        if self.recent_x.len() > 1000 {
            let n_new_trees = if pruned_count > 0 {
                pruned_count.min(10)
            } else {
                5
            };

            if verbose {
                println!("  - Adding {} new trees on buffer data", n_new_trees);
            }

            match self.add_incremental_trees(n_new_trees, verbose) {
                Ok(added) => {
                    if verbose {
                        println!("  - Added {} trees", added);
                    }
                }
                Err(e) => {
                    if verbose {
                        println!("  - Error: {}", e);
                    }
                    // Rollback on error
                    self.primary.trees = checkpoint_trees;
                    self.state = SystemState::Normal;
                    self.consecutive_vulnerable_checks = 0;
                    return Err(e);
                }
            }
        }

        // VALIDATION: Test metamorphosis quality on held-out buffer data
        let validation_size = 2000.min(self.recent_x.len() / 2);
        if validation_size > 100 {
            // Convert buffer slice to Array2 for validation
            let val_x_vec: Vec<Vec<f64>> = self
                .recent_x
                .iter()
                .rev()
                .take(validation_size)
                .cloned()
                .collect();
            let val_y: Vec<f64> = self
                .recent_y
                .iter()
                .rev()
                .take(validation_size)
                .cloned()
                .collect();

            let val_x_array = vec_to_array2(&val_x_vec);
            let post_meta_preds = self.primary.predict_proba(val_x_array.view())?;
            let post_meta_pr_auc = calculate_pr_auc(&val_y, post_meta_preds.as_slice().unwrap());

            // ROLLBACK if performance degraded by more than 2%
            let performance_threshold = 0.98;
            if post_meta_pr_auc < checkpoint_pr_auc * performance_threshold {
                if verbose {
                    println!("  ⚠️  ROLLBACK: Metamorphosis degraded performance");
                    println!(
                        "     Before: {:.4}, After: {:.4}",
                        checkpoint_pr_auc, post_meta_pr_auc
                    );
                    println!("     Restoring {} trees", checkpoint_trees.len());
                }
                self.primary.trees = checkpoint_trees;
                self.state = SystemState::Normal;
                self.consecutive_vulnerable_checks = 0;
                self.adversary.recent_vulnerabilities.clear();
                return Ok(());
            }

            // SUCCESS: Update baseline with new performance
            self.baseline_pr_auc = post_meta_pr_auc;

            if verbose {
                println!(
                    "  ✅ Performance maintained: {:.4}{:.4}",
                    checkpoint_pr_auc, post_meta_pr_auc
                );
            }
        }

        self.metamorphosis_count += 1;
        self.state = SystemState::Normal;
        self.consecutive_vulnerable_checks = 0;
        self.adversary.recent_vulnerabilities.clear();

        let metamorphosis_time = metamorphosis_start.elapsed();

        if verbose {
            println!("=== METAMORPHOSIS COMPLETE ===");
            println!("  - Active trees: {}", self.primary.trees.len());
            println!("  - Total metamorphoses: {}", self.metamorphosis_count);
            println!("  - Took: {:.2}s", metamorphosis_time.as_secs_f64());
            println!();
        }

        Ok(())
    }

    // train new trees on recent data from the buffer
    fn add_incremental_trees(&mut self, n_trees: usize, verbose: bool) -> Result<usize, String> {
        let buffer_x_vec: Vec<Vec<f64>> = self.recent_x.iter().cloned().collect();
        let buffer_y: Vec<f64> = self.recent_y.iter().cloned().collect();

        // need enough data to train on
        if buffer_x_vec.len() < 1000 {
            return Err(format!(
                "Insufficient data in buffer for retraining: {} samples",
                buffer_x_vec.len()
            ));
        }

        if verbose {
            println!(
                "    - Retraining on {} recent samples from buffer",
                buffer_x_vec.len()
            );
        }

        // Convert to Array2 for predictions
        let buffer_x = vec_to_array2(&buffer_x_vec);

        // get current predictions and convert to log-odds for gradient boosting
        let current_probs = self.primary.predict_proba(buffer_x.view())?;
        let current_probs_slice = current_probs.as_slice().unwrap();

        // Check drift severity (for logging only)
        let avg_error: f64 = current_probs_slice
            .iter()
            .zip(buffer_y.iter())
            .map(|(pred, true_y)| (pred - true_y).abs())
            .sum::<f64>()
            / buffer_y.len() as f64;

        if verbose {
            println!("    - Drift assessment: avg error = {:.4}", avg_error);
        }

        // Always use current predictions as base (NEVER reset to zero)
        let mut raw_preds: Vec<f64> = current_probs_slice
            .iter()
            .map(|&p| {
                let p_clamped = p.clamp(1e-7, 1.0 - 1e-7);
                (p_clamped / (1.0 - p_clamped)).ln() // logit transform
            })
            .collect();

        let histogram_builder = self
            .primary
            .histogram_builder
            .as_ref()
            .ok_or("Histogram builder not initialized")?;

        // 🔥 OPTIMIZATION: Transform buffer data ONCE
        let x_processed = histogram_builder.transform(buffer_x.view());
        let transposed_data = TransposedData::from_binned(x_processed);

        let n_features = buffer_x.ncols();
        let feature_indices: Vec<usize> = (0..n_features).collect();
        let sample_indices: Vec<usize> = (0..buffer_x.nrows()).collect();

        let tree_params = TreeParams {
            min_samples_split: self.primary.min_samples_split,
            min_child_weight: self.primary.min_child_weight,
            reg_lambda: self.primary.reg_lambda,
            gamma: self.primary.gamma,
            mi_weight: self.primary.mi_weight,
            n_bins_per_feature: feature_indices
                .iter()
                .map(|&i| histogram_builder.n_bins_per_feature[i])
                .collect(),
            feature_elimination_threshold: 0.01,
        };

        let mut trees_added = 0;

        // standard gradient boosting loop
        for tree_idx in 0..n_trees {
            let grad =
                self.primary
                    .loss_fn
                    .gradient(&buffer_y, &raw_preds, self.primary.scale_pos_weight);
            let hess =
                self.primary
                    .loss_fn
                    .hessian(&buffer_y, &raw_preds, self.primary.scale_pos_weight);

            let mut new_tree = OptimizedTreeShannon::new(self.primary.max_depth);
            new_tree.fit_optimized(
                &transposed_data,
                &buffer_y,
                &grad,
                &hess,
                &sample_indices,
                &feature_indices,
                &tree_params,
            );

            // get predictions from new tree and update ensemble
            let tree_preds: Vec<f64> = (0..buffer_x.nrows())
                .into_par_iter()
                .map(|i| new_tree.predict_from_transposed(&transposed_data, i))
                .collect();

            for (i, &tree_pred) in tree_preds.iter().enumerate() {
                raw_preds[i] += self.primary.learning_rate * tree_pred;
            }

            self.primary.trees.push(new_tree);
            trees_added += 1;

            if verbose && (tree_idx + 1) % 5 == 0 {
                println!("    - Added tree {}/{}", tree_idx + 1, n_trees);
            }
        }

        Ok(trees_added)
    }

    /// Predict probabilities from ArrayView2 (zero-copy from Python)
    pub fn predict_proba(&self, x: ArrayView2<'_, f64>) -> Result<Array1<f64>, String> {
        self.primary.predict_proba(x)
    }

    pub fn get_state(&self) -> SystemState {
        self.state
    }

    pub fn get_metamorphosis_count(&self) -> usize {
        self.metamorphosis_count
    }

    pub fn get_vulnerability_score(&self) -> f64 {
        self.adversary.get_vulnerability_score()
    }
}

/// Helper to convert Vec<Vec<f64>> to Array2 (for internal buffer operations)
fn vec_to_array2(rows: &[Vec<f64>]) -> Array2<f64> {
    if rows.is_empty() {
        return Array2::zeros((0, 0));
    }
    let n_rows = rows.len();
    let n_cols = rows[0].len();
    let mut arr = Array2::zeros((n_rows, n_cols));
    for (i, row) in rows.iter().enumerate() {
        for (j, &val) in row.iter().enumerate() {
            arr[[i, j]] = val;
        }
    }
    arr
}