pil2-stark-setup 1.1.0-alpha

Setup and proving/verifying-key generation for the pil2-stark prover
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
use crate::expr::expression::{ExprChild, Expression};
use crate::types::pilout_info::FIELD_EXTENSION;

/// Goldilocks field negation of 1: p - 1 = 2^64 - 2^32 + 1 - 1 = 18446744069414584320
const NEG_ONE: &str = "18446744069414584320";

// ---------------------------------------------------------------------------
// add_info_expressions
// ---------------------------------------------------------------------------

/// Recursively walk expression trees computing `exp_deg`, `dim`, `stage`,
/// and `rows_offsets`. Mirrors the JS `addInfoExpressions` from helpers.js.
///
/// The `expressions` slice must be the flat expression array (indexed by ID).
/// This function mutates expressions in-place.
///
/// For arena-indexed expressions, call with the arena index. For expressions
/// with inline children, the inline children are processed recursively.
pub fn add_info_expressions(expressions: &mut Vec<Expression>, idx: usize) {
    // Guard: already processed (mirrors JS `if("expDeg" in exp) return;`)
    if expressions[idx].info_computed {
        return;
    }

    let op = expressions[idx].op.clone();

    match op.as_str() {
        "exp" => {
            let ref_id = expressions[idx].id.unwrap_or(0);
            add_info_expressions(expressions, ref_id);

            let exp_deg = expressions[ref_id].exp_deg;
            let rows_offsets = expressions[ref_id].rows_offsets.clone();
            let ref_dim = expressions[ref_id].dim;
            let ref_stage = expressions[ref_id].stage;

            expressions[idx].exp_deg = exp_deg;
            expressions[idx].rows_offsets = rows_offsets;
            if expressions[idx].dim <= 1 {
                expressions[idx].dim = ref_dim;
            }
            if expressions[idx].stage == 0 {
                expressions[idx].stage = ref_stage;
            }
        }
        "cm" | "custom" | "const" => {
            expressions[idx].exp_deg = 1;
            if expressions[idx].stage == 0 || op == "const" {
                expressions[idx].stage = if op == "cm" { 1 } else { 0 };
            }
            if expressions[idx].dim == 0 || expressions[idx].dim == 1 {
                expressions[idx].dim = 1;
            }
            if let Some(row_off) = expressions[idx].row_offset {
                expressions[idx].rows_offsets = vec![row_off];
            }
        }
        "Zi" => {
            let boundary = expressions[idx].boundary.clone();
            if boundary.as_deref() != Some("everyRow") {
                expressions[idx].exp_deg = 1;
            } else {
                // everyRow Zi
                expressions[idx].exp_deg = 0;
                expressions[idx].stage = 0;
                if expressions[idx].dim <= 1 {
                    expressions[idx].dim = 1;
                }
            }
        }
        "xDivXSubXi" => {
            expressions[idx].exp_deg = 1;
        }
        "challenge" | "eval" => {
            expressions[idx].exp_deg = 0;
            expressions[idx].dim = FIELD_EXTENSION;
        }
        "airgroupvalue" | "proofvalue" => {
            expressions[idx].exp_deg = 0;
            if expressions[idx].dim <= 1 {
                expressions[idx].dim = if expressions[idx].stage != 1 { FIELD_EXTENSION } else { 1 };
            }
        }
        "airvalue" => {
            expressions[idx].exp_deg = 0;
            if expressions[idx].dim <= 1 {
                expressions[idx].dim = if expressions[idx].stage != 1 { FIELD_EXTENSION } else { 1 };
            }
        }
        "public" => {
            expressions[idx].exp_deg = 0;
            expressions[idx].stage = 1;
            if expressions[idx].dim <= 1 {
                expressions[idx].dim = 1;
            }
        }
        "number" => {
            expressions[idx].exp_deg = 0;
            expressions[idx].stage = 0;
            if expressions[idx].dim <= 1 {
                expressions[idx].dim = 1;
            }
        }
        "add" | "sub" | "mul" | "neg" => {
            handle_binary_or_neg(expressions, idx);
        }
        _ => {
            panic!("Exp op not defined: {}", op);
        }
    }
    expressions[idx].info_computed = true;
}

/// Compute info (exp_deg, dim, stage, rows_offsets) on a standalone
/// Expression that is NOT in the arena. Inline children are processed
/// recursively; `exp` references are resolved via the arena.
pub fn add_info_expression_inline(expressions: &mut Vec<Expression>, expr: &mut Expression) {
    if expr.info_computed {
        return;
    }

    let op = expr.op.clone();

    match op.as_str() {
        "exp" => {
            let ref_id = expr.id.unwrap_or(0);
            add_info_expressions(expressions, ref_id);

            expr.exp_deg = expressions[ref_id].exp_deg;
            expr.rows_offsets = expressions[ref_id].rows_offsets.clone();
            if expr.dim <= 1 {
                expr.dim = expressions[ref_id].dim;
            }
            if expr.stage == 0 {
                expr.stage = expressions[ref_id].stage;
            }
        }
        "cm" | "custom" | "const" => {
            expr.exp_deg = 1;
            if expr.stage == 0 || op == "const" {
                expr.stage = if op == "cm" { 1 } else { 0 };
            }
            if expr.dim == 0 || expr.dim == 1 {
                expr.dim = 1;
            }
            if let Some(row_off) = expr.row_offset {
                expr.rows_offsets = vec![row_off];
            }
        }
        "Zi" => {
            if expr.boundary.as_deref() != Some("everyRow") {
                expr.exp_deg = 1;
            } else {
                expr.exp_deg = 0;
                expr.stage = 0;
                if expr.dim <= 1 {
                    expr.dim = 1;
                }
            }
        }
        "xDivXSubXi" => {
            expr.exp_deg = 1;
        }
        "challenge" | "eval" => {
            expr.exp_deg = 0;
            expr.dim = FIELD_EXTENSION;
        }
        "airgroupvalue" | "proofvalue" => {
            expr.exp_deg = 0;
            if expr.dim <= 1 {
                expr.dim = if expr.stage != 1 { FIELD_EXTENSION } else { 1 };
            }
        }
        "airvalue" => {
            expr.exp_deg = 0;
            if expr.dim <= 1 {
                expr.dim = if expr.stage != 1 { FIELD_EXTENSION } else { 1 };
            }
        }
        "public" => {
            expr.exp_deg = 0;
            expr.stage = 1;
            if expr.dim <= 1 {
                expr.dim = 1;
            }
        }
        "number" => {
            expr.exp_deg = 0;
            expr.stage = 0;
            if expr.dim <= 1 {
                expr.dim = 1;
            }
        }
        "add" | "sub" | "mul" | "neg" => {
            handle_binary_or_neg_inline(expressions, expr);
        }
        _ => {
            panic!("Exp op not defined: {}", op);
        }
    }
    expr.info_computed = true;
}

/// Handle add/sub/mul/neg operations in add_info_expressions.
/// Mirrors the JS logic including neg->mul transformation and
/// zero-constant optimizations.
fn handle_binary_or_neg(expressions: &mut Vec<Expression>, idx: usize) {
    let op = expressions[idx].op.clone();

    // neg -> mul by NEG_ONE  (inline, NOT pushed to arena — matches JS behaviour)
    if op == "neg" {
        expressions[idx].op = "mul".to_string();
        let neg_one = Expression {
            op: "number".to_string(),
            value: Some(NEG_ONE.to_string()),
            exp_deg: 0,
            stage: 0,
            dim: 1,
            ..Default::default()
        };
        let existing_values = expressions[idx].values.clone();
        expressions[idx].values = vec![ExprChild::Inline(Box::new(neg_one)), existing_values[0].clone()];
    }

    let current_op = expressions[idx].op.clone();

    // For add where LHS is number(0), convert to mul with LHS=1
    if current_op == "add" {
        let lhs_is_zero = {
            let lhs = expressions[idx].values[0].resolve(expressions);
            lhs.op == "number" && lhs.value.as_deref() == Some("0")
        };
        if lhs_is_zero {
            expressions[idx].op = "mul".to_string();
            // Extract child kind first to avoid overlapping borrows
            let child = expressions[idx].values[0].clone();
            match child {
                ExprChild::Id(id) => {
                    expressions[id].value = Some("1".to_string());
                }
                ExprChild::Inline(mut expr) => {
                    expr.value = Some("1".to_string());
                    expressions[idx].values[0] = ExprChild::Inline(expr);
                }
            }
        }
    }

    // For add/sub where RHS is number(0), convert to mul with RHS=1
    let current_op = expressions[idx].op.clone();
    if current_op == "add" || current_op == "sub" {
        let rhs_is_zero = {
            let rhs = expressions[idx].values[1].resolve(expressions);
            rhs.op == "number" && rhs.value.as_deref() == Some("0")
        };
        if rhs_is_zero {
            expressions[idx].op = "mul".to_string();
            let child = expressions[idx].values[1].clone();
            match child {
                ExprChild::Id(id) => {
                    expressions[id].value = Some("1".to_string());
                }
                ExprChild::Inline(mut expr) => {
                    expr.value = Some("1".to_string());
                    expressions[idx].values[1] = ExprChild::Inline(expr);
                }
            }
        }
    }

    // Process children: for Id children, recurse via arena; for Inline, recurse inline
    for i in 0..expressions[idx].values.len() {
        match expressions[idx].values[i].clone() {
            ExprChild::Id(child_id) => {
                add_info_expressions(expressions, child_id);
            }
            ExprChild::Inline(mut child) => {
                add_info_expression_inline(expressions, &mut child);
                expressions[idx].values[i] = ExprChild::Inline(child);
            }
        }
    }

    // Read child info
    let (lhs_deg, lhs_dim, lhs_stage, lhs_offsets) = {
        let lhs = expressions[idx].values[0].resolve(expressions);
        (lhs.exp_deg, lhs.dim, lhs.stage, if lhs.rows_offsets.is_empty() { vec![0] } else { lhs.rows_offsets.clone() })
    };
    let (rhs_deg, rhs_dim, rhs_stage, rhs_offsets) = {
        let rhs = expressions[idx].values[1].resolve(expressions);
        (rhs.exp_deg, rhs.dim, rhs.stage, if rhs.rows_offsets.is_empty() { vec![0] } else { rhs.rows_offsets.clone() })
    };

    let final_op = expressions[idx].op.clone();
    expressions[idx].exp_deg = if final_op == "mul" { lhs_deg + rhs_deg } else { lhs_deg.max(rhs_deg) };

    expressions[idx].dim = lhs_dim.max(rhs_dim);
    expressions[idx].stage = lhs_stage.max(rhs_stage);

    // Merge rows_offsets
    let mut merged: Vec<i64> = lhs_offsets;
    for o in rhs_offsets {
        if !merged.contains(&o) {
            merged.push(o);
        }
    }
    expressions[idx].rows_offsets = merged;
}

/// Handle add/sub/mul/neg for inline expressions (not in the arena).
fn handle_binary_or_neg_inline(expressions: &mut Vec<Expression>, expr: &mut Expression) {
    let op = expr.op.clone();

    // neg -> mul by NEG_ONE
    if op == "neg" {
        expr.op = "mul".to_string();
        let neg_one = Expression {
            op: "number".to_string(),
            value: Some(NEG_ONE.to_string()),
            exp_deg: 0,
            stage: 0,
            dim: 1,
            ..Default::default()
        };
        let existing_values = expr.values.clone();
        expr.values = vec![ExprChild::Inline(Box::new(neg_one)), existing_values[0].clone()];
    }

    let current_op = expr.op.clone();
    if current_op == "add" {
        let lhs_is_zero = {
            let lhs = expr.values[0].resolve(expressions);
            lhs.op == "number" && lhs.value.as_deref() == Some("0")
        };
        if lhs_is_zero {
            expr.op = "mul".to_string();
            match &mut expr.values[0] {
                ExprChild::Id(id) => {
                    expressions[*id].value = Some("1".to_string());
                }
                ExprChild::Inline(e) => {
                    e.value = Some("1".to_string());
                }
            }
        }
    }

    let current_op = expr.op.clone();
    if current_op == "add" || current_op == "sub" {
        let rhs_is_zero = {
            let rhs = expr.values[1].resolve(expressions);
            rhs.op == "number" && rhs.value.as_deref() == Some("0")
        };
        if rhs_is_zero {
            expr.op = "mul".to_string();
            match &mut expr.values[1] {
                ExprChild::Id(id) => {
                    expressions[*id].value = Some("1".to_string());
                }
                ExprChild::Inline(e) => {
                    e.value = Some("1".to_string());
                }
            }
        }
    }

    // Process children
    for i in 0..expr.values.len() {
        match expr.values[i].clone() {
            ExprChild::Id(child_id) => {
                add_info_expressions(expressions, child_id);
            }
            ExprChild::Inline(mut child) => {
                add_info_expression_inline(expressions, &mut child);
                expr.values[i] = ExprChild::Inline(child);
            }
        }
    }

    // Read child info
    let (lhs_deg, lhs_dim, lhs_stage, lhs_offsets) = {
        let lhs = expr.values[0].resolve(expressions);
        (lhs.exp_deg, lhs.dim, lhs.stage, if lhs.rows_offsets.is_empty() { vec![0] } else { lhs.rows_offsets.clone() })
    };
    let (rhs_deg, rhs_dim, rhs_stage, rhs_offsets) = {
        let rhs = expr.values[1].resolve(expressions);
        (rhs.exp_deg, rhs.dim, rhs.stage, if rhs.rows_offsets.is_empty() { vec![0] } else { rhs.rows_offsets.clone() })
    };

    let final_op = expr.op.clone();
    expr.exp_deg = if final_op == "mul" { lhs_deg + rhs_deg } else { lhs_deg.max(rhs_deg) };

    expr.dim = lhs_dim.max(rhs_dim);
    expr.stage = lhs_stage.max(rhs_stage);

    let mut merged: Vec<i64> = lhs_offsets;
    for o in rhs_offsets {
        if !merged.contains(&o) {
            merged.push(o);
        }
    }
    expr.rows_offsets = merged;
}

// ---------------------------------------------------------------------------
// get_exp_dim
// ---------------------------------------------------------------------------

/// Get the field dimension of an expression, mirroring JS `getExpDim`.
pub fn get_exp_dim(expressions: &[Expression], exp_id: usize) -> usize {
    get_exp_dim_inner(expressions, &expressions[exp_id])
}

fn get_exp_dim_inner(expressions: &[Expression], exp: &Expression) -> usize {
    if exp.dim > 0 && exp.op != "add" && exp.op != "sub" && exp.op != "mul" {
        return exp.dim;
    }

    match exp.op.as_str() {
        "add" | "sub" | "mul" => {
            let mut max_dim = 0;
            for child in &exp.values {
                let child_expr = child.resolve(expressions);
                let child_dim = get_exp_dim_inner(expressions, child_expr);
                if child_dim > max_dim {
                    max_dim = child_dim;
                }
            }
            max_dim
        }
        "exp" => {
            let id = exp.id.unwrap_or(0);
            get_exp_dim_inner(expressions, &expressions[id])
        }
        "cm" | "custom" => {
            if exp.dim > 0 {
                exp.dim
            } else {
                1
            }
        }
        "const" | "number" | "public" | "Zi" => 1,
        "challenge" | "eval" | "xDivXSubXi" => FIELD_EXTENSION,
        _ => panic!("Exp op not defined: {}", exp.op),
    }
}

/// Track which columns (cm, const, custom) are referenced by an expression tree.
/// Mirrors JS `addInfoExpressionsSymbols`.
///
/// `ev_map` accumulates unique (type, id, prime, commitId) entries.
#[derive(Debug, Clone, PartialEq)]
pub struct EvMapItem {
    pub entry_type: String,
    pub id: usize,
    pub prime: i64,
    pub commit_id: Option<usize>,
}

pub fn add_info_expressions_symbols(
    ev_map: &mut Vec<EvMapItem>,
    expressions: &[Expression],
    idx: usize,
    explored: &mut Vec<bool>,
) {
    if explored[idx] {
        return;
    }

    let exp = &expressions[idx];
    let op = exp.op.clone();

    match op.as_str() {
        "exp" => {
            let ref_id = exp.id.unwrap_or(0);
            add_info_expressions_symbols(ev_map, expressions, ref_id, explored);
            explored[idx] = true;
        }
        "cm" | "const" | "custom" => {
            let id = exp.id.unwrap_or(0);
            let prime = exp.row_offset.unwrap_or(0);
            let commit_id = exp.commit_id;

            let new_item = EvMapItem { entry_type: op.clone(), id, prime, commit_id };

            let already_present = ev_map.iter().any(|item| {
                item.entry_type == new_item.entry_type
                    && item.id == new_item.id
                    && item.prime == new_item.prime
                    && (new_item.commit_id.is_none() || item.commit_id == new_item.commit_id)
            });

            if !already_present {
                ev_map.push(new_item);
            }
        }
        "add" | "sub" | "mul" | "neg" => {
            // Collect child arena IDs; for inline children, recurse into them
            let values = expressions[idx].values.clone();
            for child in &values {
                match child {
                    ExprChild::Id(child_id) => {
                        add_info_expressions_symbols(ev_map, expressions, *child_id, explored);
                    }
                    ExprChild::Inline(child_expr) => {
                        add_info_expressions_symbols_inline(ev_map, expressions, child_expr, explored);
                    }
                }
            }
            explored[idx] = true;
        }
        _ => {}
    }
}

/// Walk inline expression trees for symbol collection.
/// Shares the `explored` vec from the parent to avoid re-exploring arena expressions.
fn add_info_expressions_symbols_inline(
    ev_map: &mut Vec<EvMapItem>,
    expressions: &[Expression],
    expr: &Expression,
    explored: &mut Vec<bool>,
) {
    match expr.op.as_str() {
        "exp" => {
            let ref_id = expr.id.unwrap_or(0);
            add_info_expressions_symbols(ev_map, expressions, ref_id, explored);
        }
        "cm" | "const" | "custom" => {
            let id = expr.id.unwrap_or(0);
            let prime = expr.row_offset.unwrap_or(0);
            let commit_id = expr.commit_id;

            let new_item = EvMapItem { entry_type: expr.op.clone(), id, prime, commit_id };

            let already_present = ev_map.iter().any(|item| {
                item.entry_type == new_item.entry_type
                    && item.id == new_item.id
                    && item.prime == new_item.prime
                    && (new_item.commit_id.is_none() || item.commit_id == new_item.commit_id)
            });

            if !already_present {
                ev_map.push(new_item);
            }
        }
        "add" | "sub" | "mul" | "neg" => {
            for child in &expr.values {
                match child {
                    ExprChild::Id(child_id) => {
                        add_info_expressions_symbols(ev_map, expressions, *child_id, explored);
                    }
                    ExprChild::Inline(child_expr) => {
                        add_info_expressions_symbols_inline(ev_map, expressions, child_expr, explored);
                    }
                }
            }
        }
        _ => {}
    }
}

// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------

#[cfg(test)]
mod tests {
    use super::*;

    fn make_number(val: &str) -> Expression {
        Expression { op: "number".to_string(), value: Some(val.to_string()), ..Default::default() }
    }

    fn make_cm(id: usize, stage: usize) -> Expression {
        Expression { op: "cm".to_string(), id: Some(id), stage, dim: 1, row_offset: Some(0), ..Default::default() }
    }

    #[test]
    fn test_add_info_number() {
        let mut exprs = vec![make_number("42")];
        add_info_expressions(&mut exprs, 0);
        assert_eq!(exprs[0].exp_deg, 0);
        assert_eq!(exprs[0].dim, 1);
        assert_eq!(exprs[0].stage, 0);
    }

    #[test]
    fn test_add_info_cm() {
        let mut exprs = vec![make_cm(0, 1)];
        add_info_expressions(&mut exprs, 0);
        assert_eq!(exprs[0].exp_deg, 1);
        assert_eq!(exprs[0].dim, 1);
        assert_eq!(exprs[0].stage, 1);
    }

    #[test]
    fn test_add_info_mul() {
        // mul(cm, cm) => exp_deg = 2
        let cm1 = make_cm(0, 1);
        let cm2 = make_cm(1, 1);
        let mul_expr = Expression {
            op: "mul".to_string(),
            values: vec![ExprChild::Id(0), ExprChild::Id(1)],
            ..Default::default()
        };
        let mut exprs = vec![cm1, cm2, mul_expr];
        add_info_expressions(&mut exprs, 2);
        assert_eq!(exprs[2].exp_deg, 2);
        assert_eq!(exprs[2].dim, 1);
        assert_eq!(exprs[2].stage, 1);
    }

    #[test]
    fn test_get_exp_dim_number() {
        let exprs =
            vec![Expression { op: "number".to_string(), value: Some("1".to_string()), dim: 1, ..Default::default() }];
        assert_eq!(get_exp_dim(&exprs, 0), 1);
    }

    #[test]
    fn test_get_exp_dim_challenge() {
        let exprs = vec![Expression { op: "challenge".to_string(), dim: FIELD_EXTENSION, ..Default::default() }];
        assert_eq!(get_exp_dim(&exprs, 0), FIELD_EXTENSION);
    }

    #[test]
    fn test_ev_map_dedup() {
        let exprs = vec![
            make_cm(0, 1),
            make_cm(0, 1),
            Expression {
                op: "add".to_string(),
                values: vec![ExprChild::Id(0), ExprChild::Id(1)],
                ..Default::default()
            },
        ];
        let mut ev_map = Vec::new();
        let mut explored = vec![false; exprs.len()];
        add_info_expressions_symbols(&mut ev_map, &exprs, 2, &mut explored);
        // Both children reference cm id=0 prime=0, so dedup should give 1 entry
        assert_eq!(ev_map.len(), 1);
    }
}