Checking bench-table v0.1.0 (/opt/stefan/rust/github/pie_core/tools/bench-table)
warning: manual implementation of `Option::map`
--> tools/bench-table/src/main.rs:393:13
|
393 | / if let Some(dash_pos) = name.find('-') {
394 | | Some(BenchResult {
395 | | category: "legacy".to_string(),
396 | | operation: name[dash_pos + 1..].to_string(),
... |
402 | | None
403 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
help: try
|
393 ~ name.find('-').map(|dash_pos| BenchResult {
394 + category: "legacy".to_string(),
395 + operation: name[dash_pos + 1..].to_string(),
396 + implementation: name[..dash_pos].to_string(),
397 + size: None,
398 + time_ns: 0.0,
399 + })
|
warning: this `if` statement can be collapsed
--> tools/bench-table/src/main.rs:481:9
|
481 | / ... if let Some(ref filter_cat) = options.filter_category {
482 | | ... if !category.to_lowercase().contains(&filter_cat.to_lowerca...
483 | | ... continue;
484 | | ... }
485 | | ... }
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
481 ~ if let Some(ref filter_cat) = options.filter_category
482 ~ && !category.to_lowercase().contains(&filter_cat.to_lowercase()) {
483 | continue;
484 ~ }
|
warning: consider using `sort_by_key`
--> tools/bench-table/src/main.rs:512:9
|
512 | all_sizes.sort_by(|a, b| a.unwrap_or(0).cmp(&b.unwrap_or(0)));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `all_sizes.sort_by_key(|a| a.unwrap_or(0))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_sort_by
= note: `#[warn(clippy::unnecessary_sort_by)]` on by default
warning: you seem to want to iterate on a map's values
--> tools/bench-table/src/main.rs:789:32
|
789 | for (_, op_results) in operations {
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#for_kv_map
= note: `#[warn(clippy::for_kv_map)]` on by default
help: use the corresponding method
|
789 - for (_, op_results) in operations {
789 + for op_results in operations.values() {
|
warning: this `if` statement can be collapsed
--> tools/bench-table/src/main.rs:996:9
|
996 | / ... if let Some(ref filter_cat) = options.filter_category {
997 | | ... if !category.to_lowercase().contains(&filter_cat.to_lowerc...
998 | | ... continue;
999 | | ... }
1000 | | ... }
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#collapsible_if
help: collapse nested if block
|
996 ~ if let Some(ref filter_cat) = options.filter_category
997 ~ && !category.to_lowercase().contains(&filter_cat.to_lowercase()) {
998 | continue;
999 ~ }
|
warning: this `if` statement can be collapsed
--> tools/bench-table/src/main.rs:1085:13
|
1085 | / ... if let Some(ref filter_cat) = options.filter_category {
1086 | | ... if !key.category.to_lowercase().contains(&filter_cat.to_lo...
1087 | | ... continue;
1088 | | ... }
1089 | | ... }
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#collapsible_if
help: collapse nested if block
|
1085 ~ if let Some(ref filter_cat) = options.filter_category
1086 ~ && !key.category.to_lowercase().contains(&filter_cat.to_lowercase()) {
1087 | continue;
1088 ~ }
|
warning: redundant closure
--> tools/bench-table/src/main.rs:1101:65
|
1101 | ...r("-".to_string(), |s| format_size(s));
| ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_size`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
warning: this `if` statement can be collapsed
--> tools/bench-table/src/main.rs:1125:9
|
1125 | / ... if let Some(ref filter_cat) = options.filter_category {
1126 | | ... if !key.category.to_lowercase().contains(&filter_cat.to_lo...
1127 | | ... continue;
1128 | | ... }
1129 | | ... }
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#collapsible_if
help: collapse nested if block
|
1125 ~ if let Some(ref filter_cat) = options.filter_category
1126 ~ && !key.category.to_lowercase().contains(&filter_cat.to_lowercase()) {
1127 | continue;
1128 ~ }
|
warning: redundant closure
--> tools/bench-table/src/main.rs:1141:61
|
1141 | ...r("-".to_string(), |s| format_size(s));
| ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_size`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#redundant_closure
warning: `bench-table` (bin "bench-table") generated 9 warnings (run `cargo clippy --fix --bin "bench-table" -p bench-table` to apply 9 suggestions)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s