pi_agent_rust 0.8.0

Native AI coding agent CLI - Rust port of Pi Agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
//! Deterministic scheduler probes for the production deadline wrapper.
//! These futures model blocked cleanup; they do not replace a Provider or Tool.

use super::*;
use crate::model::{ContentBlock, TextContent};
use crate::session_control::TurnGuard;
use asupersync::time::VirtualClock;
use std::sync::Arc;
use std::sync::atomic::{AtomicBool, AtomicUsize, Ordering};
use std::task::{Wake, Waker};

#[derive(Default)]
struct WakeCount(AtomicUsize);

impl Wake for WakeCount {
    fn wake(self: Arc<Self>) {
        self.0.fetch_add(1, Ordering::SeqCst);
    }

    fn wake_by_ref(self: &Arc<Self>) {
        self.0.fetch_add(1, Ordering::SeqCst);
    }
}

struct DrainProbe {
    guard: Option<TurnGuard>,
    release: Arc<AtomicBool>,
    polls: Arc<AtomicUsize>,
    drops: Arc<AtomicUsize>,
    completion: Option<Result<AssistantMessage>>,
    cross_deadline: Option<Arc<VirtualClock>>,
}

impl Future for DrainProbe {
    type Output = Result<AssistantMessage>;

    fn poll(mut self: Pin<&mut Self>, _: &mut Context<'_>) -> Poll<Self::Output> {
        self.polls.fetch_add(1, Ordering::SeqCst);
        if let Some(clock) = self.cross_deadline.take() {
            clock.advance_to(Time::from_secs(20));
        }
        if !self.release.load(Ordering::SeqCst) {
            return Poll::Pending;
        }
        drop(self.guard.take());
        Poll::Ready(self.completion.take().unwrap())
    }
}

impl Drop for DrainProbe {
    fn drop(&mut self) {
        self.drops.fetch_add(1, Ordering::SeqCst);
    }
}

fn clock_deadline() -> (Arc<VirtualClock>, TurnDeadline) {
    let clock = Arc::new(VirtualClock::new());
    let timer = TimerDriverHandle::with_virtual_clock(Arc::clone(&clock));
    let deadline =
        TurnDeadline::from_timer(&AgentCx::for_request(), timer, Duration::from_secs(10)).unwrap();
    (clock, deadline)
}

fn turn(completion: Result<AssistantMessage>) -> ControlledTurn<DrainProbe> {
    let (control, guard, _) = crate::session_control::tests::live();
    ControlledTurn {
        control,
        polled: false,
        future: Box::pin(DrainProbe {
            guard: Some(guard),
            release: Arc::new(AtomicBool::new(false)),
            polls: Arc::new(AtomicUsize::new(0)),
            drops: Arc::new(AtomicUsize::new(0)),
            completion: Some(completion),
            cross_deadline: None,
        }),
    }
}

fn poll<F: Future + Unpin>(future: &mut F) -> Poll<F::Output> {
    Pin::new(future).poll(&mut Context::from_waker(Waker::noop()))
}

#[test]
fn deadline_is_absolute_and_clones_share_remaining_time() {
    let (clock, deadline) = clock_deadline();
    let shared = deadline.clone();
    clock.advance_to(Time::from_secs(7));
    assert_eq!(deadline.remaining(), Duration::from_secs(3));
    assert_eq!(shared.at(), deadline.at());
    assert_eq!(shared.remaining(), deadline.remaining());
    clock.advance_to(Time::from_secs(10));
    assert!(shared.is_elapsed());
    assert_eq!(shared.remaining(), Duration::ZERO);
}

#[test]
fn inherited_deadline_is_a_ceiling_not_a_fresh_budget() {
    let clock = Arc::new(VirtualClock::new());
    let timer = TimerDriverHandle::with_virtual_clock(clock);
    let owner = AgentCx::for_request_with_budget(
        asupersync::Budget::new().with_deadline(Time::from_secs(2)),
    );
    let deadline = TurnDeadline::from_timer(&owner, timer, Duration::from_secs(10)).unwrap();
    assert_eq!(deadline.at(), Time::from_secs(2));
}

#[test]
fn invalid_durations_and_clock_overflow_are_rejected() {
    let (clock, deadline) = clock_deadline();
    for duration in [Duration::ZERO, Duration::from_secs(86_401), Duration::MAX] {
        assert!(
            TurnDeadline::from_timer(&deadline.owner, deadline.timer.clone(), duration).is_err()
        );
    }
    clock.advance_to(Time::from_nanos(u64::MAX - 1));
    assert!(
        TurnDeadline::from_timer(&deadline.owner, deadline.timer, Duration::from_nanos(2)).is_err()
    );
}

#[test]
fn public_constructor_does_not_borrow_ambient_timer_authority() {
    let runtime = asupersync::runtime::RuntimeBuilder::current_thread()
        .build()
        .unwrap();
    runtime.block_on(async {
        let owner = AgentCx::for_current_or_request();
        assert!(TurnDeadline::after(&owner, Duration::from_secs(1)).is_ok());
        let restricted = {
            let _guard = owner
                .cx()
                .clone()
                .restrict::<asupersync::cx::cap::None>()
                .set_current_restricted();
            AgentCx::for_current_or_request()
        };
        let error = TurnDeadline::after(&restricted, Duration::from_secs(1)).unwrap_err();
        assert!(error.to_string().contains("SESSION_DEADLINE_CAPABILITY"));
    });
}

#[test]
fn expiry_wakes_a_dormant_turn_then_waits_for_native_cleanup() {
    let (clock, deadline) = clock_deadline();
    let timer = deadline.timer.clone();
    let native = turn(Err(Error::session("typed native cleanup failure")));
    let release = Arc::clone(&native.future.release);
    let drops = Arc::clone(&native.future.drops);
    let control = native.control();
    let id = control.follow_up("unclaimed-private-input").unwrap();
    let mut limited = native.with_deadline(deadline);
    let wakes = Arc::new(WakeCount::default());
    let waker = Waker::from(Arc::clone(&wakes));
    let mut cx = Context::from_waker(&waker);
    assert!(Pin::new(&mut limited).poll(&mut cx).is_pending());
    clock.advance_to(Time::from_secs(10));
    let _ = timer.process_timers();
    assert!(
        wakes.0.load(Ordering::SeqCst) > 0,
        "deadline must wake a silent provider"
    );
    assert!(Pin::new(&mut limited).poll(&mut cx).is_pending());
    assert!(!control.snapshot().accepting_input);
    assert!(!control.snapshot().finished, "cleanup has not returned yet");
    assert_eq!(
        drops.load(Ordering::SeqCst),
        0,
        "never drop the losing native future"
    );
    assert!(control.steer("too late").is_err());
    assert_eq!(control.take_pending()[0].id, id);
    release.store(true, Ordering::SeqCst);
    let Poll::Ready(Err(error)) = poll(&mut limited) else {
        panic!("timeout after cleanup")
    };
    assert!(error.is_elapsed());
    assert!(matches!(error.completion(), Some(Err(Error::Session(_)))));
    assert!(std::error::Error::source(&error).is_some());
    assert!(control.snapshot().finished);
    drop(limited);
    assert_eq!(drops.load(Ordering::SeqCst), 1);
}

#[test]
fn late_native_success_is_preserved_but_is_not_accepted_as_timely_success() {
    let (clock, deadline) = clock_deadline();
    let native = turn(Ok(AssistantMessage {
        content: vec![ContentBlock::Text(TextContent::new("private-result"))],
        ..AssistantMessage::default()
    }));
    let release = Arc::clone(&native.future.release);
    let mut limited = native.with_deadline(deadline);
    assert!(poll(&mut limited).is_pending());
    clock.advance_to(Time::from_secs(11));
    assert!(poll(&mut limited).is_pending());
    release.store(true, Ordering::SeqCst);
    let Poll::Ready(Err(error)) = poll(&mut limited) else {
        panic!("timeout")
    };
    assert!(error.is_elapsed());
    assert!(matches!(error.completion(), Some(Ok(_))));
    assert!(!format!("{error:?}").contains("private-result"));
}

#[test]
fn synchronous_poll_crossing_the_deadline_cannot_report_timely_success() {
    let (clock, deadline) = clock_deadline();
    let mut native = turn(Ok(AssistantMessage::default()));
    native.future.release.store(true, Ordering::SeqCst);
    native.future.cross_deadline = Some(clock);
    let Poll::Ready(Err(error)) = poll(&mut native.with_deadline(deadline)) else {
        panic!("late completion must be a deadline error")
    };
    assert!(error.is_elapsed());
    assert!(matches!(error.completion(), Some(Ok(_))));
}

#[test]
fn prior_explicit_abort_is_not_reclassified_while_cleanup_drains() {
    let (clock, deadline) = clock_deadline();
    let native = turn(Err(Error::session("native abort")));
    let release = Arc::clone(&native.future.release);
    let control = native.control();
    let mut limited = native.with_deadline(deadline);
    assert!(poll(&mut limited).is_pending());
    assert!(control.abort());
    clock.advance_to(Time::from_secs(20));
    release.store(true, Ordering::SeqCst);
    assert!(matches!(
        poll(&mut limited),
        Poll::Ready(Err(TurnDeadlineError::Turn(_)))
    ));
}

#[test]
fn owner_cancellation_wakes_the_current_poller_then_drains_native_cleanup() {
    let (_, deadline) = clock_deadline();
    let owner = deadline.owner.clone();
    let native = turn(Err(Error::session("native cancellation")));
    let release = Arc::clone(&native.future.release);
    let drops = Arc::clone(&native.future.drops);
    let control = native.control();
    let input = control.follow_up("recover after cancellation").unwrap();
    let mut limited = native.with_deadline(deadline);
    let old_wakes = Arc::new(WakeCount::default());
    let old_waker = Waker::from(Arc::clone(&old_wakes));
    let wakes = Arc::new(WakeCount::default());
    let waker = Waker::from(Arc::clone(&wakes));
    assert!(
        Pin::new(&mut limited)
            .poll(&mut Context::from_waker(&old_waker))
            .is_pending()
    );
    let mut cx = Context::from_waker(&waker);
    assert!(Pin::new(&mut limited).poll(&mut cx).is_pending());
    assert_eq!(wakes.0.load(Ordering::SeqCst), 0);

    // The native probe has no I/O/timer registration, and the virtual clock
    // does not advance. Without a deadline-owner subscription this task is
    // never scheduled again; manually polling after cancel would hide it.
    owner.cancel_with(asupersync::types::CancelKind::User, Some("test"));
    assert!(wakes.0.load(Ordering::SeqCst) > 0);
    assert_eq!(old_wakes.0.load(Ordering::SeqCst), 0);
    assert!(!limited.deadline.is_elapsed());
    assert!(Pin::new(&mut limited).poll(&mut cx).is_pending());
    assert!(!control.snapshot().accepting_input);
    assert!(!control.snapshot().finished);
    assert_eq!(drops.load(Ordering::SeqCst), 0);
    assert_eq!(control.take_pending()[0].id, input);
    release.store(true, Ordering::SeqCst);
    let Poll::Ready(Err(error @ TurnDeadlineError::OwnerCancelled { .. })) =
        Pin::new(&mut limited).poll(&mut cx)
    else {
        panic!("owner cancellation must finish through native cleanup");
    };
    assert!(matches!(error.completion(), Some(Err(Error::Session(_)))));
    assert!(control.snapshot().finished);
    assert!(limited.cancellation.is_none());
    drop(limited);
    assert_eq!(drops.load(Ordering::SeqCst), 1);
}

#[test]
fn normal_completion_preserves_native_success_and_typed_error() {
    for completion in [
        Ok(AssistantMessage::default()),
        Err(Error::session("expected")),
    ] {
        let (_, deadline) = clock_deadline();
        let expected_error = completion.is_err();
        let native = turn(completion);
        native.future.release.store(true, Ordering::SeqCst);
        let control = native.control();
        let Poll::Ready(result) = poll(&mut native.with_deadline(deadline)) else {
            panic!("ready")
        };
        assert_eq!(result.is_err(), expected_error);
        if let Err(error) = result {
            assert!(matches!(error, TurnDeadlineError::Turn(Error::Session(_))));
        }
        assert!(control.snapshot().finished);
    }
}

#[test]
fn completion_and_drop_retire_the_deadline_owner_waker() {
    for complete in [false, true] {
        let (clock, deadline) = clock_deadline();
        let timer = deadline.timer.clone();
        let owner = deadline.owner.clone();
        let native = turn(Ok(AssistantMessage::default()));
        native.future.release.store(complete, Ordering::SeqCst);
        let mut limited = native.with_deadline(deadline);
        let wakes = Arc::new(WakeCount::default());
        let waker = Waker::from(Arc::clone(&wakes));
        let result = Pin::new(&mut limited).poll(&mut Context::from_waker(&waker));
        assert_eq!(result.is_ready(), complete);
        if complete {
            // Verify retirement even while the completed wrapper stays alive.
            assert!(limited.cancellation.is_none());
            let before = wakes.0.load(Ordering::SeqCst);
            owner.cancel_with(
                asupersync::types::CancelKind::User,
                Some("after completion"),
            );
            assert_eq!(wakes.0.load(Ordering::SeqCst), before);
        }
        drop(limited);
        let before = wakes.0.load(Ordering::SeqCst);
        owner.cancel_with(asupersync::types::CancelKind::User, Some("after drop"));
        clock.advance_to(Time::from_secs(10));
        let _ = timer.process_timers();
        assert_eq!(wakes.0.load(Ordering::SeqCst), before);
    }
}

#[test]
fn explicit_abort_retires_owner_wait_without_reclassifying_cleanup() {
    let (_, deadline) = clock_deadline();
    let owner = deadline.owner.clone();
    let native = turn(Err(Error::session("explicit abort cleanup")));
    let release = Arc::clone(&native.future.release);
    let control = native.control();
    let mut limited = native.with_deadline(deadline);
    let wakes = Arc::new(WakeCount::default());
    let waker = Waker::from(Arc::clone(&wakes));
    let mut cx = Context::from_waker(&waker);
    assert!(Pin::new(&mut limited).poll(&mut cx).is_pending());
    assert!(control.abort());
    assert!(Pin::new(&mut limited).poll(&mut cx).is_pending());
    assert!(limited.cancellation.is_none());
    let before = wakes.0.load(Ordering::SeqCst);
    owner.cancel_with(
        asupersync::types::CancelKind::User,
        Some("after explicit abort"),
    );
    assert_eq!(wakes.0.load(Ordering::SeqCst), before);
    release.store(true, Ordering::SeqCst);
    assert!(matches!(
        Pin::new(&mut limited).poll(&mut cx),
        Poll::Ready(Err(TurnDeadlineError::Turn(Error::Session(_))))
    ));
}

#[test]
fn unpolled_drop_retires_control_without_consuming_queued_input() {
    let (_, deadline) = clock_deadline();
    let native = turn(Ok(AssistantMessage::default()));
    let polls = Arc::clone(&native.future.polls);
    let control = native.control();
    control.steer("recover on drop").unwrap();
    drop(native.with_deadline(deadline));
    assert_eq!(polls.load(Ordering::SeqCst), 0);
    assert!(control.snapshot().finished);
    assert_eq!(control.take_pending()[0].text, "recover on drop");
}

#[test]
fn expired_unpolled_turn_is_retired_without_dispatch_or_fake_completion() {
    let (clock, deadline) = clock_deadline();
    let native = turn(Ok(AssistantMessage::default()));
    let polls = Arc::clone(&native.future.polls);
    let drops = Arc::clone(&native.future.drops);
    let control = native.control();
    control.steer("never dispatched").unwrap();
    clock.advance_to(Time::from_secs(10));
    let Poll::Ready(Err(error)) = poll(&mut native.with_deadline(deadline)) else {
        panic!("expired before execution")
    };
    assert!(error.is_elapsed());
    assert!(error.completion().is_none());
    assert_eq!(polls.load(Ordering::SeqCst), 0);
    assert_eq!(drops.load(Ordering::SeqCst), 1);
    assert!(control.snapshot().finished);
    assert_eq!(control.take_pending()[0].text, "never dispatched");
}

#[test]
fn wrapping_an_already_polled_turn_still_drains_its_native_cleanup() {
    let (clock, deadline) = clock_deadline();
    let mut native = turn(Err(Error::session("actual cleanup")));
    let release = Arc::clone(&native.future.release);
    let drops = Arc::clone(&native.future.drops);
    assert!(poll(&mut native).is_pending());
    clock.advance_to(Time::from_secs(10));
    let mut limited = native.with_deadline(deadline);
    assert!(poll(&mut limited).is_pending());
    assert_eq!(drops.load(Ordering::SeqCst), 0);
    release.store(true, Ordering::SeqCst);
    let Poll::Ready(Err(error)) = poll(&mut limited) else {
        panic!("drained expired turn")
    };
    assert!(error.is_elapsed());
    assert!(matches!(error.completion(), Some(Err(Error::Session(_)))));
}

#[test]
fn cancelled_unpolled_turn_never_starts_execution() {
    let (_, deadline) = clock_deadline();
    deadline
        .owner
        .cancel_with(asupersync::types::CancelKind::User, Some("before dispatch"));
    let native = turn(Ok(AssistantMessage::default()));
    let polls = Arc::clone(&native.future.polls);
    let control = native.control();
    let Poll::Ready(Err(TurnDeadlineError::OwnerCancelled { completion })) =
        poll(&mut native.with_deadline(deadline))
    else {
        panic!("unstarted cancellation")
    };
    assert!(completion.is_none());
    assert_eq!(polls.load(Ordering::SeqCst), 0);
    assert!(control.snapshot().finished);
}

#[test]
fn a_fired_timer_is_not_polled_again_after_a_test_clock_rewind() {
    let (clock, deadline) = clock_deadline();
    let timer = deadline.timer.clone();
    let native = turn(Err(Error::session("drained")));
    let release = Arc::clone(&native.future.release);
    let mut limited = native.with_deadline(deadline);
    assert!(poll(&mut limited).is_pending());
    clock.advance_to(Time::from_secs(10));
    let _ = timer.process_timers();
    clock.set(Time::ZERO);
    assert!(poll(&mut limited).is_pending());
    release.store(true, Ordering::SeqCst);
    let Poll::Ready(Err(error)) = poll(&mut limited) else {
        panic!("latched timeout")
    };
    assert!(error.is_elapsed());
}