phylo 3.1.2

An extensible Phylogenetics library written in rust
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
//! Integration tests for ancestral sequence reconstruction, adapted from treetime test suite.
//! Reference: https://github.com/neherlab/treetime/blob/master/test/test_treetime.py

use std::collections::HashMap;
use crate::node::NodeID;
use crate::tree::PhyloTree;
use crate::prelude::*;
use crate::tree::asr::alphabet::{Alphabet, Nucleotide};
use crate::tree::asr::gtr::GtrModel;
use crate::tree::asr::alignment::Alignment;
use crate::tree::asr::reconstruction::Reconstruction;

/// Build a simple 4-taxon tree from Newick: ((A:0.6,B:0.3)C:0.1,D:0.2)E:0.001
fn build_tiny_tree() -> PhyloTree {
    let newick = b"((A:0.601,B:0.301)C:0.100,D:0.200)E:0.001;";
    crate::prelude::Newick::from_newick(newick).unwrap()
}

// ===========================================================================
// Alphabet tests
// ===========================================================================

#[test]
fn test_nucleotide_canonical_profiles() {
    assert_eq!(Nucleotide::profile(b'A'), Some(vec![1.0, 0.0, 0.0, 0.0]));
    assert_eq!(Nucleotide::profile(b'C'), Some(vec![0.0, 1.0, 0.0, 0.0]));
    assert_eq!(Nucleotide::profile(b'G'), Some(vec![0.0, 0.0, 1.0, 0.0]));
    assert_eq!(Nucleotide::profile(b'T'), Some(vec![0.0, 0.0, 0.0, 1.0]));
    assert_eq!(Nucleotide::profile(b'U'), Some(vec![0.0, 0.0, 0.0, 1.0])); // U -> T
}

#[test]
fn test_nucleotide_ambiguity_profiles() {
    // R = A or G
    let r = Nucleotide::profile(b'R').unwrap();
    assert!((r[0] - 0.5).abs() < 1e-10);
    assert!((r[2] - 0.5).abs() < 1e-10);

    // Y = C or T
    let y = Nucleotide::profile(b'Y').unwrap();
    assert!((y[1] - 0.5).abs() < 1e-10);
    assert!((y[3] - 0.5).abs() < 1e-10);

    // N = all equal
    let n = Nucleotide::profile(b'N').unwrap();
    for &v in &n {
        assert!((v - 0.25).abs() < 1e-10);
    }

    // Gap = uninformative (all ones)
    let gap = Nucleotide::profile(b'-').unwrap();
    for v in &gap {
        assert_eq!(*v, 1.0);
    }
}

#[test]
fn test_nucleotide_index_of() {
    assert_eq!(Nucleotide::index_of(b'A'), Some(0));
    assert_eq!(Nucleotide::index_of(b'C'), Some(1));
    assert_eq!(Nucleotide::index_of(b'G'), Some(2));
    assert_eq!(Nucleotide::index_of(b'T'), Some(3));
    assert_eq!(Nucleotide::index_of(b'U'), Some(3));
    assert_eq!(Nucleotide::index_of(b'X'), None);
}

#[test]
fn test_nucleotide_char_of() {
    assert_eq!(Nucleotide::char_of(0), b'A');
    assert_eq!(Nucleotide::char_of(1), b'C');
    assert_eq!(Nucleotide::char_of(2), b'G');
    assert_eq!(Nucleotide::char_of(3), b'T');
}

#[test]
fn test_amino_acid_canonical() {
    use crate::tree::asr::alphabet::AminoAcid;

    for (i, c) in AminoAcid::CANONICAL.iter().enumerate() {
        assert_eq!(AminoAcid::char_of(i), *c);
        assert_eq!(AminoAcid::index_of(*c), Some(i));
    }
}

#[test]
fn test_amino_acid_ambiguity_profiles() {
    use crate::tree::asr::alphabet::AminoAcid;

    // B = D or N
    let b = AminoAcid::profile(b'B').unwrap();
    assert!((b[3] - 0.5).abs() < 1e-10);
    assert!((b[11] - 0.5).abs() < 1e-10);

    // Z = E or Q
    let z = AminoAcid::profile(b'Z').unwrap();
    assert!((z[4] - 0.5).abs() < 1e-10);
    assert!((z[14] - 0.5).abs() < 1e-10);

    // J = I or L
    let j = AminoAcid::profile(b'J').unwrap();
    assert!((j[8] - 0.5).abs() < 1e-10);
    assert!((j[9] - 0.5).abs() < 1e-10);

    // X = uninformative
    let x = AminoAcid::profile(b'X').unwrap();
    for v in &x {
        assert_eq!(*v, 1.0);
    }
}

// ===========================================================================
// GTR model tests (adapted from treetime test_GTR)
// ===========================================================================

#[test]
fn test_gtr_jc_p_zero_is_identity() {
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();
    let p_t = model.transition(0.0);

    for i in 0..4 {
        if i == 0 {
            assert_eq!(p_t[(i, i)], 1.0);
        } else {
            assert_eq!(p_t[(i, 0)], 0.0);
        }
    }
}

#[test]
fn test_gtr_jc_row_sums_to_one() {
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();
    for t in [0.1, 0.5, 1.0, 2.0, 5.0, 10.0] {
        let p_t = model.transition(t);
        for i in 0..4 {
            let sum: f64 = (0..4).map(|j| p_t[(i, j)]).sum();
            assert!((sum - 1.0).abs() < 1e-10, "t={:.2} row {} sum = {}", t, i, sum);
        }
    }
}

#[test]
fn test_gtr_jc_positive_entries() {
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();
    for t in [0.001, 0.5, 2.0, 10.0] {
        let p_t = model.transition(t);
        for i in 0..4 {
            for j in 0..4 {
                assert!(p_t[(i, j)] >= -1e-15, "Negative entry at t={}: ({},{}) = {}", t, i, j, p_t[(i,j)]);
            }
        }
    }
}

#[test]
fn test_gtr_p_infinity_converges_to_pi() {
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();
    let pi = model.equilibrium();
    let p_inf = model.transition(100.0); // large t

    for i in 0..4 {
        for j in 0..4 {
            let diff = (p_inf[(i, j)] - pi[j]).abs();
            assert!(diff < 0.01, "t=100 ({},{}) expected {} got {}", i, j, pi[j], p_inf[(i,j)]);
        }
    }
}

#[test]
fn test_gtr_q_rows_sum_zero() {
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();
    let p_small = model.transition(1e-10);
    for i in 0..4 {
        let sum: f64 = (0..4).map(|j| p_small[(i, j)]).sum();
        assert!((sum - 1.0).abs() < 1e-8);
    }
}

#[test]
fn test_gtr_detailed_balance() {
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();
    let pi = model.equilibrium();

    for t in [0.1, 0.5, 1.0, 5.0] {
        let p_t = model.transition(t);

        // For JC, pi is uniform so pi^T P(t) should equal pi
        let result: Vec<f64> = (0..4usize).map(|j| (0..4usize).map(|i| pi[i] * p_t[(i, j)]).sum()).collect();

        for j in 0..4 {
            assert!((result[j] - pi[j]).abs() < 1e-8, "t={:.2} j={} expected {} got {}", t, j, pi[j], result[j]);
        }
    }
}

#[test]
fn test_gtr_custom_pi() {
    let pi = vec![0.30, 0.20, 0.30, 0.20];
    let w = nalgebra::DMatrix::from_element(4, 4, 1.0);
    let model = GtrModel::<Nucleotide>::new(pi, w, true).unwrap();

    let pi_norm = model.equilibrium();
    let sum: f64 = pi_norm.iter().sum();
    assert!((sum - 1.0).abs() < 1e-10);

    for &p in pi_norm.as_slice() {
        assert!(p > 0.0);
    }
}

// ===========================================================================
// Alignment tests (adapted from treetime alignment parsing)
// ===========================================================================

#[test]
fn test_alignment_fasta_multiline() {
    let data = b">Seq1\nACGTACGT\nACGTACGT\n>Seq2\nAGGTAGGT\nAGGTAGGT\n";
    let aln = Alignment::from_fasta_bytes(data).unwrap();
    assert_eq!(aln.width, 16);
    assert_eq!(aln.seqs["Seq1"], b"ACGTACGTACGTACGT");
}

#[test]
fn test_alignment_fasta_crlf() {
    let data = b">Seq1\r\nACGT\r\n>Seq2\r\nAGGT\r\n";
    let aln = Alignment::from_fasta_bytes(data).unwrap();
    assert_eq!(aln.width, 4);
}

#[test]
fn test_alignment_fasta_uppercase() {
    let data = b">Seq1\nacgt\n>Seq2\naggt\n";
    let aln = Alignment::from_fasta_bytes(data).unwrap();
    assert_eq!(aln.seqs["Seq1"], b"ACGT");
    assert_eq!(aln.seqs["Seq2"], b"AGGT");
}

#[test]
fn test_alignment_fasta_empty_header() {
    let data = b">\nACGT\n>Seq2\nAGGT\n";
    let result = Alignment::from_fasta_bytes(data);
    assert!(result.is_err(), "empty header should return an error");
}

#[test]
fn test_alignment_fasta_empty_fasta_returns_error() {
    let data = b"\n\n\n";
    let result = Alignment::from_fasta_bytes(data);
    assert!(result.is_err());
}

#[test]
fn test_alignment_fasta_ragged_returns_error() {
    let data = b">Seq1\nACGT\n>Seq2\nAGG\n";
    let result = Alignment::from_fasta_bytes(data);
    assert!(result.is_err());
}

#[test]
fn test_alignment_fasta_duplicate_id_returns_error() {
    let data = b">Seq1\nACGT\n>Seq1\nAGGT\n";
    let result = Alignment::from_fasta_bytes(data);
    assert!(result.is_err(), "duplicate taxon ID should return an error");
}

#[test]
fn test_alignment_fasta_whitespace_in_header() {
    let data = b">Seq1 some description here\nACGT\n>Seq2 another desc\nAGGT\n";
    let aln = Alignment::from_fasta_bytes(data).unwrap();
    assert_eq!(aln.seqs["Seq1"], b"ACGT");
    assert_eq!(aln.seqs["Seq2"], b"AGGT");
}

#[test]
fn test_compression_identical_columns() {
    let mut seqs = HashMap::new();
    seqs.insert("S1".to_string(), b"AATT".to_vec());
    seqs.insert("S2".to_string(), "AAT T".replace(' ', "-").as_bytes().to_vec());
    let aln = Alignment { seqs, width: 4 };

    let comp = aln.compress_columns();
    // Col 0: AA -> P0
    // Col 1: AA -> P0 (duplicate!)
    // Col 2: TT -> P1
    // Col 3: T- -> P2
    assert_eq!(comp.multiplicity[0], 2); // AA appears twice
}

// ===========================================================================
// Reconstruction serialization test
// ===========================================================================

#[test]
fn test_reconstruction_sequence_string() {
    let mut seqs = HashMap::new();
    seqs.insert(0_usize, vec![0, 1, 2, 3]); // ACGT

    let recon: Reconstruction<Nucleotide> = Reconstruction {
        sequences: seqs.clone(),
        posteriors: None,
        log_likelihood: -1.5,
        alphabet: std::marker::PhantomData,
    };

    assert_eq!(recon.sequence_string(0_usize), Some("ACGT".to_string()));
    assert_eq!(recon.sequence_string(99_usize), None);
}

// ===========================================================================
// Marginal ASR tests (adapted from treetime test_ancestral)
// ===========================================================================

#[test]
fn test_marginal_asr_basic() {
    let tree = build_tiny_tree();
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();

    // All 4 taxa of the tree must be present
    let aln_data = b">A\nACGTACGTACGTACGT\n>B\nAGGTAGGTAGGTAGGT\n>C\nACGTACGTACGTACGT\n>D\nTTTTTTTTTTTTTTTT\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    let result = tree.marginal_asr::<Nucleotide>(&model, &aln, false);
    assert!(result.is_ok());
    let recon = result.unwrap();
    assert!(!recon.sequences.is_empty());
}

#[test]
fn test_marginal_asr_with_posteriors() {
    let tree = build_tiny_tree();
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();

    let aln_data = b">A\nACGTACGTACGTACGT\n>B\nAGGTAGGTAGGTAGGT\n>C\nACGTACGTACGTACGT\n>D\nTTTTTTTTTTTTTTTT\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    let result = tree.marginal_asr::<Nucleotide>(&model, &aln, true);
    assert!(result.is_ok());
    let recon = result.unwrap();

    // Posteriors should be present
    assert!(recon.posteriors.is_some());
    let posters = recon.posteriors.unwrap();

    // Each posterior should sum to ~1.0 for each site
    for (node_id, site_posters) in &posters {
        for (site_idx, post) in site_posters.iter().enumerate() {
            let sum: f64 = post.iter().sum();
            assert!(sum > 0.5 && sum < 1.5,
                "Node {} site {}: posterior sum = {} (expected ~1.0)",
                node_id, site_idx, sum);
        }
    }
}

#[test]
fn test_marginal_asr_log_likelihood_positive() {
    let tree = build_tiny_tree();
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();

    let aln_data = b">A\nACGT\n>B\nAGGT\n>C\nACGT\n>D\nTTTT\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    let result = tree.marginal_asr::<Nucleotide>(&model, &aln, false);
    assert!(result.is_ok());
    // Log-likelihood should be finite (not +/-inf)
    assert!(result.unwrap().log_likelihood.is_finite());
}

// ===========================================================================
// Joint ASR tests (adapted from treetime test_seq_joint_reconstruction_correct)
// ===========================================================================

#[test]
fn test_joint_asr_basic() {
    let tree = build_tiny_tree();
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();

    let aln_data = b">A\nACGTACGTACGTACGT\n>B\nAGGTAGGTAGGTAGGT\n>C\nACGTACGTACGTACGT\n>D\nTTTTTTTTTTTTTTTT\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    let result = tree.joint_asr::<Nucleotide>(&model, &aln);
    assert!(result.is_ok());
    let recon = result.unwrap();

    // Posteriors should be None for joint reconstruction
    assert!(recon.posteriors.is_none());
    assert!(!recon.sequences.is_empty());
}

#[test]
fn test_joint_vs_marginal_same_sequences_simple() {
    // For very short branch lengths, marginal and joint should agree closely
    let tree = build_tiny_tree();
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();

    // Very similar sequences (short branches -> minimal divergence), include D
    let aln_data = b">A\nAAAAAAAA\n>B\nAAAAAAAC\n>C\nAAAAAAAA\n>D\nCCCCCCCC\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    let marg_result = tree.marginal_asr::<Nucleotide>(&model, &aln, false).unwrap();
    let joint_result = tree.joint_asr::<Nucleotide>(&model, &aln).unwrap();

    // Both should return sequences for all nodes
    assert_eq!(marg_result.sequences.len(), joint_result.sequences.len());
}

// ===========================================================================
// Joint LH maximality test (adapted from treetime test_seq_joint_lh_is_max)
// ===========================================================================

#[test]
fn test_marginal_asr_likelihood_normalization() {
    // From treetime: likelihood sum over all states should be 1
    let tiny_tree = b"((A:0.601,B:0.301)C:0.1,D:0.2)E:0.001;";
    let tree: PhyloTree = crate::prelude::Newick::from_newick(tiny_tree).unwrap();

    // Custom GTR with non-uniform pi (from treetime test_ancestral)
    let pi = vec![0.9, 0.06, 0.02, 0.02];
    let w = nalgebra::DMatrix::from_element(4, 4, 1.0);
    let model = GtrModel::<Nucleotide>::new(pi.clone(), w, true).unwrap();

    // Full alignment (treetime uses this pattern repeated)
    let aln_data = b">A\nAAAAAAAAAAAAAAAACCCCCCCCCCCCCCCCGGGGGGGGGGGGGGGGTTTTTTTTTTTTTTTT\n>B\nAAAACCCCGGGGTTTTAAAACCCCGGGGTTTTAAAACCCCGGGGTTTTAAAACCCCGGGGTTTT\n>C\nACGTACGTACGTACGTACGTACGTACGTACGTACGTACGTACGTACGTACGTACGTACGTACGT\n>D\nAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    // The likelihood should be finite and positive in linear space
    assert!(aln.seqs.values().next().unwrap().len() == aln.width);
    let result = tree.marginal_asr::<Nucleotide>(&model, &aln, true);
    assert!(result.is_ok());
    let recon = result.unwrap();
    assert!(recon.log_likelihood.is_finite(), "log_likelihood = {}", recon.log_likelihood);

    // Check that marginals for root sum to 1 per site (within tolerance)
    if let Some(ref posters) = recon.posteriors {
        let root_id: NodeID = tree.get_root_id();
        if let Some(site_posters) = posters.get(&root_id) {
            assert_eq!(site_posters.len(), aln.width);
            for (site_idx, post) in site_posters.iter().enumerate() {
                let sum: f64 = post.iter().sum();
                assert!((sum - 1.0).abs() < 0.001,
                    "Root posterior sum at site {} = {}", site_idx, sum);
            }
        }
    }
}

// ===========================================================================
// Taxon mismatch tests
// ===========================================================================

#[test]
fn test_asr_missing_taxon_returns_error() {
    let tree = build_tiny_tree();
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();

    // Alignment has a taxon 'X' not in the tree, and is missing D
    let aln_data = b">A\nACGT\n>B\nAGGT\n>C\nAAAA\n>X\nTTTT\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    let result = tree.marginal_asr::<Nucleotide>(&model, &aln, false);
    assert!(result.is_err());
}

// ===========================================================================
// Alphabet mismatch / bad input tests
// ===========================================================================

#[test]
fn test_marginal_asr_all_gap_alignment() {
    // All-gap alignment should still produce valid results (just uninformative)
    let tree = build_tiny_tree();
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();

    let aln_data = b">A\n----\n>B\n----\n>C\n----\n>D\n----\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    let result = tree.marginal_asr::<Nucleotide>(&model, &aln, false);
    assert!(result.is_ok());
}

#[test]
fn test_joint_asr_all_gap_alignment() {
    let tree = build_tiny_tree();
    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();

    let aln_data = b">A\n----\n>B\n----\n>C\n----\n>D\n----\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    let result = tree.joint_asr::<Nucleotide>(&model, &aln);
    // All-gaps produce uninformative data but should not error or panic
    assert!(result.is_ok(), "joint all-gap ASR should not error");
}

// ===========================================================================
// Edge weight/branch length tests
// ===========================================================================

#[test]
fn test_asr_with_zero_branch_length() {
    // Tree with zero branch lengths: children should have same distribution as parent
    let newick = b"((A:0.0,B:0.0)C:0.0,D:0.0)E:0.0;";
    let tree: PhyloTree = crate::prelude::Newick::from_newick(newick).unwrap();

    let model = GtrModel::<Nucleotide>::jukes_cantor().unwrap();

    let aln_data = b">A\nACGT\n>B\nAGGT\n>C\nAAAA\n>D\nTTTT\n";
    let aln = Alignment::from_fasta_bytes(aln_data).unwrap();

    let result = tree.marginal_asr::<Nucleotide>(&model, &aln, false);
    assert!(result.is_ok());
}

// ===========================================================================
// Compression correctness test (adapted from treetime compression patterns)
// ===========================================================================

#[test]
fn test_compression_with_duplicate_patterns() {
    let mut seqs = HashMap::new();
    // Columns 0-3: AA, CC, TT, GG -> all unique
    // Columns 4-7: AA, CC, TT, GG -> duplicates of 0-3
    // Should give 4 patterns with multiplicity 2 each
    seqs.insert("S1".to_string(), b"ACGTACGT".to_vec());
    seqs.insert("S2".to_string(), b"ACGTACGT".to_vec());
    let aln = Alignment { seqs, width: 8 };

    let comp = aln.compress_columns();
    assert_eq!(comp.patterns.len(), 4);
    for &mult in &comp.multiplicity {
        assert_eq!(mult, 2);
    }
}

#[test]
fn test_compression_re_expansion() {
    let mut seqs = HashMap::new();
    seqs.insert("S1".to_string(), b"AATTGGCC".to_vec());
    seqs.insert("S2".to_string(), b"ATGCATGC".to_vec());
    let aln = Alignment { seqs, width: 8 };

    let comp = aln.compress_columns();

    // Verify site-to-pattern mapping is correct by reconstructing the original columns
    for site in 0..aln.width {
        let p_idx = comp.site_to_pattern[site];
        let expected_col: Vec<u8> = comp.leaf_order.iter()
            .map(|name| aln.seqs[name][site])
            .collect();
        assert_eq!(comp.patterns[p_idx], expected_col,
            "Pattern for site {} mismatch", site);
    }
}

// ===========================================================================
// Amino acid alphabet test (from treetime AminoAcid patterns)
// ===========================================================================

#[test]
fn test_amino_acid_n_states() {
    use crate::tree::asr::alphabet::AminoAcid;
    assert_eq!(AminoAcid::N_STATES, 20);
}

#[test]
fn test_nucleotide_n_states() {
    use crate::tree::asr::alphabet::Nucleotide;
    assert_eq!(Nucleotide::N_STATES, 4);
}

// ===========================================================================
// Profile numerical stability tests
// ===========================================================================

#[test]
fn test_profile_scaling_stability() {
    // Test that scaling handles very small values correctly
    let tiny = vec![1e-300, 2e-300, 3e-300];
    let profile = crate::tree::asr::profile::Profile::new(tiny, 0.0).scale();

    // After scaling by max (3e-300), values should be normalized
    assert!((profile.values[2] - 1.0).abs() < 1e-15);
    // log_scale = ln(3e-300) ~ -691, which is finite and negative
    // The key invariant: total_log_likelihood = ln(sum(values)) + log_scale
    assert!(profile.log_scale.is_finite());
}

#[test]
fn test_profile_log_likelihood_with_scale() {
    // Values [0.1, 0.2, 0.3, 0.4], scale = ln(10)
    let vals = vec![0.1, 0.2, 0.3, 0.4];
    let scale = 10.0f64.ln();
    let profile = crate::tree::asr::profile::Profile::new(vals, scale);

    // sum(values) = 1.0, ln(1.0) + scale = scale
    assert!((profile.total_log_likelihood() - scale).abs() < 1e-10);
}