php-lsp 0.27.0

A PHP Language Server Protocol implementation
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
//! "Update PHPDoc to match signature" code action.
//!
//! Triggered when a function/method already has a docblock whose @param/@return
//! section is out of sync with the actual signature.

use super::*;
use expect_test::expect;

// ── Availability ─────────────────────────────────────────────────────────────

#[tokio::test]
async fn update_phpdoc_offered_when_param_added() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_actions(
            r#"<?php
class Service {
    /**
     * @param string $name
     */
    public function $0greet$0(string $name, int $times): void {}
}
"#,
        )
        .await;
    assert!(
        out.contains("Update PHPDoc to match signature"),
        "expected action in: {out}"
    );
}

#[tokio::test]
async fn update_phpdoc_offered_when_param_removed() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_actions(
            r#"<?php
class Service {
    /**
     * @param string $name
     * @param int $age
     */
    public function $0greet$0(string $name): void {}
}
"#,
        )
        .await;
    assert!(
        out.contains("Update PHPDoc to match signature"),
        "expected action in: {out}"
    );
}

#[tokio::test]
async fn update_phpdoc_offered_when_param_renamed() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_actions(
            r#"<?php
class Service {
    /**
     * @param string $oldName
     */
    public function $0greet$0(string $newName): void {}
}
"#,
        )
        .await;
    assert!(
        out.contains("Update PHPDoc to match signature"),
        "expected action in: {out}"
    );
}

#[tokio::test]
async fn update_phpdoc_offered_when_return_type_missing() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_actions(
            r#"<?php
class Service {
    /**
     * @param string $name
     */
    public function $0greet$0(string $name): string {}
}
"#,
        )
        .await;
    assert!(
        out.contains("Update PHPDoc to match signature"),
        "expected action in: {out}"
    );
}

#[tokio::test]
async fn update_phpdoc_not_offered_when_in_sync() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_actions(
            r#"<?php
class Service {
    /**
     * @param string $name
     * @return string
     */
    public function $0greet$0(string $name): string { return $name; }
}
"#,
        )
        .await;
    assert!(
        !out.contains("Update PHPDoc to match signature"),
        "should not offer when already in sync, got: {out}"
    );
}

#[tokio::test]
async fn update_phpdoc_not_offered_when_no_docblock() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_actions(
            r#"<?php
class Service {
    public function $0greet$0(string $name): void {}
}
"#,
        )
        .await;
    assert!(
        !out.contains("Update PHPDoc to match signature"),
        "should not offer when there is no docblock, got: {out}"
    );
}

#[tokio::test]
async fn update_phpdoc_not_offered_for_inherit_doc() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_actions(
            r#"<?php
class Child extends Base {
    /** {@inheritDoc} */
    public function $0greet$0(string $name, int $extra): void {}
}
"#,
        )
        .await;
    assert!(
        !out.contains("Update PHPDoc to match signature"),
        "should not offer for @inheritDoc, got: {out}"
    );
}

// ── Applied edits ─────────────────────────────────────────────────────────────

#[tokio::test]
async fn update_phpdoc_adds_missing_param() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_action_apply(
            r#"<?php
class Service {
    /**
     * @param string $name
     */
    public function $0greet$0(string $name, int $times): void {}
}
"#,
            "Update PHPDoc to match signature",
        )
        .await;
    expect![[r#"
        <?php
        class Service {
            /**
             * @param string $name
             * @param int $times
             */
            public function greet(string $name, int $times): void {}
        }
    "#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn update_phpdoc_removes_stale_param() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_action_apply(
            r#"<?php
class Service {
    /**
     * @param string $name
     * @param int $age
     */
    public function $0greet$0(string $name): void {}
}
"#,
            "Update PHPDoc to match signature",
        )
        .await;
    expect![[r#"
        <?php
        class Service {
            /**
             * @param string $name
             */
            public function greet(string $name): void {}
        }
    "#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn update_phpdoc_renames_param() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_action_apply(
            r#"<?php
class Service {
    /**
     * @param string $oldName
     */
    public function $0greet$0(string $newName): void {}
}
"#,
            "Update PHPDoc to match signature",
        )
        .await;
    expect![[r#"
        <?php
        class Service {
            /**
             * @param string $newName
             */
            public function greet(string $newName): void {}
        }
    "#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn update_phpdoc_adds_return_type() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_action_apply(
            r#"<?php
class Service {
    /**
     * @param string $name
     */
    public function $0greet$0(string $name): string { return $name; }
}
"#,
            "Update PHPDoc to match signature",
        )
        .await;
    expect![[r#"
        <?php
        class Service {
            /**
             * @param string $name
             * @return string
             */
            public function greet(string $name): string { return $name; }
        }
    "#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn update_phpdoc_preserves_description() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_action_apply(
            r#"<?php
class Greeter {
    /**
     * Say hello to someone.
     *
     * @param string $name
     */
    public function $0greet$0(string $name, int $times): void {}
}
"#,
            "Update PHPDoc to match signature",
        )
        .await;
    expect![[r#"
        <?php
        class Greeter {
            /**
             * Say hello to someone.
             *
             * @param string $name
             * @param int $times
             */
            public function greet(string $name, int $times): void {}
        }
    "#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn update_phpdoc_preserves_param_description() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_action_apply(
            r#"<?php
class Greeter {
    /**
     * @param string $name The user's name
     */
    public function $0greet$0(string $name, int $times): void {}
}
"#,
            "Update PHPDoc to match signature",
        )
        .await;
    expect![[r#"
        <?php
        class Greeter {
            /**
             * @param string $name The user's name
             * @param int $times
             */
            public function greet(string $name, int $times): void {}
        }
    "#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn update_phpdoc_preserves_throws() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_action_apply(
            r#"<?php
class Service {
    /**
     * @param string $name
     * @throws RuntimeException
     */
    public function $0greet$0(string $name, int $times): void {}
}
"#,
            "Update PHPDoc to match signature",
        )
        .await;
    expect![[r#"
        <?php
        class Service {
            /**
             * @param string $name
             * @param int $times
             * @throws RuntimeException
             */
            public function greet(string $name, int $times): void {}
        }
    "#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn update_phpdoc_free_function() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_code_action_apply(
            r#"<?php
/**
 * @param string $name
 */
function $0greet$0(string $name, int $times): void {}
"#,
            "Update PHPDoc to match signature",
        )
        .await;
    expect![[r#"
        <?php
        /**
         * @param string $name
         * @param int $times
         */
        function greet(string $name, int $times): void {}
    "#]]
    .assert_eq(&out);
}