php-lsp 0.22.2

A PHP Language Server Protocol implementation
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
use super::*;

use expect_test::expect;

// ── LSP-spec same-text invariant ────────────────────────────────────────────

/// Every range in a `LinkedEditingRanges` response must cover identical
/// text — linked-mode typing replicates one edit across all of them. Also
/// snapshots the rendered ranges so a regression collapsing to 0/1 ranges
/// (which would make the share-text invariant vacuously true) is caught.
async fn check_invariant(
    s: &mut TestServer,
    path: &str,
    src: &str,
    line: u32,
    character: u32,
) -> String {
    s.open(path, src).await;
    let resp = s.linked_editing_range(path, line, character).await;
    assert_linked_editing_ranges_share_text(&resp, src);
    render_linked_editing_range(&resp)
}

#[tokio::test]
async fn linked_ranges_cover_same_text_across_fixtures() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    // Function decl + calls.
    let fn_out = check_invariant(
        &mut s,
        "fn.php",
        "<?php\nfunction greet() {}\ngreet();\ngreet();\n",
        1,
        12,
    )
    .await;
    // Method decl + same-class call.
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let method_out = check_invariant(
        &mut s,
        "method.php",
        "<?php\nclass Calc {\n    public function add(): void {}\n    public function self_call(): void { $this->add(); }\n}\n",
        2,
        22,
    )
    .await;
    // Variable decl + uses.
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let var_out = check_invariant(
        &mut s,
        "var.php",
        "<?php\nfunction f(): void {\n    $foo = 1;\n    echo $foo;\n    $foo += 2;\n}\n",
        2,
        6,
    )
    .await;
    // Unicode identifier.
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let cjk_out = check_invariant(
        &mut s,
        "cjk.php",
        "<?php\nfunction 名前() {}\n名前();\n",
        1,
        10,
    )
    .await;

    expect![[r#"
        1:9-1:14
        2:0-2:5
        3:0-3:5
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*
        ---
        2:20-2:23
        3:47-3:50
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*
        ---
        2:4-2:8
        3:9-3:13
        4:4-4:8
        pattern: \$[a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*
        ---
        1:9-1:11
        2:0-2:2
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&[fn_out, method_out, var_out, cjk_out].join("\n---\n"));
}

// ── basic shape: declaration only ───────────────────────────────────────────

#[tokio::test]
async fn class_with_only_declaration_yields_one_range() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nclass Lin$0kedClass {}\n")
        .await;
    expect![[r#"
        1:6-1:17
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

// ── functions ───────────────────────────────────────────────────────────────

#[tokio::test]
async fn function_decl_links_to_all_call_sites() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range(
            r#"<?php
function gre$0et() {}
greet();
greet();
"#,
        )
        .await;
    expect![[r#"
        1:9-1:14
        2:0-2:5
        3:0-3:5
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn function_call_links_back_to_decl() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range(
            r#"<?php
function greet() {}
gr$0eet();
"#,
        )
        .await;
    expect![[r#"
        1:9-1:14
        2:0-2:5
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

// ── classes & members ──────────────────────────────────────────────────────

#[tokio::test]
async fn class_decl_and_new_expression() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nclass F$0oo {}\n$x = new Foo();\n")
        .await;
    expect![[r#"
        1:6-1:9
        2:9-2:12
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn method_decl_and_call() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range(
            r#"<?php
class Calc {
    public function ad$0d(): void {}
}
$c = new Calc();
$c->add();
"#,
        )
        .await;
    expect![[r#"
        2:20-2:23
        5:4-5:7
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

// ── variables ──────────────────────────────────────────────────────────────

#[tokio::test]
async fn variable_in_scope_links_all_occurrences_with_dollar_pattern() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range(
            r#"<?php
function f(): void {
    $fo$0o = 1;
    echo $foo;
    $foo += 2;
}
"#,
        )
        .await;
    expect![[r#"
        2:4-2:8
        3:9-3:13
        4:4-4:8
        pattern: \$[a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn variable_does_not_cross_function_scope() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range(
            r#"<?php
function f() { $x$0 = 1; }
function g() { $x = 2; }
"#,
        )
        .await;
    expect![[r#"
        1:15-1:17
        pattern: \$[a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn cursor_on_dollar_sign_still_finds_variable() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nfunction f() { $0$x = 1; echo $x; }\n")
        .await;
    expect![[r#"
        1:15-1:17
        1:28-1:30
        pattern: \$[a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

// ── positions that should NOT trigger linked editing ────────────────────────

#[tokio::test]
async fn whitespace_returns_no_linked_editing() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nclass Foo {} $0  $x = 1;\n")
        .await;
    expect!["<no linked editing>"].assert_eq(&out);
}

#[tokio::test]
async fn unknown_word_returns_no_linked_editing() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\necho 'nob$0ody';\n")
        .await;
    expect!["<no linked editing>"].assert_eq(&out);
}

#[tokio::test]
async fn comment_word_matching_class_name_does_not_link() {
    // Bug-fix regression: word_at extracts `Foo` from the line comment,
    // document_highlights would find AST refs to `Foo`, but the cursor
    // sits in a comment that isn't itself an AST node — entering linked
    // mode would silently mirror typing into the comment over the real
    // class declaration and `new Foo()` call. The cursor-on-highlight
    // guard suppresses linked editing here.
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\n// uses Fo$0o here\nclass Foo {}\n$x = new Foo();\n")
        .await;
    expect!["<no linked editing>"].assert_eq(&out);
}

#[tokio::test]
async fn string_literal_word_matching_function_name_does_not_link() {
    // Same bug class as the comment case: cursor sits inside the literal
    // `'greet'` (not an identifier reference); linked editing would
    // otherwise mirror typing into the string over real call sites.
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nfunction greet() {}\n$x = 'gr$0eet';\ngreet();\n")
        .await;
    expect!["<no linked editing>"].assert_eq(&out);
}

// ── word pattern correctness ────────────────────────────────────────────────

#[tokio::test]
async fn non_variable_pattern_disallows_dollar_sign() {
    // The pattern returned for a class name must NOT permit `$`, otherwise
    // the LSP client could accept linked-mode typing of `$NewName` and
    // produce invalid PHP.
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nclass Fo$0o {}\n")
        .await;
    let pattern = out
        .lines()
        .find_map(|l| l.strip_prefix("pattern: "))
        .expect("response should include a wordPattern");
    assert!(
        !pattern.contains('$') || pattern.contains(r"\$"),
        "non-variable pattern must not allow leading $; got {pattern:?}"
    );
}

#[tokio::test]
async fn variable_pattern_requires_dollar_sign() {
    // The pattern returned for a variable must REQUIRE `\$`, otherwise the
    // user could type a name without `$` and break the variable.
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nfunction f() { $x$0 = 1; }\n")
        .await;
    let pattern = out
        .lines()
        .find_map(|l| l.strip_prefix("pattern: "))
        .expect("response should include a wordPattern");
    assert!(
        pattern.starts_with(r"\$"),
        "variable pattern must require leading \\$; got {pattern:?}"
    );
}

// ── unicode identifier support ─────────────────────────────────────────────

#[tokio::test]
async fn method_in_one_class_does_not_link_unrelated_class_with_same_name() {
    // Regression: two classes share a method name. Cursor on `bar` inside
    // class A must NOT link to `bar` inside class B — typing in linked
    // mode would otherwise corrupt B's method.
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range(
            r#"<?php
class A {
    public function ba$0r(): void {}
}
class B {
    public function bar(): void {}
}
"#,
        )
        .await;
    expect![[r#"
        2:20-2:23
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn class_name_itself_still_links_globally() {
    // Cursor on the class header — the rename target IS the class. The
    // class-scope filter must NOT apply (otherwise the `new Foo()` site
    // gets dropped).
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nclass Fo$0o {}\n$x = new Foo();\n")
        .await;
    expect![[r#"
        1:6-1:9
        2:9-2:12
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn cjk_identifier_links_correctly() {
    // Regression for the BMP word-pattern range: identifiers using
    // characters beyond Latin-1 (e.g. CJK) must round-trip. The original
    // `\x80-\xff` byte range silently rejected anything past U+00FF.
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nfunction 名$0前() {}\n名前();\n")
        .await;
    expect![[r#"
        1:9-1:11
        2:0-2:2
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}

#[tokio::test]
async fn utf8_identifier_links_correctly() {
    let mut s = TestServer::new().await;
    s.validate_syntax(false);
    let out = s
        .check_linked_editing_range("<?php\nfunction caf$0é() {}\ncafé();\n")
        .await;
    expect![[r#"
        1:9-1:13
        2:0-2:4
        pattern: [a-zA-Z_\u00A0-\uFFFF][a-zA-Z0-9_\u00A0-\uFFFF]*"#]]
    .assert_eq(&out);
}