pharmsol 0.25.0

Rust library for solving analytic and ode-defined pharmacometric models.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
//! Model Library
//!
//! Provides a registry of built-in pharmacometric models that can be:
//! - Used directly via their ID
//! - Extended via the `extends` field for customization
//!
//! # Example
//!
//! ```rust,ignore
//! use pharmsol::json::library::ModelLibrary;
//!
//! let library = ModelLibrary::builtin();
//!
//! // List available models
//! for id in library.list() {
//!     println!("Available: {}", id);
//! }
//!
//! // Get a model
//! if let Some(model) = library.get("pk/1cmt-iv") {
//!     println!("Found model: {}", model.id);
//! }
//! ```

use crate::json::errors::JsonModelError;
use crate::json::model::JsonModel;
use crate::json::types::{
    CovariateDefinition, DisplayInfo, Documentation, EditorInfo, ExecutableModel, ModelType,
    NamedEquation,
};
use crate::json::Validator;
use std::collections::HashMap;
use std::path::Path;

/// A registry of JSON model definitions
#[derive(Debug, Clone)]
pub struct ModelLibrary {
    models: HashMap<String, JsonModel>,
}

// Embed built-in models at compile time
mod embedded {
    // PK Analytical Models
    pub const PK_1CMT_IV: &str = include_str!("models/pk_1cmt_iv.json");
    pub const PK_1CMT_ORAL: &str = include_str!("models/pk_1cmt_oral.json");
    pub const PK_2CMT_IV: &str = include_str!("models/pk_2cmt_iv.json");
    pub const PK_2CMT_ORAL: &str = include_str!("models/pk_2cmt_oral.json");
    pub const PK_3CMT_IV: &str = include_str!("models/pk_3cmt_iv.json");
    pub const PK_3CMT_ORAL: &str = include_str!("models/pk_3cmt_oral.json");

    // PK ODE Models
    pub const PK_1CMT_IV_ODE: &str = include_str!("models/pk_1cmt_iv_ode.json");
    pub const PK_1CMT_ORAL_ODE: &str = include_str!("models/pk_1cmt_oral_ode.json");
    pub const PK_2CMT_IV_ODE: &str = include_str!("models/pk_2cmt_iv_ode.json");
    pub const PK_2CMT_ORAL_ODE: &str = include_str!("models/pk_2cmt_oral_ode.json");
}

impl ModelLibrary {
    /// Create a new empty library
    pub fn new() -> Self {
        Self {
            models: HashMap::new(),
        }
    }

    /// Create a library with all built-in models
    pub fn builtin() -> Self {
        let mut library = Self::new();

        // Load embedded models
        let embedded_models = [
            embedded::PK_1CMT_IV,
            embedded::PK_1CMT_ORAL,
            embedded::PK_2CMT_IV,
            embedded::PK_2CMT_ORAL,
            embedded::PK_3CMT_IV,
            embedded::PK_3CMT_ORAL,
            embedded::PK_1CMT_IV_ODE,
            embedded::PK_1CMT_ORAL_ODE,
            embedded::PK_2CMT_IV_ODE,
            embedded::PK_2CMT_ORAL_ODE,
        ];

        for json in embedded_models {
            if let Ok(model) = JsonModel::from_str(json) {
                library.models.insert(model.id.clone(), model);
            }
        }

        library
    }

    /// Load models from a directory (recursively searches for .json files)
    pub fn from_dir(path: &Path) -> Result<Self, JsonModelError> {
        let mut library = Self::new();
        library.load_dir(path)?;
        Ok(library)
    }

    /// Load models from a directory into this library
    pub fn load_dir(&mut self, path: &Path) -> Result<(), JsonModelError> {
        if !path.exists() {
            return Err(JsonModelError::LibraryError(format!(
                "Directory not found: {}",
                path.display()
            )));
        }

        Self::load_dir_recursive(path, &mut self.models)?;
        Ok(())
    }

    fn load_dir_recursive(
        path: &Path,
        models: &mut HashMap<String, JsonModel>,
    ) -> Result<(), JsonModelError> {
        let entries = std::fs::read_dir(path).map_err(|e| {
            JsonModelError::LibraryError(format!("Failed to read directory: {}", e))
        })?;

        for entry in entries {
            let entry = entry.map_err(|e| {
                JsonModelError::LibraryError(format!("Failed to read entry: {}", e))
            })?;
            let file_path = entry.path();

            if file_path.is_dir() {
                Self::load_dir_recursive(&file_path, models)?;
            } else if file_path.extension().is_some_and(|ext| ext == "json") {
                let content = std::fs::read_to_string(&file_path).map_err(|e| {
                    JsonModelError::LibraryError(format!(
                        "Failed to read {}: {}",
                        file_path.display(),
                        e
                    ))
                })?;

                match JsonModel::from_str(&content) {
                    Ok(model) => {
                        models.insert(model.id.clone(), model);
                    }
                    Err(e) => {
                        // Log warning but continue loading other models
                        eprintln!("Warning: Failed to parse {}: {}", file_path.display(), e);
                    }
                }
            }
        }

        Ok(())
    }

    /// Get a model by ID
    pub fn get(&self, id: &str) -> Option<&JsonModel> {
        self.models.get(id)
    }

    /// Check if a model exists
    pub fn contains(&self, id: &str) -> bool {
        self.models.contains_key(id)
    }

    /// Add a model to the library
    pub fn add(&mut self, model: JsonModel) {
        self.models.insert(model.id.clone(), model);
    }

    /// Remove a model from the library
    pub fn remove(&mut self, id: &str) -> Option<JsonModel> {
        self.models.remove(id)
    }

    /// List all model IDs
    pub fn list(&self) -> Vec<&str> {
        let mut ids: Vec<&str> = self.models.keys().map(|s| s.as_str()).collect();
        ids.sort();
        ids
    }

    /// Get the number of models
    pub fn len(&self) -> usize {
        self.models.len()
    }

    /// Check if the library is empty
    pub fn is_empty(&self) -> bool {
        self.models.is_empty()
    }

    /// Search models by partial ID or name match
    pub fn search(&self, query: &str) -> Vec<&JsonModel> {
        let query_lower = query.to_lowercase();
        self.models
            .values()
            .filter(|model| {
                // Match by ID
                if model.id.to_lowercase().contains(&query_lower) {
                    return true;
                }
                // Match by name in display info
                if let Some(display) = model.display_info() {
                    if let Some(ref name) = display.name {
                        if name.to_lowercase().contains(&query_lower) {
                            return true;
                        }
                    }
                }
                false
            })
            .collect()
    }

    /// Filter models by type
    pub fn filter_by_type(&self, model_type: ModelType) -> Vec<&JsonModel> {
        self.models
            .values()
            .filter(|m| m.model_type == model_type)
            .collect()
    }

    /// Filter models by tag (from display info)
    pub fn filter_by_tag(&self, tag: &str) -> Vec<&JsonModel> {
        let tag_lower = tag.to_lowercase();
        self.models
            .values()
            .filter(|model| {
                if let Some(display) = model.display_info() {
                    if let Some(ref tags) = display.tags {
                        return tags.iter().any(|t| t.to_lowercase() == tag_lower);
                    }
                }
                false
            })
            .collect()
    }

    /// Resolve a model's inheritance chain, returning a fully resolved model
    ///
    /// This processes the `extends` field to merge base model properties
    /// with the derived model's overrides.
    pub fn resolve(&self, model: &JsonModel) -> Result<JsonModel, JsonModelError> {
        self.resolve_with_chain(model, &mut Vec::new())
    }

    /// Resolve a model's inheritance chain and normalize it into executable form.
    pub fn resolve_executable(&self, model: &JsonModel) -> Result<ExecutableModel, JsonModelError> {
        let resolved = self.resolve(model)?;
        let validated = Validator::new().validate(&resolved)?;
        validated.executable()
    }

    fn resolve_with_chain(
        &self,
        model: &JsonModel,
        chain: &mut Vec<String>,
    ) -> Result<JsonModel, JsonModelError> {
        // Check for circular inheritance
        if chain.contains(&model.id) {
            return Err(JsonModelError::CircularInheritance(format!(
                "{} -> {}",
                chain.join(" -> "),
                model.id
            )));
        }

        // If no base, return model as-is
        let Some(ref base_id) = model.extends else {
            return Ok(model.clone());
        };

        // Track inheritance chain
        chain.push(model.id.clone());

        // Get base model
        let base = self
            .get(base_id)
            .ok_or_else(|| JsonModelError::ModelNotFound(base_id.clone()))?;

        // Recursively resolve base
        let resolved_base = self.resolve_with_chain(base, chain)?;

        // Merge: derived model overrides base
        Ok(merge_models(&resolved_base, model))
    }
}

impl Default for ModelLibrary {
    fn default() -> Self {
        Self::new()
    }
}

/// Merge two models, with derived overriding base
fn merge_models(base: &JsonModel, derived: &JsonModel) -> JsonModel {
    JsonModel {
        // ─────────────────────────────────────────────────────────────────────
        // Layer 1: Identity (derived always owns these)
        // ─────────────────────────────────────────────────────────────────────
        schema: derived.schema.clone(),
        id: derived.id.clone(),
        model_type: derived.model_type,
        extends: None, // Clear extends after resolution
        version: derived.version.clone().or_else(|| base.version.clone()),
        aliases: merge_option_vec_dedup(&base.aliases, &derived.aliases),

        // ─────────────────────────────────────────────────────────────────────
        // Layer 2: Structural Model
        // ─────────────────────────────────────────────────────────────────────
        parameters: derived
            .parameters
            .clone()
            .or_else(|| base.parameters.clone()),
        compartments: derived
            .compartments
            .clone()
            .or_else(|| base.compartments.clone()),
        states: derived.states.clone().or_else(|| base.states.clone()),

        // ─────────────────────────────────────────────────────────────────────
        // Equation Fields
        // ─────────────────────────────────────────────────────────────────────
        analytical: derived.analytical.or(base.analytical),
        diffeq: derived.diffeq.clone().or_else(|| base.diffeq.clone()),
        drift: derived.drift.clone().or_else(|| base.drift.clone()),
        diffusion: derived.diffusion.clone().or_else(|| base.diffusion.clone()),
        secondary: merge_secondary(&base.secondary, &derived.secondary),

        // ─────────────────────────────────────────────────────────────────────
        // Output
        // ─────────────────────────────────────────────────────────────────────
        outputs: derived.outputs.clone().or_else(|| base.outputs.clone()),

        // ─────────────────────────────────────────────────────────────────────
        // Optional Features
        // ─────────────────────────────────────────────────────────────────────
        init: derived.init.clone().or_else(|| base.init.clone()),
        lag: derived.lag.clone().or_else(|| base.lag.clone()),
        fa: derived.fa.clone().or_else(|| base.fa.clone()),
        neqs: derived.neqs.or(base.neqs),
        particles: derived.particles.or(base.particles),

        // ─────────────────────────────────────────────────────────────────────
        // Layer 3: Model Extensions
        // ─────────────────────────────────────────────────────────────────────
        features: merge_option_vec(&base.features, &derived.features),
        covariates: merge_covariates(&base.covariates, &derived.covariates),

        // ─────────────────────────────────────────────────────────────────────
        // Layer 4: UI Metadata
        // ─────────────────────────────────────────────────────────────────────
        editor: merge_editor(&base.editor, &derived.editor),
    }
}

/// Merge optional vectors (append derived items)
fn merge_option_vec<T: Clone>(base: &Option<Vec<T>>, derived: &Option<Vec<T>>) -> Option<Vec<T>> {
    match (base, derived) {
        (None, None) => None,
        (Some(b), None) => Some(b.clone()),
        (None, Some(d)) => Some(d.clone()),
        (Some(b), Some(d)) => {
            let mut merged = b.clone();
            merged.extend(d.iter().cloned());
            Some(merged)
        }
    }
}

/// Merge optional string vectors, deduplicating entries
fn merge_option_vec_dedup(
    base: &Option<Vec<String>>,
    derived: &Option<Vec<String>>,
) -> Option<Vec<String>> {
    match (base, derived) {
        (None, None) => None,
        (Some(b), None) => Some(b.clone()),
        (None, Some(d)) => Some(d.clone()),
        (Some(b), Some(d)) => {
            let mut merged = b.clone();
            for item in d {
                if !merged.contains(item) {
                    merged.push(item.clone());
                }
            }
            Some(merged)
        }
    }
}

/// Merge covariates by symbol, preserving order and allowing derived overrides.
fn merge_covariates(
    base: &Option<Vec<CovariateDefinition>>,
    derived: &Option<Vec<CovariateDefinition>>,
) -> Option<Vec<CovariateDefinition>> {
    match (base, derived) {
        (None, None) => None,
        (Some(b), None) => Some(b.clone()),
        (None, Some(d)) => Some(d.clone()),
        (Some(b), Some(d)) => {
            let mut merged = b.clone();
            for item in d {
                if let Some(existing) = merged.iter_mut().find(|existing| existing.id == item.id) {
                    *existing = item.clone();
                } else {
                    merged.push(item.clone());
                }
            }
            Some(merged)
        }
    }
}

/// Merge secondary equations: derived keys override base keys, preserving order
fn merge_secondary(
    base: &Option<Vec<NamedEquation>>,
    derived: &Option<Vec<NamedEquation>>,
) -> Option<Vec<NamedEquation>> {
    match (base, derived) {
        (None, None) => None,
        (Some(b), None) => Some(b.clone()),
        (None, Some(d)) => Some(d.clone()),
        (Some(b), Some(d)) => {
            // Start with base, then override or append from derived
            let mut merged = b.clone();
            for entry in d {
                if let Some(existing) = merged.iter_mut().find(|existing| existing.id == entry.id) {
                    existing.equation = entry.equation.clone();
                } else {
                    merged.push(entry.clone());
                }
            }
            Some(merged)
        }
    }
}

/// Merge optional HashMaps (derived overrides base keys)
fn merge_option_hashmap<K: Clone + std::cmp::Eq + std::hash::Hash, V: Clone>(
    base: &Option<HashMap<K, V>>,
    derived: &Option<HashMap<K, V>>,
) -> Option<HashMap<K, V>> {
    match (base, derived) {
        (None, None) => None,
        (Some(b), None) => Some(b.clone()),
        (None, Some(d)) => Some(d.clone()),
        (Some(b), Some(d)) => {
            let mut merged = b.clone();
            merged.extend(d.iter().map(|(k, v)| (k.clone(), v.clone())));
            Some(merged)
        }
    }
}

/// Merge display info (derived overrides base)
fn merge_display(base: &Option<DisplayInfo>, derived: &Option<DisplayInfo>) -> Option<DisplayInfo> {
    match (base, derived) {
        (None, None) => None,
        (Some(b), None) => Some(b.clone()),
        (None, Some(d)) => Some(d.clone()),
        (Some(b), Some(d)) => Some(DisplayInfo {
            name: d.name.clone().or_else(|| b.name.clone()),
            short_name: d.short_name.clone().or_else(|| b.short_name.clone()),
            category: d.category.or(b.category),
            subcategory: d.subcategory.clone().or_else(|| b.subcategory.clone()),
            complexity: d.complexity.or(b.complexity),
            icon: d.icon.clone().or_else(|| b.icon.clone()),
            tags: merge_option_vec(&b.tags, &d.tags),
        }),
    }
}

/// Merge documentation (derived overrides base)
fn merge_documentation(
    base: &Option<Documentation>,
    derived: &Option<Documentation>,
) -> Option<Documentation> {
    match (base, derived) {
        (None, None) => None,
        (Some(b), None) => Some(b.clone()),
        (None, Some(d)) => Some(d.clone()),
        (Some(b), Some(d)) => Some(Documentation {
            summary: d.summary.clone().or_else(|| b.summary.clone()),
            description: d.description.clone().or_else(|| b.description.clone()),
            equations: d.equations.clone().or_else(|| b.equations.clone()),
            assumptions: merge_option_vec(&b.assumptions, &d.assumptions),
            when_to_use: merge_option_vec(&b.when_to_use, &d.when_to_use),
            when_not_to_use: merge_option_vec(&b.when_not_to_use, &d.when_not_to_use),
            references: merge_option_vec(&b.references, &d.references),
        }),
    }
}

fn merge_editor(base: &Option<EditorInfo>, derived: &Option<EditorInfo>) -> Option<EditorInfo> {
    match (base, derived) {
        (None, None) => None,
        (Some(b), None) => Some(b.clone()),
        (None, Some(d)) => Some(d.clone()),
        (Some(b), Some(d)) => Some(EditorInfo {
            display: merge_display(&b.display, &d.display),
            layout: merge_option_hashmap(&b.layout, &d.layout),
            documentation: merge_documentation(&b.documentation, &d.documentation),
        }),
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_builtin_library() {
        let library = ModelLibrary::builtin();
        assert!(!library.is_empty());
        assert!(library.contains("pk/1cmt-iv"));
        assert!(library.contains("pk/1cmt-iv-ode"));
    }

    #[test]
    fn test_search() {
        let library = ModelLibrary::builtin();

        // Search by ID
        let results = library.search("1cmt");
        assert!(!results.is_empty());
    }

    #[test]
    fn test_resolve_simple() {
        let mut library = ModelLibrary::new();

        let base = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "base-model",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["ke", "V"],
            "compartments": ["central"],
            "outputs": [
                { "id": "cp", "equation": "central / V" }
            ],
            "editor": {
                "display": { "name": "Base" }
            }
        }"#,
        )
        .unwrap();
        library.add(base);

        let derived = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "derived-model",
            "extends": "base-model",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["ke", "V", "extra"],
            "compartments": ["central"]
        }"#,
        )
        .unwrap();

        let resolved = library.resolve(&derived).unwrap();
        assert_eq!(resolved.parameters.as_ref().unwrap().len(), 3);
        assert_eq!(resolved.outputs.as_ref().unwrap()[0].id, "cp");
        assert_eq!(
            resolved
                .display_info()
                .and_then(|display| display.name.as_deref()),
            Some("Base")
        );
    }

    #[test]
    fn test_resolve_executable_uses_inherited_outputs() {
        let mut library = ModelLibrary::new();

        let base = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "base-model",
            "type": "ode",
            "parameters": ["ke", "V"],
            "compartments": ["central"],
            "diffeq": { "central": "-ke * central" },
            "outputs": [
                { "id": "cp", "equation": "central / V" }
            ]
        }"#,
        )
        .unwrap();
        library.add(base);

        let derived = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "derived-model",
            "extends": "base-model",
            "type": "ode",
            "parameters": ["ke", "V", "scale"],
            "compartments": ["central"],
            "secondary": [
                { "id": "cp_scaled", "equation": "central / V * scale" }
            ]
        }"#,
        )
        .unwrap();

        let executable = library.resolve_executable(&derived).unwrap();
        assert_eq!(executable.outputs[0].id, "cp");
        assert_eq!(
            executable
                .calculations
                .iter()
                .map(|entry| entry.id.as_str())
                .collect::<Vec<_>>(),
            vec!["cp_scaled"]
        );
    }

    #[test]
    fn test_circular_inheritance() {
        let mut library = ModelLibrary::new();

        let model_a = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "model-a",
            "extends": "model-b",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["ke", "V"],
            "compartments": ["central"],
            "outputs": [{ "id": "cp", "equation": "central / V" }]
        }"#,
        )
        .unwrap();

        let model_b = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "model-b",
            "extends": "model-a",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["ke", "V"],
            "compartments": ["central"],
            "outputs": [{ "id": "cp", "equation": "central / V" }]
        }"#,
        )
        .unwrap();

        library.add(model_a.clone());
        library.add(model_b);

        // Should detect circular inheritance
        let result = library.resolve(&model_a);
        assert!(matches!(
            result,
            Err(JsonModelError::CircularInheritance(_))
        ));
    }

    #[test]
    fn test_merge_secondary_overrides_by_key() {
        let mut library = ModelLibrary::new();

        let base = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "base",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["CL", "V"],
            "compartments": ["central"],
            "secondary": [{ "id": "ke", "equation": "CL / V" }],
            "outputs": [{ "id": "cp", "equation": "central / V" }]
        }"#,
        )
        .unwrap();
        library.add(base);

        let derived = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "derived",
            "extends": "base",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["CL", "V"],
            "compartments": ["central"],
            "secondary": [{ "id": "ke", "equation": "CL / V * 0.9" }]
        }"#,
        )
        .unwrap();

        let resolved = library.resolve(&derived).unwrap();
        let secondary = resolved.secondary.as_ref().unwrap();

        // Should have exactly one "ke", not two
        assert_eq!(
            secondary.len(),
            1,
            "Derived 'ke' should override base 'ke', not duplicate"
        );
        assert_eq!(secondary[0].id, "ke");
        assert_eq!(secondary[0].equation, "CL / V * 0.9");
    }

    #[test]
    fn test_merge_secondary_appends_new_keys() {
        let mut library = ModelLibrary::new();

        let base = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "base",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["CL", "V"],
            "compartments": ["central"],
            "secondary": [{ "id": "ke", "equation": "CL / V" }],
            "outputs": [{ "id": "cp", "equation": "central / V" }]
        }"#,
        )
        .unwrap();
        library.add(base);

        let derived = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "derived",
            "extends": "base",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["CL", "V"],
            "compartments": ["central"],
            "secondary": [{ "id": "halflife", "equation": "0.693 / ke" }]
        }"#,
        )
        .unwrap();

        let resolved = library.resolve(&derived).unwrap();
        let secondary = resolved.secondary.as_ref().unwrap();

        // Should have both base "ke" and derived "halflife"
        assert_eq!(secondary.len(), 2);
        assert_eq!(secondary[0].id, "ke");
        assert_eq!(secondary[1].id, "halflife");
    }

    #[test]
    fn test_merge_covariates_deduplicates() {
        let mut library = ModelLibrary::new();

        let base = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "base",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["ke", "V"],
            "compartments": ["central"],
            "covariates": [{ "id": "wt" }, { "id": "age" }],
            "outputs": [{ "id": "cp", "equation": "central / V" }]
        }"#,
        )
        .unwrap();
        library.add(base);

        let derived = JsonModel::from_str(
            r#"{
            "schema": "2.0",
            "id": "derived",
            "extends": "base",
            "type": "analytical",
            "analytical": "one_compartment",
            "parameters": ["ke", "V"],
            "compartments": ["central"],
            "covariates": [{ "id": "wt", "column": "WT" }, { "id": "sex" }]
        }"#,
        )
        .unwrap();

        let resolved = library.resolve(&derived).unwrap();
        let covariates = resolved.covariates.as_ref().unwrap();

        // "wt" should appear only once
        assert_eq!(
            covariates.len(),
            3,
            "Should have wt, age, sex (wt deduplicated)"
        );
        assert!(covariates.iter().any(|cov| cov.id == "wt"));
        assert!(covariates.iter().any(|cov| cov.id == "age"));
        assert!(covariates.iter().any(|cov| cov.id == "sex"));
    }
}