pgsafe 0.9.0

Static safety linter for PostgreSQL DDL migrations — catches unsafe schema changes before they lock or break production.
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39

use pg_query::NodeEnum;

use super::Rule;
use crate::{RuleHit, Severity};

pub struct VacuumFullOrCluster;

impl Rule for VacuumFullOrCluster {
    fn id(&self) -> &'static str {
        "vacuum-full-cluster"
    }
    fn severity(&self) -> Severity {
        Severity::Error
    }
    fn check(&self, node: &NodeEnum, out: &mut Vec<RuleHit>) {
        let fires = match node {
            NodeEnum::VacuumStmt(v) => {
                v.is_vacuumcmd
                    && v.options.iter().any(|opt| {
                        matches!(opt.node.as_ref(), Some(NodeEnum::DefElem(de))
                            if de.defname == "full" && super::defelem_is_true(de))
                    })
            }
            NodeEnum::ClusterStmt(_) => true,
            _ => false,
        };
        if fires {
            out.push(RuleHit {
                message: "VACUUM FULL and CLUSTER rewrite the entire table under an ACCESS EXCLUSIVE lock — \
                          minutes to hours of blocked reads and writes, plus 2x disk."
                    .into(),
                guidance: "Use pg_repack for online table/space maintenance; plain VACUUM (no FULL) takes \
                           only SHARE UPDATE EXCLUSIVE and allows concurrent reads and writes."
                    .into(),
                fix: None,
            });
        }
    }
}