pgmt 0.5.0

PostgreSQL migration tool that keeps your schema files as the source of truth
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
use anyhow::{Context, Result, anyhow};
use petgraph::algo::tarjan_scc;
use petgraph::graph::DiGraph;
use std::collections::{BTreeMap, HashMap, HashSet, VecDeque};
use std::fs;
use std::path::{Path, PathBuf};

/// Represents a schema file with its content and dependencies
#[derive(Debug, Clone)]
pub struct SchemaFile {
    pub relative_path: String,
    pub content: String,
    pub dependencies: Vec<String>,
}

/// Configuration for schema loading
#[derive(Debug, Clone)]
pub struct SchemaLoaderConfig {
    pub schema_dir: PathBuf,
}

impl SchemaLoaderConfig {
    pub fn new(schema_dir: PathBuf) -> Self {
        Self { schema_dir }
    }
}

/// Handles discovery, parsing, and ordering of schema files
pub struct SchemaLoader {
    config: SchemaLoaderConfig,
}

impl SchemaLoader {
    pub fn new(config: SchemaLoaderConfig) -> Self {
        Self { config }
    }

    /// Load and order schema files, returning the individual files
    pub fn load_ordered_schema_files(&self) -> Result<Vec<SchemaFile>> {
        let files = self.discover_schema_files()?;
        let parsed_files = self.parse_schema_files(files)?;
        let ordered_files = self.resolve_dependencies(parsed_files)?;

        Ok(ordered_files)
    }

    /// Discover all .sql files in the schema directory recursively
    fn discover_schema_files(&self) -> Result<Vec<PathBuf>> {
        let mut files = Vec::new();
        self.discover_sql_files_recursive(&self.config.schema_dir, &mut files)?;

        // Sort alphabetically for deterministic ordering
        files.sort();

        Ok(files)
    }

    /// Recursively discover .sql files in a directory
    fn discover_sql_files_recursive(&self, dir: &Path, files: &mut Vec<PathBuf>) -> Result<()> {
        if !dir.is_dir() {
            return Ok(());
        }

        let entries = fs::read_dir(dir)
            .with_context(|| format!("Failed to read directory: {}", dir.display()))?;

        for entry in entries {
            let entry = entry?;
            let path = entry.path();

            // Security check: ensure symlinks don't point outside schema directory
            if path.is_symlink() {
                let real_path = fs::canonicalize(&path)
                    .with_context(|| format!("Failed to resolve symlink: {}", path.display()))?;
                let schema_dir_canonical =
                    fs::canonicalize(&self.config.schema_dir).with_context(|| {
                        format!(
                            "Failed to resolve schema directory: {}",
                            self.config.schema_dir.display()
                        )
                    })?;

                if !real_path.starts_with(&schema_dir_canonical) {
                    return Err(anyhow!(
                        "Symlink points outside schema directory: {} -> {}",
                        path.display(),
                        real_path.display()
                    ));
                }
            }

            if path.is_dir() {
                self.discover_sql_files_recursive(&path, files)?;
            } else if path.extension().and_then(|s| s.to_str()) == Some("sql") {
                files.push(path);
            }
        }

        Ok(())
    }

    /// Parse schema files and extract their dependencies
    fn parse_schema_files(&self, file_paths: Vec<PathBuf>) -> Result<Vec<SchemaFile>> {
        let mut schema_files = Vec::new();

        for path in file_paths {
            let content = fs::read_to_string(&path)
                .with_context(|| format!("Failed to read file: {}", path.display()))?;

            let relative_path = path
                .strip_prefix(&self.config.schema_dir)
                .map_err(|_| anyhow!("File path not within schema directory: {}", path.display()))?
                .to_string_lossy()
                .to_string();

            let dependencies = self.parse_dependencies(&content)?;

            schema_files.push(SchemaFile {
                relative_path,
                content,
                dependencies,
            });
        }

        Ok(schema_files)
    }

    /// Parse dependency declarations from SQL file content
    fn parse_dependencies(&self, content: &str) -> Result<Vec<String>> {
        let mut dependencies = Vec::new();

        for line in content.lines() {
            let trimmed = line.trim();

            // Look for -- require: syntax
            if let Some(require_part) = trimmed.strip_prefix("-- require:") {
                let require_content = require_part.trim();

                // Handle multiple dependencies separated by commas
                for dep in require_content.split(',') {
                    let dep = dep.trim();
                    if !dep.is_empty() {
                        // Normalize the dependency path
                        let normalized = self.normalize_dependency_path(dep)?;
                        dependencies.push(normalized);
                    }
                }
            }
        }

        Ok(dependencies)
    }

    /// Normalize a dependency path (add .sql extension if missing, resolve relative paths)
    fn normalize_dependency_path(&self, dep_path: &str) -> Result<String> {
        let mut path = dep_path.to_string();

        // Add .sql extension if not present
        if !path.ends_with(".sql") {
            path.push_str(".sql");
        }

        // For now, all paths are relative to schema root
        // TODO: In the future, we could support ./ and ../ relative paths

        Ok(path)
    }

    /// Resolve dependencies and return files in correct order
    fn resolve_dependencies(&self, files: Vec<SchemaFile>) -> Result<Vec<SchemaFile>> {
        // Create a map of relative path -> file for quick lookup
        let file_map: HashMap<String, SchemaFile> = files
            .iter()
            .map(|f| (f.relative_path.clone(), f.clone()))
            .collect();

        // Validate all dependencies exist
        for file in &files {
            for dep in &file.dependencies {
                if !file_map.contains_key(dep) {
                    return Err(anyhow!(
                        "Missing dependency '{}' required by '{}'",
                        dep,
                        file.relative_path
                    ));
                }
            }
        }

        // Topological sort using Kahn's algorithm
        self.topological_sort(files, file_map)
    }

    /// Perform topological sort to order files by dependencies
    fn topological_sort(
        &self,
        files: Vec<SchemaFile>,
        file_map: HashMap<String, SchemaFile>,
    ) -> Result<Vec<SchemaFile>> {
        let mut in_degree: HashMap<String, usize> = HashMap::new();
        let mut graph: HashMap<String, Vec<String>> = HashMap::new();

        // Initialize in-degree counts and adjacency list
        for file in &files {
            in_degree.insert(file.relative_path.clone(), 0);
            graph.insert(file.relative_path.clone(), Vec::new());
        }

        // Build the dependency graph
        for file in &files {
            for dep in &file.dependencies {
                graph.get_mut(dep).unwrap().push(file.relative_path.clone());
                *in_degree.get_mut(&file.relative_path).unwrap() += 1;
            }
        }

        // Start with files that have no dependencies
        let mut queue: VecDeque<String> = in_degree
            .iter()
            .filter(|(_, count)| **count == 0)
            .map(|(path, _)| path.clone())
            .collect();

        // For deterministic ordering, sort the initial queue
        let mut queue_vec: Vec<_> = queue.into_iter().collect();
        queue_vec.sort();
        queue = queue_vec.into();

        let mut ordered = Vec::new();
        let mut processed = HashSet::new();

        while let Some(current) = queue.pop_front() {
            if processed.contains(&current) {
                continue;
            }

            ordered.push(file_map.get(&current).unwrap().clone());
            processed.insert(current.clone());

            // Process dependencies of current file
            let dependents = graph.get(&current).unwrap().clone();
            for dependent in dependents {
                let count = in_degree.get_mut(&dependent).unwrap();
                *count -= 1;

                if *count == 0 {
                    queue.push_back(dependent);
                }
            }

            // Sort queue for deterministic ordering
            let mut queue_vec: Vec<_> = queue.into_iter().collect();
            queue_vec.sort();
            queue = queue_vec.into();
        }

        // Check for circular dependencies
        if ordered.len() != files.len() {
            let unprocessed: HashSet<_> = files
                .iter()
                .filter(|f| !processed.contains(&f.relative_path))
                .map(|f| f.relative_path.clone())
                .collect();

            // Build a map of file -> dependencies for cycle detection
            let file_dependencies: HashMap<_, _> = files
                .iter()
                .map(|f| (f.relative_path.clone(), f.dependencies.clone()))
                .collect();

            let cycles = Self::find_cycles(&unprocessed, &file_dependencies);

            if cycles.is_empty() {
                // Fallback (shouldn't happen if our algorithm is correct)
                let mut unprocessed_list: Vec<_> = unprocessed.into_iter().collect();
                unprocessed_list.sort();
                return Err(anyhow!(
                    "Circular dependency detected. Files involved: {}",
                    unprocessed_list.join(", ")
                ));
            }

            // Format error message with actual cycles
            let cycle_descriptions: Vec<String> = cycles
                .iter()
                .map(|c| Self::format_cycle(c, &file_dependencies))
                .collect();

            if cycles.len() == 1 {
                return Err(anyhow!(
                    "Circular dependency detected: {}",
                    cycle_descriptions[0]
                ));
            } else {
                return Err(anyhow!(
                    "Multiple circular dependencies detected:\n  - {}",
                    cycle_descriptions.join("\n  - ")
                ));
            }
        }

        Ok(ordered)
    }

    /// Find actual cycles in a dependency graph using Tarjan's SCC algorithm.
    /// Returns a list of cycles, where each cycle is a vector of file paths.
    fn find_cycles(
        unprocessed: &HashSet<String>,
        file_dependencies: &HashMap<String, Vec<String>>,
    ) -> Vec<Vec<String>> {
        // Build a petgraph from unprocessed nodes only
        let mut pg: DiGraph<String, ()> = DiGraph::new();
        let mut node_indices: BTreeMap<String, _> = BTreeMap::new();

        // Add nodes (using BTreeMap for deterministic ordering)
        let mut sorted_unprocessed: Vec<_> = unprocessed.iter().cloned().collect();
        sorted_unprocessed.sort();

        for path in &sorted_unprocessed {
            let idx = pg.add_node(path.clone());
            node_indices.insert(path.clone(), idx);
        }

        // Add edges: dependency -> file (dependency must come before file)
        // This is the reverse of the "file depends on dependency" relationship
        for path in &sorted_unprocessed {
            if let Some(deps) = file_dependencies.get(path) {
                for dep in deps {
                    if unprocessed.contains(dep)
                        && let (Some(&from), Some(&to)) =
                            (node_indices.get(dep), node_indices.get(path))
                    {
                        pg.add_edge(from, to, ());
                    }
                }
            }
        }

        // Find SCCs - components with >1 node are cycles
        let sccs = tarjan_scc(&pg);

        sccs.into_iter()
            .filter(|scc| scc.len() > 1)
            .map(|scc| {
                let mut cycle: Vec<_> = scc.into_iter().map(|idx| pg[idx].clone()).collect();
                cycle.sort(); // Deterministic ordering
                cycle
            })
            .collect()
    }

    /// Format a cycle as a readable string showing the dependency chain.
    fn format_cycle(
        cycle_nodes: &[String],
        file_dependencies: &HashMap<String, Vec<String>>,
    ) -> String {
        if cycle_nodes.is_empty() {
            return String::new();
        }

        // Start from the first node alphabetically for determinism
        let mut sorted_nodes = cycle_nodes.to_vec();
        sorted_nodes.sort();

        let start = &sorted_nodes[0];
        let mut path = vec![start.clone()];
        let mut current = start.clone();
        let mut visited = HashSet::new();
        visited.insert(current.clone());

        // Follow dependencies to build the cycle path
        // We need to find which node in the cycle depends on the current node
        while path.len() < cycle_nodes.len() {
            let mut found = false;
            // Find a node in the cycle that depends on the current node
            for node in &sorted_nodes {
                if visited.contains(node) {
                    continue;
                }
                if let Some(deps) = file_dependencies.get(node)
                    && deps.contains(&current)
                {
                    path.push(node.clone());
                    visited.insert(node.clone());
                    current = node.clone();
                    found = true;
                    break;
                }
            }
            if !found {
                break;
            }
        }

        // Close the cycle by adding the start node again
        path.push(start.clone());

        path.join(" -> ")
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::fs;
    use tempfile::TempDir;

    fn create_test_schema_dir() -> TempDir {
        TempDir::new().unwrap()
    }

    fn write_file(dir: &Path, relative_path: &str, content: &str) {
        let file_path = dir.join(relative_path);
        if let Some(parent) = file_path.parent() {
            fs::create_dir_all(parent).unwrap();
        }
        fs::write(file_path, content).unwrap();
    }

    /// Helper to find a file's position in the ordered list
    fn find_file_index(files: &[SchemaFile], name: &str) -> usize {
        files
            .iter()
            .position(|f| f.relative_path.contains(name))
            .unwrap_or_else(|| panic!("File {} not found", name))
    }

    #[test]
    fn test_single_file() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        write_file(schema_dir, "my_schema.sql", "CREATE TABLE test (id INT);");

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let files = loader.load_ordered_schema_files().unwrap();
        assert_eq!(files.len(), 1);
        assert_eq!(files[0].relative_path, "my_schema.sql");
        assert!(files[0].content.contains("CREATE TABLE test"));
    }

    #[test]
    fn test_multi_file_without_dependencies() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        write_file(
            schema_dir,
            "tables/users.sql",
            "CREATE TABLE users (id INT);",
        );
        write_file(
            schema_dir,
            "tables/posts.sql",
            "CREATE TABLE posts (id INT);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let files = loader.load_ordered_schema_files().unwrap();

        // Should be alphabetically ordered (posts before users)
        assert_eq!(files.len(), 2);
        let posts_idx = find_file_index(&files, "posts.sql");
        let users_idx = find_file_index(&files, "users.sql");
        assert!(posts_idx < users_idx);
    }

    #[test]
    fn test_dependency_parsing() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        write_file(schema_dir, "base.sql", "CREATE SCHEMA app;");
        write_file(
            schema_dir,
            "tables.sql",
            "-- require: base.sql\nCREATE TABLE app.users (id INT);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let files = loader.load_ordered_schema_files().unwrap();

        // base.sql should come before tables.sql
        let base_idx = find_file_index(&files, "base.sql");
        let tables_idx = find_file_index(&files, "tables.sql");
        assert!(base_idx < tables_idx);
    }

    #[test]
    fn test_multiple_dependencies() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        write_file(schema_dir, "schema.sql", "CREATE SCHEMA app;");
        write_file(
            schema_dir,
            "types.sql",
            "-- require: schema.sql\nCREATE TYPE app.status AS ENUM ('active', 'inactive');",
        );
        write_file(
            schema_dir,
            "tables.sql",
            "-- require: schema.sql, types.sql\nCREATE TABLE app.users (id INT, status app.status);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let files = loader.load_ordered_schema_files().unwrap();

        let schema_idx = find_file_index(&files, "schema.sql");
        let types_idx = find_file_index(&files, "types.sql");
        let tables_idx = find_file_index(&files, "tables.sql");

        assert!(schema_idx < types_idx);
        assert!(schema_idx < tables_idx);
        assert!(types_idx < tables_idx);
    }

    #[test]
    fn test_circular_dependency_detection() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        write_file(
            schema_dir,
            "a.sql",
            "-- require: b.sql\nCREATE TABLE a (id INT);",
        );
        write_file(
            schema_dir,
            "b.sql",
            "-- require: a.sql\nCREATE TABLE b (id INT);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let result = loader.load_ordered_schema_files();
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("Circular dependency")
        );
    }

    #[test]
    fn test_missing_dependency() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        write_file(
            schema_dir,
            "tables.sql",
            "-- require: missing.sql\nCREATE TABLE users (id INT);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let result = loader.load_ordered_schema_files();
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("Missing dependency")
        );
    }

    #[test]
    fn test_circular_dependency_excludes_non_cycle_files() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        // A <-> B form a cycle
        write_file(
            schema_dir,
            "a.sql",
            "-- require: b.sql\nCREATE TABLE a (id INT);",
        );
        write_file(
            schema_dir,
            "b.sql",
            "-- require: a.sql\nCREATE TABLE b (id INT);",
        );

        // C depends on A but is NOT part of the cycle
        write_file(
            schema_dir,
            "c.sql",
            "-- require: a.sql\nCREATE TABLE c (id INT);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let result = loader.load_ordered_schema_files();
        assert!(result.is_err());

        let error_msg = result.unwrap_err().to_string();
        assert!(error_msg.contains("a.sql"));
        assert!(error_msg.contains("b.sql"));
        // c.sql should NOT be mentioned as it's not part of the cycle
        assert!(!error_msg.contains("c.sql"));
    }

    #[test]
    fn test_circular_dependency_shows_cycle_path() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        write_file(
            schema_dir,
            "a.sql",
            "-- require: b.sql\nCREATE TABLE a (id INT);",
        );
        write_file(
            schema_dir,
            "b.sql",
            "-- require: a.sql\nCREATE TABLE b (id INT);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let result = loader.load_ordered_schema_files();
        assert!(result.is_err());

        let error_msg = result.unwrap_err().to_string();
        // Should show the cycle path with arrows
        assert!(error_msg.contains("->"));
    }

    #[test]
    fn test_three_node_circular_dependency() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        // A -> B -> C -> A
        write_file(
            schema_dir,
            "a.sql",
            "-- require: c.sql\nCREATE TABLE a (id INT);",
        );
        write_file(
            schema_dir,
            "b.sql",
            "-- require: a.sql\nCREATE TABLE b (id INT);",
        );
        write_file(
            schema_dir,
            "c.sql",
            "-- require: b.sql\nCREATE TABLE c (id INT);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let result = loader.load_ordered_schema_files();
        assert!(result.is_err());

        let error_msg = result.unwrap_err().to_string();
        assert!(error_msg.contains("a.sql"));
        assert!(error_msg.contains("b.sql"));
        assert!(error_msg.contains("c.sql"));
        assert!(error_msg.contains("->"));
    }

    #[test]
    fn test_multiple_independent_cycles() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        // First cycle: A <-> B
        write_file(
            schema_dir,
            "a.sql",
            "-- require: b.sql\nCREATE TABLE a (id INT);",
        );
        write_file(
            schema_dir,
            "b.sql",
            "-- require: a.sql\nCREATE TABLE b (id INT);",
        );

        // Second cycle: X <-> Y
        write_file(
            schema_dir,
            "x.sql",
            "-- require: y.sql\nCREATE TABLE x (id INT);",
        );
        write_file(
            schema_dir,
            "y.sql",
            "-- require: x.sql\nCREATE TABLE y (id INT);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let result = loader.load_ordered_schema_files();
        assert!(result.is_err());

        let error_msg = result.unwrap_err().to_string();
        // Should mention multiple cycles
        assert!(error_msg.contains("Multiple circular dependencies"));
    }

    #[test]
    fn test_dependent_on_cycle_not_reported() {
        let temp_dir = create_test_schema_dir();
        let schema_dir = temp_dir.path();

        // Base file with no dependencies (will be processed)
        write_file(schema_dir, "base.sql", "CREATE SCHEMA base;");

        // Cycle: A <-> B (A also depends on base)
        write_file(
            schema_dir,
            "a.sql",
            "-- require: base.sql, b.sql\nCREATE TABLE a (id INT);",
        );
        write_file(
            schema_dir,
            "b.sql",
            "-- require: a.sql\nCREATE TABLE b (id INT);",
        );

        // C depends on A (part of cycle) - C is blocked but not in cycle
        write_file(
            schema_dir,
            "c.sql",
            "-- require: a.sql\nCREATE TABLE c (id INT);",
        );

        // D depends on C (transitively depends on cycle) - also blocked
        write_file(
            schema_dir,
            "d.sql",
            "-- require: c.sql\nCREATE TABLE d (id INT);",
        );

        let config = SchemaLoaderConfig::new(schema_dir.to_path_buf());
        let loader = SchemaLoader::new(config);

        let result = loader.load_ordered_schema_files();
        assert!(result.is_err());

        let error_msg = result.unwrap_err().to_string();

        // Only a.sql and b.sql are in the cycle
        assert!(error_msg.contains("a.sql"));
        assert!(error_msg.contains("b.sql"));

        // These should NOT be mentioned
        assert!(!error_msg.contains("base.sql"));
        assert!(!error_msg.contains("c.sql"));
        assert!(!error_msg.contains("d.sql"));
    }
}