1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
macro_rules! register_collectors {
(
$(
$module:ident => $collector_type:ident
),* $(,)?
) => {
// Import all collector modules
$(
pub mod $module;
pub use $module::$collector_type;
)*
// Generate the enum with all collector types
#[derive(Clone)]
pub enum CollectorType {
$(
$collector_type($collector_type),
)*
}
// Implement Collector trait for CollectorType enum
impl Collector for CollectorType {
fn name(&self) -> &'static str {
match self {
$(
CollectorType::$collector_type(c) => c.name(),
)*
}
}
fn register_metrics(&self, registry: &Registry) -> Result<()> {
match self {
$(
CollectorType::$collector_type(c) => c.register_metrics(registry),
)*
}
}
fn collect<'a>(&'a self, pool: &'a PgPool) -> BoxFuture<'a, Result<()>> {
match self {
$(
CollectorType::$collector_type(c) => c.collect(pool),
)*
}
}
fn enabled_by_default(&self) -> bool {
match self {
$(
CollectorType::$collector_type(c) => c.enabled_by_default(),
)*
}
}
}
/// Methods specific to particular collector variants.
///
/// These methods provide capabilities that only certain collectors have,
/// without polluting the core `Collector` trait with optional methods.
impl CollectorType {
/// Get the scraper collector for tracking scrape performance metrics.
///
/// # Design Rationale
///
/// Only `ExporterCollector` tracks scrape performance (duration, errors, etc).
/// Rather than adding an optional method to the `Collector` trait that 99%
/// of collectors would return `None` for, we implement this as a method on
/// the `CollectorType` enum.
///
/// This keeps the trait focused on the universal collector contract while
/// providing type-safe access to collector-specific capabilities.
///
/// # Returns
///
/// - `Some(Arc<ScraperCollector>)` if this is an `ExporterCollector`
/// - `None` for all other collector types
///
/// # Example
///
/// ```rust,ignore
/// // In CollectorRegistry::new()
/// for (name, factory) in factories {
/// let collector = factory();
///
/// // Extract scraper if exporter collector is enabled
/// if let Some(scraper) = collector.get_scraper() {
/// // Use scraper to track performance of all collectors
/// self.scraper = Some(scraper);
/// }
/// }
/// ```
pub fn get_scraper(&self) -> Option<std::sync::Arc<crate::collectors::exporter::ScraperCollector>> {
match self {
// ExporterCollector is the only collector that tracks scrape performance
CollectorType::ExporterCollector(c) => Some(c.get_scraper().clone()),
// All other collectors don't have scraping capabilities
_ => None,
}
}
}
// Generate the factory function map
pub fn all_factories() -> HashMap<&'static str, fn() -> CollectorType> {
let mut map: HashMap<&'static str, fn() -> CollectorType> = HashMap::new();
$(
map.insert(
stringify!($module),
|| CollectorType::$collector_type($collector_type::new()),
);
)*
map
}
// Generate array of collector names
pub const COLLECTOR_NAMES: &[&'static str] = &[
$(stringify!($module),)*
];
};
}
#[cfg(test)]
mod tests {
use crate::collectors::Collector;
use prometheus::Registry;
// Test that the macro works with the actual collectors in the parent module
#[test]
fn test_all_factories_exist() {
let factories = crate::collectors::all_factories();
// Should have all registered collectors
assert!(!factories.is_empty());
assert!(factories.len() >= 5); // At least default, vacuum, activity, locks, database, stat
}
#[test]
fn test_collector_names_exist() {
let names = crate::collectors::COLLECTOR_NAMES;
assert!(!names.is_empty());
assert!(names.len() >= 5);
// Check expected collectors are present
assert!(names.contains(&"default"));
assert!(names.contains(&"vacuum"));
assert!(names.contains(&"activity"));
assert!(names.contains(&"locks"));
assert!(names.contains(&"database"));
assert!(names.contains(&"stat"));
}
#[test]
fn test_factory_creates_valid_collectors() {
let factories = crate::collectors::all_factories();
// Test creating each collector
for (name, factory) in &factories {
let collector = factory();
// Each collector should have a non-empty name
assert!(
!collector.name().is_empty(),
"Collector {name} has empty name"
);
}
}
#[test]
fn test_factories_match_collector_names() {
let factories = crate::collectors::all_factories();
let names = crate::collectors::COLLECTOR_NAMES;
// Every factory key should be in COLLECTOR_NAMES
for key in factories.keys() {
assert!(
names.contains(key),
"Factory key '{key}' not found in COLLECTOR_NAMES"
);
}
// Every name in COLLECTOR_NAMES should have a factory
for name in names {
assert!(
factories.contains_key(name),
"Name '{name}' in COLLECTOR_NAMES has no factory"
);
}
// Counts should match
assert_eq!(factories.len(), names.len());
}
#[test]
fn test_collector_name_matches_key() {
let factories = crate::collectors::all_factories();
// The collector's name() should match the factory key
for (key, factory) in &factories {
let collector = factory();
assert_eq!(
collector.name(),
*key,
"Collector name '{}' doesn't match factory key '{}'",
collector.name(),
key
);
}
}
#[test]
fn test_default_collector_enabled_by_default() {
let factories = crate::collectors::all_factories();
if let Some(factory) = factories.get("default") {
let collector = factory();
assert!(
collector.enabled_by_default(),
"Default collector should be enabled by default"
);
}
}
#[test]
fn test_register_metrics_does_not_panic() {
let factories = crate::collectors::all_factories();
let registry = Registry::new();
// Test that each collector can register metrics without panicking
for (name, factory) in &factories {
let collector = factory();
let result = collector.register_metrics(®istry);
assert!(
result.is_ok(),
"Collector '{name}' failed to register metrics: {result:?}"
);
}
}
#[test]
fn test_collector_names_are_lowercase() {
let names = crate::collectors::COLLECTOR_NAMES;
// Convention: collector names should be lowercase
for name in names {
assert_eq!(
*name,
name.to_lowercase(),
"Collector name '{name}' is not lowercase"
);
}
}
#[test]
fn test_collector_names_are_unique() {
let names = crate::collectors::COLLECTOR_NAMES;
let mut seen = std::collections::HashSet::new();
for name in names {
assert!(
seen.insert(name),
"Duplicate collector name found: '{name}'"
);
}
}
#[test]
fn test_factory_map_keys_are_unique() {
let factories = crate::collectors::all_factories();
// HashMap keys are inherently unique, but let's verify count
let unique_count = factories
.keys()
.collect::<std::collections::HashSet<_>>()
.len();
assert_eq!(
factories.len(),
unique_count,
"Factory map has duplicate keys"
);
}
#[test]
fn test_exporter_collector_is_registered() {
let names = crate::collectors::COLLECTOR_NAMES;
assert!(
names.contains(&"exporter"),
"Exporter collector should be registered"
);
}
#[test]
fn test_exporter_collector_factory_exists() {
let factories = crate::collectors::all_factories();
assert!(
factories.contains_key("exporter"),
"Exporter factory should exist"
);
}
#[test]
#[allow(clippy::panic)]
fn test_get_scraper_returns_some_for_exporter() {
let factories = crate::collectors::all_factories();
if let Some(factory) = factories.get("exporter") {
let collector = factory();
let scraper = collector.get_scraper();
assert!(
scraper.is_some(),
"ExporterCollector should provide a scraper"
);
} else {
panic!("Exporter factory not found");
}
}
#[test]
fn test_get_scraper_returns_none_for_other_collectors() {
let factories = crate::collectors::all_factories();
// Test that non-exporter collectors return None
let non_exporter_collectors = vec!["default", "vacuum", "activity", "locks"];
for name in non_exporter_collectors {
if let Some(factory) = factories.get(name) {
let collector = factory();
let scraper = collector.get_scraper();
assert!(
scraper.is_none(),
"Collector '{name}' should not provide a scraper"
);
}
}
}
#[test]
fn test_exporter_collector_name_matches() {
let factories = crate::collectors::all_factories();
if let Some(factory) = factories.get("exporter") {
let collector = factory();
assert_eq!(
collector.name(),
"exporter",
"ExporterCollector name should be 'exporter'"
);
}
}
}