perl-workspace 0.14.0

Workspace file discovery, indexing, and observability for Perl
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
//! Import-spec extractor for workspace-level `ImportExportIndex` population.
//!
//! Recognizes `use`, `require`, `require + Module->import(...)`, and
//! standalone `ClassName->import(@names)` patterns in an AST and produces
//! [`ImportSpec`] entries for each.
//!
//! # Placement note — circular dependency debt
//!
//! This extractor lives in `perl-workspace` rather than
//! `perl-semantic-analyzer` because of a circular dependency:
//! `perl-semantic-analyzer/Cargo.toml` declares `perl-workspace` as a
//! dependency, so moving any producer into `perl-semantic-analyzer` would
//! create a cycle.
//!
//! This is **temporary architectural debt**. The correct long-term placement
//! is `perl-semantic-analyzer`, which owns the semantic production layer.
//! The blocker is the current `perl-semantic-analyzer → perl-workspace` dep
//! arc.
//!
//! **Follow-up**: invert or remove the `perl-semantic-analyzer → perl-workspace`
//! dependency (possibly by introducing a `perl-workspace-types` leaf crate for
//! the fact types), then consolidate this extractor into `perl-semantic-analyzer`.
//! Track as a follow-up after the dynamic-boundary suppression PRs merge.
//!
//! # Supported patterns
//!
//! | Perl source                                | `ImportKind`        | `ImportSymbols`          |
//! |--------------------------------------------|---------------------|--------------------------|
//! | `use Module qw(a b)`                       | `UseExplicitList`   | `Explicit(["a","b"])`    |
//! | `use Module ()`                            | `UseEmpty`          | `None`                   |
//! | `use Module ':tag'`                        | `UseTag`            | `Tags(["tag"])`          |
//! | `use Module` (bare)                        | `Use`               | `Default`                |
//! | `use constant { FOO => 1 }`                | `UseConstant`       | `Explicit(["FOO"])`      |
//! | `use constant PI => 3.14`                  | `UseConstant`       | `Explicit(["PI"])`       |
//! | `require Module`                           | `Require`           | `Default`                |
//! | `require Module; Module->import(...)`      | `RequireThenImport` | per args                 |
//! | `require $var`                             | `DynamicRequire`    | `Dynamic`                |
//! | `Foo->import(@names)` (standalone)         | `ManualImport`      | `Dynamic`                |

use crate::ast::{Node, NodeKind};
use perl_semantic_facts::{
    AnchorId, Confidence, FileId, ImportKind, ImportSpec, ImportSymbols, Provenance,
};

/// Walk the AST and return one [`ImportSpec`] per import site.
///
/// Each spec carries the supplied `file_id` and an `anchor_id` derived from
/// the statement's byte-offset (for incremental invalidation).
///
/// See the module-level doc for the full list of recognised patterns.
pub fn extract_import_specs(ast: &Node, file_id: FileId) -> Vec<ImportSpec> {
    let mut out = Vec::new();
    walk(ast, file_id, &mut out);
    out
}

// ── AST walker ──────────────────────────────────────────────────────────────

fn walk(node: &Node, file_id: FileId, out: &mut Vec<ImportSpec>) {
    // Handle `use` statements.
    if let NodeKind::Use { module, args, .. } = &node.kind {
        if let Some(spec) = classify_use(module, args, file_id, node) {
            out.push(spec);
        }
    }

    // Detect standalone `ClassName->import(@names)` method calls where the
    // object is a static identifier (not a variable). These are NOT preceded
    // by a `require` statement. The exported symbol list is often dynamic
    // (e.g. `Foo->import(@names)`), so we emit `ImportSymbols::Dynamic`
    // conservatively.
    if let Some(spec) = try_classify_standalone_class_import(node, file_id) {
        out.push(spec);
    }

    // For statement-list containers, scan consecutive statements to detect
    // `require Module; Module->import(...)` pairs and standalone `require`s.
    match &node.kind {
        NodeKind::Program { statements } | NodeKind::Block { statements } => {
            walk_statements(statements, file_id, out);
        }
        NodeKind::Package { block: Some(block), .. } => {
            if let NodeKind::Block { statements } = &block.kind {
                walk_statements(statements, file_id, out);
            }
        }
        _ => {}
    }

    for child in node.children() {
        walk(child, file_id, out);
    }
}

// ── Standalone ClassName->import(@names) detection ──────────────────────────

fn try_classify_standalone_class_import(node: &Node, file_id: FileId) -> Option<ImportSpec> {
    let (object, method, args) = match &node.kind {
        NodeKind::MethodCall { object, method, args } => (object, method, args),
        _ => return None,
    };

    if method != "import" {
        return None;
    }

    // Only static class names (Identifier nodes), not variables.
    let class_name = match &object.kind {
        NodeKind::Identifier { name } => name.as_str(),
        _ => return None,
    };

    // Only emit when the argument list is dynamic — explicit lists are handled
    // precisely elsewhere (require+import pair or use statement).
    let symbols = extract_import_call_symbols(args);
    if !matches!(symbols, ImportSymbols::Dynamic) {
        return None;
    }

    let anchor_id = anchor_from_node(node);
    Some(ImportSpec {
        module: class_name.to_string(),
        // ManualImport distinguishes this from `use Foo` — it is a
        // `Class->import(...)` method call, not a `use` declaration.
        kind: ImportKind::ManualImport,
        symbols,
        provenance: Provenance::DynamicBoundary,
        confidence: Confidence::Low,
        file_id: Some(file_id),
        anchor_id: Some(anchor_id),
        scope_id: None,
        span_start_byte: Some(node.location.start as u32),
    })
}

// ── Statement-list scanner for require patterns ──────────────────────────────

fn walk_statements(statements: &[Node], file_id: FileId, out: &mut Vec<ImportSpec>) {
    let mut consumed: std::collections::HashSet<usize> = std::collections::HashSet::new();

    for (i, stmt) in statements.iter().enumerate() {
        if consumed.contains(&i) {
            continue;
        }

        let expr = unwrap_expression_statement(stmt);

        let (require_node, require_args) = match &expr.kind {
            NodeKind::FunctionCall { name, args } if name == "require" => (stmt, args),
            _ => continue,
        };

        // Dynamic require: `require $var`
        if is_dynamic_require(require_args) {
            out.push(make_dynamic_require(file_id, require_node));
            consumed.insert(i);
            continue;
        }

        // Static require: extract module name.
        let module_name = match extract_require_module_name(require_args) {
            Some(name) => name,
            None => continue,
        };

        // Look ahead for `Module->import(...)`.
        let import_spec = statements.get(i + 1).and_then(|next_stmt| {
            let next_expr = unwrap_expression_statement(next_stmt);
            try_match_import_call(next_expr, &module_name)
        });

        if let Some((symbols, _import_node)) = import_spec {
            let anchor_id = anchor_from_node(require_node);
            let confidence = confidence_for_symbols(&symbols);
            out.push(ImportSpec {
                module: module_name,
                kind: ImportKind::RequireThenImport,
                symbols,
                provenance: Provenance::ExactAst,
                confidence,
                file_id: Some(file_id),
                anchor_id: Some(anchor_id),
                scope_id: None,
                span_start_byte: Some(require_node.location.start as u32),
            });
            consumed.insert(i);
            consumed.insert(i + 1);
        } else {
            let anchor_id = anchor_from_node(require_node);
            out.push(ImportSpec {
                module: module_name,
                kind: ImportKind::Require,
                symbols: ImportSymbols::Default,
                provenance: Provenance::ExactAst,
                confidence: Confidence::High,
                file_id: Some(file_id),
                anchor_id: Some(anchor_id),
                scope_id: None,
                span_start_byte: Some(require_node.location.start as u32),
            });
            consumed.insert(i);
        }
    }
}

// ── require helpers ──────────────────────────────────────────────────────────

fn unwrap_expression_statement(node: &Node) -> &Node {
    match &node.kind {
        NodeKind::ExpressionStatement { expression } => expression,
        _ => node,
    }
}

fn is_dynamic_require(args: &[Node]) -> bool {
    matches!(args.first(), Some(arg) if matches!(&arg.kind, NodeKind::Variable { .. }))
}

fn extract_require_module_name(args: &[Node]) -> Option<String> {
    let arg = args.first()?;
    match &arg.kind {
        NodeKind::Identifier { name } => Some(name.clone()),
        NodeKind::String { value, .. } => {
            // "Foo/Bar.pm" → "Foo::Bar"
            let cleaned = value.trim_matches('\'').trim_matches('"').trim();
            let module = cleaned.trim_end_matches(".pm").replace('/', "::");
            Some(module)
        }
        _ => None,
    }
}

fn make_dynamic_require(file_id: FileId, node: &Node) -> ImportSpec {
    let anchor_id = anchor_from_node(node);
    ImportSpec {
        module: String::new(),
        kind: ImportKind::DynamicRequire,
        symbols: ImportSymbols::Dynamic,
        provenance: Provenance::DynamicBoundary,
        confidence: Confidence::Low,
        file_id: Some(file_id),
        anchor_id: Some(anchor_id),
        scope_id: None,
        span_start_byte: Some(node.location.start as u32),
    }
}

fn try_match_import_call<'a>(
    node: &'a Node,
    expected_module: &str,
) -> Option<(ImportSymbols, &'a Node)> {
    let (object, method, args) = match &node.kind {
        NodeKind::MethodCall { object, method, args } => (object, method, args),
        _ => return None,
    };

    if method != "import" {
        return None;
    }

    let obj_name = match &object.kind {
        NodeKind::Identifier { name } => name.as_str(),
        _ => return None,
    };

    if obj_name != expected_module {
        return None;
    }

    let symbols = extract_import_call_symbols(args);
    Some((symbols, node))
}

// ── Symbol extraction from import() argument lists ───────────────────────────

fn extract_import_call_symbols(args: &[Node]) -> ImportSymbols {
    if args.is_empty() {
        return ImportSymbols::Default;
    }

    let mut names: Vec<String> = Vec::new();
    let mut tags: Vec<String> = Vec::new();
    let mut has_dynamic_arg = false;

    for arg in args {
        has_dynamic_arg |= collect_import_arg_symbols(arg, &mut names, &mut tags);
    }

    if has_dynamic_arg {
        return ImportSymbols::Dynamic;
    }

    if names.is_empty() && tags.is_empty() {
        return ImportSymbols::Default;
    }

    if !tags.is_empty() && names.is_empty() {
        return ImportSymbols::Tags(tags);
    }

    if !tags.is_empty() && !names.is_empty() {
        return ImportSymbols::Mixed { tags, names };
    }

    ImportSymbols::Explicit(names)
}

/// Returns `true` when the argument is dynamic (prevents exact symbol list).
fn collect_import_arg_symbols(arg: &Node, names: &mut Vec<String>, tags: &mut Vec<String>) -> bool {
    match &arg.kind {
        NodeKind::String { value, .. } => {
            let bare = value.trim_matches('\'').trim_matches('"');
            if let Some(tag) = bare.strip_prefix(':') {
                tags.push(tag.to_string());
            } else if !bare.is_empty() {
                names.push(bare.to_string());
            }
            false
        }
        NodeKind::Identifier { name } => {
            if let Some(inner) = parse_qw_content(name) {
                for word in inner.split_whitespace() {
                    if let Some(tag) = word.strip_prefix(':') {
                        tags.push(tag.to_string());
                    } else {
                        names.push(word.to_string());
                    }
                }
            } else if let Some(tag) = name.strip_prefix(':') {
                tags.push(tag.to_string());
            } else if !name.is_empty() {
                names.push(name.clone());
            }
            false
        }
        NodeKind::Variable { .. } => true, // `Foo->import(@names)` → dynamic
        NodeKind::ArrayLiteral { elements } => {
            let mut has_dyn = false;
            for el in elements {
                has_dyn |= collect_import_arg_symbols(el, names, tags);
            }
            has_dyn
        }
        _ => true,
    }
}

// ── use-statement classification ─────────────────────────────────────────────

fn classify_use(module: &str, args: &[String], file_id: FileId, node: &Node) -> Option<ImportSpec> {
    if is_version_pragma(module) {
        return None;
    }

    let anchor_id = anchor_from_node(node);

    if module == "constant" {
        return Some(classify_use_constant(args, file_id, anchor_id));
    }

    let (kind, symbols) = classify_args(args, module, node);

    Some(ImportSpec {
        module: module.to_string(),
        kind,
        symbols,
        provenance: Provenance::ExactAst,
        confidence: Confidence::High,
        file_id: Some(file_id),
        anchor_id: Some(anchor_id),
        scope_id: None,
        span_start_byte: Some(node.location.start as u32),
    })
}

fn classify_args(args: &[String], module: &str, node: &Node) -> (ImportKind, ImportSymbols) {
    if args.is_empty() {
        let bare_len = "use ".len() + module.len() + 1; // +1 for ';'
        let span_len = node.location.end.saturating_sub(node.location.start);
        if span_len > bare_len {
            return (ImportKind::UseEmpty, ImportSymbols::None);
        }
        return (ImportKind::Use, ImportSymbols::Default);
    }

    let mut explicit_names: Vec<String> = Vec::new();
    let mut tags: Vec<String> = Vec::new();

    for arg in args {
        let trimmed = arg.trim();

        if let Some(inner) = parse_qw_content(trimmed) {
            for word in inner.split_whitespace() {
                if let Some(tag) = word.strip_prefix(':') {
                    tags.push(tag.to_string());
                } else {
                    explicit_names.push(word.to_string());
                }
            }
            continue;
        }

        let unquoted = unquote(trimmed);
        if let Some(tag) = unquoted.strip_prefix(':') {
            tags.push(tag.to_string());
            continue;
        }

        if trimmed == "=>" || trimmed == "," || trimmed == "\\" {
            continue;
        }

        if looks_like_symbol_name(trimmed) {
            explicit_names.push(unquote(trimmed).to_string());
        }
    }

    if explicit_names.is_empty() && tags.is_empty() && !args.is_empty() {
        let has_any_symbol = args.iter().any(|a| {
            let t = a.trim();
            looks_like_symbol_name(t) || parse_qw_content(t).is_some()
        });
        if !has_any_symbol {
            return (ImportKind::UseEmpty, ImportSymbols::None);
        }
    }

    if !tags.is_empty() && explicit_names.is_empty() {
        return (ImportKind::UseTag, ImportSymbols::Tags(tags));
    }

    if !tags.is_empty() && !explicit_names.is_empty() {
        return (ImportKind::UseExplicitList, ImportSymbols::Mixed { tags, names: explicit_names });
    }

    if !explicit_names.is_empty() {
        return (ImportKind::UseExplicitList, ImportSymbols::Explicit(explicit_names));
    }

    (ImportKind::Use, ImportSymbols::Default)
}

fn classify_use_constant(args: &[String], file_id: FileId, anchor_id: AnchorId) -> ImportSpec {
    let mut constant_names: Vec<String> = Vec::new();

    if args.is_empty() {
        return ImportSpec {
            module: "constant".to_string(),
            kind: ImportKind::UseConstant,
            symbols: ImportSymbols::None,
            provenance: Provenance::ExactAst,
            confidence: Confidence::High,
            file_id: Some(file_id),
            anchor_id: Some(anchor_id),
            scope_id: None,
            span_start_byte: None,
        };
    }

    if args.first().map(|a| a.as_str()) == Some("{") {
        let mut i = 1;
        while i < args.len() {
            let token = args[i].trim();
            if token == "}" || token == "=>" || token == "," {
                i += 1;
                continue;
            }
            if i + 1 < args.len() && args[i + 1].trim() == "=>" {
                constant_names.push(token.to_string());
                i += 3;
            } else {
                i += 1;
            }
        }
    } else if let Some(inner) = args.first().and_then(|a| parse_qw_content(a.trim())) {
        constant_names.extend(inner.split_whitespace().map(|w| w.to_string()));
    } else if let Some(name) = args.first() {
        let trimmed = name.trim();
        if looks_like_constant_name(trimmed) {
            constant_names.push(trimmed.to_string());
        }
    }

    let mut seen = std::collections::HashSet::new();
    constant_names.retain(|n| seen.insert(n.clone()));

    let symbols = if constant_names.is_empty() {
        ImportSymbols::None
    } else {
        ImportSymbols::Explicit(constant_names)
    };

    ImportSpec {
        module: "constant".to_string(),
        kind: ImportKind::UseConstant,
        symbols,
        provenance: Provenance::ExactAst,
        confidence: Confidence::High,
        file_id: Some(file_id),
        anchor_id: Some(anchor_id),
        scope_id: None,
        span_start_byte: None,
    }
}

// ── Utility helpers ──────────────────────────────────────────────────────────

fn anchor_from_node(node: &Node) -> AnchorId {
    AnchorId(node.location.start as u64)
}

fn is_version_pragma(module: &str) -> bool {
    if module.chars().next().is_some_and(|c| c.is_ascii_digit()) {
        return true;
    }
    if module.starts_with('v')
        && module.len() > 1
        && module[1..].chars().all(|c| c.is_ascii_digit() || c == '.')
    {
        return true;
    }
    false
}

fn parse_qw_content(s: &str) -> Option<&str> {
    let rest = s.strip_prefix("qw")?;
    let inner = rest.strip_prefix('(')?.strip_suffix(')')?;
    Some(inner)
}

fn unquote(s: &str) -> &str {
    if (s.starts_with('\'') && s.ends_with('\'')) || (s.starts_with('"') && s.ends_with('"')) {
        if s.len() >= 2 {
            return &s[1..s.len() - 1];
        }
    }
    s
}

fn looks_like_symbol_name(s: &str) -> bool {
    let s = unquote(s);
    if s.is_empty() {
        return false;
    }
    if s.starts_with(':') {
        return true;
    }
    if s.starts_with('$')
        || s.starts_with('@')
        || s.starts_with('%')
        || s.starts_with('&')
        || s.starts_with('*')
    {
        return true;
    }
    s.chars().next().is_some_and(|c| c.is_ascii_alphabetic() || c == '_')
}

fn looks_like_constant_name(s: &str) -> bool {
    if s.is_empty() {
        return false;
    }
    s.chars().next().is_some_and(|c| c.is_ascii_alphabetic() || c == '_')
}

fn confidence_for_symbols(symbols: &ImportSymbols) -> Confidence {
    if matches!(symbols, ImportSymbols::Dynamic) { Confidence::Low } else { Confidence::High }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::Parser;

    fn parse_and_extract(code: &str) -> Vec<ImportSpec> {
        let mut parser = Parser::new(code);
        let ast = match parser.parse() {
            Ok(a) => a,
            Err(_) => return Vec::new(),
        };
        extract_import_specs(&ast, FileId(1))
    }

    #[test]
    fn use_bare_module_produces_use_default() -> Result<(), Box<dyn std::error::Error>> {
        let specs = parse_and_extract("use strict;");
        let spec = specs.first().ok_or("expected ImportSpec")?;
        assert_eq!(spec.module, "strict");
        assert_eq!(spec.kind, ImportKind::Use);
        assert_eq!(spec.symbols, ImportSymbols::Default);
        Ok(())
    }

    #[test]
    fn use_explicit_list_qw() -> Result<(), Box<dyn std::error::Error>> {
        let specs = parse_and_extract("use List::Util qw(first any);");
        let spec = specs.first().ok_or("expected ImportSpec")?;
        assert_eq!(spec.module, "List::Util");
        assert_eq!(spec.kind, ImportKind::UseExplicitList);
        if let ImportSymbols::Explicit(names) = &spec.symbols {
            assert!(names.contains(&"first".to_string()));
            assert!(names.contains(&"any".to_string()));
        } else {
            return Err(format!("expected Explicit, got {:?}", spec.symbols).into());
        }
        Ok(())
    }

    #[test]
    fn version_pragma_skipped() -> Result<(), Box<dyn std::error::Error>> {
        let specs = parse_and_extract("use 5.036;");
        assert!(specs.is_empty(), "version pragma must not produce ImportSpec");
        Ok(())
    }

    #[test]
    fn standalone_class_dynamic_import_produces_manual_import()
    -> Result<(), Box<dyn std::error::Error>> {
        let specs = parse_and_extract("Foo->import(@names);");
        let spec = specs
            .iter()
            .find(|s| s.module == "Foo" && matches!(s.symbols, ImportSymbols::Dynamic))
            .ok_or("expected Dynamic ImportSpec for Foo")?;
        assert_eq!(spec.kind, ImportKind::ManualImport);
        assert_eq!(spec.provenance, Provenance::DynamicBoundary);
        assert_eq!(spec.confidence, Confidence::Low);
        Ok(())
    }

    #[test]
    fn require_then_import_pair_produces_require_then_import()
    -> Result<(), Box<dyn std::error::Error>> {
        let code = "require Foo::Bar;\nFoo::Bar->import(qw(alpha beta));";
        let specs = parse_and_extract(code);
        let spec =
            specs.iter().find(|s| s.module == "Foo::Bar").ok_or("expected Foo::Bar ImportSpec")?;
        assert_eq!(spec.kind, ImportKind::RequireThenImport);
        if let ImportSymbols::Explicit(names) = &spec.symbols {
            assert!(names.contains(&"alpha".to_string()));
            assert!(names.contains(&"beta".to_string()));
        } else {
            return Err(format!("expected Explicit, got {:?}", spec.symbols).into());
        }
        Ok(())
    }

    #[test]
    fn require_dynamic_variable_produces_dynamic_require() -> Result<(), Box<dyn std::error::Error>>
    {
        let specs = parse_and_extract("require $mod;");
        let spec = specs
            .iter()
            .find(|s| s.kind == ImportKind::DynamicRequire)
            .ok_or("expected DynamicRequire ImportSpec")?;
        assert_eq!(spec.symbols, ImportSymbols::Dynamic);
        assert_eq!(spec.provenance, Provenance::DynamicBoundary);
        Ok(())
    }

    #[test]
    fn span_start_byte_is_populated_for_use() -> Result<(), Box<dyn std::error::Error>> {
        let specs = parse_and_extract("use Foo;");
        let spec = specs.first().ok_or("expected ImportSpec")?;
        assert!(spec.span_start_byte.is_some(), "span_start_byte must be set for use statements");
        Ok(())
    }

    #[test]
    fn standalone_explicit_class_import_not_emitted_as_dynamic()
    -> Result<(), Box<dyn std::error::Error>> {
        // `Foo->import('bar')` — static arg list should NOT produce a Dynamic spec.
        let specs = parse_and_extract("Foo->import('bar');");
        let dynamic_specs: Vec<_> =
            specs.iter().filter(|s| matches!(s.symbols, ImportSymbols::Dynamic)).collect();
        assert!(
            dynamic_specs.is_empty(),
            "explicit import args must not produce a Dynamic spec, got: {dynamic_specs:#?}"
        );
        Ok(())
    }
}