perl-symbol 0.17.0

Unified Perl symbol taxonomy, cursor extraction, indexing, and AST surface projection
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
use crate::surface::decl::SymbolDecl;
use crate::surface::r#ref::{SymbolRef, SymbolRefKind};
use crate::types::SymbolKind;
use perl_semantic_facts::{
    AnchorFact, AnchorId, Confidence, EdgeFact, EdgeId, EdgeKind, EntityFact, EntityId, EntityKind,
    FileId, OccurrenceFact, OccurrenceId, OccurrenceKind, Provenance,
};
use serde::Serialize;
use std::collections::BTreeMap;

/// Declaration that the adapter could not project into an [`EntityFact`].
///
/// Emitted when a symbol kind has no [`EntityKind`] mapping yet, or when a
/// declared container is missing from the input set so the `Defines` edge
/// cannot be resolved.
#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
pub struct UnsupportedDeclFact {
    /// Fully-qualified name of the declaration that was skipped.
    pub qualified_name: String,
    /// Original [`SymbolKind`] reported by the surface extractor.
    pub kind: SymbolKind,
    /// Human-readable reason the declaration was not projected.
    pub reason: &'static str,
}

/// Output of [`symbol_decls_to_semantic_facts`]: the semantic-facts projection
/// of a set of [`SymbolDecl`]s for one file.
#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
pub struct SymbolDeclSemanticFacts {
    /// Source-span anchors, one per projected declaration.
    pub anchors: Vec<AnchorFact>,
    /// Entity records produced from supported declaration kinds.
    pub entities: Vec<EntityFact>,
    /// `Defines` edges connecting containers to the entities they declare.
    pub defines_edges: Vec<EdgeFact>,
    /// Declarations skipped because they could not be projected (see [`UnsupportedDeclFact`]).
    pub unsupported: Vec<UnsupportedDeclFact>,
}

/// Output of [`symbol_refs_to_semantic_facts`]: occurrences and reference edges
/// derived from [`SymbolRef`]s for one file.
#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
pub struct SymbolRefSemanticFacts {
    /// Source-span anchors, one per reference.
    pub anchors: Vec<AnchorFact>,
    /// Occurrence records (read / call / method-call / etc.) for each reference.
    pub occurrences: Vec<OccurrenceFact>,
    /// `References` edges, emitted only when the reference resolves to a known entity.
    pub reference_edges: Vec<EdgeFact>,
}

/// Convert extracted [`SymbolRef`]s into the semantic-facts graph for `file_id`.
///
/// `entity_ids_by_qualified_name` provides entity IDs already minted for
/// declarations in this or other files; unresolved references produce
/// occurrences without `entity_id` and emit no reference edge.
pub fn symbol_refs_to_semantic_facts(
    refs: &[SymbolRef],
    file_id: FileId,
    entity_ids_by_qualified_name: &BTreeMap<String, EntityId>,
) -> SymbolRefSemanticFacts {
    let mut anchors = Vec::with_capacity(refs.len());
    let mut occurrences = Vec::with_capacity(refs.len());
    let mut reference_edges = Vec::new();

    for symbol_ref in refs {
        let occurrence_kind = occurrence_kind(&symbol_ref.kind);
        let provenance = occurrence_provenance(&symbol_ref.kind);
        let confidence = occurrence_confidence(&symbol_ref.kind);
        let anchor_span = symbol_ref.anchor_span.unwrap_or(symbol_ref.full_span);
        let anchor_id = AnchorId(stable_id(
            "ref-anchor",
            &symbol_ref.qualified_name,
            anchor_span.0,
            anchor_span.1,
            file_id,
        ));
        anchors.push(AnchorFact {
            id: anchor_id,
            file_id,
            span_start_byte: anchor_span.0 as u32,
            span_end_byte: anchor_span.1 as u32,
            scope_id: None,
            provenance,
            confidence,
        });

        let entity_id = entity_ids_by_qualified_name.get(&symbol_ref.qualified_name).copied();
        let occurrence_id = OccurrenceId(stable_id(
            "occurrence",
            &symbol_ref.qualified_name,
            symbol_ref.full_span.0,
            symbol_ref.full_span.1,
            file_id,
        ));
        occurrences.push(OccurrenceFact {
            id: occurrence_id,
            kind: occurrence_kind,
            entity_id,
            anchor_id,
            scope_id: None,
            provenance,
            confidence,
        });

        if let Some(to_entity_id) = entity_id {
            let from_entity_id =
                // IMPORTANT: file-neutral sentinel (FileId(0)) — this synthetic "ref-source"
                // entity acts as the "from" node for cross-file References edges and must
                // resolve to the same ID regardless of which file the reference appears in.
                // Do NOT change this to use `file_id`. See plan-review Risk 1 in #1600.
                EntityId(stable_id("ref-source", &symbol_ref.qualified_name, 0, 0, FileId(0)));
            reference_edges.push(EdgeFact {
                id: EdgeId(stable_id(
                    "references",
                    &symbol_ref.qualified_name,
                    from_entity_id.0 as usize,
                    to_entity_id.0 as usize,
                    file_id,
                )),
                kind: EdgeKind::References,
                from_entity_id,
                to_entity_id,
                via_occurrence_id: Some(occurrence_id),
                provenance: Provenance::NameHeuristic,
                confidence: Confidence::Low,
            });
        }
    }

    SymbolRefSemanticFacts { anchors, occurrences, reference_edges }
}

fn occurrence_kind(kind: &SymbolRefKind) -> OccurrenceKind {
    match kind {
        SymbolRefKind::Variable(_) => OccurrenceKind::Read,
        SymbolRefKind::SubroutineCall => OccurrenceKind::Call,
        SymbolRefKind::MethodCall => OccurrenceKind::MethodCall,
        SymbolRefKind::StaticMethodCall => OccurrenceKind::StaticMethodCall,
        SymbolRefKind::CoderefReference => OccurrenceKind::CoderefReference,
        SymbolRefKind::TypeglobReference => OccurrenceKind::TypeglobReference,
    }
}

fn occurrence_provenance(kind: &SymbolRefKind) -> Provenance {
    match kind {
        SymbolRefKind::TypeglobReference => Provenance::DynamicBoundary,
        _ => Provenance::ExactAst,
    }
}

fn occurrence_confidence(kind: &SymbolRefKind) -> Confidence {
    match kind {
        SymbolRefKind::MethodCall => Confidence::Medium,
        SymbolRefKind::TypeglobReference => Confidence::Low,
        _ => Confidence::High,
    }
}

/// Convert extracted [`SymbolDecl`]s into the semantic-facts graph for `file_id`.
///
/// Unsupported kinds and unresolved containers are reported via the
/// `unsupported` field on the returned [`SymbolDeclSemanticFacts`] rather than
/// silently dropped, so callers can diagnose missing coverage.
pub fn symbol_decls_to_semantic_facts(
    decls: &[SymbolDecl],
    file_id: FileId,
) -> SymbolDeclSemanticFacts {
    let mut anchors = Vec::with_capacity(decls.len());
    let mut entities = Vec::with_capacity(decls.len());
    let mut unsupported = Vec::new();

    let mut entity_by_name = BTreeMap::new();
    for decl in decls {
        let entity_kind = match symbol_kind_to_entity_kind(decl.kind) {
            Some(kind) => kind,
            None => {
                unsupported.push(UnsupportedDeclFact {
                    qualified_name: decl.qualified_name.clone(),
                    kind: decl.kind,
                    reason: "symbol kind is not yet representable as EntityFact",
                });
                continue;
            }
        };

        let anchor_span = decl.anchor_span.unwrap_or(decl.full_span);
        let anchor_id = AnchorId(stable_id(
            "anchor",
            &decl.qualified_name,
            anchor_span.0,
            anchor_span.1,
            file_id,
        ));
        anchors.push(AnchorFact {
            id: anchor_id,
            file_id,
            span_start_byte: anchor_span.0 as u32,
            span_end_byte: anchor_span.1 as u32,
            scope_id: None,
            provenance: Provenance::ExactAst,
            confidence: Confidence::High,
        });

        let entity_id = EntityId(stable_id(
            "entity",
            &decl.qualified_name,
            decl.full_span.0,
            decl.full_span.1,
            file_id,
        ));
        entity_by_name.insert(decl.qualified_name.clone(), entity_id);
        entities.push(EntityFact {
            id: entity_id,
            kind: entity_kind,
            canonical_name: decl.qualified_name.clone(),
            anchor_id: Some(anchor_id),
            scope_id: None,
            provenance: Provenance::ExactAst,
            confidence: Confidence::High,
        });
    }

    let mut defines_edges = Vec::new();
    for decl in decls {
        let Some(to_entity_id) = entity_by_name.get(&decl.qualified_name).copied() else {
            continue;
        };

        let Some(container) = &decl.container else {
            continue;
        };

        // Resolve the from-entity for this Defines edge.
        //
        // `container` is the *bare* enclosing package name (e.g. "Bar").
        // `qualified_name` may be multi-level (e.g. "Foo::Bar::baz"), so we
        // strip the last segment to obtain the qualified prefix ("Foo::Bar")
        // and use that as the lookup key when it is a proper segment-boundary
        // match for `container`.
        //
        // The check must be a *segment-boundary* match, not a raw byte-suffix
        // match: "FooBar".ends_with("Bar") is true but "FooBar" != "Bar" and
        // is not a qualified suffix "::Bar".
        let from_candidate = if let Some((prefix, _)) = decl.qualified_name.rsplit_once("::") {
            let is_segment_match =
                prefix == container.as_str() || prefix.ends_with(&format!("::{container}"));
            if is_segment_match { prefix.to_string() } else { container.clone() }
        } else {
            container.clone()
        };

        let Some(from_entity_id) = entity_by_name.get(&from_candidate).copied() else {
            unsupported.push(UnsupportedDeclFact {
                qualified_name: decl.qualified_name.clone(),
                kind: decl.kind,
                reason: "container declaration not present; Defines edge omitted",
            });
            continue;
        };

        let edge_id = EdgeId(stable_id(
            "defines",
            &decl.qualified_name,
            from_entity_id.0 as usize,
            to_entity_id.0 as usize,
            file_id,
        ));
        defines_edges.push(EdgeFact {
            id: edge_id,
            kind: EdgeKind::Defines,
            from_entity_id,
            to_entity_id,
            via_occurrence_id: None,
            provenance: Provenance::ExactAst,
            confidence: Confidence::High,
        });
    }

    SymbolDeclSemanticFacts { anchors, entities, defines_edges, unsupported }
}

fn symbol_kind_to_entity_kind(kind: SymbolKind) -> Option<EntityKind> {
    match kind {
        SymbolKind::Package => Some(EntityKind::Package),
        SymbolKind::Class => Some(EntityKind::Class),
        SymbolKind::Subroutine => Some(EntityKind::Subroutine),
        SymbolKind::Method => Some(EntityKind::Method),
        SymbolKind::Variable(_) => Some(EntityKind::Variable),
        SymbolKind::Constant => Some(EntityKind::Constant),
        SymbolKind::Label => Some(EntityKind::Label),
        SymbolKind::Format => Some(EntityKind::Format),
        SymbolKind::Role | SymbolKind::Import | SymbolKind::Export => None,
    }
}

/// Compute a file-scoped stable ID by hashing namespace, name, span, and
/// the [`FileId`] of the containing file.
///
/// Including `file_id` in the hash ensures that two files with identical
/// content and byte offsets produce distinct IDs for the same qualified name,
/// preventing collision in multi-root workspaces.
///
/// **Exception — file-neutral pointers**: callers that need a cross-file
/// stable ID (e.g. the synthetic `ref-source` entity that acts as the
/// "from" node for a `References` edge) should pass `FileId(0)` as a
/// sentinel so that all files agree on the same entity ID for the same
/// qualified name.
fn stable_id(namespace: &str, name: &str, start: usize, end: usize, file_id: FileId) -> u64 {
    let mut hash = 14695981039346656037u64;
    for byte in namespace
        .as_bytes()
        .iter()
        .chain([0xff].iter())
        .chain(name.as_bytes().iter())
        .chain([0xff].iter())
        .chain(start.to_le_bytes().iter())
        .chain(end.to_le_bytes().iter())
        .chain([0xff].iter())
        .chain(file_id.0.to_le_bytes().iter())
    {
        hash ^= u64::from(*byte);
        hash = hash.wrapping_mul(1099511628211);
    }
    hash
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::types::VarKind;
    use perl_tdd_support::must_some;

    #[test]
    fn adapter_is_deterministic_for_mixed_decls() {
        let decls = vec![
            SymbolDecl {
                kind: SymbolKind::Package,
                name: "Foo".to_string(),
                qualified_name: "Foo".to_string(),
                full_span: (0, 20),
                anchor_span: Some((8, 11)),
                container: None,
                declarator: None,
            },
            SymbolDecl {
                kind: SymbolKind::Subroutine,
                name: "run".to_string(),
                qualified_name: "Foo::run".to_string(),
                full_span: (21, 50),
                anchor_span: Some((25, 28)),
                container: Some("Foo".to_string()),
                declarator: None,
            },
            SymbolDecl {
                kind: SymbolKind::Variable(VarKind::Scalar),
                name: "value".to_string(),
                qualified_name: "Foo::value".to_string(),
                full_span: (51, 70),
                anchor_span: Some((54, 60)),
                container: Some("Foo".to_string()),
                declarator: Some("our".to_string()),
            },
            SymbolDecl {
                kind: SymbolKind::Label,
                name: "LOOP".to_string(),
                qualified_name: "LOOP".to_string(),
                full_span: (71, 95),
                anchor_span: None,
                container: Some("Foo".to_string()),
                declarator: None,
            },
        ];

        let actual = symbol_decls_to_semantic_facts(&decls, FileId(9));
        let again = symbol_decls_to_semantic_facts(&decls, FileId(9));
        assert_eq!(actual, again);
        assert_eq!(actual.anchors.len(), 4);
        assert_eq!(actual.entities.len(), 4);
        assert_eq!(actual.defines_edges.len(), 3);
        assert!(actual.unsupported.is_empty());
    }

    /// Regression test: container name that is a byte-suffix of a sibling
    /// package name must NOT produce a wrong Defines edge.
    ///
    /// Before the fix, `prefix.ends_with(container)` matched "FooBar" against
    /// container "Bar" and resolved to the wrong entity "FooBar" instead of
    /// falling back to the bare container name "Bar".
    #[test]
    fn container_resolution_uses_segment_boundary_not_byte_suffix() {
        // "FooBar" is a top-level package.
        // "FooBar::baz" has container "Bar" — unusual but representable
        // (imagine `package Bar { }` block inside a FooBar file context).
        // The correct from-entity key is "Bar", not "FooBar".
        let decls = vec![
            SymbolDecl {
                kind: SymbolKind::Package,
                name: "FooBar".to_string(),
                qualified_name: "FooBar".to_string(),
                full_span: (0, 10),
                anchor_span: None,
                container: None,
                declarator: None,
            },
            SymbolDecl {
                kind: SymbolKind::Package,
                name: "Bar".to_string(),
                qualified_name: "Bar".to_string(),
                full_span: (11, 20),
                anchor_span: None,
                container: None,
                declarator: None,
            },
            SymbolDecl {
                kind: SymbolKind::Subroutine,
                name: "baz".to_string(),
                qualified_name: "FooBar::baz".to_string(),
                full_span: (21, 40),
                anchor_span: Some((25, 28)),
                // container is "Bar" (bare), not "FooBar"
                container: Some("Bar".to_string()),
                declarator: None,
            },
        ];

        let facts = symbol_decls_to_semantic_facts(&decls, FileId(42));
        // "Bar" is present in entity_by_name, so the edge should resolve to Bar.
        // "FooBar" would be a wrong resolution.
        assert_eq!(facts.defines_edges.len(), 1, "should have exactly one Defines edge");
        let edge = &facts.defines_edges[0];
        let bar_entity = must_some(facts.entities.iter().find(|e| e.canonical_name == "Bar"));
        assert_eq!(
            edge.from_entity_id, bar_entity.id,
            "Defines edge must point FROM Bar (not FooBar)"
        );
        let baz_entity =
            must_some(facts.entities.iter().find(|e| e.canonical_name == "FooBar::baz"));
        assert_eq!(edge.to_entity_id, baz_entity.id, "Defines edge must point TO FooBar::baz");
        // No false unsupported reports — "Bar" container was found.
        assert!(
            facts.unsupported.is_empty(),
            "unsupported should be empty; got: {:?}",
            facts.unsupported
        );
    }

    /// When a decl's container is not itself present as a declaration, the
    /// adapter must emit an `UnsupportedDeclFact` explaining the missing edge
    /// rather than silently dropping the Defines record.
    #[test]
    fn missing_container_produces_unsupported_entry() {
        let decls = vec![SymbolDecl {
            kind: SymbolKind::Subroutine,
            name: "orphan".to_string(),
            qualified_name: "Missing::orphan".to_string(),
            full_span: (0, 30),
            anchor_span: Some((10, 16)),
            container: Some("Missing".to_string()),
            declarator: None,
        }];

        let facts = symbol_decls_to_semantic_facts(&decls, FileId(3));
        assert_eq!(facts.entities.len(), 1, "entity is still emitted");
        assert_eq!(facts.defines_edges.len(), 0, "no edge without container entity");
        assert_eq!(facts.unsupported.len(), 1, "one unsupported entry for missing container");
        assert_eq!(
            facts.unsupported[0].reason,
            "container declaration not present; Defines edge omitted",
        );
        assert_eq!(facts.unsupported[0].qualified_name, "Missing::orphan");
    }

    /// Deeply nested qualified names must resolve the container using a full
    /// segment-boundary match, not just the last segment.
    ///
    /// "A::B::C::D" with container "C" should produce a Defines edge
    /// FROM "A::B::C" (the qualified prefix that ends_with "::C") TO "A::B::C::D".
    #[test]
    fn deeply_nested_qualified_name_resolves_correct_container() {
        let decls = vec![
            SymbolDecl {
                kind: SymbolKind::Package,
                name: "A".to_string(),
                qualified_name: "A".to_string(),
                full_span: (0, 5),
                anchor_span: None,
                container: None,
                declarator: None,
            },
            SymbolDecl {
                kind: SymbolKind::Package,
                name: "B".to_string(),
                qualified_name: "A::B".to_string(),
                full_span: (6, 15),
                anchor_span: None,
                container: Some("A".to_string()),
                declarator: None,
            },
            SymbolDecl {
                kind: SymbolKind::Package,
                name: "C".to_string(),
                qualified_name: "A::B::C".to_string(),
                full_span: (16, 30),
                anchor_span: None,
                container: Some("B".to_string()),
                declarator: None,
            },
            SymbolDecl {
                kind: SymbolKind::Subroutine,
                name: "D".to_string(),
                qualified_name: "A::B::C::D".to_string(),
                full_span: (31, 55),
                anchor_span: Some((35, 36)),
                container: Some("C".to_string()),
                declarator: None,
            },
        ];

        let facts = symbol_decls_to_semantic_facts(&decls, FileId(5));
        assert_eq!(facts.entities.len(), 4);
        // A has no container -> no edge
        // A::B has container "A" -> edge A -> A::B
        // A::B::C has container "B" -> prefix "A::B", ends_with("::B") -> edge A::B -> A::B::C
        // A::B::C::D has container "C" -> prefix "A::B::C", ends_with("::C") -> edge A::B::C -> A::B::C::D
        assert_eq!(facts.defines_edges.len(), 3, "should have 3 Defines edges");
        assert!(facts.unsupported.is_empty(), "no unsupported entries");

        let c_entity = must_some(facts.entities.iter().find(|e| e.canonical_name == "A::B::C"));
        let d_entity = must_some(facts.entities.iter().find(|e| e.canonical_name == "A::B::C::D"));
        let d_edge = must_some(facts.defines_edges.iter().find(|e| e.to_entity_id == d_entity.id));
        assert_eq!(
            d_edge.from_entity_id, c_entity.id,
            "Defines edge for A::B::C::D must come FROM A::B::C"
        );
    }

    #[test]
    fn unsupported_kinds_are_reported_explicitly() {
        let decls = vec![SymbolDecl {
            kind: SymbolKind::Role,
            name: "MyRole".to_string(),
            qualified_name: "MyRole".to_string(),
            full_span: (0, 10),
            anchor_span: Some((5, 10)),
            container: None,
            declarator: None,
        }];

        let facts = symbol_decls_to_semantic_facts(&decls, FileId(1));
        assert!(facts.anchors.is_empty());
        assert!(facts.entities.is_empty());
        assert!(facts.defines_edges.is_empty());
        assert_eq!(facts.unsupported.len(), 1);
        assert_eq!(
            facts.unsupported[0].reason,
            "symbol kind is not yet representable as EntityFact"
        );
    }

    #[test]
    fn symbol_ref_adapter_emits_occurrences_and_optional_reference_edges() {
        use crate::types::VarKind;

        let refs = vec![
            SymbolRef {
                kind: SymbolRefKind::SubroutineCall,
                name: "run".to_string(),
                qualified_name: "Foo::run".to_string(),
                sigil: None,
                package_qualifier: Some("Foo".to_string()),
                full_span: (10, 20),
                anchor_span: Some((12, 15)),
            },
            SymbolRef {
                kind: SymbolRefKind::Variable(VarKind::Scalar),
                name: "x".to_string(),
                qualified_name: "x".to_string(),
                sigil: Some("$".to_string()),
                package_qualifier: None,
                full_span: (21, 23),
                anchor_span: None,
            },
            SymbolRef {
                kind: SymbolRefKind::StaticMethodCall,
                name: "new".to_string(),
                qualified_name: "Foo::new".to_string(),
                sigil: None,
                package_qualifier: Some("Foo".to_string()),
                full_span: (24, 32),
                anchor_span: None,
            },
            SymbolRef {
                kind: SymbolRefKind::MethodCall,
                name: "save".to_string(),
                qualified_name: "save".to_string(),
                sigil: None,
                package_qualifier: None,
                full_span: (33, 45),
                anchor_span: None,
            },
            SymbolRef {
                kind: SymbolRefKind::CoderefReference,
                name: "callback".to_string(),
                qualified_name: "Foo::callback".to_string(),
                sigil: Some("&".to_string()),
                package_qualifier: Some("Foo".to_string()),
                full_span: (46, 59),
                anchor_span: Some((47, 59)),
            },
            SymbolRef {
                kind: SymbolRefKind::TypeglobReference,
                name: "alias".to_string(),
                qualified_name: "alias".to_string(),
                sigil: Some("*".to_string()),
                package_qualifier: None,
                full_span: (60, 66),
                anchor_span: None,
            },
        ];
        let mut entity_map = BTreeMap::new();
        entity_map.insert("Foo::run".to_string(), EntityId(42));
        entity_map.insert("Foo::new".to_string(), EntityId(43));
        entity_map.insert("Foo::callback".to_string(), EntityId(44));

        let facts = symbol_refs_to_semantic_facts(&refs, FileId(7), &entity_map);
        assert_eq!(facts.anchors.len(), 6);
        assert_eq!(facts.occurrences.len(), 6);
        assert_eq!(facts.reference_edges.len(), 3);
        assert_eq!(facts.occurrences[0].kind, OccurrenceKind::Call);
        assert_eq!(facts.occurrences[1].kind, OccurrenceKind::Read);
        assert_eq!(facts.occurrences[2].kind, OccurrenceKind::StaticMethodCall);
        assert_eq!(facts.occurrences[3].kind, OccurrenceKind::MethodCall);
        assert_eq!(facts.occurrences[4].kind, OccurrenceKind::CoderefReference);
        assert_eq!(facts.occurrences[5].kind, OccurrenceKind::TypeglobReference);
        assert_eq!(facts.occurrences[0].entity_id, Some(EntityId(42)));
        assert_eq!(facts.occurrences[1].entity_id, None);
        assert_eq!(facts.occurrences[2].entity_id, Some(EntityId(43)));
        assert_eq!(facts.occurrences[3].entity_id, None);
        assert_eq!(facts.occurrences[4].entity_id, Some(EntityId(44)));
        assert_eq!(facts.occurrences[5].entity_id, None);
        assert_eq!(facts.occurrences[2].confidence, Confidence::High);
        assert_eq!(facts.occurrences[3].confidence, Confidence::Medium);
        assert_eq!(facts.occurrences[4].confidence, Confidence::High);
        assert_eq!(facts.occurrences[5].confidence, Confidence::Low);
        assert_eq!(facts.occurrences[5].provenance, Provenance::DynamicBoundary);
    }

    /// Test: Entity ID file ID is recoverable via the anchor fact.
    /// After file-scoped identity fix, entity.anchor_id points to an AnchorFact that
    /// carries the file_id. This test verifies that file ID can be recovered by
    /// following the entity → anchor → file_id chain. (#1600)
    #[test]
    fn entity_id_file_id_recoverable_via_anchor() {
        let test_file_id = FileId(555);
        let decls = vec![
            SymbolDecl {
                kind: SymbolKind::Package,
                name: "TestPkg".to_string(),
                qualified_name: "TestPkg".to_string(),
                full_span: (0, 20),
                anchor_span: Some((8, 15)),
                container: None,
                declarator: None,
            },
            SymbolDecl {
                kind: SymbolKind::Subroutine,
                name: "helper".to_string(),
                qualified_name: "TestPkg::helper".to_string(),
                full_span: (21, 50),
                anchor_span: Some((25, 31)),
                container: Some("TestPkg".to_string()),
                declarator: None,
            },
        ];

        // Invoke the adapter with a specific file_id.
        let facts = symbol_decls_to_semantic_facts(&decls, test_file_id);

        // Verify we have entities and anchors.
        assert!(!facts.entities.is_empty(), "facts should have entities");
        assert!(!facts.anchors.is_empty(), "facts should have anchors");

        // For each entity with an anchor, verify that the anchor carries the correct file_id.
        for entity in &facts.entities {
            if let Some(anchor_id) = entity.anchor_id {
                let matching_anchor = facts
                    .anchors
                    .iter()
                    .find(|anchor| anchor.id == anchor_id)
                    .expect("entity's anchor_id must match an anchor in facts");

                // Key assertion: the anchor's file_id must match the file_id passed in.
                assert_eq!(
                    matching_anchor.file_id, test_file_id,
                    "anchor's file_id must match the input file_id"
                );
            }
        }
    }
}