perl-semantic-analyzer 0.13.3

Semantic analysis and symbol extraction for Perl
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
//! Package graph edge extraction from Perl inheritance and role-composition patterns.
//!
//! Walks the AST to extract [`PackageEdge`] entries that describe inheritance,
//! role composition, and dependency relationships between Perl packages.
//!
//! # Supported Patterns
//!
//! | Perl source                              | `PackageEdgeKind`     |
//! |------------------------------------------|-----------------------|
//! | `use parent 'Base'`                      | `Inherits`            |
//! | `use parent qw(Base1 Base2)`             | `Inherits`            |
//! | `use base 'Base'`                        | `Inherits`            |
//! | `use base qw(Base1 Base2)`               | `Inherits`            |
//! | `@ISA = ('Base')`                        | `Inherits`            |
//! | `our @ISA = qw(Base1 Base2)`             | `Inherits`            |
//! | `push @ISA, 'Base'`                      | `Inherits`            |
//! | `extends 'Base'` (Moo/Moose)             | `Inherits`            |
//! | `with 'Role'` (Moo/Moose)               | `ComposesRole`        |

use crate::ast::{Node, NodeKind};
use perl_semantic_facts::{AnchorId, Confidence, FileId, PackageEdge, PackageEdgeKind, Provenance};

/// Extractor that walks an AST to produce [`PackageEdge`] entries for each
/// inheritance, role-composition, or dependency relationship found.
pub struct PackageGraphExtractor;

impl PackageGraphExtractor {
    /// Walk the entire AST and return one [`PackageEdge`] per detected
    /// inheritance or role-composition relationship.
    ///
    /// Each edge carries the supplied `file_id` and an `anchor_id` derived
    /// from the statement's byte-offset span.
    pub fn extract(ast: &Node, _file_id: FileId) -> Vec<PackageEdge> {
        let mut state = ExtractorState { current_package: "main".to_string(), edges: Vec::new() };
        state.walk(ast);
        state.edges
    }
}

/// Internal state for the recursive AST walk.
struct ExtractorState {
    /// Current package context (updated when `package Foo;` is encountered).
    current_package: String,
    /// Accumulated edges.
    edges: Vec<PackageEdge>,
}

impl ExtractorState {
    /// Recursive AST walker.
    fn walk(&mut self, node: &Node) {
        match &node.kind {
            // For statement containers (Program, Block), walk statements in order
            // so that `package Foo;` (semicolon form) updates the current package
            // for subsequent sibling statements.
            NodeKind::Program { statements } | NodeKind::Block { statements } => {
                for stmt in statements {
                    self.walk(stmt);
                }
                return;
            }

            // `package Foo { ... }` (block form) — scoped package context.
            NodeKind::Package { name, block: Some(block), .. } => {
                let prev_package = self.current_package.clone();
                self.current_package = name.clone();
                self.walk(block);
                self.current_package = prev_package;
                return;
            }

            // `package Foo;` (semicolon form) — updates current package for
            // subsequent siblings. The actual statements follow as siblings
            // in the parent Program/Block.
            NodeKind::Package { name, block: None, .. } => {
                self.current_package = name.clone();
                return;
            }

            // `use parent 'Base'` / `use parent qw(Base1 Base2)`
            // `use base 'Base'` / `use base qw(Base1 Base2)`
            NodeKind::Use { module, args, .. } if module == "parent" || module == "base" => {
                let anchor_id = Self::anchor_from_node(node);
                let names = Self::extract_parent_names_from_args(args);
                for name in names {
                    self.emit_edge(name, PackageEdgeKind::Inherits, anchor_id, Confidence::High);
                }
            }

            // `our @ISA = qw(Base1 Base2)` (VariableDeclaration form)
            NodeKind::VariableDeclaration { variable, initializer: Some(init), .. } => {
                if Self::is_isa_variable(variable) {
                    let anchor_id = Self::anchor_from_node(node);
                    let names = Self::collect_names_from_node(init);
                    for name in names {
                        self.emit_edge(
                            name,
                            PackageEdgeKind::Inherits,
                            anchor_id,
                            Confidence::High,
                        );
                    }
                }
            }

            // `@ISA = qw(Base1 Base2)` (bare Assignment form)
            NodeKind::Assignment { lhs, rhs, .. } => {
                if Self::is_isa_variable(lhs) {
                    let anchor_id = Self::anchor_from_node(node);
                    let names = Self::collect_names_from_node(rhs);
                    for name in names {
                        self.emit_edge(
                            name,
                            PackageEdgeKind::Inherits,
                            anchor_id,
                            Confidence::High,
                        );
                    }
                }
            }

            // `push @ISA, 'Base'` and `extends 'Base'` / `with 'Role'`
            // Both appear as ExpressionStatement(FunctionCall { ... })
            NodeKind::ExpressionStatement { expression } => {
                self.handle_expression_statement(expression, node);
            }

            _ => {}
        }

        // Recurse into children for all other node types.
        for child in node.children() {
            self.walk(child);
        }
    }

    /// Handle expression statements that may contain `push @ISA`, `extends`, or `with`.
    fn handle_expression_statement(&mut self, expression: &Node, stmt_node: &Node) {
        if let NodeKind::FunctionCall { name, args } = &expression.kind {
            match name.as_str() {
                // `push @ISA, 'Base1', 'Base2'`
                "push" => {
                    if let Some(first_arg) = args.first() {
                        if Self::is_isa_variable(first_arg) {
                            let anchor_id = Self::anchor_from_node(stmt_node);
                            for arg in args.iter().skip(1) {
                                let names = Self::collect_names_from_node(arg);
                                for name in names {
                                    self.emit_edge(
                                        name,
                                        PackageEdgeKind::Inherits,
                                        anchor_id,
                                        Confidence::High,
                                    );
                                }
                            }
                        }
                    }
                }
                // `extends 'Base'` (Moo/Moose)
                "extends" => {
                    let anchor_id = Self::anchor_from_node(stmt_node);
                    let names = Self::collect_names_from_args(args);
                    for name in names {
                        self.emit_edge(
                            name,
                            PackageEdgeKind::Inherits,
                            anchor_id,
                            Confidence::High,
                        );
                    }
                }
                // `with 'Role'` (Moo/Moose)
                "with" => {
                    let anchor_id = Self::anchor_from_node(stmt_node);
                    let names = Self::collect_names_from_args(args);
                    for name in names {
                        self.emit_edge(
                            name,
                            PackageEdgeKind::ComposesRole,
                            anchor_id,
                            Confidence::High,
                        );
                    }
                }
                _ => {}
            }
        }

        // Also handle the two-statement form where `extends`/`with` is parsed
        // as a bare Identifier followed by a String in the next statement.
        // This is handled by the parent walk since we process siblings.
    }

    // ── Helpers ─────────────────────────────────────────────────────────

    /// Emit a [`PackageEdge`] from the current package to the given target.
    fn emit_edge(
        &mut self,
        to_package: String,
        kind: PackageEdgeKind,
        anchor_id: AnchorId,
        confidence: Confidence,
    ) {
        self.edges.push(PackageEdge::new(
            self.current_package.clone(),
            to_package,
            kind,
            Some(anchor_id),
            Provenance::ExactAst,
            confidence,
        ));
    }

    /// Derive an [`AnchorId`] from a node's byte-offset span.
    fn anchor_from_node(node: &Node) -> AnchorId {
        AnchorId(node.location.start as u64)
    }

    /// Check whether a node is the `@ISA` variable.
    fn is_isa_variable(node: &Node) -> bool {
        matches!(&node.kind, NodeKind::Variable { sigil, name } if sigil == "@" && name == "ISA")
    }

    /// Extract parent class names from `use parent`/`use base` args.
    ///
    /// The parser stores args as strings. Handles:
    /// - Quoted strings: `"'Parent'"` → `"Parent"`
    /// - qw-lists: `"qw(Base1 Base2)"` → `["Base1", "Base2"]`
    /// - Flags like `-norequire` are skipped.
    fn extract_parent_names_from_args(args: &[String]) -> Vec<String> {
        let mut names = Vec::new();
        for arg in args {
            let trimmed = arg.trim();
            // Skip flags like -norequire
            if trimmed.starts_with('-') || trimmed.is_empty() {
                continue;
            }
            names.extend(Self::expand_arg_to_names(trimmed));
        }
        names
    }

    /// Expand a single arg string into individual class/role names.
    ///
    /// Handles qw(...) lists and quoted strings.
    fn expand_arg_to_names(arg: &str) -> Vec<String> {
        let arg = arg.trim();
        // qw(...) form
        if arg.starts_with("qw(") {
            if let Some(content) = arg.strip_prefix("qw(").and_then(|s| s.strip_suffix(')')) {
                return content
                    .split_whitespace()
                    .filter(|s| !s.is_empty())
                    .map(|s| s.to_string())
                    .collect();
            }
        }
        // Other qw variants: qw{...}, qw[...], qw/.../ etc.
        if arg.starts_with("qw") && arg.len() > 3 {
            let bytes = arg.as_bytes();
            let open = bytes[2] as char;
            let close = match open {
                '(' => ')',
                '{' => '}',
                '[' => ']',
                '<' => '>',
                c => c,
            };
            if let Some(end) = arg.rfind(close) {
                if end > 3 {
                    let content = &arg[3..end];
                    return content
                        .split_whitespace()
                        .filter(|s| !s.is_empty())
                        .map(|s| s.to_string())
                        .collect();
                }
            }
        }
        // Quoted string: strip quotes
        let unquoted = arg.trim_matches('\'').trim_matches('"').trim();
        if unquoted.is_empty() {
            return Vec::new();
        }
        vec![unquoted.to_string()]
    }

    /// Collect package/class/role names from an AST node (RHS of @ISA assignment
    /// or argument to push/extends/with).
    fn collect_names_from_node(node: &Node) -> Vec<String> {
        match &node.kind {
            NodeKind::String { value, .. } => {
                let trimmed = value.trim_matches('\'').trim_matches('"').trim();
                if trimmed.is_empty() { Vec::new() } else { vec![trimmed.to_string()] }
            }
            NodeKind::Identifier { name } => {
                // Handle qw(...) stored as identifier
                if name.starts_with("qw") {
                    Self::expand_arg_to_names(name)
                } else if name.is_empty() {
                    Vec::new()
                } else {
                    vec![name.clone()]
                }
            }
            NodeKind::ArrayLiteral { elements } => {
                elements.iter().flat_map(Self::collect_names_from_node).collect()
            }
            _ => Vec::new(),
        }
    }

    /// Collect names from function call arguments (Vec<Node>).
    fn collect_names_from_args(args: &[Node]) -> Vec<String> {
        args.iter().flat_map(Self::collect_names_from_node).collect()
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::Parser;

    /// Parse Perl source and extract package graph edges.
    fn parse_and_extract(code: &str) -> Vec<PackageEdge> {
        let mut parser = Parser::new(code);
        let ast = match parser.parse() {
            Ok(ast) => ast,
            Err(_) => return Vec::new(),
        };
        PackageGraphExtractor::extract(&ast, FileId(1))
    }

    // ── use parent 'Base' → Inherits ────────────────────────────────────

    #[test]
    fn test_use_parent_single() -> Result<(), String> {
        let edges = parse_and_extract("package Child;\nuse parent 'Base';\n1;");
        let edge = edges.first().ok_or("expected at least one PackageEdge")?;

        assert_eq!(edge.from_package, "Child");
        assert_eq!(edge.to_package, "Base");
        assert_eq!(edge.kind, PackageEdgeKind::Inherits);
        assert_eq!(edge.provenance, Provenance::ExactAst);
        assert_eq!(edge.confidence, Confidence::High);
        assert!(edge.anchor_id.is_some());
        Ok(())
    }

    #[test]
    fn test_use_parent_qw_multiple() -> Result<(), String> {
        let edges = parse_and_extract("package Child;\nuse parent qw(Base1 Base2);\n1;");
        assert_eq!(edges.len(), 2, "expected two edges, got {}", edges.len());

        assert_eq!(edges[0].from_package, "Child");
        assert_eq!(edges[0].to_package, "Base1");
        assert_eq!(edges[0].kind, PackageEdgeKind::Inherits);

        assert_eq!(edges[1].from_package, "Child");
        assert_eq!(edges[1].to_package, "Base2");
        assert_eq!(edges[1].kind, PackageEdgeKind::Inherits);
        Ok(())
    }

    #[test]
    fn test_use_parent_with_norequire() -> Result<(), String> {
        let edges = parse_and_extract("package Child;\nuse parent -norequire, 'Base';\n1;");
        let edge = edges.first().ok_or("expected at least one PackageEdge")?;

        assert_eq!(edge.from_package, "Child");
        assert_eq!(edge.to_package, "Base");
        assert_eq!(edge.kind, PackageEdgeKind::Inherits);
        Ok(())
    }

    // ── use base 'Base' → Inherits ──────────────────────────────────────

    #[test]
    fn test_use_base_single() -> Result<(), String> {
        let edges = parse_and_extract("package Child;\nuse base 'Base';\n1;");
        let edge = edges.first().ok_or("expected at least one PackageEdge")?;

        assert_eq!(edge.from_package, "Child");
        assert_eq!(edge.to_package, "Base");
        assert_eq!(edge.kind, PackageEdgeKind::Inherits);
        assert_eq!(edge.confidence, Confidence::High);
        Ok(())
    }

    #[test]
    fn test_use_base_qw_multiple() -> Result<(), String> {
        let edges = parse_and_extract("package Child;\nuse base qw(Base1 Base2);\n1;");
        assert_eq!(edges.len(), 2, "expected two edges, got {}", edges.len());

        assert_eq!(edges[0].to_package, "Base1");
        assert_eq!(edges[1].to_package, "Base2");
        Ok(())
    }

    // ── @ISA = ('Base') → Inherits ──────────────────────────────────────

    #[test]
    fn test_isa_assignment_bare() -> Result<(), String> {
        let edges = parse_and_extract("package Child;\n@ISA = ('Base');\n1;");
        let edge = edges.first().ok_or("expected at least one PackageEdge")?;

        assert_eq!(edge.from_package, "Child");
        assert_eq!(edge.to_package, "Base");
        assert_eq!(edge.kind, PackageEdgeKind::Inherits);
        Ok(())
    }

    #[test]
    fn test_isa_assignment_our() -> Result<(), String> {
        let edges = parse_and_extract("package Child;\nour @ISA = qw(Base1 Base2);\n1;");
        assert_eq!(edges.len(), 2, "expected two edges, got {}", edges.len());

        assert_eq!(edges[0].to_package, "Base1");
        assert_eq!(edges[1].to_package, "Base2");
        Ok(())
    }

    // ── push @ISA, 'Base' → Inherits ────────────────────────────────────

    #[test]
    fn test_push_isa_single() -> Result<(), String> {
        let edges = parse_and_extract("package Child;\npush @ISA, 'Base';\n1;");
        let edge = edges.first().ok_or("expected at least one PackageEdge")?;

        assert_eq!(edge.from_package, "Child");
        assert_eq!(edge.to_package, "Base");
        assert_eq!(edge.kind, PackageEdgeKind::Inherits);
        Ok(())
    }

    #[test]
    fn test_push_isa_multiple() -> Result<(), String> {
        let edges = parse_and_extract("package Child;\npush @ISA, 'Base1', 'Base2';\n1;");
        assert_eq!(edges.len(), 2, "expected two edges, got {}", edges.len());

        assert_eq!(edges[0].to_package, "Base1");
        assert_eq!(edges[1].to_package, "Base2");
        Ok(())
    }

    // ── extends 'Base' (Moo/Moose) → Inherits ──────────────────────────

    #[test]
    fn test_extends_single() -> Result<(), String> {
        let edges =
            parse_and_extract("package MyApp::Admin;\nuse Moose;\nextends 'MyApp::User';\n1;");
        // May also get a DependsOn for `use Moose` — filter to Inherits.
        let inherits: Vec<_> =
            edges.iter().filter(|e| e.kind == PackageEdgeKind::Inherits).collect();
        let edge = inherits.first().ok_or("expected at least one Inherits edge")?;

        assert_eq!(edge.from_package, "MyApp::Admin");
        assert_eq!(edge.to_package, "MyApp::User");
        assert_eq!(edge.kind, PackageEdgeKind::Inherits);
        Ok(())
    }

    // ── with 'Role' (Moo/Moose) → ComposesRole ─────────────────────────

    #[test]
    fn test_with_single_role() -> Result<(), String> {
        let edges =
            parse_and_extract("package MyApp::User;\nuse Moose;\nwith 'MyApp::Printable';\n1;");
        let roles: Vec<_> =
            edges.iter().filter(|e| e.kind == PackageEdgeKind::ComposesRole).collect();
        let edge = roles.first().ok_or("expected at least one ComposesRole edge")?;

        assert_eq!(edge.from_package, "MyApp::User");
        assert_eq!(edge.to_package, "MyApp::Printable");
        assert_eq!(edge.kind, PackageEdgeKind::ComposesRole);
        Ok(())
    }

    #[test]
    fn test_with_multiple_roles() -> Result<(), String> {
        let edges =
            parse_and_extract("package MyApp::User;\nuse Moose;\nwith 'Role1', 'Role2';\n1;");
        let roles: Vec<_> =
            edges.iter().filter(|e| e.kind == PackageEdgeKind::ComposesRole).collect();
        assert_eq!(roles.len(), 2, "expected two ComposesRole edges, got {}", roles.len());

        assert_eq!(roles[0].to_package, "Role1");
        assert_eq!(roles[1].to_package, "Role2");
        Ok(())
    }

    // ── Package context tracking ────────────────────────────────────────

    #[test]
    fn test_multiple_packages() -> Result<(), String> {
        let code = r#"
package Parent;
1;

package Child;
use parent 'Parent';
1;
"#;
        let edges = parse_and_extract(code);
        let edge = edges.first().ok_or("expected at least one PackageEdge")?;

        assert_eq!(edge.from_package, "Child");
        assert_eq!(edge.to_package, "Parent");
        Ok(())
    }

    #[test]
    fn test_default_main_package() -> Result<(), String> {
        let edges = parse_and_extract("use parent 'Base';\n1;");
        let edge = edges.first().ok_or("expected at least one PackageEdge")?;

        assert_eq!(edge.from_package, "main");
        assert_eq!(edge.to_package, "Base");
        Ok(())
    }

    // ── Combined patterns ───────────────────────────────────────────────

    #[test]
    fn test_extends_and_with_combined() -> Result<(), String> {
        let code = r#"
package MyApp::Admin;
use Moose;
extends 'MyApp::User';
with 'MyApp::Printable', 'MyApp::Serializable';
1;
"#;
        let edges = parse_and_extract(code);
        let inherits: Vec<_> =
            edges.iter().filter(|e| e.kind == PackageEdgeKind::Inherits).collect();
        let roles: Vec<_> =
            edges.iter().filter(|e| e.kind == PackageEdgeKind::ComposesRole).collect();

        assert_eq!(inherits.len(), 1, "expected one Inherits edge");
        assert_eq!(inherits[0].to_package, "MyApp::User");

        assert_eq!(roles.len(), 2, "expected two ComposesRole edges");
        assert_eq!(roles[0].to_package, "MyApp::Printable");
        assert_eq!(roles[1].to_package, "MyApp::Serializable");
        Ok(())
    }

    // ── No edges for unrelated code ─────────────────────────────────────

    #[test]
    fn test_no_edges_for_plain_use() -> Result<(), String> {
        let edges = parse_and_extract("package Foo;\nuse strict;\nuse warnings;\n1;");
        // No inheritance or role edges expected.
        let inheritance_edges: Vec<_> = edges
            .iter()
            .filter(|e| {
                e.kind == PackageEdgeKind::Inherits || e.kind == PackageEdgeKind::ComposesRole
            })
            .collect();
        assert!(
            inheritance_edges.is_empty(),
            "expected no inheritance/role edges, got {inheritance_edges:?}"
        );
        Ok(())
    }

    // ── Qualified package names ─────────────────────────────────────────

    #[test]
    fn test_qualified_parent_names() -> Result<(), String> {
        let edges = parse_and_extract("package My::Child;\nuse parent 'My::Base::Class';\n1;");
        let edge = edges.first().ok_or("expected at least one PackageEdge")?;

        assert_eq!(edge.from_package, "My::Child");
        assert_eq!(edge.to_package, "My::Base::Class");
        Ok(())
    }
}