perl-lsp-completion 0.12.2

Context-aware LSP completion engine for Perl — variables, functions, methods, packages, and file paths
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
//! BDD-style behavior specification tests for perl-lsp-completion
//!
//! These tests describe *what* the completion engine does from an editor
//! user's perspective.  Each test name reads as a behavior statement:
//! "completes <thing> after <trigger>" or "when <context>, suggests <items>."
//!
//! Coverage targets:
//! - Variable completion by sigil ($, @, %)
//! - Method completion after arrow (->)
//! - Module / package completion after ::
//! - Keyword and builtin function completion
//! - Context suppression (comments, strings, regex)
//! - Test::More completion in test files
//! - Moo/Moose `has` option-key completion
//! - Cancellation behaviour
//! - Edge cases: empty input, boundary positions, unicode

use perl_lsp_completion::{CompletionItem, CompletionProvider};
use perl_parser_core::Parser;
use perl_tdd_support::{must, must_some};
use perl_workspace_index::workspace_index::WorkspaceIndex;
use std::sync::Arc;
use url::Url;

// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------

fn completions(code: &str, position: usize) -> Vec<CompletionItem> {
    let mut parser = Parser::new(code);
    let ast = must(parser.parse());
    let provider = CompletionProvider::new_with_index_and_source(&ast, code, None);
    provider.get_completions(code, position)
}

fn completions_at_end(code: &str) -> Vec<CompletionItem> {
    completions(code, code.len())
}

fn completions_with_path(code: &str, position: usize, filepath: &str) -> Vec<CompletionItem> {
    let mut parser = Parser::new(code);
    let ast = must(parser.parse());
    let provider = CompletionProvider::new_with_index_and_source(&ast, code, None);
    provider.get_completions_with_path(code, position, Some(filepath))
}

fn completions_with_index(
    code: &str,
    position: usize,
    index: Arc<WorkspaceIndex>,
) -> Vec<CompletionItem> {
    let mut parser = Parser::new(code);
    let ast = must(parser.parse());
    let provider = CompletionProvider::new_with_index_and_source(&ast, code, Some(index));
    provider.get_completions(code, position)
}

fn has_label(items: &[CompletionItem], label: &str) -> bool {
    items.iter().any(|i| i.label == label)
}

fn labels(items: &[CompletionItem]) -> Vec<String> {
    items.iter().map(|i| i.label.clone()).collect()
}

// ===========================================================================
// 1. Variable completion after dollar sign
// ===========================================================================

#[test]
fn completes_scalar_variable_names_after_dollar() {
    let code = "my $username = 'alice';\nmy $user_id = 1;\n$us";
    let items = completions_at_end(code);

    assert!(has_label(&items, "$username"), "should suggest $username, got: {:?}", labels(&items));
    assert!(has_label(&items, "$user_id"), "should suggest $user_id, got: {:?}", labels(&items));
}

#[test]
fn completes_array_variable_names_after_at() {
    let code = "my @items = ();\nmy @inventory = ();\n@i";
    let items = completions_at_end(code);

    assert!(has_label(&items, "@items"), "should suggest @items, got: {:?}", labels(&items));
    assert!(
        has_label(&items, "@inventory"),
        "should suggest @inventory, got: {:?}",
        labels(&items)
    );
}

#[test]
fn completes_hash_variable_names_after_percent() {
    let code = "my %config = ();\nmy %cache = ();\n%c";
    let items = completions_at_end(code);

    assert!(has_label(&items, "%config"), "should suggest %config, got: {:?}", labels(&items));
    assert!(has_label(&items, "%cache"), "should suggest %cache, got: {:?}", labels(&items));
}

#[test]
fn does_not_cross_sigil_types_for_scalar_prefix() {
    let code = "my $alpha = 1;\nmy @alpha_list;\n$al";
    let items = completions_at_end(code);

    assert!(has_label(&items, "$alpha"), "should suggest scalar $alpha");
    assert!(
        !has_label(&items, "@alpha_list"),
        "should NOT suggest array @alpha_list for scalar prefix, got: {:?}",
        labels(&items)
    );
}

// ===========================================================================
// 2. Method completion after arrow
// ===========================================================================

#[test]
fn completes_method_names_after_arrow() {
    let code = r#"
package Calculator;
sub add { }
sub subtract { }
sub multiply { }

my $calc = Calculator->new();
$calc->
"#;
    // Position right after "->"
    let pos = must_some(code.rfind("->")) + 2;
    let items = completions(code, pos);

    // Should include user-defined methods
    assert!(
        items.iter().any(|c| c.label == "add" || c.label == "subtract" || c.label == "multiply"),
        "should suggest defined methods after ->, got: {:?}",
        labels(&items)
    );
}

#[test]
fn completes_dbi_methods_after_arrow_for_dbh_variable() {
    let code = "my $dbh = DBI->connect('dbi:SQLite:');\n$dbh->";
    let pos = code.len();
    let items = completions(code, pos);

    assert!(
        has_label(&items, "prepare"),
        "should suggest DBI prepare for $dbh, got: {:?}",
        labels(&items)
    );
    assert!(
        has_label(&items, "disconnect"),
        "should suggest DBI disconnect for $dbh, got: {:?}",
        labels(&items)
    );
}

#[test]
fn completes_dbi_statement_methods_for_sth_variable() {
    let code = "my $sth = $dbh->prepare('SELECT 1');\n$sth->";
    let pos = code.len();
    let items = completions(code, pos);

    assert!(
        has_label(&items, "execute"),
        "should suggest execute for $sth, got: {:?}",
        labels(&items)
    );
    assert!(
        has_label(&items, "fetchrow_hashref"),
        "should suggest fetchrow_hashref for $sth, got: {:?}",
        labels(&items)
    );
}

// ===========================================================================
// 3. Module / package completion after ::
// ===========================================================================

#[test]
fn completes_module_names_after_use() {
    // Create workspace with an indexed module
    let index = Arc::new(WorkspaceIndex::new());
    let module_uri = must(Url::parse("file:///workspace/MyApp/Config.pm"));
    let module_code = "package MyApp::Config;\nsub load { }\n1;";
    must(index.index_file(module_uri, module_code.to_string()));

    let code = "use MyApp::Config;\nMyApp::Config::";
    let items = completions_with_index(code, code.len(), index);

    assert!(
        has_label(&items, "load"),
        "should suggest exported function from indexed module, got: {:?}",
        labels(&items)
    );
}

// ===========================================================================
// 4. Keyword completion
// ===========================================================================

#[test]
fn completes_keywords_for_partial_input() {
    let code = "fo";
    let items = completions_at_end(code);

    assert!(
        items.iter().any(|c| c.label == "for" || c.label == "foreach"),
        "should suggest for/foreach keywords, got: {:?}",
        labels(&items)
    );
}

#[test]
fn completes_sub_keyword() {
    let code = "su";
    let items = completions_at_end(code);

    assert!(has_label(&items, "sub"), "should suggest 'sub' keyword, got: {:?}", labels(&items));
}

// ===========================================================================
// 5. Builtin function completion
// ===========================================================================

#[test]
fn completes_builtin_print_functions() {
    let code = "pri";
    let items = completions_at_end(code);

    assert!(has_label(&items, "print"), "should suggest print, got: {:?}", labels(&items));
    assert!(has_label(&items, "printf"), "should suggest printf, got: {:?}", labels(&items));
}

#[test]
fn completes_builtin_open_function() {
    let code = "ope";
    let items = completions_at_end(code);

    assert!(has_label(&items, "open"), "should suggest open, got: {:?}", labels(&items));
}

#[test]
fn completes_builtin_chomp_and_chop() {
    let code = "cho";
    let items = completions_at_end(code);

    assert!(has_label(&items, "chomp"), "should suggest chomp, got: {:?}", labels(&items));
    assert!(has_label(&items, "chop"), "should suggest chop, got: {:?}", labels(&items));
}

// ===========================================================================
// 6. Context suppression
// ===========================================================================

#[test]
fn does_not_complete_inside_comments() {
    let code = "# pri";
    let items = completions_at_end(code);

    assert!(
        items.is_empty(),
        "should suppress completions inside comments, got: {:?}",
        labels(&items)
    );
}

#[test]
fn does_not_complete_inside_end_of_line_comment() {
    let code = "my $x = 1; # pr";
    let items = completions_at_end(code);

    assert!(
        items.is_empty(),
        "should suppress completions in trailing comments, got: {:?}",
        labels(&items)
    );
}

// ===========================================================================
// 7. Test::More completion in test context
// ===========================================================================

#[test]
fn completes_test_more_functions_in_test_file() {
    let code = "use Test::More;\nis";
    let items = completions_with_path(code, code.len(), "/project/t/basic.t");

    assert!(
        items.iter().any(|c| c.label == "is" || c.label == "is_deeply"),
        "should suggest Test::More functions in .t files, got: {:?}",
        labels(&items)
    );
}

#[test]
fn completes_test_more_when_source_uses_test_module() {
    let code = "use Test::More tests => 3;\nok";
    let items = completions_at_end(code);

    assert!(
        has_label(&items, "ok"),
        "should suggest ok() when Test::More is imported, got: {:?}",
        labels(&items)
    );
}

// ===========================================================================
// 8. Moo/Moose `has` option-key completion
// ===========================================================================

#[test]
fn completes_moo_has_option_keys_inside_parentheses() {
    let code = "use Moo;\nhas 'name' => (is => 'ro', ";
    let items = completions_at_end(code);

    assert!(
        has_label(&items, "isa"),
        "should suggest 'isa' inside has() options, got: {:?}",
        labels(&items)
    );
    assert!(
        has_label(&items, "required"),
        "should suggest 'required' inside has() options, got: {:?}",
        labels(&items)
    );
    assert!(
        has_label(&items, "default"),
        "should suggest 'default' inside has() options, got: {:?}",
        labels(&items)
    );
}

#[test]
fn completes_moo_has_option_keys_with_prefix_filter() {
    let code = "use Moo;\nhas 'name' => (re";
    let items = completions_at_end(code);

    assert!(
        has_label(&items, "required"),
        "should suggest 'required' matching prefix 're', got: {:?}",
        labels(&items)
    );
    assert!(
        has_label(&items, "reader"),
        "should suggest 'reader' matching prefix 're', got: {:?}",
        labels(&items)
    );
}

// ===========================================================================
// 9. Moo/Moose accessor completion
// ===========================================================================

#[test]
fn completes_moo_accessor_methods_after_self_arrow() {
    let code = r#"
package User;
use Moo;

has 'email' => (is => 'ro', isa => 'Str');

sub display {
    my $self = shift;
    $self->
}
"#;
    let pos = must_some(code.find("$self->")) + "$self->".len();
    let items = completions(code, pos);

    assert!(
        has_label(&items, "email"),
        "should suggest Moo accessor 'email' after $self->, got: {:?}",
        labels(&items)
    );
}

#[test]
fn moo_accessor_completion_includes_type_documentation() {
    let code = r#"
package Config;
use Moo;

has 'timeout' => (is => 'rw', isa => 'Int');

sub check {
    my $self = shift;
    $self->
}
"#;
    let pos = must_some(code.find("$self->")) + "$self->".len();
    let items = completions(code, pos);

    let timeout_item = must_some(items.iter().find(|c| c.label == "timeout"));
    let doc = must_some(timeout_item.documentation.as_deref());
    assert!(
        doc.contains("Int"),
        "accessor documentation should include the isa type, got: {:?}",
        doc
    );
}

// ===========================================================================
// 10. Cancellation
// ===========================================================================

#[test]
fn returns_empty_when_immediately_cancelled() {
    let code = "my $x = 1;\n$x";
    let mut parser = Parser::new(code);
    let ast = must(parser.parse());
    let provider = CompletionProvider::new_with_index_and_source(&ast, code, None);

    let items = provider.get_completions_with_path_cancellable(
        code,
        code.len(),
        None,
        &|| true, // always cancelled
    );

    assert!(items.is_empty(), "should return empty when cancelled immediately");
}

// ===========================================================================
// 11. Edge cases
// ===========================================================================

#[test]
fn empty_source_returns_only_keywords_or_nothing() {
    let items = completions_at_end("");
    // Empty source may still yield keyword completions; verify each item
    // has a non-empty label (structural validity check).
    for item in &items {
        assert!(!item.label.is_empty(), "completion labels must be non-empty");
    }
}

#[test]
fn position_at_zero_returns_valid_completions_or_empty() {
    let code = "my $x = 1;";
    let items = completions(code, 0);
    // Position zero is before any typed text; completions may include keywords.
    for item in &items {
        assert!(!item.label.is_empty(), "completion labels must be non-empty at position 0");
    }
}

#[test]
fn position_beyond_source_returns_empty() {
    let code = "my $x = 1;";
    let items = completions(code, code.len() + 100);
    assert!(items.is_empty(), "out-of-bounds position should return empty");
}

#[test]
fn user_defined_subroutine_appears_in_completions() {
    let code = r#"
sub calculate_total { }
sub calculate_tax { }
calc
"#;
    let items = completions_at_end(code);

    assert!(
        has_label(&items, "calculate_total"),
        "should suggest user-defined sub calculate_total, got: {:?}",
        labels(&items)
    );
    assert!(
        has_label(&items, "calculate_tax"),
        "should suggest user-defined sub calculate_tax, got: {:?}",
        labels(&items)
    );
}

#[test]
fn completions_are_deduplicated() {
    let code = "my $count = 1;\n$c";
    let items = completions_at_end(code);

    let count_items: Vec<_> = items.iter().filter(|i| i.label == "$count").collect();
    assert!(
        count_items.len() <= 1,
        "should not have duplicate completions, found {} entries for $count",
        count_items.len()
    );
}

#[test]
fn special_variables_appear_for_dollar_prefix() {
    let code = "my $x = 1;\n$";
    let items = completions_at_end(code);

    assert!(
        has_label(&items, "$_"),
        "should suggest special variable $_, got: {:?}",
        labels(&items)
    );
}