peat-mesh 0.8.2

Peat mesh networking library with CRDT sync, transport security, and topology management
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
//! QoS-aware eviction controller (ADR-019 Phase 4)
//!
//! Orchestrates storage eviction cycles based on QoS policies,
//! with full audit logging and operator override support.
//!
//! # Features
//!
//! - Automated eviction cycles triggered by storage pressure
//! - Priority-based eviction (P5 → P4 → P3 → P2, never P1)
//! - Manual eviction trigger for operator override
//! - Compression before eviction where applicable
//! - Full audit trail of all eviction decisions

use super::{
    audit::{AuditEntry, EvictionAuditLog},
    storage::{EvictionCandidate, QoSAwareStorage, StorageMetrics},
    QoSClass,
};
use std::collections::HashMap;
use std::sync::Arc;
use std::sync::RwLock;
use std::time::Instant;

/// Result of an eviction cycle
#[derive(Debug, Clone, Default)]
pub struct EvictionResult {
    /// Number of documents evicted
    pub docs_evicted: usize,

    /// Total bytes freed
    pub bytes_freed: usize,

    /// Evictions broken down by QoS class
    pub by_class: HashMap<QoSClass, usize>,

    /// Number of compression operations performed
    pub compressions: usize,

    /// Bytes saved by compression
    pub compression_savings: usize,

    /// Number of failed evictions
    pub failures: usize,

    /// Duration of the eviction cycle in milliseconds
    pub duration_ms: u64,

    /// Storage pressure before eviction
    pub pressure_before: f32,

    /// Storage pressure after eviction
    pub pressure_after: f32,
}

impl EvictionResult {
    /// Check if eviction was successful
    pub fn is_success(&self) -> bool {
        self.docs_evicted > 0 || self.compression_savings > 0
    }

    /// Check if eviction freed enough space
    pub fn freed_target(&self, target_bytes: usize) -> bool {
        self.bytes_freed + self.compression_savings >= target_bytes
    }
}

/// Callback for actual document eviction
///
/// The eviction controller doesn't directly delete documents; it identifies
/// candidates and calls this callback to perform the actual deletion.
pub type EvictionCallback = Box<dyn Fn(&str) -> Result<(), String> + Send + Sync>;

/// Callback for document compression
pub type CompressionCallback = Box<dyn Fn(&str) -> Result<usize, String> + Send + Sync>;

/// Configuration for the eviction controller
#[derive(Debug, Clone)]
pub struct EvictionConfig {
    /// Storage pressure threshold to trigger eviction (default: 0.9)
    pub eviction_threshold: f32,

    /// Target pressure after eviction (default: 0.7)
    pub target_pressure: f32,

    /// Whether to attempt compression before eviction
    pub compress_before_eviction: bool,

    /// Maximum number of documents to evict in a single cycle
    pub max_evictions_per_cycle: usize,

    /// Maximum duration of an eviction cycle in milliseconds
    pub max_cycle_duration_ms: u64,
}

impl Default for EvictionConfig {
    fn default() -> Self {
        Self {
            eviction_threshold: 0.9,
            target_pressure: 0.7,
            compress_before_eviction: true,
            max_evictions_per_cycle: 1000,
            max_cycle_duration_ms: 5000, // 5 seconds
        }
    }
}

impl EvictionConfig {
    /// Configuration for aggressive eviction (storage-constrained devices)
    pub fn aggressive() -> Self {
        Self {
            eviction_threshold: 0.75,
            target_pressure: 0.5,
            compress_before_eviction: true,
            max_evictions_per_cycle: 2000,
            max_cycle_duration_ms: 10000,
        }
    }

    /// Configuration for conservative eviction (keep more data)
    pub fn conservative() -> Self {
        Self {
            eviction_threshold: 0.95,
            target_pressure: 0.85,
            compress_before_eviction: true,
            max_evictions_per_cycle: 500,
            max_cycle_duration_ms: 3000,
        }
    }
}

/// Eviction controller that manages storage eviction with QoS awareness
pub struct EvictionController {
    /// Storage manager
    storage: Arc<QoSAwareStorage>,

    /// Audit log for tracking eviction events
    audit_log: Arc<EvictionAuditLog>,

    /// Configuration
    config: EvictionConfig,

    /// Optional callback for performing actual eviction
    eviction_callback: RwLock<Option<EvictionCallback>>,

    /// Optional callback for compression
    compression_callback: RwLock<Option<CompressionCallback>>,

    /// Set of protected document IDs (operator override)
    protected_docs: RwLock<std::collections::HashSet<String>>,

    /// Statistics from recent eviction cycles
    recent_stats: RwLock<Vec<EvictionResult>>,
}

impl EvictionController {
    /// Create a new eviction controller
    pub fn new(storage: Arc<QoSAwareStorage>, audit_log: Arc<EvictionAuditLog>) -> Self {
        Self {
            storage,
            audit_log,
            config: EvictionConfig::default(),
            eviction_callback: RwLock::new(None),
            compression_callback: RwLock::new(None),
            protected_docs: RwLock::new(std::collections::HashSet::new()),
            recent_stats: RwLock::new(Vec::with_capacity(10)),
        }
    }

    /// Create with custom configuration
    pub fn with_config(mut self, config: EvictionConfig) -> Self {
        self.config = config;
        self
    }

    /// Set the eviction callback
    pub fn set_eviction_callback(&self, callback: EvictionCallback) {
        *self
            .eviction_callback
            .write()
            .unwrap_or_else(|e| e.into_inner()) = Some(callback);
    }

    /// Set the compression callback
    pub fn set_compression_callback(&self, callback: CompressionCallback) {
        *self
            .compression_callback
            .write()
            .unwrap_or_else(|e| e.into_inner()) = Some(callback);
    }

    /// Run an eviction cycle if needed
    ///
    /// Returns `Some(result)` if eviction was performed, `None` if not needed.
    pub fn run_eviction_cycle(&self) -> Option<EvictionResult> {
        let current_pressure = self.storage.storage_pressure();

        if current_pressure < self.config.eviction_threshold {
            return None;
        }

        Some(self.execute_eviction_cycle(None))
    }

    /// Force an eviction cycle to free specified bytes
    ///
    /// This is an operator override that runs eviction regardless of pressure.
    pub fn force_eviction(&self, bytes_to_free: usize) -> EvictionResult {
        self.execute_eviction_cycle(Some(bytes_to_free))
    }

    /// Execute an eviction cycle
    fn execute_eviction_cycle(&self, target_bytes: Option<usize>) -> EvictionResult {
        let start = Instant::now();
        let mut result = EvictionResult {
            pressure_before: self.storage.storage_pressure(),
            ..Default::default()
        };

        // Calculate bytes to free
        let bytes_needed = target_bytes.unwrap_or_else(|| {
            let current = self.storage.current_storage_bytes();
            let target =
                (self.storage.max_storage_bytes() as f32 * self.config.target_pressure) as usize;
            current.saturating_sub(target)
        });

        if bytes_needed == 0 {
            result.pressure_after = self.storage.storage_pressure();
            result.duration_ms = start.elapsed().as_millis() as u64;
            return result;
        }

        // Step 1: Try compression first if enabled
        if self.config.compress_before_eviction {
            let compression_result = self.compress_eligible_documents(&mut result);
            if compression_result >= bytes_needed {
                result.pressure_after = self.storage.storage_pressure();
                result.duration_ms = start.elapsed().as_millis() as u64;
                self.record_cycle_completion(&result);
                return result;
            }
        }

        // Step 2: Get eviction candidates
        let remaining_needed = bytes_needed.saturating_sub(result.compression_savings);
        let candidates = self.storage.get_eviction_candidates(remaining_needed);

        // Step 3: Evict candidates
        for candidate in candidates {
            // Check time limit
            if start.elapsed().as_millis() as u64 > self.config.max_cycle_duration_ms {
                break;
            }

            // Check eviction limit
            if result.docs_evicted >= self.config.max_evictions_per_cycle {
                break;
            }

            // Check if protected by operator override
            if self
                .protected_docs
                .read()
                .unwrap_or_else(|e| e.into_inner())
                .contains(&candidate.doc_id)
            {
                continue;
            }

            // Perform eviction
            match self.evict_document(&candidate) {
                Ok(bytes) => {
                    result.docs_evicted += 1;
                    result.bytes_freed += bytes;
                    *result.by_class.entry(candidate.qos_class).or_insert(0) += 1;

                    // Check if we've freed enough
                    if result.bytes_freed + result.compression_savings >= bytes_needed {
                        break;
                    }
                }
                Err(e) => {
                    result.failures += 1;
                    self.audit_log
                        .record_failure(&candidate.doc_id, candidate.qos_class, e);
                }
            }
        }

        result.pressure_after = self.storage.storage_pressure();
        result.duration_ms = start.elapsed().as_millis() as u64;

        // Record completion
        self.record_cycle_completion(&result);

        // Store stats
        let mut stats = self.recent_stats.write().unwrap_or_else(|e| e.into_inner());
        if stats.len() >= 10 {
            stats.remove(0);
        }
        stats.push(result.clone());

        result
    }

    /// Compress eligible documents
    fn compress_eligible_documents(&self, result: &mut EvictionResult) -> usize {
        let callback = self
            .compression_callback
            .read()
            .unwrap_or_else(|e| e.into_inner());
        let callback = match callback.as_ref() {
            Some(cb) => cb,
            None => return 0,
        };

        let candidates = self.storage.get_compression_candidates();
        let mut total_savings = 0;

        for doc_id in candidates {
            if let Some(doc) = self.storage.get_document(&doc_id) {
                let original_size = doc.size_bytes;

                match callback(&doc_id) {
                    Ok(new_size) => {
                        if new_size < original_size {
                            let savings = original_size - new_size;
                            self.storage.update_compressed(&doc_id, new_size);
                            self.audit_log.record_compression(
                                &doc_id,
                                doc.qos_class,
                                original_size,
                                new_size,
                            );
                            total_savings += savings;
                            result.compressions += 1;
                            result.compression_savings += savings;
                        }
                    }
                    Err(e) => {
                        self.audit_log.record_failure(
                            &doc_id,
                            doc.qos_class,
                            format!("Compression failed: {}", e),
                        );
                    }
                }
            }
        }

        total_savings
    }

    /// Evict a single document
    fn evict_document(&self, candidate: &EvictionCandidate) -> Result<usize, String> {
        let callback = self
            .eviction_callback
            .read()
            .unwrap_or_else(|e| e.into_inner());
        let callback = callback.as_ref().ok_or("No eviction callback set")?;

        // Call the eviction callback
        callback(&candidate.doc_id)?;

        // Unregister from storage tracking
        if let Some(doc) = self.storage.unregister_document(&candidate.doc_id) {
            self.audit_log.record_eviction(
                &candidate.doc_id,
                candidate.qos_class,
                doc.size_bytes,
                format!(
                    "Storage pressure eviction (age: {}s, score: {:.2})",
                    candidate.age_seconds, candidate.eviction_score
                ),
            );
            Ok(doc.size_bytes)
        } else {
            Ok(candidate.size_bytes)
        }
    }

    /// Record eviction cycle completion to audit log
    fn record_cycle_completion(&self, result: &EvictionResult) {
        self.audit_log.record(AuditEntry::cleanup_completed(
            result.docs_evicted,
            result.bytes_freed + result.compression_savings,
            result.duration_ms,
        ));
    }

    /// Mark a document as protected (operator override)
    ///
    /// Protected documents will never be evicted by automatic cycles.
    pub fn mark_protected(&self, doc_id: &str) {
        self.protected_docs
            .write()
            .unwrap_or_else(|e| e.into_inner())
            .insert(doc_id.to_string());
        self.storage.mark_protected(doc_id);

        if let Some(doc) = self.storage.get_document(doc_id) {
            self.audit_log
                .record_protection(doc_id, doc.qos_class, "Operator override");
        }
    }

    /// Remove protection from a document
    pub fn unmark_protected(&self, doc_id: &str) {
        self.protected_docs
            .write()
            .unwrap_or_else(|e| e.into_inner())
            .remove(doc_id);
        self.storage.unmark_protected(doc_id);

        if let Some(doc) = self.storage.get_document(doc_id) {
            self.audit_log.record(AuditEntry::new(
                super::audit::AuditAction::UnmarkedProtected,
                doc_id,
                doc.qos_class,
                "Operator override removed",
            ));
        }
    }

    /// Check if a document is protected
    pub fn is_protected(&self, doc_id: &str) -> bool {
        self.protected_docs
            .read()
            .unwrap_or_else(|e| e.into_inner())
            .contains(doc_id)
    }

    /// Get storage metrics
    pub fn storage_metrics(&self) -> StorageMetrics {
        self.storage.metrics()
    }

    /// Get recent eviction statistics
    pub fn recent_stats(&self) -> Vec<EvictionResult> {
        self.recent_stats
            .read()
            .unwrap_or_else(|e| e.into_inner())
            .clone()
    }

    /// Get audit log summary
    pub fn audit_summary(&self) -> super::audit::AuditSummary {
        self.audit_log.summary()
    }

    /// Export audit log as JSON
    pub fn export_audit_log(&self) -> Result<String, serde_json::Error> {
        self.audit_log.export_json()
    }

    /// Get current configuration
    pub fn config(&self) -> &EvictionConfig {
        &self.config
    }

    /// Check if eviction is currently needed
    pub fn needs_eviction(&self) -> bool {
        self.storage.storage_pressure() >= self.config.eviction_threshold
    }

    /// Get count of protected documents
    pub fn protected_count(&self) -> usize {
        self.protected_docs
            .read()
            .unwrap_or_else(|e| e.into_inner())
            .len()
    }
}

impl std::fmt::Debug for EvictionController {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("EvictionController")
            .field("config", &self.config)
            .field(
                "protected_count",
                &self
                    .protected_docs
                    .read()
                    .unwrap_or_else(|e| e.into_inner())
                    .len(),
            )
            .field(
                "recent_stats_count",
                &self
                    .recent_stats
                    .read()
                    .unwrap_or_else(|e| e.into_inner())
                    .len(),
            )
            .finish()
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::qos::storage::StoredDocument;

    fn create_test_storage() -> Arc<QoSAwareStorage> {
        Arc::new(QoSAwareStorage::new(100_000)) // 100KB
    }

    fn create_test_controller() -> EvictionController {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        EvictionController::new(storage.clone(), audit_log)
    }

    #[test]
    fn test_eviction_config_defaults() {
        let config = EvictionConfig::default();

        assert_eq!(config.eviction_threshold, 0.9);
        assert_eq!(config.target_pressure, 0.7);
        assert!(config.compress_before_eviction);
    }

    #[test]
    fn test_eviction_config_aggressive() {
        let config = EvictionConfig::aggressive();

        assert_eq!(config.eviction_threshold, 0.75);
        assert_eq!(config.target_pressure, 0.5);
    }

    #[test]
    fn test_no_eviction_when_not_needed() {
        let controller = create_test_controller();

        // Add some documents but stay below threshold
        controller.storage.register_document(StoredDocument::new(
            "doc-1",
            QoSClass::Normal,
            10_000,
        ));

        // Should not trigger eviction
        let result = controller.run_eviction_cycle();
        assert!(result.is_none());
    }

    #[test]
    fn test_eviction_triggered_at_threshold() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                eviction_threshold: 0.8,
                target_pressure: 0.5,
                compress_before_eviction: false,
                ..Default::default()
            });

        // Fill to 85%
        storage.register_document(StoredDocument::new("bulk-1", QoSClass::Bulk, 30_000));
        storage.register_document(StoredDocument::new("bulk-2", QoSClass::Bulk, 30_000));
        storage.register_document(StoredDocument::new("bulk-3", QoSClass::Bulk, 25_000));

        // Set up eviction callback
        controller.set_eviction_callback(Box::new(move |_doc_id| {
            // In real implementation, this would delete from actual storage
            Ok(())
        }));

        // Should trigger eviction
        let result = controller.run_eviction_cycle();
        assert!(result.is_some());

        let result = result.unwrap();
        assert!(result.pressure_before >= 0.8);
    }

    #[test]
    fn test_force_eviction() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                compress_before_eviction: false,
                ..Default::default()
            });

        // Add documents old enough to be evicted (Bulk max_retain: 300s)
        storage
            .register_document(StoredDocument::new("bulk-1", QoSClass::Bulk, 20_000).with_age(400));
        storage
            .register_document(StoredDocument::new("bulk-2", QoSClass::Bulk, 20_000).with_age(400));

        // Set up eviction callback
        controller.set_eviction_callback(Box::new(|_| Ok(())));

        // Force eviction of 15KB
        let result = controller.force_eviction(15_000);

        // Should have evicted at least one document
        assert!(
            result.docs_evicted >= 1,
            "Expected at least one eviction, got {}",
            result.docs_evicted
        );
    }

    #[test]
    fn test_protected_documents_not_evicted() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                eviction_threshold: 0.5,
                compress_before_eviction: false,
                ..Default::default()
            });

        // Add a bulk document and protect it
        storage.register_document(StoredDocument::new(
            "protected-bulk",
            QoSClass::Bulk,
            60_000,
        ));
        controller.mark_protected("protected-bulk");

        assert!(controller.is_protected("protected-bulk"));

        // Force eviction - protected doc should not be evicted
        controller.set_eviction_callback(Box::new(|_| Ok(())));
        let result = controller.force_eviction(60_000);

        // Should not have evicted the protected document
        assert_eq!(result.docs_evicted, 0);
    }

    #[test]
    fn test_unmark_protected() {
        let controller = create_test_controller();

        controller
            .storage
            .register_document(StoredDocument::new("doc-1", QoSClass::Bulk, 10_000));
        controller.mark_protected("doc-1");
        assert!(controller.is_protected("doc-1"));

        controller.unmark_protected("doc-1");
        assert!(!controller.is_protected("doc-1"));
    }

    #[test]
    fn test_eviction_result_helpers() {
        let result = EvictionResult {
            docs_evicted: 5,
            bytes_freed: 10_000,
            compression_savings: 5_000,
            ..Default::default()
        };

        assert!(result.is_success());
        assert!(result.freed_target(15_000));
        assert!(!result.freed_target(20_000));

        let empty_result = EvictionResult::default();
        assert!(!empty_result.is_success());
    }

    #[test]
    fn test_storage_metrics() {
        let controller = create_test_controller();

        controller.storage.register_document(StoredDocument::new(
            "doc-1",
            QoSClass::Normal,
            10_000,
        ));
        controller
            .storage
            .register_document(StoredDocument::new("doc-2", QoSClass::Bulk, 20_000));

        let metrics = controller.storage_metrics();

        assert_eq!(metrics.used_bytes, 30_000);
        assert_eq!(metrics.max_bytes, 100_000);
    }

    #[test]
    fn test_audit_summary() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller = EvictionController::new(storage.clone(), audit_log.clone());

        // Record some events
        audit_log.record_eviction("doc-1", QoSClass::Bulk, 1000, "Test");
        audit_log.record_eviction("doc-2", QoSClass::Low, 2000, "Test");

        let summary = controller.audit_summary();

        assert_eq!(summary.total_evictions, 2);
        assert_eq!(summary.bytes_evicted, 3000);
    }

    #[test]
    fn test_recent_stats() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller = EvictionController::new(storage.clone(), audit_log);

        // Initially empty
        assert!(controller.recent_stats().is_empty());

        // Add documents to evict (Bulk max_retain: 300s)
        storage
            .register_document(StoredDocument::new("bulk-1", QoSClass::Bulk, 10_000).with_age(400));

        // Force eviction to generate stats
        controller.set_eviction_callback(Box::new(|_| Ok(())));
        let _ = controller.force_eviction(5_000);

        // Should have one stats entry (even if nothing evicted, stats are recorded)
        assert_eq!(controller.recent_stats().len(), 1);
    }

    #[test]
    fn test_needs_eviction() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                eviction_threshold: 0.8,
                ..Default::default()
            });

        // Below threshold
        storage.register_document(StoredDocument::new("doc-1", QoSClass::Normal, 70_000));
        assert!(!controller.needs_eviction());

        // Above threshold
        storage.register_document(StoredDocument::new("doc-2", QoSClass::Normal, 15_000));
        assert!(controller.needs_eviction());
    }

    #[test]
    fn test_export_audit_log() {
        let controller = create_test_controller();

        controller
            .storage
            .register_document(StoredDocument::new("doc-1", QoSClass::Bulk, 1000));
        controller.mark_protected("doc-1");

        let json = controller.export_audit_log();
        assert!(json.is_ok());

        let json_str = json.unwrap();
        assert!(json_str.contains("doc-1"));
    }

    #[test]
    fn test_eviction_by_class_tracking() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                eviction_threshold: 0.5,
                compress_before_eviction: false,
                ..Default::default()
            });

        // Add documents of different classes
        storage.register_document(StoredDocument::new("bulk-1", QoSClass::Bulk, 20_000));
        storage.register_document(StoredDocument::new("bulk-2", QoSClass::Bulk, 20_000));
        storage.register_document(StoredDocument::new("low-1", QoSClass::Low, 20_000));

        controller.set_eviction_callback(Box::new(|_| Ok(())));
        let result = controller.force_eviction(30_000);

        // Check that by_class tracking works
        if result.docs_evicted > 0 {
            assert!(!result.by_class.is_empty());
            // Bulk should be evicted first
            if let Some(&bulk_count) = result.by_class.get(&QoSClass::Bulk) {
                assert!(bulk_count > 0);
            }
        }
    }

    #[test]
    fn test_eviction_config_conservative() {
        let config = EvictionConfig::conservative();
        assert_eq!(config.eviction_threshold, 0.95);
        assert_eq!(config.target_pressure, 0.85);
        assert!(config.compress_before_eviction);
        assert_eq!(config.max_evictions_per_cycle, 500);
        assert_eq!(config.max_cycle_duration_ms, 3000);
    }

    #[test]
    fn test_eviction_result_is_success_with_compression_only() {
        let result = EvictionResult {
            docs_evicted: 0,
            compression_savings: 1000,
            ..Default::default()
        };
        assert!(result.is_success());
    }

    #[test]
    fn test_eviction_result_freed_target_with_compression() {
        let result = EvictionResult {
            bytes_freed: 5_000,
            compression_savings: 10_000,
            ..Default::default()
        };
        assert!(result.freed_target(15_000));
        assert!(!result.freed_target(16_000));
    }

    #[test]
    fn test_force_eviction_zero_bytes() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                compress_before_eviction: false,
                ..Default::default()
            });

        // Force eviction of 0 bytes should return immediately
        let result = controller.force_eviction(0);
        assert_eq!(result.docs_evicted, 0);
        assert_eq!(result.bytes_freed, 0);
    }

    #[test]
    fn test_eviction_without_callback() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                compress_before_eviction: false,
                ..Default::default()
            });

        // Add a bulk document
        storage
            .register_document(StoredDocument::new("bulk-1", QoSClass::Bulk, 20_000).with_age(400));

        // Force eviction without setting callback - evictions should fail
        let result = controller.force_eviction(10_000);
        assert_eq!(result.docs_evicted, 0);
        assert!(result.failures > 0);
    }

    #[test]
    fn test_eviction_with_failing_callback() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                compress_before_eviction: false,
                ..Default::default()
            });

        storage
            .register_document(StoredDocument::new("bulk-1", QoSClass::Bulk, 20_000).with_age(400));

        // Set up failing eviction callback
        controller.set_eviction_callback(Box::new(|_| Err("disk full".to_string())));

        let result = controller.force_eviction(10_000);
        assert_eq!(result.docs_evicted, 0);
        assert!(result.failures > 0);
    }

    #[test]
    fn test_protected_count() {
        let controller = create_test_controller();

        assert_eq!(controller.protected_count(), 0);

        controller
            .storage
            .register_document(StoredDocument::new("doc-1", QoSClass::Normal, 1000));
        controller
            .storage
            .register_document(StoredDocument::new("doc-2", QoSClass::Normal, 1000));

        controller.mark_protected("doc-1");
        assert_eq!(controller.protected_count(), 1);

        controller.mark_protected("doc-2");
        assert_eq!(controller.protected_count(), 2);

        controller.unmark_protected("doc-1");
        assert_eq!(controller.protected_count(), 1);
    }

    #[test]
    fn test_eviction_controller_debug() {
        let controller = create_test_controller();
        let debug_str = format!("{:?}", controller);
        assert!(debug_str.contains("EvictionController"));
        assert!(debug_str.contains("config"));
    }

    #[test]
    fn test_eviction_controller_config_accessor() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage, audit_log).with_config(EvictionConfig::aggressive());

        let config = controller.config();
        assert_eq!(config.eviction_threshold, 0.75);
        assert_eq!(config.target_pressure, 0.5);
    }

    #[test]
    fn test_recent_stats_capped_at_10() {
        let storage = create_test_storage();
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                compress_before_eviction: false,
                ..Default::default()
            });

        controller.set_eviction_callback(Box::new(|_| Ok(())));

        // Force 15 eviction cycles
        for _ in 0..15 {
            controller.force_eviction(1);
        }

        // Recent stats should be capped at 10
        assert!(controller.recent_stats().len() <= 10);
    }

    #[test]
    fn test_compression_callback() {
        // Use a small storage (20KB) to ensure high pressure after filling
        let storage = Arc::new(QoSAwareStorage::new(20_000));
        let audit_log = Arc::new(EvictionAuditLog::new(100));
        let controller =
            EvictionController::new(storage.clone(), audit_log).with_config(EvictionConfig {
                compress_before_eviction: true,
                ..Default::default()
            });

        // Register documents to create high pressure (>50% for compression threshold)
        storage.register_document(StoredDocument::new("doc-1", QoSClass::Bulk, 15_000));

        // Set compression callback that "compresses" to half size
        controller.set_compression_callback(Box::new(|_doc_id| Ok(7_500)));

        controller.set_eviction_callback(Box::new(|_| Ok(())));

        let result = controller.force_eviction(4_000);
        // With high pressure and compression enabled, at least one action should occur
        let total_freed = result.bytes_freed + result.compression_savings;
        assert!(
            total_freed > 0 || result.docs_evicted > 0,
            "Expected some space freed or evictions, got bytes_freed={}, compression_savings={}, docs_evicted={}",
            result.bytes_freed, result.compression_savings, result.docs_evicted
        );
    }
}