pdf-xfa 1.0.0-beta.4

XFA engine — extraction, layout rendering, font resolution. Experimental and under active development.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
//! Central JavaScript handling policy for PDF/XFA hardening paths.

use std::collections::HashSet;

use lopdf::{Document, Object, ObjectId};

use crate::error::XfaError;

/// JavaScript may be parsed and inspected so hardening code can locate and
/// remove active content, but this crate must never execute document-supplied
/// JavaScript. PDF/XFA inputs are untrusted and JavaScript actions can reach
/// viewer APIs, network/file operations, and mutable form state. Keeping parse,
/// execution, and flatten behavior as explicit policy values prevents hidden
/// no-op fallbacks from becoming accidental execution paths in future work.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum JavaScriptPolicy {
    /// JavaScript syntax/payloads may be parsed or inspected for audit/strip.
    AllowParse,
    /// JavaScript execution is denied for all document-supplied entrypoints.
    DenyExecution,
    /// JavaScript-bearing actions are stripped from flattened/hardened output.
    StripOnFlatten,
}
/// ALLOW_PARSE.
pub const ALLOW_PARSE: JavaScriptPolicy = JavaScriptPolicy::AllowParse;
/// DENY_EXECUTION.
pub const DENY_EXECUTION: JavaScriptPolicy = JavaScriptPolicy::DenyExecution;
/// STRIP_ON_FLATTEN.
pub const STRIP_ON_FLATTEN: JavaScriptPolicy = JavaScriptPolicy::StripOnFlatten;
/// JavaScriptEntryPoint.

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum JavaScriptEntryPoint {
    /// PdfOpenAction.
    PdfOpenAction,
    /// AnnotationAdditionalAction.
    AnnotationAdditionalAction,
    /// FieldAction.
    FieldAction,
    /// XfaEventHook.
    XfaEventHook,
}

impl JavaScriptEntryPoint {
    /// as_str.
    pub fn as_str(self) -> &'static str {
        match self {
            Self::PdfOpenAction => "PDF /OpenAction JavaScript",
            Self::AnnotationAdditionalAction => "annotation /AA JavaScript",
            Self::FieldAction => "field /A JavaScript",
            Self::XfaEventHook => "XFA event JavaScript",
        }
    }
}
/// parse_policy.
pub fn parse_policy() -> JavaScriptPolicy {
    ALLOW_PARSE
}
/// execution_policy.
pub fn execution_policy(_entrypoint: JavaScriptEntryPoint) -> JavaScriptPolicy {
    DENY_EXECUTION
}
/// flatten_policy.
pub fn flatten_policy(_entrypoint: JavaScriptEntryPoint) -> JavaScriptPolicy {
    STRIP_ON_FLATTEN
}
/// reject_execution.
pub fn reject_execution(entrypoint: JavaScriptEntryPoint) -> XfaError {
    debug_assert_eq!(execution_policy(entrypoint), DENY_EXECUTION);
    XfaError::UnsupportedFeature("javascript".to_string())
}
/// execution_denied_message.
pub fn execution_denied_message(entrypoint: JavaScriptEntryPoint) -> String {
    format!(
        "{} denied by policy: JavaScript is parsed for inspection but never executed",
        entrypoint.as_str()
    )
}
/// template_mentions_javascript.
pub fn template_mentions_javascript(template_xml: &str) -> bool {
    let lower = template_xml.to_ascii_lowercase();
    lower.contains("text/javascript")
        || lower.contains("application/javascript")
        || lower.contains("application/x-javascript")
        || lower.contains("/x-javascript")
}
/// is_javascript_action_dict.
pub fn is_javascript_action_dict(dict: &lopdf::Dictionary) -> bool {
    matches!(
        dict.get(b"S").ok(),
        Some(Object::Name(name)) if name == b"JavaScript"
    )
}
/// catalog_has_javascript_open_action.
pub fn catalog_has_javascript_open_action(doc: &Document) -> bool {
    let Some(catalog_id) = catalog_id(doc) else {
        return false;
    };
    let Some(Object::Dictionary(catalog)) = doc.objects.get(&catalog_id) else {
        return false;
    };
    catalog
        .get(b"OpenAction")
        .ok()
        .is_some_and(|action| object_is_javascript_action(doc, action))
}
/// dict_has_javascript_additional_actions.
pub fn dict_has_javascript_additional_actions(doc: &Document, dict: &lopdf::Dictionary) -> bool {
    dict.get(b"AA")
        .ok()
        .is_some_and(|aa| additional_actions_contain_javascript(doc, aa))
}
/// dict_has_javascript_field_action.
pub fn dict_has_javascript_field_action(doc: &Document, dict: &lopdf::Dictionary) -> bool {
    dict.get(b"A")
        .ok()
        .is_some_and(|action| object_is_javascript_action(doc, action))
}

/// Strip JavaScript-bearing PDF actions from XFA flattened output.
///
/// Returns the number of executable entrypoints neutralized. This is a
/// hardening count, not a complete object garbage-collection report.
pub fn strip_javascript_for_flatten(doc: &mut Document) -> usize {
    debug_assert_eq!(
        flatten_policy(JavaScriptEntryPoint::PdfOpenAction),
        STRIP_ON_FLATTEN
    );

    let mut count = 0;
    count += strip_javascript_name_tree(doc);

    if let Some(catalog_id) = catalog_id(doc) {
        let remove_open_action = doc
            .objects
            .get(&catalog_id)
            .and_then(|object| match object {
                Object::Dictionary(catalog) => catalog.get(b"OpenAction").ok(),
                _ => None,
            })
            .is_some_and(|action| object_is_javascript_action(doc, action));

        if remove_open_action {
            if let Some(Object::Dictionary(catalog)) = doc.objects.get_mut(&catalog_id) {
                catalog.remove(b"OpenAction");
                count += 1;
            }
        }
    }

    // Two-phase strip: detection runs read-only against the original
    // document state, then mutation applies the collected decisions. A
    // single-pass loop is order-dependent because mutating a JS-action
    // object first can hide it from later `dict_has_javascript_field_action`
    // / `dict_has_javascript_additional_actions` checks on dictionaries
    // that reference it indirectly, leaving `/A` or `/AA` keys behind
    // even though the original graph was JS-bearing. Splitting detection
    // and mutation makes the outcome deterministic regardless of the
    // underlying object iteration order.
    let ids: Vec<ObjectId> = doc.objects.keys().copied().collect();
    let mut decisions: Vec<(ObjectId, StripDecision)> = Vec::new();
    for id in ids {
        let decision = match doc.objects.get(&id) {
            Some(Object::Dictionary(dict)) => StripDecision {
                is_js_action: is_javascript_action_dict(dict),
                has_js_field_action: dict_has_javascript_field_action(doc, dict),
                has_js_aa: dict_has_javascript_additional_actions(doc, dict),
            },
            _ => StripDecision::default(),
        };
        if decision.has_any() {
            decisions.push((id, decision));
        }
    }

    for (id, decision) in decisions {
        if let Some(Object::Dictionary(dict)) = doc.objects.get_mut(&id) {
            if decision.is_js_action {
                dict.remove(b"JS");
                dict.remove(b"S");
                count += 1;
            }
            if decision.has_js_field_action {
                dict.remove(b"A");
                count += 1;
            }
            if decision.has_js_aa {
                dict.remove(b"AA");
                count += 1;
            }
        }
    }

    count
}

#[derive(Default, Clone, Copy)]
struct StripDecision {
    is_js_action: bool,
    has_js_field_action: bool,
    has_js_aa: bool,
}

impl StripDecision {
    fn has_any(&self) -> bool {
        self.is_js_action || self.has_js_field_action || self.has_js_aa
    }
}

fn strip_javascript_name_tree(doc: &mut Document) -> usize {
    let Some(catalog_id) = catalog_id(doc) else {
        return 0;
    };

    let names_id = doc
        .objects
        .get(&catalog_id)
        .and_then(|object| match object {
            Object::Dictionary(catalog) => match catalog.get(b"Names").ok() {
                Some(Object::Reference(id)) => Some(*id),
                _ => None,
            },
            _ => None,
        });

    let mut count = 0;
    if let Some(names_id) = names_id {
        if let Some(Object::Dictionary(names)) = doc.objects.get_mut(&names_id) {
            if names.has(b"JavaScript") {
                names.remove(b"JavaScript");
                count += 1;
            }
        }
    }

    let has_inline_js = doc.objects.get(&catalog_id).is_some_and(|object| {
        matches!(object, Object::Dictionary(catalog) if matches!(
            catalog.get(b"Names").ok(),
            Some(Object::Dictionary(names)) if names.has(b"JavaScript")
        ))
    });

    if has_inline_js {
        if let Some(Object::Dictionary(catalog)) = doc.objects.get_mut(&catalog_id) {
            if let Ok(Object::Dictionary(names)) = catalog.get_mut(b"Names") {
                names.remove(b"JavaScript");
                count += 1;
            }
        }
    }

    count
}

fn additional_actions_contain_javascript(doc: &Document, aa: &Object) -> bool {
    ActionGraphWalk::default().additional_actions_contain_javascript(doc, aa, 0)
}

fn object_is_javascript_action(doc: &Document, action: &Object) -> bool {
    ActionGraphWalk::default().object_is_javascript_action(doc, action, 0)
}

const MAX_ACTION_GRAPH_DEPTH: usize = 64;
const MAX_ACTION_GRAPH_REFERENCES: usize = 128;

#[derive(Default)]
struct ActionGraphWalk {
    visiting: HashSet<ObjectId>,
    resolved_references: usize,
}

impl ActionGraphWalk {
    fn additional_actions_contain_javascript(
        &mut self,
        doc: &Document,
        aa: &Object,
        depth: usize,
    ) -> bool {
        if depth > MAX_ACTION_GRAPH_DEPTH {
            return true;
        }

        match aa {
            Object::Dictionary(dict) => dict
                .iter()
                .any(|(_, action)| self.object_is_javascript_action(doc, action, depth + 1)),
            Object::Reference(id) => {
                self.referenced_additional_actions_contain_javascript(doc, *id, depth + 1)
            }
            _ => false,
        }
    }

    fn referenced_additional_actions_contain_javascript(
        &mut self,
        doc: &Document,
        id: ObjectId,
        depth: usize,
    ) -> bool {
        if !self.enter_reference(id) {
            return true;
        }
        let contains_js = doc.objects.get(&id).is_some_and(|object| {
            self.additional_actions_contain_javascript(doc, object, depth + 1)
        });
        self.visiting.remove(&id);
        contains_js
    }

    fn object_is_javascript_action(
        &mut self,
        doc: &Document,
        action: &Object,
        depth: usize,
    ) -> bool {
        if depth > MAX_ACTION_GRAPH_DEPTH {
            return true;
        }

        match action {
            Object::Dictionary(dict) => self.action_dict_contains_javascript(doc, dict, depth + 1),
            Object::Reference(id) => {
                self.referenced_action_contains_javascript(doc, *id, depth + 1)
            }
            Object::Array(actions) => actions
                .iter()
                .any(|action| self.object_is_javascript_action(doc, action, depth + 1)),
            _ => false,
        }
    }

    fn referenced_action_contains_javascript(
        &mut self,
        doc: &Document,
        id: ObjectId,
        depth: usize,
    ) -> bool {
        if !self.enter_reference(id) {
            return true;
        }
        let contains_js = doc
            .objects
            .get(&id)
            .is_some_and(|object| self.object_is_javascript_action(doc, object, depth + 1));
        self.visiting.remove(&id);
        contains_js
    }

    fn action_dict_contains_javascript(
        &mut self,
        doc: &Document,
        dict: &lopdf::Dictionary,
        depth: usize,
    ) -> bool {
        if is_javascript_action_dict(dict) {
            return true;
        }
        dict.get(b"Next")
            .ok()
            .is_some_and(|next| self.object_is_javascript_action(doc, next, depth + 1))
    }

    fn enter_reference(&mut self, id: ObjectId) -> bool {
        if self.resolved_references >= MAX_ACTION_GRAPH_REFERENCES {
            return false;
        }
        if self.visiting.contains(&id) {
            return false;
        }
        self.resolved_references += 1;
        self.visiting.insert(id)
    }
}

fn catalog_id(doc: &Document) -> Option<ObjectId> {
    match doc.trailer.get(b"Root").ok()? {
        Object::Reference(id) => Some(*id),
        _ => None,
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use lopdf::{dictionary, Document, Object};

    fn basic_doc_with_catalog(catalog: lopdf::Dictionary) -> Document {
        let mut doc = Document::with_version("1.4");
        let pages_id = doc.add_object(Object::Dictionary(dictionary! {
            "Type" => Object::Name(b"Pages".to_vec()),
            "Count" => Object::Integer(0),
            "Kids" => Object::Array(vec![]),
        }));
        let mut catalog = catalog;
        catalog.set("Type", Object::Name(b"Catalog".to_vec()));
        catalog.set("Pages", Object::Reference(pages_id));
        let catalog_id = doc.add_object(Object::Dictionary(catalog));
        doc.trailer.set("Root", Object::Reference(catalog_id));
        doc
    }

    fn js_action(source: &[u8]) -> Object {
        Object::Dictionary(dictionary! {
            "S" => Object::Name(b"JavaScript".to_vec()),
            "JS" => Object::String(source.to_vec(), lopdf::StringFormat::Literal),
        })
    }

    fn hide_action_dict(next: Option<Object>) -> lopdf::Dictionary {
        let mut dict = dictionary! {
            "S" => Object::Name(b"Hide".to_vec()),
        };
        if let Some(next) = next {
            dict.set("Next", next);
        }
        dict
    }

    fn hide_action(next: Option<Object>) -> Object {
        Object::Dictionary(hide_action_dict(next))
    }

    fn set_catalog_open_action(doc: &mut Document, action: Object) {
        let catalog_id = catalog_id(doc).expect("catalog id");
        let Some(Object::Dictionary(catalog)) = doc.objects.get_mut(&catalog_id) else {
            panic!("catalog dictionary");
        };
        catalog.set("OpenAction", action);
    }

    fn catalog_has_open_action(doc: &Document) -> bool {
        let catalog_id = catalog_id(doc).expect("catalog id");
        matches!(
            doc.objects.get(&catalog_id),
            Some(Object::Dictionary(catalog)) if catalog.has(b"OpenAction")
        )
    }

    #[test]
    fn policy_constants_are_explicit() {
        assert_eq!(parse_policy(), ALLOW_PARSE);
        assert_eq!(
            execution_policy(JavaScriptEntryPoint::XfaEventHook),
            DENY_EXECUTION
        );
        assert_eq!(
            flatten_policy(JavaScriptEntryPoint::AnnotationAdditionalAction),
            STRIP_ON_FLATTEN
        );
    }

    #[test]
    fn reject_execution_returns_unsupported_javascript() {
        let err = reject_execution(JavaScriptEntryPoint::XfaEventHook);
        assert_eq!(format!("{err}"), "unsupported feature: javascript");
    }

    #[test]
    fn detects_open_action_javascript() {
        let doc = basic_doc_with_catalog(dictionary! {
            "OpenAction" => js_action(b"app.alert('x')"),
        });

        assert!(catalog_has_javascript_open_action(&doc));
    }

    #[test]
    fn strips_open_action_javascript_on_flatten() {
        let mut doc = basic_doc_with_catalog(dictionary! {
            "OpenAction" => js_action(b"app.alert('x')"),
        });

        assert_eq!(strip_javascript_for_flatten(&mut doc), 1);
        assert!(!catalog_has_javascript_open_action(&doc));
    }

    #[test]
    fn strips_open_action_when_next_dict_contains_javascript() {
        let mut doc = basic_doc_with_catalog(dictionary! {
            "OpenAction" => hide_action(Some(js_action(b"app.alert('next')"))),
        });

        assert!(catalog_has_javascript_open_action(&doc));
        assert_eq!(strip_javascript_for_flatten(&mut doc), 1);
        assert!(!catalog_has_open_action(&doc));
    }

    #[test]
    fn strips_open_action_when_next_array_contains_javascript() {
        let mut doc = basic_doc_with_catalog(dictionary! {
            "OpenAction" => hide_action(Some(Object::Array(vec![
                hide_action(None),
                js_action(b"app.alert('array')"),
            ]))),
        });

        assert!(catalog_has_javascript_open_action(&doc));
        assert_eq!(strip_javascript_for_flatten(&mut doc), 1);
        assert!(!catalog_has_open_action(&doc));
    }

    #[test]
    fn cyclic_next_chain_is_fail_closed_without_looping() {
        let mut doc = basic_doc_with_catalog(dictionary! {});
        let action_a_id = doc.new_object_id();
        let action_b_id = doc.new_object_id();
        doc.objects.insert(
            action_a_id,
            Object::Dictionary(hide_action_dict(Some(Object::Reference(action_b_id)))),
        );
        doc.objects.insert(
            action_b_id,
            Object::Dictionary(hide_action_dict(Some(Object::Reference(action_a_id)))),
        );
        set_catalog_open_action(&mut doc, Object::Reference(action_a_id));

        assert!(catalog_has_javascript_open_action(&doc));
        assert_eq!(strip_javascript_for_flatten(&mut doc), 1);
        assert!(!catalog_has_open_action(&doc));
    }

    #[test]
    fn detects_annotation_additional_action_javascript() {
        let doc = basic_doc_with_catalog(dictionary! {});
        let annot = dictionary! {
            "Type" => Object::Name(b"Annot".to_vec()),
            "Subtype" => Object::Name(b"Widget".to_vec()),
            "AA" => Object::Dictionary(dictionary! {
                "E" => js_action(b"app.alert('enter')"),
            }),
        };

        assert!(dict_has_javascript_additional_actions(&doc, &annot));
    }

    #[test]
    fn strips_additional_action_entry_with_next_chain_javascript() {
        let mut doc = basic_doc_with_catalog(dictionary! {});
        let action_id = doc.add_object(hide_action(Some(js_action(
            b"app.alert('additional action')",
        ))));
        let annot_id = doc.add_object(Object::Dictionary(dictionary! {
            "Type" => Object::Name(b"Annot".to_vec()),
            "Subtype" => Object::Name(b"Widget".to_vec()),
            "AA" => Object::Dictionary(dictionary! {
                "U" => Object::Reference(action_id),
            }),
        }));

        let annot = match doc.objects.get(&annot_id) {
            Some(Object::Dictionary(annot)) => annot,
            _ => panic!("annotation dictionary"),
        };
        assert!(dict_has_javascript_additional_actions(&doc, annot));

        assert_eq!(strip_javascript_for_flatten(&mut doc), 1);
        let annot = match doc.objects.get(&annot_id) {
            Some(Object::Dictionary(annot)) => annot,
            _ => panic!("annotation dictionary"),
        };
        assert!(!annot.has(b"AA"));
    }

    #[test]
    fn detects_field_action_javascript() {
        let doc = basic_doc_with_catalog(dictionary! {});
        let field = dictionary! {
            "FT" => Object::Name(b"Tx".to_vec()),
            "A" => js_action(b"app.alert('field')"),
        };

        assert!(dict_has_javascript_field_action(&doc, &field));
    }

    #[test]
    fn strips_field_action_with_next_chain_javascript() {
        let mut doc = basic_doc_with_catalog(dictionary! {});
        let field_id = doc.add_object(Object::Dictionary(dictionary! {
            "FT" => Object::Name(b"Tx".to_vec()),
            "A" => hide_action(Some(js_action(b"app.alert('field next')"))),
        }));

        assert_eq!(strip_javascript_for_flatten(&mut doc), 1);
        let field = match doc.objects.get(&field_id) {
            Some(Object::Dictionary(field)) => field,
            _ => panic!("field dictionary"),
        };
        assert!(!field.has(b"A"));
    }

    #[test]
    fn pure_non_javascript_action_chain_is_preserved() {
        let mut doc = basic_doc_with_catalog(dictionary! {
            "OpenAction" => hide_action(Some(hide_action(Some(hide_action(None))))),
        });

        assert!(!catalog_has_javascript_open_action(&doc));
        assert_eq!(strip_javascript_for_flatten(&mut doc), 0);
        assert!(catalog_has_open_action(&doc));
    }

    #[test]
    fn malformed_javascript_payload_is_never_parsed_for_execution() {
        let mut doc = basic_doc_with_catalog(dictionary! {
            "OpenAction" => js_action(b"\0}\xff{not valid js"),
        });

        assert!(catalog_has_javascript_open_action(&doc));
        assert_eq!(strip_javascript_for_flatten(&mut doc), 1);
    }

    #[test]
    fn indirect_field_action_to_javascript_is_always_stripped() {
        // Codex P2 regression-guard: a field whose `/A` is an indirect
        // reference to a JavaScript action object must always be stripped,
        // even when the underlying object iteration order would visit the
        // JS-action object before the field dict that points to it. The
        // single-pass loop used to mutate the JS-action first and then
        // see no JS in the field's referenced action graph; the two-phase
        // detect-then-mutate split keeps the result deterministic.
        let mut doc = basic_doc_with_catalog(dictionary! {});
        let js_action_id = doc.add_object(js_action(b"app.alert('indirect')"));
        let field_id = doc.add_object(Object::Dictionary(dictionary! {
            "FT" => Object::Name(b"Tx".to_vec()),
            "A" => Object::Reference(js_action_id),
        }));

        let count = strip_javascript_for_flatten(&mut doc);
        // Field /A removal + JS action /JS+/S removal = 2 strip events.
        assert_eq!(
            count, 2,
            "both field /A and JS action body must be stripped"
        );

        let field = match doc.objects.get(&field_id) {
            Some(Object::Dictionary(field)) => field,
            _ => panic!("field dictionary"),
        };
        assert!(
            !field.has(b"A"),
            "field /A pointing indirectly to JS action must be stripped"
        );

        let js_obj = match doc.objects.get(&js_action_id) {
            Some(Object::Dictionary(action)) => action,
            _ => panic!("js action dictionary"),
        };
        assert!(
            !js_obj.has(b"JS"),
            "indirect JS action /JS payload must be stripped"
        );
        assert!(
            !js_obj.has(b"S"),
            "indirect JS action /S name must be stripped"
        );
    }

    #[test]
    fn strip_outcome_is_independent_of_object_insertion_order() {
        // Build the same logical graph (field /A → indirect JS action) twice,
        // but allocate the objects in opposite orders so HashMap iteration
        // hits them in different sequence. The two-phase strip must produce
        // identical post-state in both arrangements.
        let mut doc_action_first = basic_doc_with_catalog(dictionary! {});
        let action_id_a = doc_action_first.add_object(js_action(b"app.alert('A')"));
        let field_id_a = doc_action_first.add_object(Object::Dictionary(dictionary! {
            "FT" => Object::Name(b"Tx".to_vec()),
            "A" => Object::Reference(action_id_a),
        }));

        let mut doc_field_first = basic_doc_with_catalog(dictionary! {});
        let field_id_b = doc_field_first.add_object(Object::Dictionary(dictionary! {
            "FT" => Object::Name(b"Tx".to_vec()),
            "A" => Object::Reference(lopdf::ObjectId::default()), // placeholder
        }));
        let action_id_b = doc_field_first.add_object(js_action(b"app.alert('A')"));
        // Patch the placeholder so the field really points at the action.
        if let Some(Object::Dictionary(d)) = doc_field_first.objects.get_mut(&field_id_b) {
            d.set("A", Object::Reference(action_id_b));
        }

        let count_a = strip_javascript_for_flatten(&mut doc_action_first);
        let count_b = strip_javascript_for_flatten(&mut doc_field_first);
        assert_eq!(count_a, count_b, "strip count must match across orderings");

        for (doc, fid, aid) in [
            (&doc_action_first, field_id_a, action_id_a),
            (&doc_field_first, field_id_b, action_id_b),
        ] {
            let field = match doc.objects.get(&fid) {
                Some(Object::Dictionary(f)) => f,
                _ => panic!("field"),
            };
            assert!(
                !field.has(b"A"),
                "field /A must be stripped in both orderings"
            );
            let act = match doc.objects.get(&aid) {
                Some(Object::Dictionary(a)) => a,
                _ => panic!("action"),
            };
            assert!(
                !act.has(b"JS"),
                "action /JS must be stripped in both orderings"
            );
            assert!(
                !act.has(b"S"),
                "action /S must be stripped in both orderings"
            );
        }
    }

    #[test]
    fn non_javascript_action_chain_with_indirect_targets_is_preserved() {
        // Pure non-JS chain reachable through indirect references must not
        // be stripped by the two-phase pass. Confirms that only JS-bearing
        // graphs are removed, not innocent action chains.
        let mut doc = basic_doc_with_catalog(dictionary! {});
        let inner_hide_id = doc.add_object(hide_action(None));
        let outer_hide = hide_action(Some(Object::Reference(inner_hide_id)));
        let field_id = doc.add_object(Object::Dictionary(dictionary! {
            "FT" => Object::Name(b"Tx".to_vec()),
            "A" => outer_hide,
        }));

        assert_eq!(
            strip_javascript_for_flatten(&mut doc),
            0,
            "non-JS action chain must be preserved"
        );

        let field = match doc.objects.get(&field_id) {
            Some(Object::Dictionary(f)) => f,
            _ => panic!("field"),
        };
        assert!(field.has(b"A"), "non-JS /A must remain on field");
        let inner = match doc.objects.get(&inner_hide_id) {
            Some(Object::Dictionary(a)) => a,
            _ => panic!("inner hide action"),
        };
        assert!(inner.has(b"S"), "non-JS action /S must remain");
    }
}